Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139654/?format=api
{ "id": 139654, "url": "http://patchwork.dpdk.org/api/patches/139654/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/6b2eaa1a91a7cfe3bb2baa74e87c25a6ff3ba31a.1713964708.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<6b2eaa1a91a7cfe3bb2baa74e87c25a6ff3ba31a.1713964708.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/6b2eaa1a91a7cfe3bb2baa74e87c25a6ff3ba31a.1713964708.git.anatoly.burakov@intel.com", "date": "2024-04-24T13:21:43", "name": "[v1,09/22] net/ixgbe/base: improve function comments", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a6da00c450ef84184a1ae44658ae4354a4ce7d88", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 10, "url": "http://patchwork.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/6b2eaa1a91a7cfe3bb2baa74e87c25a6ff3ba31a.1713964708.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 31814, "url": "http://patchwork.dpdk.org/api/series/31814/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31814", "date": "2024-04-24T13:21:34", "name": "Update IXGBE base driver", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31814/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139654/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139654/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BBBC843EAD;\n\tWed, 24 Apr 2024 15:23:24 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 82D71434B1;\n\tWed, 24 Apr 2024 15:22:37 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.9])\n by mails.dpdk.org (Postfix) with ESMTP id 406AC434A7\n for <dev@dpdk.org>; Wed, 24 Apr 2024 15:22:36 +0200 (CEST)", "from fmviesa006.fm.intel.com ([10.60.135.146])\n by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Apr 2024 06:22:36 -0700", "from silpixa00401119.ir.intel.com ([10.55.129.167])\n by fmviesa006.fm.intel.com with ESMTP; 24 Apr 2024 06:22:33 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1713964957; x=1745500957;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=z2qOzHIS+Ph3SY6OPRWvvgBpdN3jZhr0V5K0tQEAx5o=;\n b=nRPYKfZg+qg2HXbgQYUTV5EZ09qicKIxCYOjOUzcIBwywPQVnl4gSe9c\n iu7U90PfAS185rYZ4gx/mRN7TBQO/gvQS78ZU2/4iO7qm5fSYm/cvBRIT\n VKqSdxUefaaFONEUDnLuuYwWtnyTNZKxI2nfOW6VRvzh1s+XZaAAd5k4w\n EY9REezAQdA65OrpjZ0+O0/uypqOiWWTSrRnNJiVFC/NG24npjRMJCMeV\n W/DKmsU+vanLWjXOZMWBmOjk/kAt0NyCvS96Rt8ZpNilWQkyHE6w3ekMM\n aRNt1dOa8C7DUZVZQB5y+sj4Va0fKSkdjELSwNtRWZ7imC6aJFStU4kTg g==;", "X-CSE-ConnectionGUID": [ "SE84P/65Q8GRCC2f7Dg2nA==", "BYeKa6I1SE+8duZaT9rLEQ==" ], "X-CSE-MsgGUID": [ "k3NfJ/lWRhysfx3+DLgRfw==", "o1gV0lmwR9KSC+mn4DEfkA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11054\"; a=\"20289264\"", "E=Sophos;i=\"6.07,226,1708416000\"; d=\"scan'208\";a=\"20289264\"", "E=Sophos;i=\"6.07,226,1708416000\"; d=\"scan'208\";a=\"24749388\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Radoslaw Tyl <radoslawx.tyl@intel.com>,\n\tvladimir.medvedkin@intel.com, bruce.richardson@intel.com,\n\tSkajewski@dpdk.org, PiotrX <piotrx.skajewski@intel.com>,\n\tMrozowicz@dpdk.org, SlawomirX <slawomirx.mrozowicz@intel.com>,\n\tMichael@dpdk.org, Alice <alice.michael@intel.com>", "Subject": "[PATCH v1 09/22] net/ixgbe/base: improve function comments", "Date": "Wed, 24 Apr 2024 14:21:43 +0100", "Message-ID": "\n <6b2eaa1a91a7cfe3bb2baa74e87c25a6ff3ba31a.1713964708.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<cover.1713964707.git.anatoly.burakov@intel.com>", "References": "<cover.1713964707.git.anatoly.burakov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Radoslaw Tyl <radoslawx.tyl@intel.com>\n\nSome function comments have mismatches between actual function names and\nfunction name in comments, which causes warnings with kernel-doc. Fix\ncomments to match function names.\n\nSigned-off-by: Radoslaw Tyl <radoslawx.tyl@intel.com>\nReviewed-by: Skajewski, PiotrX <piotrx.skajewski@intel.com>\nReviewed-by: Mrozowicz, SlawomirX <slawomirx.mrozowicz@intel.com>\nReviewed-by: Michael, Alice <alice.michael@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_82599.c | 2 +-\n drivers/net/ixgbe/base/ixgbe_api.c | 2 +-\n drivers/net/ixgbe/base/ixgbe_common.c | 11 ++++++-----\n drivers/net/ixgbe/base/ixgbe_dcb.c | 2 +-\n drivers/net/ixgbe/base/ixgbe_hv_vf.c | 10 +++++-----\n drivers/net/ixgbe/base/ixgbe_phy.c | 2 +-\n drivers/net/ixgbe/base/ixgbe_x550.c | 12 ++++++------\n 7 files changed, 21 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_82599.c b/drivers/net/ixgbe/base/ixgbe_82599.c\nindex 7d2938b253..73c7766ecf 100644\n--- a/drivers/net/ixgbe/base/ixgbe_82599.c\n+++ b/drivers/net/ixgbe/base/ixgbe_82599.c\n@@ -1497,7 +1497,7 @@ u32 ixgbe_atr_compute_sig_hash_82599(union ixgbe_atr_hash_dword input,\n }\n \n /**\n- * ixgbe_atr_add_signature_filter_82599 - Adds a signature hash filter\n+ * ixgbe_fdir_add_signature_filter_82599 - Adds a signature hash filter\n * @hw: pointer to hardware structure\n * @input: unique input dword\n * @common: compressed common input dword\ndiff --git a/drivers/net/ixgbe/base/ixgbe_api.c b/drivers/net/ixgbe/base/ixgbe_api.c\nindex 89e1650d63..d2b74cdffc 100644\n--- a/drivers/net/ixgbe/base/ixgbe_api.c\n+++ b/drivers/net/ixgbe/base/ixgbe_api.c\n@@ -870,7 +870,7 @@ s32 ixgbe_validate_eeprom_checksum(struct ixgbe_hw *hw, u16 *checksum_val)\n }\n \n /**\n- * ixgbe_eeprom_update_checksum - Updates the EEPROM checksum\n+ * ixgbe_update_eeprom_checksum - Updates the EEPROM checksum\n * @hw: pointer to hardware structure\n **/\n s32 ixgbe_update_eeprom_checksum(struct ixgbe_hw *hw)\ndiff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c\nindex aa843bd5c4..dd8310748b 100644\n--- a/drivers/net/ixgbe/base/ixgbe_common.c\n+++ b/drivers/net/ixgbe/base/ixgbe_common.c\n@@ -3827,14 +3827,15 @@ s32 ixgbe_set_vmdq_generic(struct ixgbe_hw *hw, u32 rar, u32 vmdq)\n }\n \n /**\n+ * ixgbe_set_vmdq_san_mac_generic - Associate default VMDq pool index with\n+ * a rx address\n+ * @hw: pointer to hardware struct\n+ * @vmdq: VMDq pool index\n+ *\n * This function should only be involved in the IOV mode.\n * In IOV mode, Default pool is next pool after the number of\n * VFs advertized and not 0.\n * MPSAR table needs to be updated for SAN_MAC RAR [hw->mac.san_mac_rar_index]\n- *\n- * ixgbe_set_vmdq_san_mac - Associate default VMDq pool index with a rx address\n- * @hw: pointer to hardware struct\n- * @vmdq: VMDq pool index\n **/\n s32 ixgbe_set_vmdq_san_mac_generic(struct ixgbe_hw *hw, u32 vmdq)\n {\n@@ -4825,7 +4826,7 @@ STATIC const u8 ixgbe_emc_therm_limit[4] = {\n };\n \n /**\n- * ixgbe_get_thermal_sensor_data - Gathers thermal sensor data\n+ * ixgbe_get_thermal_sensor_data_generic - Gathers thermal sensor data\n * @hw: pointer to hardware structure\n *\n * Returns the thermal sensor data structure\ndiff --git a/drivers/net/ixgbe/base/ixgbe_dcb.c b/drivers/net/ixgbe/base/ixgbe_dcb.c\nindex 41469c10db..55402b230f 100644\n--- a/drivers/net/ixgbe/base/ixgbe_dcb.c\n+++ b/drivers/net/ixgbe/base/ixgbe_dcb.c\n@@ -263,7 +263,7 @@ void ixgbe_dcb_unpack_map_cee(struct ixgbe_dcb_config *cfg, int direction,\n }\n \n /**\n- * ixgbe_dcb_config - Struct containing DCB settings.\n+ * ixgbe_dcb_check_config_cee - Struct containing DCB settings.\n * @dcb_config: Pointer to DCB config structure\n *\n * This function checks DCB rules for DCB settings.\ndiff --git a/drivers/net/ixgbe/base/ixgbe_hv_vf.c b/drivers/net/ixgbe/base/ixgbe_hv_vf.c\nindex 34add03e8b..1279659926 100644\n--- a/drivers/net/ixgbe/base/ixgbe_hv_vf.c\n+++ b/drivers/net/ixgbe/base/ixgbe_hv_vf.c\n@@ -7,7 +7,7 @@\n #include \"ixgbe_osdep.h\"\n \n /**\n- * Hyper-V variant - just a stub.\n+ * ixgbevf_hv_update_mc_addr_list_vf - Hyper-V variant - just a stub.\n * @hw: unused\n * @mc_addr_list: unused\n * @mc_addr_count: unused\n@@ -24,7 +24,7 @@ static s32 ixgbevf_hv_update_mc_addr_list_vf(struct ixgbe_hw *hw, u8 *mc_addr_li\n }\n \n /**\n- * Hyper-V variant - just a stub.\n+ * ixgbevf_hv_update_xcast_mode - Hyper-V variant - just a stub.\n * @hw: unused\n * @xcast_mode: unused\n */\n@@ -36,7 +36,7 @@ static s32 ixgbevf_hv_update_xcast_mode(struct ixgbe_hw *hw, int xcast_mode)\n }\n \n /**\n- * Hyper-V variant - just a stub.\n+ * ixgbevf_hv_set_vfta_vf - Hyper-V variant - just a stub.\n * @hw: unused\n * @vlan: unused\n * @vind: unused\n@@ -79,12 +79,12 @@ static s32 ixgbevf_hv_set_rar_vf(struct ixgbe_hw *hw, u32 index, u8 *addr, u32 v\n }\n \n /**\n- * Hyper-V variant; there is no mailbox communication.\n+ * ixgbevf_hv_check_mac_link_vf - Hyper-V variant; there is no mailbox\n+ * communication.\n * @hw: pointer to hardware structure\n * @speed: pointer to link speed\n * @link_up: true is link is up, false otherwise\n * @autoneg_wait_to_complete: unused\n- *\n */\n static s32 ixgbevf_hv_check_mac_link_vf(struct ixgbe_hw *hw,\n \t\t\t\t\tixgbe_link_speed *speed,\ndiff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c\nindex 56267bb00d..8a7712c8f2 100644\n--- a/drivers/net/ixgbe/base/ixgbe_phy.c\n+++ b/drivers/net/ixgbe/base/ixgbe_phy.c\n@@ -557,7 +557,7 @@ void ixgbe_restart_auto_neg(struct ixgbe_hw *hw)\n }\n \n /**\n- * ixgbe_read_phy_mdi - Reads a value from a specified PHY register without\n+ * ixgbe_read_phy_reg_mdi - Reads a value from a specified PHY register without\n * the SWFW lock\n * @hw: pointer to hardware structure\n * @reg_addr: 32 bit address of PHY register to read\ndiff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c\nindex 8810d1658e..844c06cc08 100644\n--- a/drivers/net/ixgbe/base/ixgbe_x550.c\n+++ b/drivers/net/ixgbe/base/ixgbe_x550.c\n@@ -715,7 +715,7 @@ static s32 ixgbe_setup_fw_link(struct ixgbe_hw *hw)\n }\n \n /**\n- * ixgbe_fc_autoneg_fw _ Set up flow control for FW-controlled PHYs\n+ * ixgbe_fc_autoneg_fw - Set up flow control for FW-controlled PHYs\n * @hw: pointer to hardware structure\n *\n * Called at init time to set up flow control.\n@@ -1843,7 +1843,7 @@ void ixgbe_init_mac_link_ops_X550em(struct ixgbe_hw *hw)\n }\n \n /**\n- * ixgbe_get_link_capabilities_x550em - Determines link capabilities\n+ * ixgbe_get_link_capabilities_X550em - Determines link capabilities\n * @hw: pointer to hardware structure\n * @speed: pointer to link speed\n * @autoneg: true when autoneg or autotry is enabled\n@@ -3205,7 +3205,7 @@ s32 ixgbe_read_ee_hostif_buffer_X550(struct ixgbe_hw *hw,\n }\n \n /**\n- * ixgbe_write_ee_hostif_X550 - Write EEPROM word using hostif\n+ * ixgbe_write_ee_hostif_data_X550 - Write EEPROM word using hostif\n * @hw: pointer to hardware structure\n * @offset: offset of word in the EEPROM to write\n * @data: word write to the EEPROM\n@@ -3673,7 +3673,7 @@ u64 ixgbe_get_supported_physical_layer_X550em(struct ixgbe_hw *hw)\n }\n \n /**\n- * ixgbe_get_bus_info_x550em - Set PCI bus info\n+ * ixgbe_get_bus_info_X550em - Set PCI bus info\n * @hw: pointer to hardware structure\n *\n * Sets bus link width and speed to unknown because X550em is\n@@ -3738,7 +3738,7 @@ void ixgbe_disable_rx_x550(struct ixgbe_hw *hw)\n }\n \n /**\n- * ixgbe_enter_lplu_x550em - Transition to low power states\n+ * ixgbe_enter_lplu_t_x550em - Transition to low power states\n * @hw: pointer to hardware structure\n *\n * Configures Low Power Link Up on transition to low power states\n@@ -3846,7 +3846,7 @@ s32 ixgbe_enter_lplu_t_x550em(struct ixgbe_hw *hw)\n }\n \n /**\n- * ixgbe_get_lcd_x550em - Determine lowest common denominator\n+ * ixgbe_get_lcd_t_x550em - Determine lowest common denominator\n * @hw: pointer to hardware structure\n * @lcd_speed: pointer to lowest common link speed\n *\n", "prefixes": [ "v1", "09/22" ] }