Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 139660,
    "url": "http://patchwork.dpdk.org/api/patches/139660/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/a7c7e6c936238bfc731cb828261fe9b4b36230ee.1713964708.git.anatoly.burakov@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<a7c7e6c936238bfc731cb828261fe9b4b36230ee.1713964708.git.anatoly.burakov@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/a7c7e6c936238bfc731cb828261fe9b4b36230ee.1713964708.git.anatoly.burakov@intel.com",
    "date": "2024-04-24T13:21:49",
    "name": "[v1,15/22] net/ixgbe/base: filter out spurious link up indication",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "dbece49af2e7046822ec38ac015d2bf11b437a57",
    "submitter": {
        "id": 4,
        "url": "http://patchwork.dpdk.org/api/people/4/?format=api",
        "name": "Anatoly Burakov",
        "email": "anatoly.burakov@intel.com"
    },
    "delegate": {
        "id": 10,
        "url": "http://patchwork.dpdk.org/api/users/10/?format=api",
        "username": "bruce",
        "first_name": "Bruce",
        "last_name": "Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/a7c7e6c936238bfc731cb828261fe9b4b36230ee.1713964708.git.anatoly.burakov@intel.com/mbox/",
    "series": [
        {
            "id": 31814,
            "url": "http://patchwork.dpdk.org/api/series/31814/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31814",
            "date": "2024-04-24T13:21:34",
            "name": "Update IXGBE base driver",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/31814/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/139660/comments/",
    "check": "warning",
    "checks": "http://patchwork.dpdk.org/api/patches/139660/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5605B43EAD;\n\tWed, 24 Apr 2024 15:24:03 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6307E434AD;\n\tWed, 24 Apr 2024 15:22:52 +0200 (CEST)",
            "from mgamail.intel.com (mgamail.intel.com [192.198.163.9])\n by mails.dpdk.org (Postfix) with ESMTP id 1D4E4434C7\n for <dev@dpdk.org>; Wed, 24 Apr 2024 15:22:49 +0200 (CEST)",
            "from fmviesa006.fm.intel.com ([10.60.135.146])\n by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Apr 2024 06:22:50 -0700",
            "from silpixa00401119.ir.intel.com ([10.55.129.167])\n by fmviesa006.fm.intel.com with ESMTP; 24 Apr 2024 06:22:48 -0700"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1713964970; x=1745500970;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=pGIAgsVSnCsBr0uCmf5KfzmGfU5QPV0DkdvoQ51t2M8=;\n b=IWLxOpHYiYKSomhWpslDGLgpFy5VlfxaeLYLEr7mLqzmzJvv+1k4GwZM\n ULYOTl4xK1vuQDdPXTHu6vRY4GiPuyew3RpbUd4RbEaVwS0KrdQ93PY9W\n vqeVPU0+rObyBeqTaxjJZ4BIFQCusl/jK00npv6jHV2jS8xCAvqCdv1Yr\n fbDI+3Iq59G7lFXkE8SsR2ZxKszTNvgYczGMW/cCh39qcYeaC3mwbWIjx\n GYtPNXxCOFXbL2UQMwJKmIxWlrmE+FwB+G6TZm7DWlMNwEcf/nqWrndzz\n DHiKOG4QA0Ju4bkOZkSjPizfUrwKhnPTRxyFZ+GJRBvQfw1TipZ55gXqw g==;",
        "X-CSE-ConnectionGUID": [
            "GrGBfYjMTDqZL2VtvQNT0g==",
            "knhvYFegSqu7G0kkRQQMoQ=="
        ],
        "X-CSE-MsgGUID": [
            "SnCbcEkFSH+3i6HYy4V7CA==",
            "HH7LqRGMRm61uzflsVzn0Q=="
        ],
        "X-IronPort-AV": [
            "E=McAfee;i=\"6600,9927,11054\"; a=\"20289275\"",
            "E=Sophos;i=\"6.07,226,1708416000\"; d=\"scan'208\";a=\"20289275\"",
            "E=Sophos;i=\"6.07,226,1708416000\"; d=\"scan'208\";a=\"24749472\""
        ],
        "X-ExtLoop1": "1",
        "From": "Anatoly Burakov <anatoly.burakov@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Krzysztof Galazka <krzysztof.galazka@intel.com>,\n vladimir.medvedkin@intel.com, bruce.richardson@intel.com,\n Jan Sokolowski <jan.sokolowski@intel.com>",
        "Subject": "[PATCH v1 15/22] net/ixgbe/base: filter out spurious link up\n indication",
        "Date": "Wed, 24 Apr 2024 14:21:49 +0100",
        "Message-ID": "\n <a7c7e6c936238bfc731cb828261fe9b4b36230ee.1713964708.git.anatoly.burakov@intel.com>",
        "X-Mailer": "git-send-email 2.43.0",
        "In-Reply-To": "<cover.1713964707.git.anatoly.burakov@intel.com>",
        "References": "<cover.1713964707.git.anatoly.burakov@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Krzysztof Galazka <krzysztof.galazka@intel.com>\n\nExtend SFP+ cage crosstalk fix by re-checking link state\nafter 5ms delay to filter out spurious link up indication\nby transceiver with no fibre cable connected.\n\nSigned-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>\nReviewed-by: Jan Sokolowski <jan.sokolowski@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_common.c | 19 +++++++++++++++++--\n 1 file changed, 17 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c\nindex bb6e72fbe6..a19f4d715c 100644\n--- a/drivers/net/ixgbe/base/ixgbe_common.c\n+++ b/drivers/net/ixgbe/base/ixgbe_common.c\n@@ -4194,10 +4194,25 @@ s32 ixgbe_check_mac_link_generic(struct ixgbe_hw *hw, ixgbe_link_speed *speed,\n \t\t\tlinks_reg = IXGBE_READ_REG(hw, IXGBE_LINKS);\n \t\t}\n \t} else {\n-\t\tif (links_reg & IXGBE_LINKS_UP)\n+\t\tif (links_reg & IXGBE_LINKS_UP) {\n+\t\t\tif (ixgbe_need_crosstalk_fix(hw)) {\n+\t\t\t\t/* Check the link state again after a delay\n+\t\t\t\t * to filter out spurious link up\n+\t\t\t\t * notifications.\n+\t\t\t\t */\n+\t\t\t\tmsec_delay(5);\n+\t\t\t\tlinks_reg = IXGBE_READ_REG(hw, IXGBE_LINKS);\n+\t\t\t\tif (!(links_reg & IXGBE_LINKS_UP)) {\n+\t\t\t\t\t*link_up = false;\n+\t\t\t\t\t*speed = IXGBE_LINK_SPEED_UNKNOWN;\n+\t\t\t\t\treturn IXGBE_SUCCESS;\n+\t\t\t\t}\n+\n+\t\t\t}\n \t\t\t*link_up = true;\n-\t\telse\n+\t\t} else {\n \t\t\t*link_up = false;\n+\t\t}\n \t}\n \n \tswitch (links_reg & IXGBE_LINKS_SPEED_82599) {\n",
    "prefixes": [
        "v1",
        "15/22"
    ]
}