Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139681/?format=api
{ "id": 139681, "url": "http://patchwork.dpdk.org/api/patches/139681/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240425165308.1078454-1-ferruh.yigit@amd.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240425165308.1078454-1-ferruh.yigit@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240425165308.1078454-1-ferruh.yigit@amd.com", "date": "2024-04-25T16:53:08", "name": "ethdev: document that stats reset APIs are not thread-safe", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "dfb3b46875821fbb5b6eb8b807dbeb6c0f36d708", "submitter": { "id": 2700, "url": "http://patchwork.dpdk.org/api/people/2700/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@amd.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240425165308.1078454-1-ferruh.yigit@amd.com/mbox/", "series": [ { "id": 31822, "url": "http://patchwork.dpdk.org/api/series/31822/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31822", "date": "2024-04-25T16:53:08", "name": "ethdev: document that stats reset APIs are not thread-safe", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31822/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139681/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139681/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 609EB43F08;\n\tThu, 25 Apr 2024 18:53:28 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 31A90438F3;\n\tThu, 25 Apr 2024 18:53:28 +0200 (CEST)", "from NAM12-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam12on2064.outbound.protection.outlook.com [40.107.243.64])\n by mails.dpdk.org (Postfix) with ESMTP id F073B438DA;\n Thu, 25 Apr 2024 18:53:25 +0200 (CEST)", "from SJ0PR13CA0186.namprd13.prod.outlook.com (2603:10b6:a03:2c3::11)\n by LV3PR12MB9266.namprd12.prod.outlook.com (2603:10b6:408:21b::21)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Thu, 25 Apr\n 2024 16:53:23 +0000", "from SJ5PEPF000001D3.namprd05.prod.outlook.com\n (2603:10b6:a03:2c3:cafe::b8) by SJ0PR13CA0186.outlook.office365.com\n (2603:10b6:a03:2c3::11) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.23 via Frontend\n Transport; Thu, 25 Apr 2024 16:53:23 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n SJ5PEPF000001D3.mail.protection.outlook.com (10.167.242.55) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7519.19 via Frontend Transport; Thu, 25 Apr 2024 16:53:22 +0000", "from telcodpdk.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Apr\n 2024 11:53:21 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=dcZaiMbSxzearx1svmYQ07xZopGFg1fS7hMRN70wDEDG8B3Z0U7DRRxsLyzK1iXbwMBsejEEe3//LlVMGBgYb076U0ZOJtSJljW/ljXkjjIDqIv5Eimt6Bh3r6iPiRycXwtR8DvErbn/C1pboZGQ9scd36YFiKruStG8NktelpCAytgVaZ4B4sTAqGpM0/18MFSIb+sQGbGP6EReQkPZHNplfHem5BM8YbOsHqr+hmFk3Sr1rGvl3b2fHkTzOK2unTB9qHimIwcVxBgyhR5XWat+gQtVzaqE3DEiGy4FDRtM/LJXZoUjVBGG3H+qcLPoqlbnUHZF1J3G3ZvRcNgBPg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ImEO5a6l0Ycywe4ieS9eQ0NodKLWxgnxcZl1T6r5cdA=;\n b=Vhg7bmNiPXUmTPDFwLSKp25mB/u/wNzMqlT/M9UZ790AjfH1zb0vGf33V6v04/qeSdCndUDXQBrteEqzUdXGBYjHWGtY1yrvGHwaSqkaljxfUwiyl6BQmomXDQc3yjMn/o6qBt/1Ug1MWfRADHL3M882DxV4qQjsrr5J6Az1UwnBoM7DnRbffQmRIUowe2g9cy+d25bGoroAUZIgqoem3ML5PDzCylt/yuGwwN0PDBRycatvGH2NRcGgxpUlZr27IqX2Cp29yqjnzXMri1B4uGDcpxigOG/MOCl3HG48Wo/uy0Pi0Hm8MJ7gDkSt8HCuYmzqiITYmDOQqgLzKhDdsg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=monjalon.net smtp.mailfrom=amd.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=amd.com; dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ImEO5a6l0Ycywe4ieS9eQ0NodKLWxgnxcZl1T6r5cdA=;\n b=rekTFxiy1ZtHqDakSytN1Eck5YAtchOugHi/B0RvQvJbqxRJ3432clbkC6ID0xLb+1S8YYt2HnzFCdEehKhIPT1s6oJ83eTZ48CwoFG5gVDU5slh+AlngsON4bAjpy//BRylFj7ox5FDQ48xCREwyZYJslAb8LnyyfRapxSrAfA=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Ferruh Yigit <ferruh.yigit@amd.com>", "To": "Thomas Monjalon <thomas@monjalon.net>, Andrew Rybchenko\n <andrew.rybchenko@oktetlabs.ru>", "CC": "<dev@dpdk.org>, <stable@dpdk.org>,\n =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n Stephen Hemminger <stephen@networkplumber.org>, =?utf-8?q?Morten_Br=C3=B8ru?=\n\t=?utf-8?q?p?= <mb@smartsharesystems.com>", "Subject": "[PATCH] ethdev: document that stats reset APIs are not thread-safe", "Date": "Thu, 25 Apr 2024 17:53:08 +0100", "Message-ID": "<20240425165308.1078454-1-ferruh.yigit@amd.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ5PEPF000001D3:EE_|LV3PR12MB9266:EE_", "X-MS-Office365-Filtering-Correlation-Id": "f4309a52-93fd-4ad9-6c19-08dc654837d3", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "=?utf-8?q?8aC1gfN3J2AsAd4V92kqR1GrH0wsuxv?=\n\t=?utf-8?q?4dTWOjc+t5tgn1a+XAbOaXbiMj2Xpw8lCdUHRZpc4hJq/jd2SD7er5SiOMNg66n0/?=\n\t=?utf-8?q?Hv8/B1hBFqhVv2kx0TwmMGZlrTQLchNnJiECQUSad2C/W9XvAL5UTB2NlqEmF1e2Q?=\n\t=?utf-8?q?pNyjQT5ngyCaOVJrPWPz14/YLQpTF1f+WG/7AYk+jae+ztp7h/unwVHRHP2LJqdeA?=\n\t=?utf-8?q?wkT9XLY8oucDJi2D5nOmQVdPk4cbG0VGH91qL2w72PX/71Yx5R9dVklzJTi4d7sIz?=\n\t=?utf-8?q?U0xLXfNySL4386CcivyIA1FBkf4lkTEVmJlqvYM8181eoCQyiZDk9Nr8mxpvYdmhe?=\n\t=?utf-8?q?kUvoLji9jHBLj3rqyYt60OZk9Ys5Jb8S2QyFWM9dHpI2FvgiCzXkxUdNLJf6DnEqO?=\n\t=?utf-8?q?tX5qzvlqOAX+UM0IlCuTUHUXPQWTXZASZi0ngx+YjysLSSDT9gdZShm9m4dhFLreT?=\n\t=?utf-8?q?WzqTgcELKZLSl6ybNvKC8sDyw5ocZMHA4o3xma60jKBP9CRzZG3ZGG5OITOJw75aq?=\n\t=?utf-8?q?6Ijyez33+ERBMnZcvheWjMo74l7a21BZluuK21ljqjiuXOW4FaSkMuqZqEaRuCTY+?=\n\t=?utf-8?q?SMuHyhI/uml9n8PJFYrAwF0YMDAfGPC1KhMC+I+ugbBGBMZwhOfKbNepjWQLq7eSG?=\n\t=?utf-8?q?43bEVasQFi1paer0YaC863QBGD4yf1C6unmmC6ROQgE00BJrkRsLGn5agS7JGMeQX?=\n\t=?utf-8?q?uVgK+nEhVWrEFw+dNVSolrYf1tu1sArNKP8jAmqi9sMmjvuB7iJ/6NywFbPCsOiNA?=\n\t=?utf-8?q?yH8qUnm+yL17k1JKj2lV5Bc4BcHgYGX52gn+VAJ4k8TM2bcUJ7josfzIFTP6v8c9u?=\n\t=?utf-8?q?LiZssKScIhjmeU/ba6qdjzwxubWqkgKCADWc1xhC3cKkSe0LWzpUzU+m9I4mNRrv0?=\n\t=?utf-8?q?AtcXez3FXfso3d87nAS26ukN85RDryUMAVPcJ3sQsOX+6BM8zTLJrM8gH80LGA6U7?=\n\t=?utf-8?q?jwh1Ormsx48FTYzV4fx20gq9svq2fpN2xD3lS9XjgFeN9ZoInrll6ZyphFURBa+S2?=\n\t=?utf-8?q?Rr+Vt3fcVbob7qEKdgZ6n3D1hPKAqI2Nc2bizDIjfaPfERjOY4fL8IIFFeclZzAI3?=\n\t=?utf-8?q?/+4AHz7MktTRg9DhDAnZdtgrAY1bVvNq1XY6cK70WM0Lf8djz+VSZBt46Yle5yCEI?=\n\t=?utf-8?q?3yGNAImftcZbdLyMCUEmNz/NrK5+JOMZYuEZSoGFAE2bL/BJQPjuoTKdrfhkPdSgw?=\n\t=?utf-8?q?Mke14BR4Uw1ecOuvNErQ+WNoiqvCZbAAtWVHKTukMrUA9q8jLgC6+jjx/vLMvwlcB?=\n\t=?utf-8?q?obZ5DLwnXU0tZ?=", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(36860700004)(376005)(82310400014)(1800799015); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "25 Apr 2024 16:53:22.7014 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n f4309a52-93fd-4ad9-6c19-08dc654837d3", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n SJ5PEPF000001D3.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "LV3PR12MB9266", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Making 'rte_eth_stats_reset()' and 'rte_eth_xstats_reset()' APIs thread\nsafe has performance impact on datapath.\n\nInstead document APIs as not thread safe and add condition for reliable\nstats reset functionality, forwarding should be stopped.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@amd.com>\n---\nCc: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\nCc: Stephen Hemminger <stephen@networkplumber.org>\nCc: Morten Brørup <mb@smartsharesystems.com>\n\nThis update triggered by mail list discussion [1].\n\n[1]\nhttps://inbox.dpdk.org/dev/3b2cf48e-2293-4226-b6cd-5f4dd3969f99@lysator.liu.se/\n---\n lib/ethdev/rte_ethdev.h | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h\nindex 548fada1c7ad..40f04c0e191b 100644\n--- a/lib/ethdev/rte_ethdev.h\n+++ b/lib/ethdev/rte_ethdev.h\n@@ -3136,6 +3136,9 @@ int rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats);\n /**\n * Reset the general I/O statistics of an Ethernet device.\n *\n+ * API is not multi-thread safe.\n+ * Application should stop forwarding before calling this API.\n+ *\n * @param port_id\n * The port identifier of the Ethernet device.\n * @return\n@@ -3296,6 +3299,9 @@ int rte_eth_xstats_get_id_by_name(uint16_t port_id, const char *xstat_name,\n /**\n * Reset extended statistics of an Ethernet device.\n *\n+ * API is not multi-thread safe.\n+ * Application should stop forwarding before calling this API.\n+ *\n * @param port_id\n * The port identifier of the Ethernet device.\n * @return\n", "prefixes": [] }