Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139701/?format=api
{ "id": 139701, "url": "http://patchwork.dpdk.org/api/patches/139701/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240426090502.100487-1-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240426090502.100487-1-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240426090502.100487-1-mattias.ronnblom@ericsson.com", "date": "2024-04-26T09:05:02", "name": "[v3] net/af_packet: cache align Rx/Tx structs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5493d36f0e94eb1c59c7b7b7f857fa78bc2e2835", "submitter": { "id": 1077, "url": "http://patchwork.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240426090502.100487-1-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 31830, "url": "http://patchwork.dpdk.org/api/series/31830/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31830", "date": "2024-04-26T09:05:02", "name": "[v3] net/af_packet: cache align Rx/Tx structs", "version": 3, "mbox": "http://patchwork.dpdk.org/series/31830/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139701/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/139701/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 66C6843F13;\n\tFri, 26 Apr 2024 11:15:30 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 70EBA43CEC;\n\tFri, 26 Apr 2024 11:15:29 +0200 (CEST)", "from EUR01-VE1-obe.outbound.protection.outlook.com\n (mail-ve1eur01on2048.outbound.protection.outlook.com [40.107.14.48])\n by mails.dpdk.org (Postfix) with ESMTP id 086B340289;\n Fri, 26 Apr 2024 11:15:27 +0200 (CEST)", "from AS4P190CA0063.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:656::14)\n by DU0PR07MB9242.eurprd07.prod.outlook.com (2603:10a6:10:42d::15)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.22; Fri, 26 Apr\n 2024 09:15:26 +0000", "from AMS0EPF000001AB.eurprd05.prod.outlook.com\n (2603:10a6:20b:656:cafe::6d) by AS4P190CA0063.outlook.office365.com\n (2603:10a6:20b:656::14) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.25 via Frontend\n Transport; Fri, 26 Apr 2024 09:15:26 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n AMS0EPF000001AB.mail.protection.outlook.com (10.167.16.151) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7519.19 via Frontend Transport; Fri, 26 Apr 2024 09:15:25 +0000", "from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by\n smtp-central.internal.ericsson.com (100.87.178.69) with Microsoft SMTP Server\n id 15.2.1258.12; Fri, 26 Apr 2024 11:15:25 +0200", "from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100])\n by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id\n 935F81C006A; Fri, 26 Apr 2024 11:15:25 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=WMsEzUykLTRu2TB5asT6HPqSD2+GjcQu9A6McTaPJKO+0f78hMcs3NtgIIpJNkzVOa7+F8WxJyiduqC+SDRbu50i9cfjcjIJZ8p0D1srreQ9m3QdrdXgj+0szL8K5XBT1gGccbnrDDpO14vJTbFn0u76AaJqLrzoA3vB8naMorj0Tl2hBwCgZJTl3bt3XV67oRCxgLDEUWqzRX9VQlxiQ6f6o4H1r712o908AWN3zj+z/d3obCdwsGVEG1BQwtqUNslLsKZ5iqj4L2GyaWTGaLPxd8OZg1RIFTE9rfVKw1cSu/CSvrTNhj+Tf5qeBQzWwg9kEenIS8r1lv+KqXTBDw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=5uZB59glz7vmq0yAbr3ViVcHIYbxEhtkSl6UluLZxqc=;\n b=PpQaKwCA6g8kFn0q95RKvrM+bKH1I1f7VgH91BvCj4j2fK399Zn2J4Yhju3JwvmBnXEzBIGXo1RLJgu39NEtZW3aEqP/z88TE8vs5YLevNZfwmZE8539FMPaNqWKsbafvd2HS7Eve363o3kHoIzENLnN2fOcS2KDCSlUql2KGfdShcBBdSA85HrVfCbtvhKYZDQT2ySVmdB7WB995RR73SRnT6+284LvRIAp6DB7SqyiAvAiV7c/HlBNGspUB8jeMaX933YKmxSj/EErp0qxHMd23jvhmIaIg/oIJBU7F+GMbFiho17R1NP1DSSTGIpouQFrcHYJKdgbjN/zJxqmDg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=amd.com smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=5uZB59glz7vmq0yAbr3ViVcHIYbxEhtkSl6UluLZxqc=;\n b=lvIAz3TG3+KMvrVSZ9SI1M5/WTy2KpWYjjwQlggg2YaTAEr/3FqWHCQL4CjhAMjB8QwOEBkpM/a7oYmKyhrlqH+BNz5H3HyZ0/MaR0ITCqZ9yYRqIwnIIbjU7q9JFVr0fSHgzKCL8GzQldBviaxDlWJ6bnYeUS4g2E5x3u2GK7Ozms9GC5LTNVrX8CP/QfKvChVI4V9gUVhYmS/XEbCCqiH93CCDdc9ZU+gvWCH2dkG6zw8IFr5wKWYDDIRIWdBx8J6U+5w5lA2e3mueGQRO5kIVGwJH8xLTDLW7n+lifF4AtAgN4REQLUEgw4U+j+LDloQrt6VfdiLc/g1syKm79w==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "<hofors@lysator.liu.se>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Thomas Monjalon <thomas@monjalon.net>,\n \"John W . Linville\" <linville@tuxdriver.com>,\n Ferruh Yigit <ferruh.yigit@amd.com>,\n =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n <stable@dpdk.org>", "Subject": "[PATCH v3] net/af_packet: cache align Rx/Tx structs", "Date": "Fri, 26 Apr 2024 11:05:02 +0200", "Message-ID": "<20240426090502.100487-1-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240426073824.100386-1-mattias.ronnblom@ericsson.com>", "References": "<20240426073824.100386-1-mattias.ronnblom@ericsson.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AMS0EPF000001AB:EE_|DU0PR07MB9242:EE_", "X-MS-Office365-Filtering-Correlation-Id": "299acc7e-44d9-4f1c-3088-08dc65d168cb", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230031|376005|82310400014|1800799015|36860700004;", "X-Microsoft-Antispam-Message-Info": "=?utf-8?q?MUrifqSh0hmLZVNyt9xh3ggZ6G/Hmk2?=\n\t=?utf-8?q?1dhrnvLDCEye8hlib0hvOpHBU9FLRw/Cr5iBzHVkq49gT1fdberf7fSXqUShqcxob?=\n\t=?utf-8?q?yU2bBFno1DkpYmLmBKnD07fGqKhxNDpg6Q1yl8ISgpNObO6TSu3vl5voRmOR2jdk5?=\n\t=?utf-8?q?9SAvHF2+2HiUJQXfeFBaaNP3L21D5n/9oidWk/sk9mjUgAeql/0CbwlsDhQkx7BKQ?=\n\t=?utf-8?q?IbZPSyIs3JrQY8MyOYFWiqskN395dBpJODwQJfBPhdet/dwJutO1XHEnXbQClHuee?=\n\t=?utf-8?q?mVj4pmsRGJNU38xI7MjKUy5N3pnEwh7w1Qe7A2rGiUEs+P7+o7HWiW8CxiasczPKK?=\n\t=?utf-8?q?lyvsmZyJBUpljU6sIBldiA7hRLe3NqEXjXL+xJSOEtJoMyNReMf66nhuSbcMrkxxO?=\n\t=?utf-8?q?UtNkQ3btIJBLrfTEespNjccdYOpUmNsx8dneyf7aU6xgEoME86z9ssAploduVmdrI?=\n\t=?utf-8?q?cP+itwgBFdpHqfJH+80CGkoZZWpdT3LvXufjz+RFf2qIFyAnptFA/IwOocmPOvovq?=\n\t=?utf-8?q?Pv6ThdTbduYHiC/Ppo2tif/3axVFXNe3QpmXjFntUFnfSCz2M7tEQkc5cE99hKvkm?=\n\t=?utf-8?q?HCA7RHXrYqZDZDay0Ao65Kh9IW7et92HPVCQIGzdureQtjLwkj9vaDvvJA3dxi51u?=\n\t=?utf-8?q?2c2VC5o/B6imA84C0Fs6GNBLr3wH0zVmq1gDFQ5dyOD+3B6ROM0IfSk1EPAE2vsDU?=\n\t=?utf-8?q?TYMSLOnBa0F/YXnE+wx/dnRAdNK3SZLYsKcw7Hog50RLcqypzGLgsfxs1iAoH482i?=\n\t=?utf-8?q?uY3svk5ZDDIHV/tqpOOIAbvth8yNAo8KaqBPGxuNFWvlw7nxqYgTSrF8YlcgS3Sr4?=\n\t=?utf-8?q?fTuSjIYQvHTtHMcWwAINklo0ASFyHBojcog32UXu7Rf74hRe6ZGRUaoIWz+krYuQK?=\n\t=?utf-8?q?DIQrfJjYGkJdZzmXMokAGDYPhBkkeY320dj/V3qlbeFCBoEwTcViNY8ZY053YfBLC?=\n\t=?utf-8?q?2X9LxJXggiVG5CuQb+wgqW376nAjUBbtczJgr77K6/ghROO4fIzxkuxC1jznlWOF2?=\n\t=?utf-8?q?H+IOkxMuxpBToPmfWk6+5Yxy06i6EVzyFBruUS1KslI/sHa0hBgQxeJocv2nPRIdE?=\n\t=?utf-8?q?qC+rSwaJpYqx1xSn7g5GO4Q61EU4dmueSenm9TaL6KEaUOUQOtEqGxMXi/0e4+CvK?=\n\t=?utf-8?q?+562kPY+y8fNZ+FzYLsous6JEO7RV+M9GTZIEw3T7fccbu8yXn4N8ldhuyigVUPlj?=\n\t=?utf-8?q?GP1eWoz+Sa8dR0XLnJ1RSEdB92avw/jl+NGxGw1zinu/ISFC8LAU27Op0rRsORKYA?=\n\t=?utf-8?q?unwIjqVSjB5anBu4dBEw7ZIMYTYgCPXsQLFtlC5/VT7T0DmfWf2A+8yY5q5hXS9Sd?=\n\t=?utf-8?q?YStDurphVfYZ?=", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;\n CAT:NONE; SFS:(13230031)(376005)(82310400014)(1800799015)(36860700004);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "26 Apr 2024 09:15:25.9859 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 299acc7e-44d9-4f1c-3088-08dc65d168cb", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n AMS0EPF000001AB.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DU0PR07MB9242", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Cache align Rx and Tx queue struct to avoid false sharing.\n\nThe RX struct happens to be 64 bytes on x86_64 already, so cache\nalignment has no effect there, but it does on 32-bit ISAs.\n\nThe TX struct is 56 bytes on x86_64.\n\nBoth structs keep counters, and in the RX case they are updated even\nfor empty polls.\n\nv3: Move __rte_cache_aligned directive to a MSVC-compatible location.\n\nFixes: 364e08f2bbc0 (\"af_packet: add PMD for AF_PACKET-based virtual devices\")\nCc: stable@dpdk.org\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\n---\n drivers/net/af_packet/rte_eth_af_packet.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c\nindex 397a32db58..6b7b16f348 100644\n--- a/drivers/net/af_packet/rte_eth_af_packet.c\n+++ b/drivers/net/af_packet/rte_eth_af_packet.c\n@@ -6,6 +6,7 @@\n * All rights reserved.\n */\n \n+#include <rte_common.h>\n #include <rte_string_fns.h>\n #include <rte_mbuf.h>\n #include <ethdev_driver.h>\n@@ -39,7 +40,7 @@\n #define DFLT_FRAME_SIZE\t\t(1 << 11)\n #define DFLT_FRAME_COUNT\t(1 << 9)\n \n-struct pkt_rx_queue {\n+struct __rte_cache_aligned pkt_rx_queue {\n \tint sockfd;\n \n \tstruct iovec *rd;\n@@ -55,7 +56,7 @@ struct pkt_rx_queue {\n \tvolatile unsigned long rx_bytes;\n };\n \n-struct pkt_tx_queue {\n+struct __rte_cache_aligned pkt_tx_queue {\n \tint sockfd;\n \tunsigned int frame_data_size;\n \n", "prefixes": [ "v3" ] }