Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139726/?format=api
{ "id": 139726, "url": "http://patchwork.dpdk.org/api/patches/139726/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/CAOE=1Z1+oQmrofXh7t4fEzCNL_DrHO8iYZ7r2TKym56cyJoA=A@mail.gmail.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<CAOE=1Z1+oQmrofXh7t4fEzCNL_DrHO8iYZ7r2TKym56cyJoA=A@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAOE=1Z1+oQmrofXh7t4fEzCNL_DrHO8iYZ7r2TKym56cyJoA=A@mail.gmail.com", "date": "2024-04-30T01:17:30", "name": "[bugfix] set same mac of bond slave", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "fb304d2f7eb1ed578eea1823399bff11a2e454eb", "submitter": { "id": 1007, "url": "http://patchwork.dpdk.org/api/people/1007/?format=api", "name": "Simon Jones", "email": "batmanustc@gmail.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/CAOE=1Z1+oQmrofXh7t4fEzCNL_DrHO8iYZ7r2TKym56cyJoA=A@mail.gmail.com/mbox/", "series": [ { "id": 31841, "url": "http://patchwork.dpdk.org/api/series/31841/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31841", "date": "2024-04-30T01:17:30", "name": "[bugfix] set same mac of bond slave", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31841/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139726/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/139726/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E3EED43F4E;\n\tTue, 30 Apr 2024 03:17:45 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7A2C2402A8;\n\tTue, 30 Apr 2024 03:17:45 +0200 (CEST)", "from mail-pl1-f169.google.com (mail-pl1-f169.google.com\n [209.85.214.169])\n by mails.dpdk.org (Postfix) with ESMTP id 8F5F640262\n for <dev@dpdk.org>; Tue, 30 Apr 2024 03:17:43 +0200 (CEST)", "by mail-pl1-f169.google.com with SMTP id\n d9443c01a7336-1eab16c8d83so41155995ad.3\n for <dev@dpdk.org>; Mon, 29 Apr 2024 18:17:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1714439862; x=1715044662; darn=dpdk.org;\n h=to:subject:message-id:date:from:mime-version:from:to:cc:subject\n :date:message-id:reply-to;\n bh=o0zHPMSWF5OgM+d+NG2jiKnRHchwVhjI7Pw7/KrGSPE=;\n b=EkAr60IagH4VHn65n7TJFLEvWgY2oPHPT8hTggcP/muGG/ht+8oBqgX0eX8b3o9TqJ\n Sr3pQoGm/8ACYXYuCHiTou10HvRwml90IoMLY/koRpR+ljGlHvY74O6dWQON/l1iYgwJ\n D21Xh9tJ5X900qiW/YG6rHfzo8fZEMNVqwsy1wmiOtWRxMdJ+eVBpxlyWpUouSOZ5/hQ\n R7O8sXnUbQRoclBvwPhPUEpT+L8W+YIqjWAktz7MlSdPNHSQjxRdBACRMX09qFoG5zE3\n rNj8TxGF9keLO4l0xfFAgfO1xt77KL/IZZWTlrBhBnZBJmVDfsRz9jRJuufYGrUZjkaw\n nHVQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1714439862; x=1715044662;\n h=to:subject:message-id:date:from:mime-version:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=o0zHPMSWF5OgM+d+NG2jiKnRHchwVhjI7Pw7/KrGSPE=;\n b=X7eftcGJVJIkUtwdg5j3tzTQZ9SeM9Cj8r3FcphvEZi1Nduqfntfummzt7hl3ac1s6\n FG9lEVXzrkXSvApLdef4lkAQzMMESDvBe5uAGqofMMylcQqqUEdjei5evodI48hXE6ht\n 7lFWNOwt2z1HqnbAehKxinZuYWGtq7eGHplztk10pOTofnT/TSQvT10xTlicLQxfffQc\n awTazugZwoBH7SvqzeIJHEaJOY7Xv1GLoa10pSpDj5YOP140mfpSWRcAeLoPOLOXIRx4\n LcrWDLJ5l5/ccgGwEFukFFcc3nUyBWaCmrE5sn3EdKgee1ZYUudPenAxTAZhIWXX68gK\n IE2A==", "X-Gm-Message-State": "AOJu0Yyaqgfx4NF4wWNv3cMtSkrkyxvbPIylK07FXuYNQynDmYsEwSHD\n daeGqSerVA4yQ8bN9E9b1fdolO7rbMzSWWF/87B2dBQ58z4dBmPgRlSLO7v5YTV/gevwr83+MkL\n sefRdToeR7Fzt2Rb4OjBNhTF5vdAJbCdnVXT8cg==", "X-Google-Smtp-Source": "\n AGHT+IFRl64CW3z9BeVKc2L1lHPEZgBFImbi5r6+ilh1ArMeDM55ueevdACrkCiz8rfHytRVesCIecKVXgo4qZ2BHnM=", "X-Received": "by 2002:a17:903:40ca:b0:1e2:9ac2:4a03 with SMTP id\n t10-20020a17090340ca00b001e29ac24a03mr14707936pld.28.1714439862038; Mon, 29\n Apr 2024 18:17:42 -0700 (PDT)", "MIME-Version": "1.0", "From": "Simon Jones <batmanustc@gmail.com>", "Date": "Tue, 30 Apr 2024 09:17:30 +0800", "Message-ID": "\n <CAOE=1Z1+oQmrofXh7t4fEzCNL_DrHO8iYZ7r2TKym56cyJoA=A@mail.gmail.com>", "Subject": "[bugfix] set same mac of bond slave", "To": "dev@dpdk.org", "Content-Type": "multipart/alternative; boundary=\"000000000000f736b60617462232\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Hi, all\n\nShould bond slave need set same mac address?\nLike this patch does:\nhttps://github.com/batmancn/dpdk/commit/a484ac3f407a6a22d4eb63da23e98e8e76833722\n```\ncommit a484ac3f407a6a22d4eb63da23e98e8e76833722 (HEAD ->\nbugfix-bond-same-mac-20240429, batmancn/bugfix-bond-same-mac-20240429)\nAuthor: batmancn <batmanustc@gmail.com>\nDate: Mon Apr 29 18:44:18 2024 +0800\n\n Bugfix, config same mac address of bond slave.\n\n Signed-off-by: Simon Jones <batmanustc@gmail.com>\n\n~\n```\n\n----\nSimon Jones", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c\nb/drivers/net/bonding/rte_eth_bond_pmd.c\nindex c40d18d128..0387a9b2aa 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -1562,6 +1562,15 @@ mac_address_members_update(struct rte_eth_dev\n*bonding_eth_dev)\n }\n break;\n case BONDING_MODE_8023AD:\n+ for (i = 0; i < internals->slave_count; i++) {\n+ if (rte_eth_dev_default_mac_addr_set(\n+ internals->slaves[i].port_id,\n+ bonded_eth_dev->data->mac_addrs)) {\n+ RTE_BOND_LOG(ERR, \"Failed to update port Id\n%d MAC address\",\n+\ninternals->slaves[i].port_id);\n+ return -1;\n+ }\n+ }\n bond_mode_8023ad_mac_address_update(bonding_eth_dev);\n break;\n case BONDING_MODE_ACTIVE_BACKUP:\ndiff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex f1c658f49e..c3f8b8d01e 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -1746,7 +1746,8 @@ rte_eth_dev_start(uint16_t port_id)\n return ret;\n\n /* Lets restore MAC now if device does not support live change */\n- if (*dev_info.dev_flags & RTE_ETH_DEV_NOLIVE_MAC_ADDR)\n+ if ((*dev_info.dev_flags & RTE_ETH_DEV_NOLIVE_MAC_ADDR) &&\n+ !(*dev_info.dev_flags & RTE_ETH_DEV_BONDED_SLAVE))\n eth_dev_mac_restore(dev, &dev_info);\n\n diag = (*dev->dev_ops->dev_start)(dev);\n", "prefixes": [ "bugfix" ] }