Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139798/?format=api
{ "id": 139798, "url": "http://patchwork.dpdk.org/api/patches/139798/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240502055706.112443-7-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240502055706.112443-7-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240502055706.112443-7-mattias.ronnblom@ericsson.com", "date": "2024-05-02T05:57:06", "name": "[RFC,v6,6/6] eal: add unit tests for atomic bit access functions", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bbaf67d51868c7186fb1a0fc33bf7f4196744b6a", "submitter": { "id": 1077, "url": "http://patchwork.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240502055706.112443-7-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 31863, "url": "http://patchwork.dpdk.org/api/series/31863/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31863", "date": "2024-05-02T05:57:00", "name": "Improve EAL bit operations API", "version": 6, "mbox": "http://patchwork.dpdk.org/series/31863/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139798/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/139798/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8F04A43F65;\n\tThu, 2 May 2024 08:08:04 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9610D402F0;\n\tThu, 2 May 2024 08:07:37 +0200 (CEST)", "from EUR02-AM0-obe.outbound.protection.outlook.com\n (mail-am0eur02on2080.outbound.protection.outlook.com [40.107.247.80])\n by mails.dpdk.org (Postfix) with ESMTP id 86BD3402D6\n for <dev@dpdk.org>; Thu, 2 May 2024 08:07:33 +0200 (CEST)", "from AS4P251CA0024.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:5d3::16)\n by DB9PR07MB10004.eurprd07.prod.outlook.com (2603:10a6:10:4cd::18)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.29; Thu, 2 May\n 2024 06:07:32 +0000", "from AM4PEPF00025F98.EURPRD83.prod.outlook.com\n (2603:10a6:20b:5d3:cafe::2e) by AS4P251CA0024.outlook.office365.com\n (2603:10a6:20b:5d3::16) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.27 via Frontend\n Transport; Thu, 2 May 2024 06:07:32 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n AM4PEPF00025F98.mail.protection.outlook.com (10.167.16.7) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7519.0 via Frontend Transport; Thu, 2 May 2024 06:07:31 +0000", "from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by\n smtp-central.internal.ericsson.com (100.87.178.60) with Microsoft SMTP Server\n id 15.2.1544.9; Thu, 2 May 2024 08:07:31 +0200", "from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100])\n by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id\n 8056E380061; Thu, 2 May 2024 08:07:31 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=jwbZgHVwTMP4EHdlIlzKWMhWeSbcp9S/pYHVMFZpf3j/wU9YC0b7E8vxpBo7gZfzyOebPtIXMBBWn+weScurUw2a5j4z6o3vEI7j/klAn0SezElBTqTrlHvjJ3QirwMMb5EixwOTjsgEtIQtLjFuOzA4rZi6ppA1PcYV+31Et63UjxTGC4OU/35ecKwh5ZgoNZnECAx/OnGThoZOgrrgSMIrZByare7UekRAmT235UX1ol0+QS67P0sWksr4QvMx6xuZzVJUSWcz7hq3Epm6O2D6EKz2G36NACTwk+iJsXgxRQFNEJP8n49GNIu9AoMozW8wDQSUjQKYzj626VcrKw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=9OUelsYpMkkuM3XvGHV53aJb4v8YWs53DjmkXfumHoc=;\n b=ZdRvL9iag0MVyLoL+ivfHHSbVgeh4dhjZv1g05wBfB2LiO4b0Dm+wYvLj22/I93F4tw2gx+b0SmIZnPCUiodi8yZ1h6GS66JQIp7G0fCSTLw8YF9o/f2/ors1tgy7ONEvZkM4LDKZ/UvzGI7jI+YN5qR1JGsqV23y1/mlMaKv1gCb4QVCQJK4MbEvjWX5vy2ESDyMT1xqRLLBQFgjw48sqwHBYfOv7dayl4Hjm/A1Kpi4JFzscaJ4IpOQdjc1Cx6vRxSgc5QQMsYIaSNIApGWVXX4VxR9R5VktX4uN9QhxOIdO3M0jDljK0wKHMQUf7NfvpM0z3Sq+o7IB7nt8UGGA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=9OUelsYpMkkuM3XvGHV53aJb4v8YWs53DjmkXfumHoc=;\n b=jo0r5exqj3lg8w5FpZbpLK47fQ53rGSlwsGGD4bqX+v7LPpuJM7AvPho5XZ3bGkpBiq4+XkYxaVDHSUExDrX0TzNT5PQbmNPOh9fV5hWlsksaZhk6/UxGzcsC/+MaCNtN6yUEHxXi7SIM+npF7F/sgXlU7b7qPke186GM5xQMa1sIlH1FuVyvxu71ZqRLcBSKs3e6Spk6BLcNiiud2UwM5CcH/zZK674qmG9SIMmgXAQgZsDVBppP4Xok/kBVMhvR1UYWL4USKI0gUamARzh/TJWoBL4hp9Iv6Iv9oOSUnvZL1s8ANfLcPV2YBblFrXJS7rxn45CftbxpH/4mIwPlQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "<hofors@lysator.liu.se>, Heng Wang <heng.wang@ericsson.com>,\n \"Stephen Hemminger\" <stephen@networkplumber.org>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>, =?utf-8?q?Mattia?=\n\t=?utf-8?q?s_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "Subject": "[RFC v6 6/6] eal: add unit tests for atomic bit access functions", "Date": "Thu, 2 May 2024 07:57:06 +0200", "Message-ID": "<20240502055706.112443-7-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240502055706.112443-1-mattias.ronnblom@ericsson.com>", "References": "<20240430120810.108928-2-mattias.ronnblom@ericsson.com>\n <20240502055706.112443-1-mattias.ronnblom@ericsson.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AM4PEPF00025F98:EE_|DB9PR07MB10004:EE_", "X-MS-Office365-Filtering-Correlation-Id": "1463655b-71f5-4d0a-c5c4-08dc6a6e2770", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;ARA:13230031|1800799015|36860700004|376005;", "X-Microsoft-Antispam-Message-Info": "=?utf-8?q?tTzI7EhL8L6byEHhpEd9EK9bEs4Qns/?=\n\t=?utf-8?q?SXhPLlWNTRq4r+iWBMhv298yr1ZpEsrqLHSmrusH56NQW31LjUtS+5YtudGYLNWd8?=\n\t=?utf-8?q?f66+o8gHfe6tEUaPUbX2X4I3TWRknUqHLeE1LhRTvkrSLoqyM4zGEnggm+k7qx+kj?=\n\t=?utf-8?q?+oGrzMnCMoHndscj1SwQxYLh/dzan8Bz6ezEdUS9VjqxBpyQduj7JJxwqSF/R2R71?=\n\t=?utf-8?q?NE2do7ad8qi3x/pdSoDsZzTZ9QVrWs7L1VorHtSjD62tZcNGkZ9kPDvi8IqDU0fdg?=\n\t=?utf-8?q?nM14CPbqdeBU7TU3glYOFfmEkSYH/2hITz8k6oCb4TUbw8PLinlZBDQtxjkna0Pjz?=\n\t=?utf-8?q?RNLjp46LCU+A14RZAIqqthF4kMwGMTLq7mEC5Ewks3wXNaXFKZh0SMHF/xnwh0n+J?=\n\t=?utf-8?q?qZFZocPoBDO+yLpW9W4PG1f29O44FkEHIaLVX/n29Z3buO/rWeGOvELLBro1B0OhN?=\n\t=?utf-8?q?arvWvvz+RjHuT++onTRTdUCz8Zvh60ta4w1sXLyt5UjLzNW46MEnhYOmeZ9MerplP?=\n\t=?utf-8?q?xz8vqS6C2ABEwpJDK1CY96sfaTTkYG6QxHmHEsdAIPMjhh4+TLeVLIkukY+z8XuLN?=\n\t=?utf-8?q?8y6yfqFJwcwoaE1JE3ZNjqhuC9rGfI9gH1E9jVwXguDMqcW1e3/1RuJFRDQBgVEBd?=\n\t=?utf-8?q?Go1cUQct22VEezJYsD5i/dIwPo7xE3oUnCCdf5BGOg/rjmdEHszK90pfGYhLvewyn?=\n\t=?utf-8?q?iaecO6UZTcdpwIr9Nyi9P/pr+0DvZ5OM2s7atwJWozjpTxm2fYOO15h0msRaN4Ls5?=\n\t=?utf-8?q?K2NoBDX/6QB1M0de0PEvhABVtlhUNjQZStPRcHlb9B5qz4dBYuksvxFdwNpYOsAWd?=\n\t=?utf-8?q?muHdOyMceHcokjkefqsRpr+sIOyqjpBVAiH8VTzDa4GTbtRu22usT/dKrgcprI7HK?=\n\t=?utf-8?q?0Yw1mlL6q4XrdcYqAPeyHsqIwep8uLjtWIAF3vaXeNFnnjBxECLJ4pOL89wb3tKOL?=\n\t=?utf-8?q?2kC9JI97wWUKW/kwV81JwXPvUeCu5hool8rTRLibml4IqgBckB0g9smiWI9mdUlit?=\n\t=?utf-8?q?KXVdlPszWa758Q0x0bmQn8z8+DqL0HkJGx1jW3FhtjCPrJCqPjblMIlmCkqy3oKp1?=\n\t=?utf-8?q?Te4Kec2qntpsw6G2AnSEHl7rNAKNxhWnUm+upfNNypZUKycfnlRXd2Zas2fE0Bhev?=\n\t=?utf-8?q?1WNMkvc/nUHMNtqedAyHhjK47T+S0jEknHra24/4xTBzW+P7S9HCFMqAUNojr8KUP?=\n\t=?utf-8?q?VYFMDzGfIx/UNqOc3s9nMIConPBfgM7FH9EoPLFCTkHMeOybNKTgog55g8F/ZL+Ld?=\n\t=?utf-8?q?M4p+1Q1NsKvoaJwxubuZl3KCLf2LOata2WUMIIT6Bkg3erjLMD+Zx/fgUP/TP49bn?=\n\t=?utf-8?q?nClLrFLrDih4?=", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;\n CAT:NONE; SFS:(13230031)(1800799015)(36860700004)(376005); DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "02 May 2024 06:07:31.9947 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 1463655b-71f5-4d0a-c5c4-08dc6a6e2770", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n AM4PEPF00025F98.EURPRD83.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB9PR07MB10004", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Extend bitops tests to cover the rte_bit_atomic_*() family of\nfunctions.\n\nRFC v4:\n * Add atomicity test for atomic bit flip.\n\nRFC v3:\n * Rename variable 'main' to make ICC happy.\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n app/test/test_bitops.c | 315 ++++++++++++++++++++++++++++++++++++++++-\n 1 file changed, 314 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c\nindex 9bffc4da14..c86d7e1f77 100644\n--- a/app/test/test_bitops.c\n+++ b/app/test/test_bitops.c\n@@ -3,10 +3,13 @@\n * Copyright(c) 2024 Ericsson AB\n */\n \n+#include <inttypes.h>\n #include <stdbool.h>\n \n-#include <rte_launch.h>\n #include <rte_bitops.h>\n+#include <rte_cycles.h>\n+#include <rte_launch.h>\n+#include <rte_lcore.h>\n #include <rte_random.h>\n #include \"test.h\"\n \n@@ -69,6 +72,304 @@ GEN_TEST_BIT_ACCESS(test_bit_once_access64, rte_bit_once_set,\n \t\t rte_bit_once_clear, rte_bit_once_assign,\n \t\t rte_bit_once_flip, rte_bit_once_test, 64)\n \n+#define bit_atomic_set(addr, nr)\t\t\t\t\\\n+\trte_bit_atomic_set(addr, nr, rte_memory_order_relaxed)\n+\n+#define bit_atomic_clear(addr, nr)\t\t\t\t\t\\\n+\trte_bit_atomic_clear(addr, nr, rte_memory_order_relaxed)\n+\n+#define bit_atomic_assign(addr, nr, value)\t\t\t\t\\\n+\trte_bit_atomic_assign(addr, nr, value, rte_memory_order_relaxed)\n+\n+#define bit_atomic_flip(addr, nr)\t\t\t\t\t\\\n+ rte_bit_atomic_flip(addr, nr, rte_memory_order_relaxed)\n+\n+#define bit_atomic_test(addr, nr)\t\t\t\t\\\n+\trte_bit_atomic_test(addr, nr, rte_memory_order_relaxed)\n+\n+GEN_TEST_BIT_ACCESS(test_bit_atomic_access32, bit_atomic_set,\n+\t\t bit_atomic_clear, bit_atomic_assign,\n+\t\t bit_atomic_flip, bit_atomic_test, 32)\n+\n+GEN_TEST_BIT_ACCESS(test_bit_atomic_access64, bit_atomic_set,\n+\t\t bit_atomic_clear, bit_atomic_assign,\n+\t\t bit_atomic_flip, bit_atomic_test, 64)\n+\n+#define PARALLEL_TEST_RUNTIME 0.25\n+\n+#define GEN_TEST_BIT_PARALLEL_ASSIGN(size)\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\tstruct parallel_access_lcore ## size\t\t\t\t\\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\tunsigned int bit;\t\t\t\t\t\\\n+\t\tuint ## size ##_t *word;\t\t\t\t\\\n+\t\tbool failed;\t\t\t\t\t\t\\\n+\t};\t\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\tstatic int\t\t\t\t\t\t\t\\\n+\trun_parallel_assign ## size(void *arg)\t\t\t\t\\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\tstruct parallel_access_lcore ## size *lcore = arg;\t\\\n+\t\tuint64_t deadline = rte_get_timer_cycles() +\t\t\\\n+\t\t\tPARALLEL_TEST_RUNTIME * rte_get_timer_hz();\t\\\n+\t\tbool value = false;\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tdo {\t\t\t\t\t\t\t\\\n+\t\t\tbool new_value = rte_rand() & 1;\t\t\\\n+\t\t\tbool use_test_and_modify = rte_rand() & 1;\t\\\n+\t\t\tbool use_assign = rte_rand() & 1;\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\t\tif (rte_bit_atomic_test(lcore->word, lcore->bit, \\\n+\t\t\t\t\t\trte_memory_order_relaxed) != value) { \\\n+\t\t\t\tlcore->failed = true;\t\t\t\\\n+\t\t\t\tbreak;\t\t\t\t\t\\\n+\t\t\t}\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\t\tif (use_test_and_modify) {\t\t\t\\\n+\t\t\t\tbool old_value;\t\t\t\t\\\n+\t\t\t\tif (use_assign) \t\t\t\\\n+\t\t\t\t\told_value = rte_bit_atomic_test_and_assign( \\\n+\t\t\t\t\t\tlcore->word, lcore->bit, new_value, \\\n+\t\t\t\t\t\trte_memory_order_relaxed); \\\n+\t\t\t\telse {\t\t\t\t\t\\\n+\t\t\t\t\told_value = new_value ?\t\t\\\n+\t\t\t\t\t\trte_bit_atomic_test_and_set( \\\n+\t\t\t\t\t\t\tlcore->word, lcore->bit, \\\n+\t\t\t\t\t\t\trte_memory_order_relaxed) : \\\n+\t\t\t\t\t\trte_bit_atomic_test_and_clear( \\\n+\t\t\t\t\t\t\tlcore->word, lcore->bit, \\\n+\t\t\t\t\t\t\trte_memory_order_relaxed); \\\n+\t\t\t\t}\t\t\t\t\t\\\n+\t\t\t\tif (old_value != value) {\t\t\\\n+\t\t\t\t\tlcore->failed = true;\t\t\\\n+\t\t\t\t\tbreak;\t\t\t\t\\\n+\t\t\t\t}\t\t\t\t\t\\\n+\t\t\t} else {\t\t\t\t\t\\\n+\t\t\t\tif (use_assign)\t\t\t\t\\\n+\t\t\t\t\trte_bit_atomic_assign(lcore->word, lcore->bit, \\\n+\t\t\t\t\t\t\t new_value, \\\n+\t\t\t\t\t\t\t rte_memory_order_relaxed); \\\n+\t\t\t\telse {\t\t\t\t\t\\\n+\t\t\t\t\tif (new_value)\t\t\t\\\n+\t\t\t\t\t\trte_bit_atomic_set(\t\\\n+\t\t\t\t\t\t\tlcore->word, lcore->bit, \\\n+\t\t\t\t\t\t\trte_memory_order_relaxed); \\\n+\t\t\t\t\telse\t\t\t\t\\\n+\t\t\t\t\t\trte_bit_atomic_clear(\t\\\n+\t\t\t\t\t\t\tlcore->word, lcore->bit, \\\n+\t\t\t\t\t\t\trte_memory_order_relaxed); \\\n+\t\t\t\t}\t\t\t\t\t\\\n+\t\t\t}\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\t\tvalue = new_value;\t\t\t\t\\\n+\t\t} while (rte_get_timer_cycles() < deadline);\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\treturn 0;\t\t\t\t\t\t\\\n+\t}\t\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\tstatic int\t\t\t\t\t\t\t\\\n+\ttest_bit_atomic_parallel_assign ## size(void)\t\t\t\\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\tunsigned int worker_lcore_id;\t\t\t\t\\\n+\t\tuint ## size ## _t word = 0;\t\t\t\t\\\n+\t\tstruct parallel_access_lcore ## size lmain = {\t\t\\\n+\t\t\t.word = &word\t\t\t\t\t\\\n+\t\t};\t\t\t\t\t\t\t\\\n+\t\tstruct parallel_access_lcore ## size lworker = {\t\\\n+\t\t\t.word = &word\t\t\t\t\t\\\n+\t\t};\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tif (rte_lcore_count() < 2) {\t\t\t\t\\\n+\t\t\tprintf(\"Need multiple cores to run parallel test.\\n\"); \\\n+\t\t\treturn TEST_SKIPPED;\t\t\t\t\\\n+\t\t}\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tworker_lcore_id = rte_get_next_lcore(-1, 1, 0);\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tlmain.bit = rte_rand_max(size);\t\t\t\t\\\n+\t\tdo {\t\t\t\t\t\t\t\\\n+\t\t\tlworker.bit = rte_rand_max(size);\t\t\\\n+\t\t} while (lworker.bit == lmain.bit);\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tint rc = rte_eal_remote_launch(run_parallel_assign ## size, \\\n+\t\t\t\t\t &lworker, worker_lcore_id); \\\n+\t\tTEST_ASSERT(rc == 0, \"Worker thread launch failed\");\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\trun_parallel_assign ## size(&lmain);\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\trte_eal_mp_wait_lcore();\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tTEST_ASSERT(!lmain.failed, \"Main lcore atomic access failed\"); \\\n+\t\tTEST_ASSERT(!lworker.failed, \"Worker lcore atomic access \" \\\n+\t\t\t \"failed\");\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\treturn TEST_SUCCESS;\t\t\t\t\t\\\n+\t}\n+\n+GEN_TEST_BIT_PARALLEL_ASSIGN(32)\n+GEN_TEST_BIT_PARALLEL_ASSIGN(64)\n+\n+#define GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(size)\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\tstruct parallel_test_and_set_lcore ## size\t\t\t\\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\tuint ## size ##_t *word;\t\t\t\t\\\n+\t\tunsigned int bit;\t\t\t\t\t\\\n+\t\tuint64_t flips;\t\t\t\t\t\t\\\n+\t};\t\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\tstatic int\t\t\t\t\t\t\t\\\n+\trun_parallel_test_and_modify ## size(void *arg)\t\t\\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\tstruct parallel_test_and_set_lcore ## size *lcore = arg; \\\n+\t\tuint64_t deadline = rte_get_timer_cycles() +\t\t\\\n+\t\t\tPARALLEL_TEST_RUNTIME * rte_get_timer_hz();\t\\\n+\t\tdo {\t\t\t\t\t\t\t\\\n+\t\t\tbool old_value;\t\t\t\t\t\\\n+\t\t\tbool new_value = rte_rand() & 1;\t\t\\\n+\t\t\tbool use_assign = rte_rand() & 1;\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\t\tif (use_assign)\t\t\t\t\t\\\n+\t\t\t\told_value = rte_bit_atomic_test_and_assign( \\\n+\t\t\t\t\tlcore->word, lcore->bit, new_value, \\\n+\t\t\t\t\trte_memory_order_relaxed);\t\\\n+\t\t\telse\t\t\t\t\t\t\\\n+\t\t\t\told_value = new_value ?\t\t\t\\\n+\t\t\t\t\trte_bit_atomic_test_and_set(\t\\\n+\t\t\t\t\t\tlcore->word, lcore->bit, \\\n+\t\t\t\t\t\trte_memory_order_relaxed) : \\\n+\t\t\t\t\trte_bit_atomic_test_and_clear(\t\\\n+\t\t\t\t\t\tlcore->word, lcore->bit, \\\n+\t\t\t\t\t\trte_memory_order_relaxed); \\\n+\t\t\tif (old_value != new_value)\t\t\t\\\n+\t\t\t\tlcore->flips++;\t\t\t\t\\\n+\t\t} while (rte_get_timer_cycles() < deadline);\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\treturn 0;\t\t\t\t\t\t\\\n+\t}\t\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\tstatic int\t\t\t\t\t\t\t\\\n+\ttest_bit_atomic_parallel_test_and_modify ## size(void)\t\t\\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\tunsigned int worker_lcore_id;\t\t\t\t\\\n+\t\tuint ## size ## _t word = 0;\t\t\t\t\\\n+\t\tunsigned int bit = rte_rand_max(size);\t\t\t\\\n+\t\tstruct parallel_test_and_set_lcore ## size lmain = {\t\\\n+\t\t\t.word = &word,\t\t\t\t\t\\\n+\t\t\t.bit = bit\t\t\t\t\t\\\n+\t\t};\t\t\t\t\t\t\t\\\n+\t\tstruct parallel_test_and_set_lcore ## size lworker = {\t\\\n+\t\t\t.word = &word,\t\t\t\t\t\\\n+\t\t\t.bit = bit\t\t\t\t\t\\\n+\t\t};\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tif (rte_lcore_count() < 2) {\t\t\t\t\\\n+\t\t\tprintf(\"Need multiple cores to run parallel test.\\n\"); \\\n+\t\t\treturn TEST_SKIPPED;\t\t\t\t\\\n+\t\t}\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tworker_lcore_id = rte_get_next_lcore(-1, 1, 0);\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tint rc = rte_eal_remote_launch(run_parallel_test_and_modify ## size, \\\n+\t\t\t\t\t &lworker, worker_lcore_id); \\\n+\t\tTEST_ASSERT(rc == 0, \"Worker thread launch failed\");\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\trun_parallel_test_and_modify ## size(&lmain);\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\trte_eal_mp_wait_lcore();\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tuint64_t total_flips = lmain.flips + lworker.flips;\t\\\n+\t\tbool expected_value = total_flips % 2;\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tTEST_ASSERT(expected_value == rte_bit_test(&word, bit), \\\n+\t\t\t \"After %\"PRId64\" flips, the bit value \"\t\\\n+\t\t\t \"should be %d\", total_flips, expected_value); \\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tuint64_t expected_word = 0;\t\t\t\t\\\n+\t\trte_bit_assign(&expected_word, bit, expected_value);\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tTEST_ASSERT(expected_word == word, \"Untouched bits have \" \\\n+\t\t\t \"changed value\");\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\treturn TEST_SUCCESS;\t\t\t\t\t\\\n+\t}\n+\n+GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(32)\n+GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(64)\n+\n+#define GEN_TEST_BIT_PARALLEL_FLIP(size)\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\tstruct parallel_flip_lcore ## size\t\t\t\t\\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\tuint ## size ##_t *word;\t\t\t\t\\\n+\t\tunsigned int bit;\t\t\t\t\t\\\n+\t\tuint64_t flips;\t\t\t\t\t\t\\\n+\t};\t\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\tstatic int\t\t\t\t\t\t\t\\\n+\trun_parallel_flip ## size(void *arg)\t\t\t\t\\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\tstruct parallel_flip_lcore ## size *lcore = arg; \\\n+\t\tuint64_t deadline = rte_get_timer_cycles() +\t\t\\\n+\t\t\tPARALLEL_TEST_RUNTIME * rte_get_timer_hz();\t\\\n+\t\tdo {\t\t\t\t\t\t\t\\\n+\t\t\trte_bit_atomic_flip(lcore->word, lcore->bit,\t\\\n+\t\t\t\t\t rte_memory_order_relaxed);\t\\\n+\t\t\tlcore->flips++;\t\t\t\t\t\\\n+\t\t} while (rte_get_timer_cycles() < deadline);\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\treturn 0;\t\t\t\t\t\t\\\n+\t}\t\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\tstatic int\t\t\t\t\t\t\t\\\n+\ttest_bit_atomic_parallel_flip ## size(void)\t\t\t\\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\tunsigned int worker_lcore_id;\t\t\t\t\\\n+\t\tuint ## size ## _t word = 0;\t\t\t\t\\\n+\t\tunsigned int bit = rte_rand_max(size);\t\t\t\\\n+\t\tstruct parallel_flip_lcore ## size lmain = {\t\t\\\n+\t\t\t.word = &word,\t\t\t\t\t\\\n+\t\t\t.bit = bit\t\t\t\t\t\\\n+\t\t};\t\t\t\t\t\t\t\\\n+\t\tstruct parallel_flip_lcore ## size lworker = {\t\t\\\n+\t\t\t.word = &word,\t\t\t\t\t\\\n+\t\t\t.bit = bit\t\t\t\t\t\\\n+\t\t};\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tif (rte_lcore_count() < 2) {\t\t\t\t\\\n+\t\t\tprintf(\"Need multiple cores to run parallel test.\\n\"); \\\n+\t\t\treturn TEST_SKIPPED;\t\t\t\t\\\n+\t\t}\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tworker_lcore_id = rte_get_next_lcore(-1, 1, 0);\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tint rc = rte_eal_remote_launch(run_parallel_flip ## size, \\\n+\t\t\t\t\t &lworker, worker_lcore_id); \\\n+\t\tTEST_ASSERT(rc == 0, \"Worker thread launch failed\");\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\trun_parallel_flip ## size(&lmain);\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\trte_eal_mp_wait_lcore();\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tuint64_t total_flips = lmain.flips + lworker.flips;\t\\\n+\t\tbool expected_value = total_flips % 2;\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tTEST_ASSERT(expected_value == rte_bit_test(&word, bit), \\\n+\t\t\t \"After %\"PRId64\" flips, the bit value \"\t\\\n+\t\t\t \"should be %d\", total_flips, expected_value); \\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tuint64_t expected_word = 0;\t\t\t\t\\\n+\t\trte_bit_assign(&expected_word, bit, expected_value);\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tTEST_ASSERT(expected_word == word, \"Untouched bits have \" \\\n+\t\t\t \"changed value\");\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\treturn TEST_SUCCESS;\t\t\t\t\t\\\n+\t}\n+\n+GEN_TEST_BIT_PARALLEL_FLIP(32)\n+GEN_TEST_BIT_PARALLEL_FLIP(64)\n+\n static uint32_t val32;\n static uint64_t val64;\n \n@@ -187,6 +488,18 @@ static struct unit_test_suite test_suite = {\n \t\tTEST_CASE(test_bit_access64),\n \t\tTEST_CASE(test_bit_once_access32),\n \t\tTEST_CASE(test_bit_once_access64),\n+\t\tTEST_CASE(test_bit_access32),\n+\t\tTEST_CASE(test_bit_access64),\n+\t\tTEST_CASE(test_bit_once_access32),\n+\t\tTEST_CASE(test_bit_once_access64),\n+\t\tTEST_CASE(test_bit_atomic_access32),\n+\t\tTEST_CASE(test_bit_atomic_access64),\n+\t\tTEST_CASE(test_bit_atomic_parallel_assign32),\n+\t\tTEST_CASE(test_bit_atomic_parallel_assign64),\n+\t\tTEST_CASE(test_bit_atomic_parallel_test_and_modify32),\n+\t\tTEST_CASE(test_bit_atomic_parallel_test_and_modify64),\n+\t\tTEST_CASE(test_bit_atomic_parallel_flip32),\n+\t\tTEST_CASE(test_bit_atomic_parallel_flip64),\n \t\tTEST_CASE(test_bit_relaxed_set),\n \t\tTEST_CASE(test_bit_relaxed_clear),\n \t\tTEST_CASE(test_bit_relaxed_test_set_clear),\n", "prefixes": [ "RFC", "v6", "6/6" ] }