Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139802/?format=api
{ "id": 139802, "url": "http://patchwork.dpdk.org/api/patches/139802/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240502142116.63760-1-daniel.gregory@bytedance.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240502142116.63760-1-daniel.gregory@bytedance.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240502142116.63760-1-daniel.gregory@bytedance.com", "date": "2024-05-02T14:21:16", "name": "eal/arm: replace RTE_BUILD_BUG on non-constant", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3afa9dd6b30fcf217619013339bc10191ad3e579", "submitter": { "id": 3322, "url": "http://patchwork.dpdk.org/api/people/3322/?format=api", "name": "Daniel Gregory", "email": "daniel.gregory@bytedance.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240502142116.63760-1-daniel.gregory@bytedance.com/mbox/", "series": [ { "id": 31865, "url": "http://patchwork.dpdk.org/api/series/31865/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31865", "date": "2024-05-02T14:21:16", "name": "eal/arm: replace RTE_BUILD_BUG on non-constant", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31865/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139802/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/139802/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 881B343F69;\n\tThu, 2 May 2024 16:22:08 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0FCFB402B2;\n\tThu, 2 May 2024 16:22:08 +0200 (CEST)", "from mail-wm1-f51.google.com (mail-wm1-f51.google.com\n [209.85.128.51]) by mails.dpdk.org (Postfix) with ESMTP id 43F5B40299\n for <dev@dpdk.org>; Thu, 2 May 2024 16:22:06 +0200 (CEST)", "by mail-wm1-f51.google.com with SMTP id\n 5b1f17b1804b1-41b782405bbso48219845e9.1\n for <dev@dpdk.org>; Thu, 02 May 2024 07:22:06 -0700 (PDT)", "from C02FF2N1MD6T.bytedance.net ([79.173.157.19])\n by smtp.gmail.com with ESMTPSA id\n s7-20020a05600c384700b0041c12324eb6sm5904744wmr.22.2024.05.02.07.22.05\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 02 May 2024 07:22:05 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bytedance.com; s=google; t=1714659726; x=1715264526; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=joYaMtyx/EraF468MIeAT/phfNyE11LoenH8GP9ck6A=;\n b=CFIRcsp6h/HrneQPg7iZMSWXccca0nhBmVDdh5gyGZdGxB0YM7tjCo3UAjXz+Ttfbk\n ZnqVlsodUS1v8LJEogXrV8IfizVfGYBteU8N2d6U/cCLhWOcMcSzUwog1/BTy9xawQGk\n FKxZ0zcjwHBUpY+j2+6c7dqRtvH5MydZcd3S+rUgzXJwJAQHafVAXzFeOUPU1rx1t25x\n 6HIgc0MaTKZQjXnPSmWpYmstvysEzfe8NU5PmCegLTXZwOrjOeXpcLiseR8mQiyG8P7f\n BN7wsyqSkQDqSOmhmlyDbIns/axCWIgO1iLP3lAQQ8WDgK4+sJwQfdeGEtGnNVIPkA6e\n Haiw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1714659726; x=1715264526;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=joYaMtyx/EraF468MIeAT/phfNyE11LoenH8GP9ck6A=;\n b=rssuFBH41CgLVU1EuuQzPDfhSOi7H7clDfEos71kiJSOztVOuAwli/zwq5PY+fX23x\n m8H8hY3JgcmmqiRE6feK37jlTiF4L/T8tQjPzNRqQVVDUshz4BYVnFKRue35EgQAiJ0v\n p5rwxz1tOrRgTyaSgxDa/1pyTKOE1wEHZzEgFY263UwS9SYUkPLlHJKdLJd5jRdYfJ3I\n tHCW9xMacmgKSUxzz1Vb2Oq5gu8l5qvs9o+O/2GxDKz9hvjfKVyiZE88otVi1UdzdUyV\n tNtq7eIFgTPnAqmvmkAwdrQtMP+RgHwfJjOsaNgdWY857/Sf9r4yYnAsNfjZAkmCPGPj\n IcEA==", "X-Gm-Message-State": "AOJu0Yz13g+JagMnSlHG7/SxCgnPT0CPqzcIRzBPk58zMWxfKWmlnEvk\n GPHYZA3eJKIchEulvNO5eyFMj4AjxZvsRs7PyWsq5FCdpts913HAkUsNzmRKfm4=", "X-Google-Smtp-Source": "\n AGHT+IFZzrZ4zBVWKLn6q+OTsfOaRdmPKwFjE5jpF9F7vrSLQWRlyNwtLmISHO3rrEp1mOt2WZF/fw==", "X-Received": "by 2002:a05:600c:358c:b0:41c:3e1:9dbd with SMTP id\n p12-20020a05600c358c00b0041c03e19dbdmr1437240wmq.40.1714659725701;\n Thu, 02 May 2024 07:22:05 -0700 (PDT)", "From": "Daniel Gregory <daniel.gregory@bytedance.com>", "To": "Ruifeng Wang <ruifeng.wang@arm.com>", "Cc": "dev@dpdk.org, Punit Agrawal <punit.agrawal@bytedance.com>,\n Liang Ma <liangma@bytedance.com>,\n Daniel Gregory <daniel.gregory@bytedance.com>", "Subject": "[PATCH] eal/arm: replace RTE_BUILD_BUG on non-constant", "Date": "Thu, 2 May 2024 15:21:16 +0100", "Message-Id": "<20240502142116.63760-1-daniel.gregory@bytedance.com>", "X-Mailer": "git-send-email 2.39.3 (Apple Git-146)", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The ARM implementation of rte_pause uses RTE_BUILD_BUG_ON to check\nmemorder, which is not constant. This causes compile errors when it is\nenabled with RTE_ARM_USE_WFE. eg.\n\n../lib/eal/arm/include/rte_pause_64.h: In function ‘rte_wait_until_equal_16’:\n../lib/eal/include/rte_common.h:530:56: error: expression in static assertion is not constant\n 530 | #define RTE_BUILD_BUG_ON(condition) do { static_assert(!(condition), #condition); } while (0)\n | ^~~~~~~~~~~~\n../lib/eal/arm/include/rte_pause_64.h:156:9: note: in expansion of macro ‘RTE_BUILD_BUG_ON’\n 156 | RTE_BUILD_BUG_ON(memorder != rte_memory_order_acquire &&\n | ^~~~~~~~~~~~~~~~\n\nThis has been the case since the switch to C11 assert (537caad2). Fix\nthe compile errors by replacing the check with an RTE_ASSERT.\n\nSigned-off-by: Daniel Gregory <daniel.gregory@bytedance.com>\n---\n lib/eal/arm/include/rte_pause_64.h | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/eal/arm/include/rte_pause_64.h b/lib/eal/arm/include/rte_pause_64.h\nindex 5cb8b59056..98e10e91c4 100644\n--- a/lib/eal/arm/include/rte_pause_64.h\n+++ b/lib/eal/arm/include/rte_pause_64.h\n@@ -11,6 +11,7 @@ extern \"C\" {\n #endif\n \n #include <rte_common.h>\n+#include <rte_debug.h>\n \n #ifdef RTE_ARM_USE_WFE\n #define RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED\n@@ -153,7 +154,7 @@ rte_wait_until_equal_16(volatile uint16_t *addr, uint16_t expected,\n {\n \tuint16_t value;\n \n-\tRTE_BUILD_BUG_ON(memorder != rte_memory_order_acquire &&\n+\tRTE_ASSERT(memorder != rte_memory_order_acquire &&\n \t\tmemorder != rte_memory_order_relaxed);\n \n \t__RTE_ARM_LOAD_EXC_16(addr, value, memorder)\n@@ -172,7 +173,7 @@ rte_wait_until_equal_32(volatile uint32_t *addr, uint32_t expected,\n {\n \tuint32_t value;\n \n-\tRTE_BUILD_BUG_ON(memorder != rte_memory_order_acquire &&\n+\tRTE_ASSERT(memorder != rte_memory_order_acquire &&\n \t\tmemorder != rte_memory_order_relaxed);\n \n \t__RTE_ARM_LOAD_EXC_32(addr, value, memorder)\n@@ -191,7 +192,7 @@ rte_wait_until_equal_64(volatile uint64_t *addr, uint64_t expected,\n {\n \tuint64_t value;\n \n-\tRTE_BUILD_BUG_ON(memorder != rte_memory_order_acquire &&\n+\tRTE_ASSERT(memorder != rte_memory_order_acquire &&\n \t\tmemorder != rte_memory_order_relaxed);\n \n \t__RTE_ARM_LOAD_EXC_64(addr, value, memorder)\n", "prefixes": [] }