Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139816/?format=api
{ "id": 139816, "url": "http://patchwork.dpdk.org/api/patches/139816/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240502213618.11391-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240502213618.11391-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240502213618.11391-4-stephen@networkplumber.org", "date": "2024-05-02T21:31:39", "name": "[v12,03/12] net/tap: remove unused fields", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0cc4bbcc8a2f01af5abe1738fa093291b7f3d4c3", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240502213618.11391-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 31871, "url": "http://patchwork.dpdk.org/api/series/31871/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31871", "date": "2024-05-02T21:31:36", "name": "net/tap: RSS and other fixes", "version": 12, "mbox": "http://patchwork.dpdk.org/series/31871/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139816/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139816/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BACFE43F6C;\n\tThu, 2 May 2024 23:36:52 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4FCC9402F1;\n\tThu, 2 May 2024 23:36:35 +0200 (CEST)", "from mail-pf1-f173.google.com (mail-pf1-f173.google.com\n [209.85.210.173])\n by mails.dpdk.org (Postfix) with ESMTP id 60CCC402D4\n for <dev@dpdk.org>; Thu, 2 May 2024 23:36:31 +0200 (CEST)", "by mail-pf1-f173.google.com with SMTP id\n d2e1a72fcca58-6f074520c8cso8043298b3a.0\n for <dev@dpdk.org>; Thu, 02 May 2024 14:36:31 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n f14-20020a056a001ace00b006f3eee787d5sm1804829pfv.18.2024.05.02.14.36.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 02 May 2024 14:36:30 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714685790;\n x=1715290590; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=;\n b=GUoyvITfAbqz6shfD2kP+kicd5cGIJOvY1LKoP46A53V4mvg+y5t+0AJds9UQeb0dr\n zOOdDDGZFnATc6x1jxiPDmH4YeH7e80+8IDjMiWrJq9JLWt2D3Yno0Ku/x0dPDQIX/Uz\n W56GyNaNzOS3EdH6RQyJJwC6VHUTz+6Y7BAWDStXPvZ3DGcUI4Ga+2rFhG/u6i1cIvbD\n M0P+DUDLHafUrNinTR9gnKOJXaNqn41FvGpqNMTE83bwRlW+8KY/SurOSozWOo+EfHUQ\n IPYYR3x00HCJTzFd8LLc2/PXO7XtIo/g1PCIzS+CjZtMik1k9fS8+stwq/al0ggWS4xq\n QFAg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1714685790; x=1715290590;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=;\n b=bZapP9lMwBQR0i5aGzQPwiUL2+FNljqH7Gm2H2iNQ5fa/bi5miM74w1r75ccbceqfh\n SpnLmnB6tFtyCWKo4lQIulG1BCcjAqPuhyXHF1oJ8eFFQiRLby3av/YSzNfAc2qY950w\n BpaQD/qNB1i8XkLXB6veIire+qsMEoZx5DDN6et3Ip9a12pqwgzhr1IzZc4P36QccXRb\n a3gdm418tgokCi8ZrVG63iQ6fzKsUN0l1VMFHb5usHjHa/zUKDuU7Ruu2qh0Irj37QgZ\n TSAsB2+tn2a/n4I2Ql4+q/kvmtBUIlrhEWgmDfsRyRCXDXreviTml7JNv+cpligSUuMl\n dhKA==", "X-Gm-Message-State": "AOJu0Yy2SodBzvHZ1v46+isqkLPjBxXCOXo8c2S195n5v77w37n4p/NL\n 19W47QFOrQy04uJkU8GnuqvRxdgalhnPQy5OXF8Jwi+//TuKCtKlctYUWyUZAH7agtx4zQhVXfN\n S/LwwbA==", "X-Google-Smtp-Source": "\n AGHT+IFODuUhEp7rU5ighHnx+T8nDBTyBOYvYeRcqOZkCoEyJ0cW+A0+AZJSfaNUi8e0306zaw5rbA==", "X-Received": "by 2002:a05:6a00:2e88:b0:6ed:6f25:f361 with SMTP id\n fd8-20020a056a002e8800b006ed6f25f361mr968379pfb.29.1714685790449;\n Thu, 02 May 2024 14:36:30 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v12 03/12] net/tap: remove unused fields", "Date": "Thu, 2 May 2024 14:31:39 -0700", "Message-ID": "<20240502213618.11391-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240502213618.11391-1-stephen@networkplumber.org>", "References": "<20240130034925.44869-1-stephen@networkplumber.org>\n <20240502213618.11391-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The driver doesn't support these other hash types, and there\nis no reason to implement these in future. The rss_flows list\nwas set but never used.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/tap/rte_eth_tap.h | 4 +---\n drivers/net/tap/tap_flow.c | 1 -\n drivers/net/tap/tap_rss.h | 6 ------\n 3 files changed, 1 insertion(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/tap/rte_eth_tap.h b/drivers/net/tap/rte_eth_tap.h\nindex dc8201020b..1bcf92ce80 100644\n--- a/drivers/net/tap/rte_eth_tap.h\n+++ b/drivers/net/tap/rte_eth_tap.h\n@@ -77,14 +77,12 @@ struct pmd_internals {\n \tint ioctl_sock; /* socket for ioctl calls */\n \tint nlsk_fd; /* Netlink socket fd */\n \tint flow_isolate; /* 1 if flow isolation is enabled */\n-\tint flower_support; /* 1 if kernel supports, else 0 */\n-\tint flower_vlan_support; /* 1 if kernel supports, else 0 */\n \tint rss_enabled; /* 1 if RSS is enabled, else 0 */\n \tint persist;\t\t\t /* 1 if keep link up, else 0 */\n \t/* implicit rules set when RSS is enabled */\n \tint map_fd; /* BPF RSS map fd */\n \tint bpf_fd[RTE_PMD_TAP_MAX_QUEUES];/* List of bpf fds per queue */\n-\tLIST_HEAD(tap_rss_flows, rte_flow) rss_flows;\n+\n \tLIST_HEAD(tap_flows, rte_flow) flows; /* rte_flow rules */\n \t/* implicit rte_flow rules set when a remote device is active */\n \tLIST_HEAD(tap_implicit_flows, rte_flow) implicit_flows;\ndiff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c\nindex a78fd50cd4..8fccd599f0 100644\n--- a/drivers/net/tap/tap_flow.c\n+++ b/drivers/net/tap/tap_flow.c\n@@ -1958,7 +1958,6 @@ static int rss_enable(struct pmd_internals *pmd,\n \t\t\t\terrno, strerror(errno));\n \t\t\treturn err;\n \t\t}\n-\t\tLIST_INSERT_HEAD(&pmd->rss_flows, rss_flow, next);\n \t}\n \n \tpmd->rss_enabled = 1;\ndiff --git a/drivers/net/tap/tap_rss.h b/drivers/net/tap/tap_rss.h\nindex dff46a012f..8766ffc244 100644\n--- a/drivers/net/tap/tap_rss.h\n+++ b/drivers/net/tap/tap_rss.h\n@@ -21,12 +21,6 @@ enum hash_field {\n \tHASH_FIELD_IPV4_L3_L4,\t/* IPv4 src/dst addr + L4 src/dst ports */\n \tHASH_FIELD_IPV6_L3,\t/* IPv6 src/dst addr */\n \tHASH_FIELD_IPV6_L3_L4,\t/* IPv6 src/dst addr + L4 src/dst ports */\n-\tHASH_FIELD_L2_SRC,\t/* Ethernet src addr */\n-\tHASH_FIELD_L2_DST,\t/* Ethernet dst addr */\n-\tHASH_FIELD_L3_SRC,\t/* L3 src addr */\n-\tHASH_FIELD_L3_DST,\t/* L3 dst addr */\n-\tHASH_FIELD_L4_SRC,\t/* TCP/UDP src ports */\n-\tHASH_FIELD_L4_DST,\t/* TCP/UDP dst ports */\n };\n \n struct rss_key {\n", "prefixes": [ "v12", "03/12" ] }