Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139843/?format=api
{ "id": 139843, "url": "http://patchwork.dpdk.org/api/patches/139843/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/e7cfdec6a08fd0d8cabe7f22510b18ae4e3fcb78.1714744628.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<e7cfdec6a08fd0d8cabe7f22510b18ae4e3fcb78.1714744628.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/e7cfdec6a08fd0d8cabe7f22510b18ae4e3fcb78.1714744628.git.anatoly.burakov@intel.com", "date": "2024-05-03T13:57:46", "name": "[v2,15/27] net/ixgbe/base: filter out spurious link up indication", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "dbece49af2e7046822ec38ac015d2bf11b437a57", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/e7cfdec6a08fd0d8cabe7f22510b18ae4e3fcb78.1714744628.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 31875, "url": "http://patchwork.dpdk.org/api/series/31875/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31875", "date": "2024-05-03T13:57:31", "name": "Update IXGBE base driver", "version": 2, "mbox": "http://patchwork.dpdk.org/series/31875/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139843/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/139843/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 661A043F76;\n\tFri, 3 May 2024 16:00:03 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2A83D40DDE;\n\tFri, 3 May 2024 15:58:54 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.15])\n by mails.dpdk.org (Postfix) with ESMTP id F038A40E09\n for <dev@dpdk.org>; Fri, 3 May 2024 15:58:51 +0200 (CEST)", "from fmviesa002.fm.intel.com ([10.60.135.142])\n by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 May 2024 06:58:51 -0700", "from silpixa00401119.ir.intel.com ([10.55.129.167])\n by fmviesa002.fm.intel.com with ESMTP; 03 May 2024 06:58:50 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1714744732; x=1746280732;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=pGIAgsVSnCsBr0uCmf5KfzmGfU5QPV0DkdvoQ51t2M8=;\n b=L3I0Afz6XA2OSxxs/myyk4Z6USP+wIuOt6gCX01yn5WoEsTIdST+/32S\n y5NFhBlG+fG+5aifLojME4RDYs6JOouTqNctNXWKTZsJfXHX4OJ9gtWt0\n XzPabOzWR+J2HuqhJmptwaQGf/nI5pQkpViJNyOV9FLFuBHayK49ZgJvw\n OBcM3PIbcSNRwCzPxXTKXIksN0SYC/ZJoSGp9PM5XgTknGGy0KglEmxWP\n mt9wbY65mO2Kip3734FV9+GZDtYqZxuOKYrxODU7n0NhF0tBPUhZv2COx\n 8elM/uFKwYGk7ZRb9eSVXi72lk2MPi2Yam7jRMRVxFs/6ummnVKJPqHJ4 w==;", "X-CSE-ConnectionGUID": [ "6/T21L5lRcudwtgw8We7XQ==", "Gh2EExLqTy+FxKcmG057pg==" ], "X-CSE-MsgGUID": [ "7zlKt1pEQ4CBS0xGeU03KQ==", "A0Kp1D3fTmWTCsJc356MNA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,11063\"; a=\"10714955\"", "E=Sophos;i=\"6.07,251,1708416000\"; d=\"scan'208\";a=\"10714955\"", "E=Sophos;i=\"6.07,251,1708416000\"; d=\"scan'208\";a=\"50642026\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Krzysztof Galazka <krzysztof.galazka@intel.com>,\n bruce.richardson@intel.com, vladimir.medvedkin@intel.com,\n Jan Sokolowski <jan.sokolowski@intel.com>", "Subject": "[PATCH v2 15/27] net/ixgbe/base: filter out spurious link up\n indication", "Date": "Fri, 3 May 2024 14:57:46 +0100", "Message-ID": "\n <e7cfdec6a08fd0d8cabe7f22510b18ae4e3fcb78.1714744628.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<cover.1714744628.git.anatoly.burakov@intel.com>", "References": "<cover.1713964707.git.anatoly.burakov@intel.com>\n <cover.1714744628.git.anatoly.burakov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Krzysztof Galazka <krzysztof.galazka@intel.com>\n\nExtend SFP+ cage crosstalk fix by re-checking link state\nafter 5ms delay to filter out spurious link up indication\nby transceiver with no fibre cable connected.\n\nSigned-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>\nReviewed-by: Jan Sokolowski <jan.sokolowski@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_common.c | 19 +++++++++++++++++--\n 1 file changed, 17 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c\nindex bb6e72fbe6..a19f4d715c 100644\n--- a/drivers/net/ixgbe/base/ixgbe_common.c\n+++ b/drivers/net/ixgbe/base/ixgbe_common.c\n@@ -4194,10 +4194,25 @@ s32 ixgbe_check_mac_link_generic(struct ixgbe_hw *hw, ixgbe_link_speed *speed,\n \t\t\tlinks_reg = IXGBE_READ_REG(hw, IXGBE_LINKS);\n \t\t}\n \t} else {\n-\t\tif (links_reg & IXGBE_LINKS_UP)\n+\t\tif (links_reg & IXGBE_LINKS_UP) {\n+\t\t\tif (ixgbe_need_crosstalk_fix(hw)) {\n+\t\t\t\t/* Check the link state again after a delay\n+\t\t\t\t * to filter out spurious link up\n+\t\t\t\t * notifications.\n+\t\t\t\t */\n+\t\t\t\tmsec_delay(5);\n+\t\t\t\tlinks_reg = IXGBE_READ_REG(hw, IXGBE_LINKS);\n+\t\t\t\tif (!(links_reg & IXGBE_LINKS_UP)) {\n+\t\t\t\t\t*link_up = false;\n+\t\t\t\t\t*speed = IXGBE_LINK_SPEED_UNKNOWN;\n+\t\t\t\t\treturn IXGBE_SUCCESS;\n+\t\t\t\t}\n+\n+\t\t\t}\n \t\t\t*link_up = true;\n-\t\telse\n+\t\t} else {\n \t\t\t*link_up = false;\n+\t\t}\n \t}\n \n \tswitch (links_reg & IXGBE_LINKS_SPEED_82599) {\n", "prefixes": [ "v2", "15/27" ] }