Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139865/?format=api
{ "id": 139865, "url": "http://patchwork.dpdk.org/api/patches/139865/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240505073313.118515-6-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240505073313.118515-6-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240505073313.118515-6-mattias.ronnblom@ericsson.com", "date": "2024-05-05T07:33:13", "name": "[RFC,v5,6/6] event/dsw: optimize serving port logic", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0a2f6430888e7268be0b1ea64c4f4a0773e791ca", "submitter": { "id": 1077, "url": "http://patchwork.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240505073313.118515-6-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 31881, "url": "http://patchwork.dpdk.org/api/series/31881/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31881", "date": "2024-05-05T07:33:08", "name": "[RFC,v5,1/6] eal: add bitset type", "version": 5, "mbox": "http://patchwork.dpdk.org/series/31881/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139865/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/139865/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5B38143FAC;\n\tSun, 5 May 2024 09:44:07 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E186F4064C;\n\tSun, 5 May 2024 09:43:43 +0200 (CEST)", "from EUR05-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur05on2053.outbound.protection.outlook.com [40.107.21.53])\n by mails.dpdk.org (Postfix) with ESMTP id B981C4025D\n for <dev@dpdk.org>; Sun, 5 May 2024 09:43:37 +0200 (CEST)", "from DUZPR01CA0332.eurprd01.prod.exchangelabs.com\n (2603:10a6:10:4b8::18) by AS8PR07MB7765.eurprd07.prod.outlook.com\n (2603:10a6:20b:396::16) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.39; Sun, 5 May\n 2024 07:43:36 +0000", "from DB1PEPF000509E7.eurprd03.prod.outlook.com\n (2603:10a6:10:4b8:cafe::fb) by DUZPR01CA0332.outlook.office365.com\n (2603:10a6:10:4b8::18) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.39 via Frontend\n Transport; Sun, 5 May 2024 07:43:36 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n DB1PEPF000509E7.mail.protection.outlook.com (10.167.242.57) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7519.19 via Frontend Transport; Sun, 5 May 2024 07:43:36 +0000", "from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by\n smtp-central.internal.ericsson.com (100.87.178.69) with Microsoft SMTP Server\n id 15.2.1544.9; Sun, 5 May 2024 09:43:35 +0200", "from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100])\n by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id\n 258FA38007A; Sun, 5 May 2024 09:43:35 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=g8YJRG2mxjp3hmazc7Qp+B4O0XRZZqFAKMFKKioZJF0JR8zRO7xnvil2CcCbFrTyCkLITEHZ6H8xeBGTAw2PwvMu4DidfXuK4ZsOOCUU4tEdbArrMQ+rNk4Mp06BRnsGr99QwB2DAp3F/dQDxID1IGYHWVYzFR5USSIU7N1rCXB0tU7U3hkqKaLsLS8/szKna7ZqaDAJwmiSRo9UM5fW+e/F5Fyo9/8REfDr79ONmvjCAG2NUqNZey6jG+W+QNmq08wXZSKSPl1vpoTPW92DfxSnIrXXFRDk4KdRPlz1OmY8762x4ovnPLTKNrayoHu79ER/BMLKkEzDOa9ljq20Kw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=yg9JyEy7mLkxh3uPP7MtbRx4iQ/spseeByLLkTdz4d0=;\n b=aYcqtmE9e/qiglTYihtXS6SUJTzeFKhuQK1sGN7MX+nPRNCUvDIGc4ZdIBxujyf+u2tgqWmb4HpJFK/QdV1i8HM1zNQp97ucTKrKq4pYeS+YwUEAmZ8wbv6ZnOp4ReUHNf6UNakb+qiPzUq17SPU5CILBMRUFHdluKkAw32lH0X0eZ7/Nxf5Iu7bBJbYyg/vb9oautzXjrHtSuFqCzE/wBg7kFmJwn+OYuKRIdPF7pU7byG66hleFA18M/rX9IZ20ypMiludaggpUZcHIFmrBUaFJ3cd0MnrvxrCiDnSviXHYLOIJ3LdN/W5X7v9X0b2inSYJQ9CeTGR8ISMmqztHg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=yg9JyEy7mLkxh3uPP7MtbRx4iQ/spseeByLLkTdz4d0=;\n b=qrD13SVzZMIwZcAl2zesOO9xH0dCecWjuCZeb8vQVfChNMQ3O2wbW48xfl6XVPDkLr7OcdU+YMIHHwjfLkuPwiGTbwabb2yzvWvv2xUFdwMPcC14P2Oqkw01P0t08WJuQnYSdj/uAV5zGRbfaxoqkyVlhJ9fX8adGvRzzKjAKiNRZfZtOJV5WppG7wZtRGnIOaTvxUX+0UCCen8OknIe4nD9ByJC3o2eJw/GEuGumPFxUYMQDImmDEv7LY3ATIFIdyohKIsA5HcpOGvUB6xWYsEGgpzKosDvzokvee7C7u25GS+Nes9Z9mU9Rf436r3iQmUKaGw2HQlLF+Riu8nvZg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "<hofors@lysator.liu.se>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Harry van Haaren <harry.van.haaren@intel.com>, =?utf-8?q?Mattias_R=C3=B6nnb?=\n\t=?utf-8?q?lom?= <mattias.ronnblom@ericsson.com>", "Subject": "[RFC v5 6/6] event/dsw: optimize serving port logic", "Date": "Sun, 5 May 2024 09:33:13 +0200", "Message-ID": "<20240505073313.118515-6-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240505073313.118515-1-mattias.ronnblom@ericsson.com>", "References": "<20240216102348.480407-1-mattias.ronnblom@ericsson.com>\n <20240505073313.118515-1-mattias.ronnblom@ericsson.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DB1PEPF000509E7:EE_|AS8PR07MB7765:EE_", "X-MS-Office365-Filtering-Correlation-Id": "b95395f7-336b-4b66-6d5e-08dc6cd7127b", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230031|82310400017|36860700004|1800799015|376005;", "X-Microsoft-Antispam-Message-Info": "=?utf-8?q?nP0pd3993kRA3aj9Cm/3SA/IAXmHsdf?=\n\t=?utf-8?q?gmOj2PC6hzz0xjTzGs9fmsEaAnonv5Hq8I4Ic7rI2WYdV219QcW2PQuLAAmfisWG/?=\n\t=?utf-8?q?YCZ1P+8+h4gyessw95u8fkMLsGX7A0RfT7VwJqn/Bz+LNDhvBtDUZwdyHzhlMbY6J?=\n\t=?utf-8?q?45IYYX8o7P+F/BQ76PG/iHAdGiSMHcP8B8zP9pxpuCWdLyBHUApEDdDEYnXxn22UH?=\n\t=?utf-8?q?SqDUh/VlYTg98rqR3lOD89sJABinBwBvdRBpzkU9gcgmMJAv4fuQCnZqh0DcOKIPj?=\n\t=?utf-8?q?aYBNkP4rdglAp2Pp0Q4mzpF5PABHJNGmhbAYo3WhLgWIyLohYjKRtDJhZOQYn2+ML?=\n\t=?utf-8?q?nuPixSx/9XB2I2nleN2kdENk75blBXIvLaKUisHEAkG2mYPsupyNh7z2uRKiIPue2?=\n\t=?utf-8?q?OZHCnJZB41Myb+mlGPzWLjhL6UPzTPEGpk36COzFNStjxLpk0bHoUO2nn81mnVBJZ?=\n\t=?utf-8?q?VYZqVg6aCawkQuapd/7GViq+ppqirYUGu7Vw8hGEVDT/1xa2dfsKvXOwm+YenBwOq?=\n\t=?utf-8?q?ZYbqL90ScvPg7Tf30xH8KfbefenfLrkrtJStNhne3e/3/7sR2fD8fkDhW2eh6NdVo?=\n\t=?utf-8?q?Sjt5kVBOUxgBfA9Z83Qm/g6D8oNeUW98DxO2rRytxqzNRpfyphNIJHPFQJ44ji/sF?=\n\t=?utf-8?q?eVfXVBto1whyjJuYgu5Gw45SzlKd7NuaGxp6YlwE5y1kVRR9bbpvJH2FVxtQSKNPD?=\n\t=?utf-8?q?xoGnpjtGVcuZAsfHwCbLDzs86jbBr/lof3PZqneuEYIibDCxpzKqRnlIo/2/nUDc6?=\n\t=?utf-8?q?cCOMHFxoCSWNbQDO/r+GGqPAakXrBthSbYL3BswnWbDw7Q8tGKHq4dNGFjYH665SM?=\n\t=?utf-8?q?rv2yAsuiVyymTfLOXS4VcwdQBSEpoz1KFNdWCNTTpXjjqsRdZHSN9YD9vw6ZHha2/?=\n\t=?utf-8?q?vjyz3kQxpAsmC9lesYyOFvJkcykTvgSbCQbkOZwLUHhB9rvI0zUFoC/7WsvKntZ4C?=\n\t=?utf-8?q?MPpSqr+yHhNaBHRb/aPq3txUdg9XgJJ6XguzgVH95yH2RI3tvkexoWYn+kizWkc8E?=\n\t=?utf-8?q?DZjXTmSBzV8AHXi2O8kwXmSMBwmrE0VHeZvo5ZjKb5KOVyo/T4X7gbS6cEzfbUwYT?=\n\t=?utf-8?q?F4haDr7jyGBw8/6L7xvwQLOrX/FzcdhvHI6QiMjaA149QksNrMhCWfEhZ/weWeKPE?=\n\t=?utf-8?q?NkL4vEFsLmpuvkcW1WH5YpH32M+uJujCO4f24zewP4surh/e8PKjb5r+32Eemjvf2?=\n\t=?utf-8?q?sCR4V9/k2UXRzZrz90iv0+69rpUS1UoJZRwtVJJgSgoecpT3iEa8Jx8OPYtJ3w6fS?=\n\t=?utf-8?q?k+Jux0UtzeAO2Xt8UpA7UhYTL4/W1caKL1zE2zLqPdQpJzg4JJvsgvi5FXW3BJ01z?=\n\t=?utf-8?q?MitynCiuYzmj?=", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;\n CAT:NONE; SFS:(13230031)(82310400017)(36860700004)(1800799015)(376005);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "05 May 2024 07:43:36.2833 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n b95395f7-336b-4b66-6d5e-08dc6cd7127b", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DB1PEPF000509E7.eurprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AS8PR07MB7765", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "To reduce flow migration overhead, replace the array-based\nrepresentation of which set of ports are bound to a particular queue\nby a multi-word bitset.\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\n---\n drivers/event/dsw/dsw_evdev.c | 19 +++++++------------\n drivers/event/dsw/dsw_evdev.h | 3 ++-\n drivers/event/dsw/dsw_event.c | 7 ++++---\n 3 files changed, 13 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c\nindex ab0420b549..f3ca99e935 100644\n--- a/drivers/event/dsw/dsw_evdev.c\n+++ b/drivers/event/dsw/dsw_evdev.c\n@@ -118,6 +118,7 @@ dsw_queue_setup(struct rte_eventdev *dev, uint8_t queue_id,\n \t\tqueue->schedule_type = conf->schedule_type;\n \t}\n \n+\trte_bitset_init(queue->serving_ports, DSW_MAX_PORTS);\n \tqueue->num_serving_ports = 0;\n \n \treturn 0;\n@@ -144,20 +145,16 @@ dsw_queue_release(struct rte_eventdev *dev __rte_unused,\n static void\n queue_add_port(struct dsw_queue *queue, uint16_t port_id)\n {\n-\tuint64_t port_mask = UINT64_C(1) << port_id;\n-\n-\tqueue->serving_ports |=\tport_mask;\n+\trte_bitset_set(queue->serving_ports, port_id);\n \tqueue->num_serving_ports++;\n }\n \n static bool\n queue_remove_port(struct dsw_queue *queue, uint16_t port_id)\n {\n-\tuint64_t port_mask = UINT64_C(1) << port_id;\n-\n-\tif (queue->serving_ports & port_mask) {\n+\tif (rte_bitset_test(queue->serving_ports, port_id)) {\n \t\tqueue->num_serving_ports--;\n-\t\tqueue->serving_ports ^= port_mask;\n+\t\trte_bitset_clear(queue->serving_ports, port_id);\n \t\treturn true;\n \t}\n \n@@ -257,14 +254,12 @@ initial_flow_to_port_assignment(struct dsw_evdev *dsw)\n \t\tstruct dsw_queue *queue = &dsw->queues[queue_id];\n \t\tuint16_t flow_hash;\n \t\tfor (flow_hash = 0; flow_hash < DSW_MAX_FLOWS; flow_hash++) {\n-\t\t\tuint8_t skip =\n-\t\t\t\trte_rand_max(queue->num_serving_ports);\n+\t\t\tuint8_t skip = rte_rand_max(queue->num_serving_ports);\n \t\t\tuint8_t port_id;\n \n \t\t\tfor (port_id = 0;; port_id++) {\n-\t\t\t\tuint64_t port_mask = UINT64_C(1) << port_id;\n-\n-\t\t\t\tif (queue->serving_ports & port_mask) {\n+\t\t\t\tif (rte_bitset_test(queue->serving_ports,\n+\t\t\t\t\t\t port_id)) {\n \t\t\t\t\tif (skip == 0)\n \t\t\t\t\t\tbreak;\n \t\t\t\t\tskip--;\ndiff --git a/drivers/event/dsw/dsw_evdev.h b/drivers/event/dsw/dsw_evdev.h\nindex 3a5989f148..0c40c45e46 100644\n--- a/drivers/event/dsw/dsw_evdev.h\n+++ b/drivers/event/dsw/dsw_evdev.h\n@@ -7,6 +7,7 @@\n \n #include <eventdev_pmd.h>\n \n+#include <rte_bitset.h>\n #include <rte_event_ring.h>\n #include <rte_eventdev.h>\n \n@@ -234,7 +235,7 @@ struct __rte_cache_aligned dsw_port {\n \n struct dsw_queue {\n \tuint8_t schedule_type;\n-\tuint64_t serving_ports;\n+\tRTE_BITSET_DECLARE(serving_ports, DSW_MAX_PORTS);\n \tuint16_t num_serving_ports;\n \n \talignas(RTE_CACHE_LINE_SIZE) uint8_t flow_to_port_map[DSW_MAX_FLOWS];\ndiff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c\nindex 23488d9030..b855f9ecf1 100644\n--- a/drivers/event/dsw/dsw_event.c\n+++ b/drivers/event/dsw/dsw_event.c\n@@ -447,9 +447,8 @@ static bool\n dsw_is_serving_port(struct dsw_evdev *dsw, uint8_t port_id, uint8_t queue_id)\n {\n \tstruct dsw_queue *queue = &dsw->queues[queue_id];\n-\tuint64_t port_mask = UINT64_C(1) << port_id;\n \n-\treturn queue->serving_ports & port_mask;\n+\treturn rte_bitset_test(queue->serving_ports, port_id);\n }\n \n static bool\n@@ -571,7 +570,9 @@ dsw_schedule(struct dsw_evdev *dsw, uint8_t queue_id, uint16_t flow_hash)\n \t\t/* A single-link queue, or atomic/ordered/parallel but\n \t\t * with just a single serving port.\n \t\t */\n-\t\tport_id = rte_bsf64(queue->serving_ports);\n+\t\tport_id = (uint8_t)rte_bitset_find_first_set(\n+\t\t\tqueue->serving_ports, DSW_MAX_PORTS\n+\t\t);\n \n \tDSW_LOG_DP(DEBUG, \"Event with queue_id %d flow_hash %d is scheduled \"\n \t\t \"to port %d.\\n\", queue_id, flow_hash, port_id);\n", "prefixes": [ "RFC", "v5", "6/6" ] }