Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139868/?format=api
{ "id": 139868, "url": "http://patchwork.dpdk.org/api/patches/139868/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240505083737.118649-3-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240505083737.118649-3-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240505083737.118649-3-mattias.ronnblom@ericsson.com", "date": "2024-05-05T08:37:33", "name": "[RFC,v7,2/6] eal: add unit tests for bit operations", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4cefcf167922d5916300d914648b6d92a0ec7ab2", "submitter": { "id": 1077, "url": "http://patchwork.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240505083737.118649-3-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 31882, "url": "http://patchwork.dpdk.org/api/series/31882/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31882", "date": "2024-05-05T08:37:31", "name": "Improve EAL bit operations API", "version": 7, "mbox": "http://patchwork.dpdk.org/series/31882/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139868/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/139868/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D51B143FAE;\n\tSun, 5 May 2024 10:48:15 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9183D402EF;\n\tSun, 5 May 2024 10:48:03 +0200 (CEST)", "from EUR04-DB3-obe.outbound.protection.outlook.com\n (mail-db3eur04on2043.outbound.protection.outlook.com [40.107.6.43])\n by mails.dpdk.org (Postfix) with ESMTP id 88AAD4025D\n for <dev@dpdk.org>; Sun, 5 May 2024 10:47:59 +0200 (CEST)", "from DB7PR05CA0058.eurprd05.prod.outlook.com (2603:10a6:10:2e::35)\n by DUZPR07MB9815.eurprd07.prod.outlook.com (2603:10a6:10:4d8::17) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.39; Sun, 5 May\n 2024 08:47:57 +0000", "from DU2PEPF0001E9C1.eurprd03.prod.outlook.com\n (2603:10a6:10:2e:cafe::ba) by DB7PR05CA0058.outlook.office365.com\n (2603:10a6:10:2e::35) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.40 via Frontend\n Transport; Sun, 5 May 2024 08:47:57 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n DU2PEPF0001E9C1.mail.protection.outlook.com (10.167.8.70) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7519.19 via Frontend Transport; Sun, 5 May 2024 08:47:57 +0000", "from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by\n smtp-central.internal.ericsson.com (100.87.178.64) with Microsoft SMTP Server\n id 15.2.1544.9; Sun, 5 May 2024 10:47:57 +0200", "from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100])\n by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id\n F092C38007A; Sun, 5 May 2024 10:47:56 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=CLwfoVz2j00zzT0fwWjk4EB27Xju7NbgYRBKQraoii1POE2jPGD+AohT5IZRlPsSKj5NTPcxK81vDCxLZkkSp6sasJ6lT93jBP+B38RGrDupOiqT0cW2CnZZ07+hTwXfOyC8ekatQsYkhBaEHaOPR1UtHeGeNFkM89loM0g9Gisi+FRbUxVWbEuB3xBoYYGoTpNmKW7LT+OcIWghUz7ciJS1/yIz2qVw6CE7PJi9UcBVFUENyZ4kbwIxzmSaHudjMGbUSbnF/NARkMPE3TyCZ+UqqGcXdEfkk5DgybkiAi9oYR1OxCS7RTq3bNQrDi300NUsArGroP0K0sNAKACo9A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=d8z68B8fzU8h0PRajH8DnhYus8GmVFVNaHI8wvhWqbw=;\n b=iscgQAO6bLJyxRjf1AG7CVdFENOtSByCeWMvuFDyxsOLmFBSgF5endm1r57q1cZAZvGC16BUPTA1NAfeIBrPcJHOm0dzjnAB3QzOuq6O54k5/E2oHeuFsIxBgmCpCg+OKyv93DFED/m1iZIhhUy1oWl03p90pryS1tjRflqhvSdvEgNiET2p7Uc4uoi7eRz4kYCzlhcs8LKx7WRB3qhyj0Wnhz0XvlNg0poxphaidwGY/tmxutmio7Tfzp3J6n+f8RDMrRLT2jrLoHk6Qidoxk4IpStf6RTgotJ4pyL9ihlQTQ2v39Ge9VwE3/mLBJu1yuIqV68UvYKKmpdpyKl03A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=d8z68B8fzU8h0PRajH8DnhYus8GmVFVNaHI8wvhWqbw=;\n b=YtY0hpTF3XyUXvweruLbBht1drIbDfJQE1tIpZppIhHFS3XVsgETc05Syr06CcS+WiswoLtXJ116wr34lIZxQErnjJJDb1Kt5IdvI6nfqANEr24spUCAYIlob89iBgUJAfqNsNLcjI+ywi+T8S/0RkOgttOWLF8iqS2F2sYBEiG3J3lPkS8oZG8A41Wt8UYL6U1mlL82eBmDipsjLglE20kWB1LUXMum0zKZkutI3bKvuV0pSjddoKN/mMO/nmHAtQ24VDzoywkKxm104NYFtNK4eHXgsy0L2+uVcNksx3d36wcZDZuQOpI4g1hmOaVxwmcx9+kRHe5mqw6jwaiszQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "<hofors@lysator.liu.se>, Heng Wang <heng.wang@ericsson.com>,\n \"Stephen Hemminger\" <stephen@networkplumber.org>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>, =?utf-8?q?Mattia?=\n\t=?utf-8?q?s_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "Subject": "[RFC v7 2/6] eal: add unit tests for bit operations", "Date": "Sun, 5 May 2024 10:37:33 +0200", "Message-ID": "<20240505083737.118649-3-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240505083737.118649-1-mattias.ronnblom@ericsson.com>", "References": "<20240502055706.112443-2-mattias.ronnblom@ericsson.com>\n <20240505083737.118649-1-mattias.ronnblom@ericsson.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DU2PEPF0001E9C1:EE_|DUZPR07MB9815:EE_", "X-MS-Office365-Filtering-Correlation-Id": "cb861e23-09c7-4ecf-fb7a-08dc6ce00fed", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230031|82310400017|36860700004|1800799015|376005;", "X-Microsoft-Antispam-Message-Info": "=?utf-8?q?2f+QmG8MoRubmLJHEDwYhTplE8iH+Ab?=\n\t=?utf-8?q?rV5ISFCt9cnBwCMc1OBSIUnf0IPEIVAhfuwWqfjo8fU3Hz87pYBSdk8aq2MFw0v3M?=\n\t=?utf-8?q?cBi2jKuM997yjurCAvfy22xRfjq7vWa9bV11fOZWMhGtxNi8WZnqGr/+nfF3smlkJ?=\n\t=?utf-8?q?skKaLjxRaJsNsToR5es1kc/BKKqIWigNZlvlrETFdhG7/saUC2wK7rA6M0H4EEAGz?=\n\t=?utf-8?q?2GaNYQN41ii3kwdiGH9dLujjGJZKMBXRho+Q0EXSFa3sjM4dHBoO6bjIg0TmZUYv0?=\n\t=?utf-8?q?9yCZmYhBOLgclDGwKuDbn9tB9xsqrc6Lq00BcsNz1RjC8DwrRvEJoinJztSXq+3HN?=\n\t=?utf-8?q?zFNYNRS6KiM/PyjMrDcLGBBLhDpTq8lQJ7014FF2AZgXTFEMpNB6jOSAXchmukWIV?=\n\t=?utf-8?q?2lfqGOJOJakdHoWCKJBGgG/cWvGA0pZRmIkMVR94xRzQZpToLEfSGV4fAH9ALiSA8?=\n\t=?utf-8?q?CqYOX9GD44y0XyMf+U4wRZ167WIN393LIGzo1hB6zqQmZG/VneYwAk+UDLB7/bDNS?=\n\t=?utf-8?q?MKjKMt4MY153YX2j7nfOLXPuddFJ6w+SmyeZ4LexG8B+o/vRqK9pUV0mhmUacxweF?=\n\t=?utf-8?q?sqqxpGOwbHvVDSovZWP8Zvxu2NMMKlliGGfSBZ+cTlGhpnrRIIRvXFhRhLQA90FCU?=\n\t=?utf-8?q?bI7ktM9vBKj6I5XfqAVA8wIsiXPvdZSvv82wKl0ePjBWfW2pF8OlYd3vPyegNGe0g?=\n\t=?utf-8?q?zo1/cZu1wJ4+KQMpckVPlRwdeHj5Ezx3N1AWc8tNg6hni3RK2w90Na2qjwvLLpNM+?=\n\t=?utf-8?q?R1zxQ+XezLCvBiZ4PQ1XqC7icY9vW3sYOad6ShnSEkACQ4mEH8JmJe4UGGhhKDTM8?=\n\t=?utf-8?q?VKnNRc0uw+/wu77yTRCfPELyoDFoBT1pUfcLVdf0bktzgdxcSEBYZPXIW1WFOTjrd?=\n\t=?utf-8?q?upIRkmIfrP+5RWG62OazQmvfSgkYiENQdWQaaZjn1s7SwdCkr3DXJliwrKgihBEcO?=\n\t=?utf-8?q?qlE/2jEfaUZV0OHxx05olYXvrRhyUC9hfcCV7DdFmPsYs26ZMrZ5IFFL0hz/mb/Jx?=\n\t=?utf-8?q?a4I5G/YN9A3ieXycuZcVfzfQe+vxwtat9FWrD69XszhBODaxKp7b1MAQ0t6qkC1Dz?=\n\t=?utf-8?q?Oi/IK4PTLKgfoSF/laNCP8xKFvejKG6sIQFwvaqszrzB4HkaaYdTZwXzW/jH81i6N?=\n\t=?utf-8?q?5fAHVaESiB7e3gg1YVVshbCCH2mho/u865WJ9OTQE5hUuyImZqrz05RU36jn1lEAh?=\n\t=?utf-8?q?Duz6RLhDeGA98k9/WbwzU996fz7JdSENAVxB9Pb6IiDfH6sLUlFNd3+3W3U8VlP0/?=\n\t=?utf-8?q?Kn4aweFErt3kX1HXo/TSn0GIeCXO9CWMd+4W34P+l6XUwL5OPxmzqYrM=3D?=", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;\n CAT:NONE; SFS:(13230031)(82310400017)(36860700004)(1800799015)(376005);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "05 May 2024 08:47:57.4715 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n cb861e23-09c7-4ecf-fb7a-08dc6ce00fed", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DU2PEPF0001E9C1.eurprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DUZPR07MB9815", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Extend bitops tests to cover the\nrte_bit_[test|set|clear|assign|flip]()\nfunctions.\n\nThe tests are converted to use the test suite runner framework.\n\nRFC v6:\n * Test rte_bit_*test() usage through const pointers.\n\nRFC v4:\n * Remove redundant line continuations.\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n app/test/test_bitops.c | 85 ++++++++++++++++++++++++++++++++++--------\n 1 file changed, 70 insertions(+), 15 deletions(-)", "diff": "diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c\nindex 0d4ccfb468..322f58c066 100644\n--- a/app/test/test_bitops.c\n+++ b/app/test/test_bitops.c\n@@ -1,13 +1,68 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n * Copyright(c) 2019 Arm Limited\n+ * Copyright(c) 2024 Ericsson AB\n */\n \n+#include <stdbool.h>\n+\n #include <rte_launch.h>\n #include <rte_bitops.h>\n+#include <rte_random.h>\n #include \"test.h\"\n \n-uint32_t val32;\n-uint64_t val64;\n+#define GEN_TEST_BIT_ACCESS(test_name, set_fun, clear_fun, assign_fun,\t\\\n+\t\t\t flip_fun, test_fun, size)\t\t\t\\\n+\tstatic int\t\t\t\t\t\t\t\\\n+\ttest_name(void)\t\t\t\t\t\t\t\\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\tuint ## size ## _t reference = (uint ## size ## _t)rte_rand(); \\\n+\t\tunsigned int bit_nr;\t\t\t\t\t\\\n+\t\tuint ## size ## _t word = (uint ## size ## _t)rte_rand(); \\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tfor (bit_nr = 0; bit_nr < size; bit_nr++) {\t\t\\\n+\t\t\tbool reference_bit = (reference >> bit_nr) & 1;\t\\\n+\t\t\tbool assign = rte_rand() & 1;\t\t\t\\\n+\t\t\tif (assign)\t\t\t\t\t\\\n+\t\t\t\tassign_fun(&word, bit_nr, reference_bit); \\\n+\t\t\telse {\t\t\t\t\t\t\\\n+\t\t\t\tif (reference_bit)\t\t\t\\\n+\t\t\t\t\tset_fun(&word, bit_nr);\t\t\\\n+\t\t\t\telse\t\t\t\t\t\\\n+\t\t\t\t\tclear_fun(&word, bit_nr);\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\t\t}\t\t\t\t\t\t\\\n+\t\t\tTEST_ASSERT(test_fun(&word, bit_nr) == reference_bit, \\\n+\t\t\t\t \"Bit %d had unexpected value\", bit_nr); \\\n+\t\t\tflip_fun(&word, bit_nr);\t\t\t\\\n+\t\t\tTEST_ASSERT(test_fun(&word, bit_nr) != reference_bit, \\\n+\t\t\t\t \"Bit %d had unflipped value\", bit_nr); \\\n+\t\t\tflip_fun(&word, bit_nr);\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\t\tconst uint ## size ## _t *const_ptr = &word;\t\\\n+\t\t\tTEST_ASSERT(test_fun(const_ptr, bit_nr) ==\t\\\n+\t\t\t\t reference_bit,\t\t\t\\\n+\t\t\t\t \"Bit %d had unexpected value\", bit_nr); \\\n+\t\t}\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tfor (bit_nr = 0; bit_nr < size; bit_nr++) {\t\t\\\n+\t\t\tbool reference_bit = (reference >> bit_nr) & 1;\t\\\n+\t\t\tTEST_ASSERT(test_fun(&word, bit_nr) == reference_bit, \\\n+\t\t\t\t \"Bit %d had unexpected value\", bit_nr); \\\n+\t\t}\t\t\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tTEST_ASSERT(reference == word, \"Word had unexpected value\"); \\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\treturn TEST_SUCCESS;\t\t\t\t\t\\\n+\t}\n+\n+GEN_TEST_BIT_ACCESS(test_bit_access32, rte_bit_set, rte_bit_clear,\n+\t\t rte_bit_assign, rte_bit_flip, rte_bit_test, 32)\n+\n+GEN_TEST_BIT_ACCESS(test_bit_access64, rte_bit_set, rte_bit_clear,\n+\t\t rte_bit_assign, rte_bit_flip, rte_bit_test, 64)\n+\n+static uint32_t val32;\n+static uint64_t val64;\n \n #define MAX_BITS_32 32\n #define MAX_BITS_64 64\n@@ -117,22 +172,22 @@ test_bit_relaxed_test_set_clear(void)\n \treturn TEST_SUCCESS;\n }\n \n+static struct unit_test_suite test_suite = {\n+\t.suite_name = \"Bitops test suite\",\n+\t.unit_test_cases = {\n+\t\tTEST_CASE(test_bit_access32),\n+\t\tTEST_CASE(test_bit_access64),\n+\t\tTEST_CASE(test_bit_relaxed_set),\n+\t\tTEST_CASE(test_bit_relaxed_clear),\n+\t\tTEST_CASE(test_bit_relaxed_test_set_clear),\n+\t\tTEST_CASES_END()\n+\t}\n+};\n+\n static int\n test_bitops(void)\n {\n-\tval32 = 0;\n-\tval64 = 0;\n-\n-\tif (test_bit_relaxed_set() < 0)\n-\t\treturn TEST_FAILED;\n-\n-\tif (test_bit_relaxed_clear() < 0)\n-\t\treturn TEST_FAILED;\n-\n-\tif (test_bit_relaxed_test_set_clear() < 0)\n-\t\treturn TEST_FAILED;\n-\n-\treturn TEST_SUCCESS;\n+\treturn unit_test_suite_runner(&test_suite);\n }\n \n REGISTER_FAST_TEST(bitops_autotest, true, true, test_bitops);\n", "prefixes": [ "RFC", "v7", "2/6" ] }