Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139877/?format=api
{ "id": 139877, "url": "http://patchwork.dpdk.org/api/patches/139877/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240506082721.120666-4-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240506082721.120666-4-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240506082721.120666-4-mattias.ronnblom@ericsson.com", "date": "2024-05-06T08:27:18", "name": "[RFC,v6,3/6] random: keep PRNG state in lcore variable", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "973c202c8ec7ef5d550339395236333738c2fad9", "submitter": { "id": 1077, "url": "http://patchwork.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240506082721.120666-4-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 31884, "url": "http://patchwork.dpdk.org/api/series/31884/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31884", "date": "2024-05-06T08:27:15", "name": "Lcore variables", "version": 6, "mbox": "http://patchwork.dpdk.org/series/31884/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139877/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139877/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AD7A943FC4;\n\tMon, 6 May 2024 10:38:58 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BF93440633;\n\tMon, 6 May 2024 10:38:33 +0200 (CEST)", "from EUR01-VE1-obe.outbound.protection.outlook.com\n (mail-ve1eur01on2079.outbound.protection.outlook.com [40.107.14.79])\n by mails.dpdk.org (Postfix) with ESMTP id 4742A402E9\n for <dev@dpdk.org>; Mon, 6 May 2024 10:38:26 +0200 (CEST)", "from DUZPR01CA0154.eurprd01.prod.exchangelabs.com\n (2603:10a6:10:4bd::24) by DU2PR07MB8142.eurprd07.prod.outlook.com\n (2603:10a6:10:270::15) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Mon, 6 May\n 2024 08:38:23 +0000", "from DB5PEPF00014B91.eurprd02.prod.outlook.com\n (2603:10a6:10:4bd:cafe::a) by DUZPR01CA0154.outlook.office365.com\n (2603:10a6:10:4bd::24) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.28 via Frontend\n Transport; Mon, 6 May 2024 08:38:23 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n DB5PEPF00014B91.mail.protection.outlook.com (10.167.8.229) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7544.18 via Frontend Transport; Mon, 6 May 2024 08:38:22 +0000", "from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by\n smtp-central.internal.ericsson.com (100.87.178.63) with Microsoft SMTP Server\n id 15.2.1544.9; Mon, 6 May 2024 10:38:22 +0200", "from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100])\n by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id\n 8C42F1C006A; Mon, 6 May 2024 10:38:22 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=LL2vDDrKOi3xfeWnoGFbPe3fWdUL6a9HNCvWd1tyHjfpPE4zhe4mDTsmPwmPopZMBJRjwR6Tkgln9McDGYVmwIK8v2m/d7f8xNqbf4GOwV4QJSsL4DnXzxrM5taz697yQwriKP+5lxYic7LpPys9lunkMHw2E0C70P3aKOfIIWLaUg5ONeyVr5pWTgf/003sRCECsSLlCHaoe2Ok2yOYhPdTMA5tzB1mGXxtb7dzCmj0JpCnoHv0z6p9oJKnQvg1uER0wGAgiyzLwcX0M2Ebeh9JzKzZ4UUfx764t8wpuwrvuSVvUMm/XXlGM4fyrfhMlZFE/RvL3GglilupgyFNAw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=A6J/3RAvMEZtYuQWbxJNql5QXwI0mQ2DklM3t8JmQcU=;\n b=cRQ/m+tnk4pouBm4AQTbNrvuhEvSCjRrEABCnsroHNUYJH1Ce/flEQw9GLrvCbWBYSPS1yBJvRvTeGRbo1cnxjSYDEuG6TrJnJHt1X5G6hwaEBWTZRLSAfB0idNqY7Sij6fjes7q4Y9xLRudR+kKXLuh4fOh8uf2C6rkB7hcIi3Gd0BU7o/Xn+llzV1VS/prf//528E2zsMv/9uQqhVnozsaoWSrKdrMi+nS0MRV8R62arJTXvYklt9NuRFZRYCv3VKu7ME2JybLV0kLUW+jguQ5fS6nBSa+sQKgo/YiU0qltyj5E0JKXi5T5SX0d2BvNrHS5zAHT6kQzoj6GbhErQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=A6J/3RAvMEZtYuQWbxJNql5QXwI0mQ2DklM3t8JmQcU=;\n b=axGlWj6/MTIPDG6O1Fsx8GxTF5RqY2QuKln8FrOR4ujyD5DsaKMZ2ZLR6tLhfNytLGuYXhBOUZTFR5b7T+s0JxMUcqSVS0X+/Etsn8+lia83sQKS3n3MoXvqXwfOpFe6LjfxU2wLa9w/Yud9lYpjUFItDPDLu1xURjQgySz0YL74WIa1zFY0blnCnksqIraN1q6jLpLGIEuPLC6FPjlsgURODolD7yzZsY5nu4/QI85yBsmL925MI+atglYA0s/77b+oBuN6ZOYaSqQxYS+c7iYmRNIwU0OGjlS4ZRvb2NQG1lv+AbEVLaJpZg0bGu1DP4+woc4auNq3jyTUbbrDDg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "<hofors@lysator.liu.se>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>, =?utf-8?q?Mattias_R?=\n\t=?utf-8?q?=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "Subject": "[RFC v6 3/6] random: keep PRNG state in lcore variable", "Date": "Mon, 6 May 2024 10:27:18 +0200", "Message-ID": "<20240506082721.120666-4-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240506082721.120666-1-mattias.ronnblom@ericsson.com>", "References": "<20240228100928.524277-2-mattias.ronnblom@ericsson.com>\n <20240506082721.120666-1-mattias.ronnblom@ericsson.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DB5PEPF00014B91:EE_|DU2PR07MB8142:EE_", "X-MS-Office365-Filtering-Correlation-Id": "fdcde52b-8922-49a7-7a71-08dc6da7e3dc", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230031|36860700004|82310400017|376005|1800799015;", "X-Microsoft-Antispam-Message-Info": "=?utf-8?q?C/zzCrf1Cla+T1Bhao52GAVYcciOT/Q?=\n\t=?utf-8?q?QvqbNjDLbD8x5GZd3gMPSyiOAONsfvsxvZMHkoI5bSK6B355gsluGKHACWxBHn9fA?=\n\t=?utf-8?q?vwhf6MhdRO9J2LfZ5QNKm+znL/7W0Z5ggbJ9M+k25OZGoQuoMZDkTjcrmWrwJsrrc?=\n\t=?utf-8?q?VPhg51RyeiFFOIc/nl9QRQ8P3wnPM21x/bKCsWA1/eswQEr+v7/iaPRDYJ8gprCBe?=\n\t=?utf-8?q?RoAoQO5vf7kHaMqBTAZj4NJNfPcVDoOIb1H+J3OyYPGx4yZyYGzzAU9iZU7DSRJND?=\n\t=?utf-8?q?o8tDf4WQrlo6vzaLQURnJlD+1Myisk0aZEEDBId2LTw2fz/40xOdES++zbQlRfGPs?=\n\t=?utf-8?q?dIxR4X/tED0jLtFizbJ6dyuU04qPuyOMsijm8H1c0XtSHWiEIQbKU/clNA1i8PNlU?=\n\t=?utf-8?q?5SEOc627xiSEFXk+pQPEEhY/Fhh0T/QVydb8cnHRzqyv97fVHfirNvBu70iKrOEft?=\n\t=?utf-8?q?9HjqbgsqUJwVO/43Co5wdhHZCxltPjZbqS2n28zQ6/Mz2DO4r/vhYNB0R4dWizKtS?=\n\t=?utf-8?q?24DsdbnSHV7FdYWlRYW8aHWx3+TBv1Art4906wU4Ge5Dmn0gDAC+OGjY+VxgrGWyb?=\n\t=?utf-8?q?dx0dnTEokSz2Ej/bAMyCSNZ5TUGwWsmzUiRCwp96t9U6R9vZuDgeKvY8SRQOYTj1s?=\n\t=?utf-8?q?FIpkCOasgGG8h4UdWuJjqB6UUNig5y62Y2BYYcQ8vwTpLtxrJnsbyNZ3Qy9rQimS/?=\n\t=?utf-8?q?IdS5kszatq8lzuXzEB44vwzFpmqvSrnVqlmt9FSJQB5lSx1Wjon+XlcSwYI0OMjRx?=\n\t=?utf-8?q?lLPXZu0UTFBoVUwhJDNhNo+oi63X0HVfCL0Uhi+hCp44ZiPmotygP71lFMA7rh/BA?=\n\t=?utf-8?q?tiQlaXZGQXKATnF2gFBANVDqOpFsrh58WsiD4jj+8aDJijOoQIAuRIGlv312vSdzi?=\n\t=?utf-8?q?VKWHpVkje9VdFwtU+p7CymUQlL73tvVM3CW99+/Vt0G8AmdsWldQrb06zasera8WP?=\n\t=?utf-8?q?V9yv8c05t+BhmttPIE6u5PkVmyPNGXSM3jy2Bjwqf8DE1CR6yITCwKN0/N8kMEh3P?=\n\t=?utf-8?q?xTwWDXfdQAKq7quRabjkhvWIllPEUom9dt/Ivm8l37ztz9g8fK2N1qmY0rDf9gQHP?=\n\t=?utf-8?q?RmWANf7q4fSokvqKvpCJmVyzKB9/1eri5j/wDS9l64rgi5z+waKRXcW+AgBuAHkgY?=\n\t=?utf-8?q?MlM16nRn/5QMDlxWYTQl/rjnS/uaNc3MK94dwQ4i/S3WQyNEr5ikZD4SbDXxGPzod?=\n\t=?utf-8?q?udJyjmW9srYeJi6RthRL93sJFRqCUjWQvJP9ArkKMp03wCtuUBgVlTIMZhIlehZ5d?=\n\t=?utf-8?q?zmkj3GjHkxAle0bgsIpJcjUTf7e/67H0o73zyu0bwoSb4WhtkfeoH4qw=3D?=", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;\n CAT:NONE; SFS:(13230031)(36860700004)(82310400017)(376005)(1800799015);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "06 May 2024 08:38:22.8829 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n fdcde52b-8922-49a7-7a71-08dc6da7e3dc", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DB5PEPF00014B91.eurprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DU2PR07MB8142", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace keeping PRNG state in a RTE_MAX_LCORE-sized static array of\ncache-aligned and RTE_CACHE_GUARDed struct instances with keeping the\nsame state in a more cache-friendly lcore variable.\n\nRFC v3:\n * Remove cache alignment on unregistered threads' rte_rand_state.\n (Morten Brørup)\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/eal/common/rte_random.c | 28 +++++++++++++++++-----------\n 1 file changed, 17 insertions(+), 11 deletions(-)", "diff": "diff --git a/lib/eal/common/rte_random.c b/lib/eal/common/rte_random.c\nindex 90e91b3c4f..a8d00308dd 100644\n--- a/lib/eal/common/rte_random.c\n+++ b/lib/eal/common/rte_random.c\n@@ -11,6 +11,7 @@\n #include <rte_branch_prediction.h>\n #include <rte_cycles.h>\n #include <rte_lcore.h>\n+#include <rte_lcore_var.h>\n #include <rte_random.h>\n \n struct __rte_cache_aligned rte_rand_state {\n@@ -19,14 +20,12 @@ struct __rte_cache_aligned rte_rand_state {\n \tuint64_t z3;\n \tuint64_t z4;\n \tuint64_t z5;\n-\tRTE_CACHE_GUARD;\n };\n \n-/* One instance each for every lcore id-equipped thread, and one\n- * additional instance to be shared by all others threads (i.e., all\n- * unregistered non-EAL threads).\n- */\n-static struct rte_rand_state rand_states[RTE_MAX_LCORE + 1];\n+RTE_LCORE_VAR_HANDLE(struct rte_rand_state, rand_state);\n+\n+/* instance to be shared by all unregistered non-EAL threads */\n+static struct rte_rand_state unregistered_rand_state;\n \n static uint32_t\n __rte_rand_lcg32(uint32_t *seed)\n@@ -85,8 +84,14 @@ rte_srand(uint64_t seed)\n \tunsigned int lcore_id;\n \n \t/* add lcore_id to seed to avoid having the same sequence */\n-\tfor (lcore_id = 0; lcore_id < RTE_DIM(rand_states); lcore_id++)\n-\t\t__rte_srand_lfsr258(seed + lcore_id, &rand_states[lcore_id]);\n+\tfor (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {\n+\t\tstruct rte_rand_state *lcore_state =\n+\t\t\tRTE_LCORE_VAR_LCORE_VALUE(lcore_id, rand_state);\n+\n+\t\t__rte_srand_lfsr258(seed + lcore_id, lcore_state);\n+\t}\n+\n+\t__rte_srand_lfsr258(seed + lcore_id, &unregistered_rand_state);\n }\n \n static __rte_always_inline uint64_t\n@@ -124,11 +129,10 @@ struct rte_rand_state *__rte_rand_get_state(void)\n \n \tidx = rte_lcore_id();\n \n-\t/* last instance reserved for unregistered non-EAL threads */\n \tif (unlikely(idx == LCORE_ID_ANY))\n-\t\tidx = RTE_MAX_LCORE;\n+\t\treturn &unregistered_rand_state;\n \n-\treturn &rand_states[idx];\n+\treturn RTE_LCORE_VAR_VALUE(rand_state);\n }\n \n uint64_t\n@@ -228,6 +232,8 @@ RTE_INIT(rte_rand_init)\n {\n \tuint64_t seed;\n \n+\tRTE_LCORE_VAR_ALLOC(rand_state);\n+\n \tseed = __rte_random_initial_seed();\n \n \trte_srand(seed);\n", "prefixes": [ "RFC", "v6", "3/6" ] }