Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139979/?format=api
{ "id": 139979, "url": "http://patchwork.dpdk.org/api/patches/139979/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240507124305.2318-17-venkatkumar.ande@amd.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240507124305.2318-17-venkatkumar.ande@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240507124305.2318-17-venkatkumar.ande@amd.com", "date": "2024-05-07T12:42:57", "name": "[v2,17/25] net/axgbe: use definitions for mailbox commands", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "70c1af9785e1823b006dfc3a81dcace31667203d", "submitter": { "id": 3256, "url": "http://patchwork.dpdk.org/api/people/3256/?format=api", "name": "Venkat Kumar Ande", "email": "venkatkumar.ande@amd.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240507124305.2318-17-venkatkumar.ande@amd.com/mbox/", "series": [ { "id": 31890, "url": "http://patchwork.dpdk.org/api/series/31890/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31890", "date": "2024-05-07T12:42:41", "name": "[v2,01/25] net/axgbe: fix mdio access for non-zero ports and CL45 PHYs", "version": 2, "mbox": "http://patchwork.dpdk.org/series/31890/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/139979/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/139979/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2387643FC9;\n\tTue, 7 May 2024 14:45:35 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C7D3A433BB;\n\tTue, 7 May 2024 14:44:27 +0200 (CEST)", "from NAM04-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam04on2066.outbound.protection.outlook.com [40.107.100.66])\n by mails.dpdk.org (Postfix) with ESMTP id 722A943399\n for <dev@dpdk.org>; Tue, 7 May 2024 14:44:26 +0200 (CEST)", "from PR2P264CA0008.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::20) by\n MN2PR12MB4488.namprd12.prod.outlook.com (2603:10b6:208:24e::19) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Tue, 7 May\n 2024 12:44:23 +0000", "from SN1PEPF00036F42.namprd05.prod.outlook.com\n (2603:10a6:101:0:cafe::50) by PR2P264CA0008.outlook.office365.com\n (2603:10a6:101::20) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend\n Transport; Tue, 7 May 2024 12:44:20 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n SN1PEPF00036F42.mail.protection.outlook.com (10.167.248.26) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7544.18 via Frontend Transport; Tue, 7 May 2024 12:44:20 +0000", "from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 7 May\n 2024 07:44:14 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=UEqCXaeOSpuM5KwbtwqIcaarfStU2tc4VrywZVO4FlSn2ZILfIQfh9w0p8e7PmApdVXBdqYV20JkU5E8QhUgUmp1bs93ZCOtI/zp5VCeUvHhNbRU7YF7JlubuZNsoqYCOf+CmKRIbsFqa4H0DkuB9bT1M0XSGiF63g6t/nNCRsAXlucJHdkW2Xr/k/UhM4USJJjVaA8lKQs33r9X8ljrrdw4ZGufaS6n7huWl5cD5rKk1I/TYMs3Fl6gpRtTkgInQ2bJK6G7QLt0zh1wdNLol9I5/4u3/gnFXkUVaL27a37Eg3Oe9rlOUpkekdS0fAaG3v3RZJdk8hCy4zuTvYv2pg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=4w1IE3Lbewl0c22GGy3WHauCbqGZcp0MuhXUpltgFxY=;\n b=YphSdmUY/0mOa8YrJUtVjIjBXcOdY4J4yy2JNPEYNjxHg+mowUXoyrRGai20cYGSIcThL8hLcrIP3J0VgeBI+H+w1ZZGIcX1Q1wJ7L2AqebbV6FTMQkZmRIhu78EC9uq5qCDKCh/wFVHi4kQAUCTKd6g1gEpuymuJTkjv23TKYkSD0QHT2mcUlDrsuxMz/0+AmiTqTQzrh1EWyioDhtdjvJ/Z82RmIDesJCgKoKPtdMLUT5jbQQPNCckH1Wa4O0rMjS+wGuCpYQ9bElUF4oyqlyQCdDnT8lMpjGvxn2ajBa6j/JI8fzIqZavERYyl61XEQ8eQ+9X9Zgc9G5JHtaC+g==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=4w1IE3Lbewl0c22GGy3WHauCbqGZcp0MuhXUpltgFxY=;\n b=5hQi2ZaBv3kRkPUyFVA7+/SBre9XN2euWmZ+3eEoLpndGnlbjxry2PyWAF0haPmF6XEc+QhiY5umSszUzc6V9fna2ThnuQcsjUDO0j84dlEU0FzTrG08XqrwK8A8Z9A5EFfK2ZH5UqrZWaxcMLK8o0iMUxOk7MIB5UlWJoLIJ1Y=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Venkat Kumar Ande <venkatkumar.ande@amd.com>", "To": "<dev@dpdk.org>", "CC": "<Selwin.Sebastian@amd.com>, Venkat Kumar Ande <venkatkumar.ande@amd.com>", "Subject": "[PATCH v2 17/25] net/axgbe: use definitions for mailbox commands", "Date": "Tue, 7 May 2024 18:12:57 +0530", "Message-ID": "<20240507124305.2318-17-venkatkumar.ande@amd.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240507124305.2318-1-venkatkumar.ande@amd.com>", "References": "<20240412125013.10498-1-VenkatKumar.Ande@amd.com>\n <20240507124305.2318-1-venkatkumar.ande@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SN1PEPF00036F42:EE_|MN2PR12MB4488:EE_", "X-MS-Office365-Filtering-Correlation-Id": "892ca5c9-3ed7-427e-8147-08dc6e936a79", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230031|82310400017|1800799015|36860700004|376005;", "X-Microsoft-Antispam-Message-Info": "\n r7L+USaphBBqWIgWQo0trLhgF5vALoIwG/UiJac1SrZ+xlTCKal/C1pv89i97+gPct28e1cSyYAHgvE6Am2X6n8KL5svdhaayIGjuerclzgJtSDyE48yBtrx0W1bvQSRpdhIuAP7OokKO7Pxnqd0cExFtkFHX43VJNR5+ATsBlw8HfJLW5NklgBhn27QmBSnw6d94EhaU7FwOzeHsNTyo79pljjHqxMH2CgBCs3lJBt04C8dUNXcemTT1mrQ2AT7pv3ctleWzCLfkbmfIYX0Wn1bKmUWnjIp/OuBg9mxr04Sw/rwLqCBGPqdE51j32S1+F4af1kEqcGXPPTd0aNRlrT/qq1HE0u6nQHm//WQBDuEeupYb9wHoxz3xGeihZ2SuPYRdrP9Xvgo4V6UQWBLpCw5E1/7jp1zwhvKbEhqXnmcwQlZDsea1Zuw1202elH1eUIQHLLNfQ8VmmDtGGAuhYLxcxTmDTFMZpfA6STCpBoTAIz5JZYnoqWPRAMnw/BuQ7dc5m3oWB3WpjnZV2t579pJZ/THnqFkei+acp10AWSBVlFrzy2kTRGteYe5T7E/ZgqAVPTmZbGdU9B4AdDT40m4gZtefqTkF1BwIoZKP9unqhJeHPyCnUtuEyvGgz9cY0MVKvm5vFkdmNCXH1UbQRzPm4eJLNRigsuGWmoshRSXTHShbSxZzwkZOywJfXhy/1iIVGGtlMvBe3xxy/FSHC4dsWrdAwCrs+IHrknmPqF+8rV2FDfEl2ae+b8t56Uy7cLrpaRv9YaNdZOHnxTH8InORGC2jYtiHIDMdnkQ+Wamu0zX4XkAcr+96OA2IgBxI2JXd3TaXzmfnFQ/rHJtNl0autBe269HfCZwHREsee+ROIXhQtzReo8ibwWsyefrXUZZfEsOyM4HzcIV8MH+X4b0IhlvjKsGiONN4HlxVaKGNhjFvqzVoAt0WqNxzR2RsUNgh/p759ShTN0b+hzrjuYiQDI4AaGzdVSsvQHqqVp6coh8W4ne+ntrG6S7Hj0uTZ3VJoXEvvogcYpY720CCu6jathMqN/6m0zwiuj/MZ0J0ooyu7RY16uD1C2ExNC3qOQcnWpajPinXy7hBiuz+sEXb8gLdTmfj9zwSNvi/7875tqcMprtBHH4hTehCeqLbattfGa1Ze1RrqM0XCcJhWKLRsSE/XElZO7jfMYexT0IRo+RQO/0omoDNFMaXQc5CcZ7I4jwAQXk2L/9GnyhgFFZes9bO9f8adjgeIgogJjF9ziAj+zF59oRkKVVHV+0Az7J2Ml2CaLSyYSKtSHvEbcqB6gXZLZOsz8mxkAC5h9Jp+eaHrgSyz8OsQoep40FQlIAe6FeEcP6286MiZUMOVPmA6k/SULSZ0LeGvsrBqroZYuwZXNdYPdMH+dG8dJV", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(82310400017)(1800799015)(36860700004)(376005); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 May 2024 12:44:20.4582 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 892ca5c9-3ed7-427e-8147-08dc6e936a79", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n SN1PEPF00036F42.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR12MB4488", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Instead of using hardcoded values, use enumerations for mailbox command\nand sub commands.\n\nSigned-off-by: Venkat Kumar Ande <venkatkumar.ande@amd.com>\n---\n drivers/net/axgbe/axgbe_ethdev.h | 25 +++++++++++++++++++++++++\n drivers/net/axgbe/axgbe_phy_impl.c | 25 +++++++++++++++----------\n 2 files changed, 40 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h\nindex b9d8a4e74f..6dc1c1274b 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.h\n+++ b/drivers/net/axgbe/axgbe_ethdev.h\n@@ -231,6 +231,31 @@ enum axgbe_mdio_mode {\n \tAXGBE_MDIO_MODE_CL45,\n };\n \n+enum axgbe_mb_cmd {\n+\tAXGBE_MB_CMD_POWER_OFF = 0,\n+\tAXGBE_MB_CMD_SET_1G,\n+\tAXGBE_MB_CMD_SET_2_5G,\n+\tAXGBE_MB_CMD_SET_10G_SFI,\n+\tAXGBE_MB_CMD_SET_10G_KR,\n+\tAXGBE_MB_CMD_RRC\n+};\n+\n+enum axgbe_mb_subcmd {\n+\tAXGBE_MB_SUBCMD_NONE = 0,\n+\n+\t/* 10GbE SFP subcommands */\n+\tAXGBE_MB_SUBCMD_ACTIVE = 0,\n+\tAXGBE_MB_SUBCMD_PASSIVE_1M,\n+\tAXGBE_MB_SUBCMD_PASSIVE_3M,\n+\tAXGBE_MB_SUBCMD_PASSIVE_OTHER,\n+\n+\t/* 1GbE Mode subcommands */\n+\tAXGBE_MB_SUBCMD_10MBITS = 0,\n+\tAXGBE_MB_SUBCMD_100MBITS,\n+\tAXGBE_MB_SUBCMD_1G_SGMII,\n+\tAXGBE_MB_SUBCMD_1G_KX\n+};\n+\n struct axgbe_phy {\n \tuint32_t supported;\n \tuint32_t advertising;\ndiff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c\nindex 2620d44dfb..67a18e7c55 100644\n--- a/drivers/net/axgbe/axgbe_phy_impl.c\n+++ b/drivers/net/axgbe/axgbe_phy_impl.c\n@@ -1219,7 +1219,7 @@ static void axgbe_phy_pll_ctrl(struct axgbe_port *pdata, bool enable)\n }\n \n static void axgbe_phy_perform_ratechange(struct axgbe_port *pdata,\n-\t\t\t\t\tunsigned int cmd, unsigned int sub_cmd)\n+\t\tenum axgbe_mb_cmd cmd, enum axgbe_mb_subcmd sub_cmd)\n {\n \tunsigned int s0 = 0;\n \tunsigned int wait;\n@@ -1266,7 +1266,7 @@ static void axgbe_phy_rrc(struct axgbe_port *pdata)\n \n \n \t/* Receiver Reset Cycle */\n-\taxgbe_phy_perform_ratechange(pdata, 5, 0);\n+\taxgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_RRC, AXGBE_MB_SUBCMD_NONE);\n \n \tPMD_DRV_LOG(DEBUG, \"receiver reset complete\\n\");\n }\n@@ -1276,7 +1276,7 @@ static void axgbe_phy_power_off(struct axgbe_port *pdata)\n \tstruct axgbe_phy_data *phy_data = pdata->phy_data;\n \n \t/* Power off */\n-\taxgbe_phy_perform_ratechange(pdata, 0, 0);\n+\taxgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_POWER_OFF, AXGBE_MB_SUBCMD_NONE);\n \n \tphy_data->cur_mode = AXGBE_MODE_UNKNOWN;\n \n@@ -1291,14 +1291,18 @@ static void axgbe_phy_sfi_mode(struct axgbe_port *pdata)\n \n \t/* 10G/SFI */\n \tif (phy_data->sfp_cable != AXGBE_SFP_CABLE_PASSIVE) {\n-\t\taxgbe_phy_perform_ratechange(pdata, 3, 0);\n+\t\taxgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_SET_10G_SFI,\n+\t\t\t\t\t\t\tAXGBE_MB_SUBCMD_ACTIVE);\n \t} else {\n \t\tif (phy_data->sfp_cable_len <= 1)\n-\t\t\taxgbe_phy_perform_ratechange(pdata, 3, 1);\n+\t\t\taxgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_SET_10G_SFI,\n+\t\t\t\t\t\t\tAXGBE_MB_SUBCMD_PASSIVE_1M);\n \t\telse if (phy_data->sfp_cable_len <= 3)\n-\t\t\taxgbe_phy_perform_ratechange(pdata, 3, 2);\n+\t\t\taxgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_SET_10G_SFI,\n+\t\t\t\t\t\t\tAXGBE_MB_SUBCMD_PASSIVE_3M);\n \t\telse\n-\t\t\taxgbe_phy_perform_ratechange(pdata, 3, 3);\n+\t\t\taxgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_SET_10G_SFI,\n+\t\t\t\t\t\t\tAXGBE_MB_SUBCMD_PASSIVE_OTHER);\n \t}\n \n \tphy_data->cur_mode = AXGBE_MODE_SFI;\n@@ -1313,7 +1317,8 @@ static void axgbe_phy_kr_mode(struct axgbe_port *pdata)\n \taxgbe_phy_set_redrv_mode(pdata);\n \n \t/* 10G/KR */\n-\taxgbe_phy_perform_ratechange(pdata, 4, 0);\n+\t\taxgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_SET_10G_KR,\n+\t\t\t\t\t\tAXGBE_MB_SUBCMD_NONE);\n \tphy_data->cur_mode = AXGBE_MODE_KR;\n \n \tPMD_DRV_LOG(DEBUG, \"10GbE KR mode set\\n\");\n@@ -1326,7 +1331,7 @@ static void axgbe_phy_kx_2500_mode(struct axgbe_port *pdata)\n \taxgbe_phy_set_redrv_mode(pdata);\n \n \t/* 2.5G/KX */\n-\taxgbe_phy_perform_ratechange(pdata, 2, 0);\n+\taxgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_SET_2_5G, AXGBE_MB_SUBCMD_NONE);\n \tphy_data->cur_mode = AXGBE_MODE_KX_2500;\n }\n \n@@ -1337,7 +1342,7 @@ static void axgbe_phy_sgmii_1000_mode(struct axgbe_port *pdata)\n \taxgbe_phy_set_redrv_mode(pdata);\n \n \t/* 1G/SGMII */\n-\taxgbe_phy_perform_ratechange(pdata, 1, 2);\n+\taxgbe_phy_perform_ratechange(pdata, AXGBE_MB_CMD_SET_1G, AXGBE_MB_SUBCMD_1G_SGMII);\n \n \tphy_data->cur_mode = AXGBE_MODE_SGMII_1000;\n }\n", "prefixes": [ "v2", "17/25" ] }