Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140013/?format=api
{ "id": 140013, "url": "http://patchwork.dpdk.org/api/patches/140013/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240510050507.14381-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240510050507.14381-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240510050507.14381-2-stephen@networkplumber.org", "date": "2024-05-10T05:01:21", "name": "[RFC,1/3] ethdev: add internal helper of SW driver statistics", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "36f6a98351f5f45817dcf7e39c8861edfbfea91e", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240510050507.14381-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 31900, "url": "http://patchwork.dpdk.org/api/series/31900/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31900", "date": "2024-05-10T05:01:20", "name": "generic sw counters", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31900/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/140013/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/140013/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E26C243FEC;\n\tFri, 10 May 2024 07:05:18 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7ABA7402EC;\n\tFri, 10 May 2024 07:05:14 +0200 (CEST)", "from mail-pl1-f179.google.com (mail-pl1-f179.google.com\n [209.85.214.179])\n by mails.dpdk.org (Postfix) with ESMTP id AF7DD4025F\n for <dev@dpdk.org>; Fri, 10 May 2024 07:05:12 +0200 (CEST)", "by mail-pl1-f179.google.com with SMTP id\n d9443c01a7336-1ed012c1afbso13634875ad.1\n for <dev@dpdk.org>; Thu, 09 May 2024 22:05:12 -0700 (PDT)", "from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-1ef0c25566asm23007385ad.283.2024.05.09.22.05.10\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 May 2024 22:05:11 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715317512;\n x=1715922312; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=LQEvvo9hdsnNCJU05asnkzipDryml9gKV3XPEkyKQ1U=;\n b=PQgPYTbs30Ev+vhbvkd9+o6HrSRGeA/IP7XDm6eeaIZ3jz4repTPya+PI2Qf3z2l1E\n dH/1qiywsFk4G0Ye4kXMhOeIavGRa+xAQI3BVWkikmtzl2xSmpdSUCF50bZ5tLeT33PA\n oE69+7090Bhl/HoZIpu1Y84QxoJeLpYfoQO+M9MDnLUnUXH1a0TcIajySAMtnaZg/Py9\n VkrK1MNyfOuPc1LRvKGZkDKH2cWTCPNSTu6KBb3XRCH1iwHDIKWOV1BsyOhfqhPnQwQb\n 0JRg2LCW6Qo3vUtUGb4BJ9gVY28jwnapn98H2ZXhLwYOW3Pdfzg34F6VUws15ElVFSBn\n kI6Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715317512; x=1715922312;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=LQEvvo9hdsnNCJU05asnkzipDryml9gKV3XPEkyKQ1U=;\n b=kDPJftFAthBd9ldUVhLiFT3aUF0AhnTQ33heIMJi7yVXGatv6/6BqO5Yt0ryQWxZkV\n iDpk/NiBsA/+Ab2vokqilyZVJ/FVfieRS41eI5GAjYUwYKVO3cxFC+ez+U5ElSANeAZr\n 8osPI+ECG7sHeOQuwPkHf3tH9l4jEoxl+7gb3E2Irq9hNqxKmqWdJtB2AY0NWSsW92Th\n kBt/loVfn+4fOfe07FLfz8uG4dVcTht5MqvxaI8UsJaXSzcvf3ogAjZWIk1Q6cgeh7Vh\n KetwrbQlWKBbUCVTJ1SqpHUpBb0FyLNgb8MLpGkVnpukoxAMUU4QA4YnW0KRIYl+wRlg\n la3A==", "X-Gm-Message-State": "AOJu0Yz7EpsUmvfGB2wSfm627BNObxERSDT1JkYIdI5MLGQzeP5Hw/ml\n wX8b54XbwcV0demOP8OQ1H2gZANhj71UGVKNU/CnVDku72PwcgMnc4Q15iJ38z+4pJ5xT1C2kaY\n rqLk=", "X-Google-Smtp-Source": "\n AGHT+IH7RdwNUUB24GQmblHQzJEWlZ4AZC52oTf5GbFN8x8H7loagzr2jzBvILB/L02V4qypb4C4WQ==", "X-Received": "by 2002:a17:902:dad2:b0:1eb:828:9a71 with SMTP id\n d9443c01a7336-1ef432a0cbbmr25962525ad.31.1715317511799;\n Thu, 09 May 2024 22:05:11 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[RFC 1/3] ethdev: add internal helper of SW driver statistics", "Date": "Thu, 9 May 2024 22:01:21 -0700", "Message-ID": "<20240510050507.14381-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240510050507.14381-1-stephen@networkplumber.org>", "References": "<20240425174617.2126159-1-ferruh.yigit@amd.com>\n <20240510050507.14381-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This clones the staistic update code from virtio for use\nby other drivers. It also uses native uint64_t on 64 bit platform\nbut atomic operations on 32 bit platforms.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n\nethdev: use atomic on 32\n---\n lib/ethdev/ethdev_swstats.c | 294 ++++++++++++++++++++++++++++++++++++\n lib/ethdev/ethdev_swstats.h | 60 ++++++++\n lib/ethdev/meson.build | 2 +\n lib/ethdev/version.map | 7 +\n 4 files changed, 363 insertions(+)\n create mode 100644 lib/ethdev/ethdev_swstats.c\n create mode 100644 lib/ethdev/ethdev_swstats.h", "diff": "diff --git a/lib/ethdev/ethdev_swstats.c b/lib/ethdev/ethdev_swstats.c\nnew file mode 100644\nindex 0000000000..81b9ac13b5\n--- /dev/null\n+++ b/lib/ethdev/ethdev_swstats.c\n@@ -0,0 +1,294 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (c) Stephen Hemminger <stephen@networkplumber.org>\n+ */\n+\n+#include <stdbool.h>\n+\n+#include <rte_common.h>\n+#include <ethdev_driver.h>\n+\n+#include \"rte_ethdev.h\"\n+#include \"ethdev_swstats.h\"\n+\n+/*\n+ * Handling of 64 bit counters to problems with load/store tearing on 32 bit.\n+ * Store of aligned 64 bit never gets seperated on 64 bit platform.\n+ * But on 32 bit need to use atomic.\n+ */\n+#ifdef RTE_ARCH_64\n+typedef uint64_t eth_counter_t;\n+\n+static inline void\n+eth_counter_add(eth_counter_t *counter, uint32_t val)\n+{\n+\tcounter += val;\n+}\n+\n+static inline uint64_t\n+eth_counter_read(const eth_counter_t *counter)\n+{\n+\treturn *counter;\n+}\n+\n+static inline void\n+eth_counter_reset(eth_counter_t *counter)\n+{\n+\t*counter = 0;\n+}\n+#else\n+static inline void\n+eth_counter_add(eth_counter_t *counter, uint32_t val)\n+{\n+\trte_atomic_fetch_add_explicit(counter, val, rte_memory_order_relaxed);\n+}\n+\n+static inline uint64_t\n+eth_counter_read(const eth_counter_t *counter)\n+{\n+\treturn rte_atomic_load_explicit(counter, rte_memory_order_relaxed);\n+}\n+\n+static inline void\n+eth_counter_reset(eth_counter_t *counter)\n+{\n+\trte_atomic_store_explicit(counter, 0, rte_memory_order_relaxed);\n+}\n+\n+#endif\n+\n+static void\n+eth_qsw_reset(struct rte_eth_qsw_stats *qstats)\n+{\n+\tunsigned int i;\n+\n+\teth_counter_reset(&qstats->packets);\n+\teth_counter_reset(&qstats->bytes);\n+\teth_counter_reset(&qstats->multicast);\n+\teth_counter_reset(&qstats->broadcast);\n+\n+\tfor (i = 0; i < RTE_DIM(qstats->size_bins); i++)\n+\t\teth_counter_reset(&qstats->size_bins[i]);\n+}\n+\n+void\n+rte_eth_qsw_update(struct rte_eth_qsw_stats *qstats, const struct rte_mbuf *mbuf)\n+{\n+\tuint32_t s = mbuf->pkt_len;\n+\tuint32_t bin;\n+\tconst struct rte_ether_addr *ea;\n+\n+\tif (s == 64) {\n+\t\tbin = 1;\n+\t} else if (s > 64 && s < 1024) {\n+\t\t/* count zeros, and offset into correct bin */\n+\t\tbin = (sizeof(s) * 8) - rte_clz32(s) - 5;\n+\t} else if (s < 64) {\n+\t\tbin = 0;\n+\t} else if (s < 1519) {\n+\t\tbin = 6;\n+\t} else {\n+\t\tbin = 7;\n+\t}\n+\n+\teth_counter_add(&qstats->packets, 1);\n+\teth_counter_add(&qstats->bytes, s);\n+\teth_counter_add(&qstats->size_bins[bin], 1);\n+\n+\tea = rte_pktmbuf_mtod(mbuf, const struct rte_ether_addr *);\n+\tif (rte_is_multicast_ether_addr(ea)) {\n+\t\tif (rte_is_broadcast_ether_addr(ea))\n+\t\t\teth_counter_add(&qstats->broadcast, 1);\n+\t\telse\n+\t\t\teth_counter_add(&qstats->multicast, 1);\n+\t}\n+}\n+\n+void\n+rte_eth_qsw_error_inc(struct rte_eth_qsw_stats *qstats)\n+{\n+\teth_counter_add(&qstats->errors, 1);\n+}\n+\n+int\n+rte_eth_qsw_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n+{\n+\tunsigned int i;\n+\tuint64_t packets, bytes, errors;\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\t/* assumes that rte_eth_qsw_stats is at start of the queue structure */\n+\t\tconst struct rte_eth_qsw_stats *qstats = dev->data->tx_queues[i];\n+\n+\t\tif (qstats == NULL)\n+\t\t\tcontinue;\n+\n+\t\tpackets = eth_counter_read(&qstats->packets);\n+\t\tbytes = eth_counter_read(&qstats->bytes);\n+\t\terrors = eth_counter_read(&qstats->errors);\n+\n+\t\tstats->opackets += packets;\n+\t\tstats->obytes += bytes;\n+\t\tstats->oerrors += errors;\n+\n+\t\tif (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {\n+\t\t\tstats->q_opackets[i] = packets;\n+\t\t\tstats->q_obytes[i] = bytes;\n+\t\t}\n+\t}\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\t/* assumes that rte_eth_qsw_stats is at start of the queue structure */\n+\t\tconst struct rte_eth_qsw_stats *qstats = dev->data->rx_queues[i];\n+\n+\t\tif (qstats == NULL)\n+\t\t\tcontinue;\n+\n+\t\tpackets = eth_counter_read(&qstats->packets);\n+\t\tbytes = eth_counter_read(&qstats->bytes);\n+\t\terrors = eth_counter_read(&qstats->errors);\n+\n+\t\tstats->ipackets += packets;\n+\t\tstats->ibytes += bytes;\n+\t\tstats->ierrors += errors;\n+\n+\t\tif (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {\n+\t\t\tstats->q_ipackets[i] = packets;\n+\t\t\tstats->q_ibytes[i] = bytes;\n+\t\t}\n+\t}\n+\n+\tstats->rx_nombuf = dev->data->rx_mbuf_alloc_failed;\n+\treturn 0;\n+}\n+\n+int\n+rte_eth_qsw_stats_reset(struct rte_eth_dev *dev)\n+{\n+\tunsigned int i;\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tstruct rte_eth_qsw_stats *qstats = dev->data->tx_queues[i];\n+\n+\t\tif (qstats != NULL)\n+\t\t\teth_qsw_reset(qstats);\n+\t}\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tstruct rte_eth_qsw_stats *qstats = dev->data->rx_queues[i];\n+\n+\t\tif (qstats != NULL)\n+\t\t\teth_qsw_reset(qstats);\n+\t}\n+\n+\treturn 0;\n+}\n+\n+struct xstats_name_off {\n+\tchar name[RTE_ETH_XSTATS_NAME_SIZE];\n+\tsize_t offset;\n+};\n+\n+/* [rt]x_qX_ is prepended to the name string here */\n+static const struct xstats_name_off eth_swstats_strings[] = {\n+\t{\"good_packets\", offsetof(struct rte_eth_qsw_stats, packets)},\n+\t{\"good_bytes\", offsetof(struct rte_eth_qsw_stats, bytes)},\n+\t{\"errors\", offsetof(struct rte_eth_qsw_stats, errors)},\n+\t{\"multicast_packets\", offsetof(struct rte_eth_qsw_stats, multicast)},\n+\t{\"broadcast_packets\", offsetof(struct rte_eth_qsw_stats, broadcast)},\n+\t{\"undersize_packets\", offsetof(struct rte_eth_qsw_stats, size_bins[0])},\n+\t{\"size_64_packets\", offsetof(struct rte_eth_qsw_stats, size_bins[1])},\n+\t{\"size_65_127_packets\", offsetof(struct rte_eth_qsw_stats, size_bins[2])},\n+\t{\"size_128_255_packets\", offsetof(struct rte_eth_qsw_stats, size_bins[3])},\n+\t{\"size_256_511_packets\", offsetof(struct rte_eth_qsw_stats, size_bins[4])},\n+\t{\"size_512_1023_packets\", offsetof(struct rte_eth_qsw_stats, size_bins[5])},\n+\t{\"size_1024_1518_packets\", offsetof(struct rte_eth_qsw_stats, size_bins[6])},\n+\t{\"size_1519_max_packets\", offsetof(struct rte_eth_qsw_stats, size_bins[7])},\n+};\n+#define NUM_SWSTATS_XSTATS RTE_DIM(eth_swstats_strings)\n+\n+\n+int\n+rte_eth_qsw_xstats_get_names(struct rte_eth_dev *dev,\n+\t\t\t\tstruct rte_eth_xstat_name *xstats_names,\n+\t\t\t\t__rte_unused unsigned limit)\n+{\n+\tunsigned int i, t, count = 0;\n+\n+\tif (xstats_names == NULL)\n+\t\treturn (dev->data->nb_tx_queues + dev->data->nb_rx_queues) * NUM_SWSTATS_XSTATS;\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tconst void *rxq = dev->data->rx_queues[i];\n+\n+\t\tif (rxq == NULL)\n+\t\t\tcontinue;\n+\n+\t\tfor (t = 0; t < NUM_SWSTATS_XSTATS; t++) {\n+\t\t\tsnprintf(xstats_names[count].name, sizeof(xstats_names[count].name),\n+\t\t\t\t \"rx_q%u_%s\", i, eth_swstats_strings[t].name);\n+\t\t\tcount++;\n+\t\t}\n+\t}\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tconst void *txq = dev->data->tx_queues[i];\n+\n+\t\tif (txq == NULL)\n+\t\t\tcontinue;\n+\n+\t\tfor (t = 0; t < NUM_SWSTATS_XSTATS; t++) {\n+\t\t\tsnprintf(xstats_names[count].name, sizeof(xstats_names[count].name),\n+\t\t\t\t \"tx_q%u_%s\", i, eth_swstats_strings[t].name);\n+\t\t\tcount++;\n+\t\t}\n+\t}\n+\treturn count;\n+}\n+\n+int\n+rte_eth_qsw_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats, unsigned int n)\n+{\n+\tunsigned int i, t, count = 0;\n+\tconst unsigned int nstats\n+\t\t= (dev->data->nb_tx_queues + dev->data->nb_rx_queues) * NUM_SWSTATS_XSTATS;\n+\n+\tif (n < nstats)\n+\t\treturn nstats;\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\t/* assumes that rte_eth_qsw_stats is at start of the queue structure */\n+\t\tconst struct rte_eth_qsw_stats *qstats = dev->data->rx_queues[i];\n+\n+\t\tif (qstats == NULL)\n+\t\t\tcontinue;\n+\n+\t\tfor (t = 0; t < NUM_SWSTATS_XSTATS; t++) {\n+\t\t\tconst uint64_t *valuep\n+\t\t\t\t= (const uint64_t *)((const char *)qstats\n+\t\t\t\t\t\t + eth_swstats_strings[t].offset);\n+\n+\t\t\txstats[count].value = *valuep;\n+\t\t\txstats[count].id = count;\n+\t\t\t++count;\n+\t\t}\n+\t}\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tconst struct rte_eth_qsw_stats *qstats = dev->data->tx_queues[i];\n+\n+\t\tif (qstats == NULL)\n+\t\t\tcontinue;\n+\n+\t\tfor (t = 0; t < NUM_SWSTATS_XSTATS; t++) {\n+\t\t\tconst uint64_t *valuep\n+\t\t\t\t= (const uint64_t *)((const char *)qstats\n+\t\t\t\t\t\t + eth_swstats_strings[t].offset);\n+\n+\t\t\txstats[count].value = *valuep;\n+\t\t\txstats[count].id = count;\n+\t\t\t++count;\n+\t\t}\n+\t}\n+\n+\treturn count;\n+}\ndiff --git a/lib/ethdev/ethdev_swstats.h b/lib/ethdev/ethdev_swstats.h\nnew file mode 100644\nindex 0000000000..6309107128\n--- /dev/null\n+++ b/lib/ethdev/ethdev_swstats.h\n@@ -0,0 +1,60 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (c) Stephen Hemminger <stephen@networkplumber.org>\n+ */\n+\n+#ifndef _RTE_ETHDEV_SWSTATS_H_\n+#define _RTE_ETHDEV_SWSTATS_H_\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+#include <rte_stdatomic.h>\n+\n+#ifdef RTE_ARCH_64\n+typedef uint64_t eth_counter_t;\n+#else\n+typedef RTE_ATOMIC(uint64_t) eth_counter_t;\n+#endif\n+\n+struct rte_eth_qsw_stats {\n+\teth_counter_t\tpackets;\n+\teth_counter_t\tbytes;\n+\teth_counter_t\terrors;\n+\teth_counter_t\tmulticast;\n+\teth_counter_t\tbroadcast;\n+\t/* Size bins in array as RFC 2819, undersized [0], 64 [1], etc */\n+\teth_counter_t\tsize_bins[8];\n+};\n+\n+__rte_internal\n+void\n+rte_eth_qsw_update(struct rte_eth_qsw_stats *stats, const struct rte_mbuf *mbuf);\n+\n+__rte_internal\n+void\n+rte_eth_qsw_error_inc(struct rte_eth_qsw_stats *stats);\n+\n+__rte_internal\n+int\n+rte_eth_qsw_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats);\n+\n+__rte_internal\n+int\n+rte_eth_qsw_stats_reset(struct rte_eth_dev *dev);\n+\n+__rte_internal\n+int\n+rte_eth_qsw_xstats_get_names(struct rte_eth_dev *dev,\n+\t\t\t\tstruct rte_eth_xstat_name *xstats_names,\n+\t\t\t\tunsigned int limit);\n+__rte_internal\n+int\n+rte_eth_qsw_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,\n+\t\t\t unsigned int n);\n+\n+#ifdef __cplusplus\n+}\n+#endif\n+\n+#endif /* _RTE_ETHDEV_SWSTATS_H_ */\ndiff --git a/lib/ethdev/meson.build b/lib/ethdev/meson.build\nindex f1d2586591..7ce29a46d4 100644\n--- a/lib/ethdev/meson.build\n+++ b/lib/ethdev/meson.build\n@@ -3,6 +3,7 @@\n \n sources = files(\n 'ethdev_driver.c',\n+ 'ethdev_swstats.c',\n 'ethdev_private.c',\n 'ethdev_profile.c',\n 'ethdev_trace_points.c',\n@@ -42,6 +43,7 @@ driver_sdk_headers += files(\n 'ethdev_driver.h',\n 'ethdev_pci.h',\n 'ethdev_vdev.h',\n+ 'ethdev_swstats.h',\n )\n \n if is_linux\ndiff --git a/lib/ethdev/version.map b/lib/ethdev/version.map\nindex 79f6f5293b..32ebe5ea09 100644\n--- a/lib/ethdev/version.map\n+++ b/lib/ethdev/version.map\n@@ -358,4 +358,11 @@ INTERNAL {\n \trte_eth_switch_domain_alloc;\n \trte_eth_switch_domain_free;\n \trte_flow_fp_default_ops;\n+\n+\trte_eth_qsw_error_inc;\n+\trte_eth_qsw_stats_get;\n+\trte_eth_qsw_stats_reset;\n+\trte_eth_qsw_update;\n+\trte_eth_qsw_xstats_get;\n+\trte_eth_qsw_xstats_get_names;\n };\n", "prefixes": [ "RFC", "1/3" ] }