Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140040/?format=api
{ "id": 140040, "url": "http://patchwork.dpdk.org/api/patches/140040/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240513185448.120356-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240513185448.120356-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240513185448.120356-2-stephen@networkplumber.org", "date": "2024-05-13T18:52:11", "name": "[RFC,v2,1/7] eal: generic 64 bit counter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a92b59a0c487a69b2bb71171e77ac76b777b33c0", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240513185448.120356-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 31915, "url": "http://patchwork.dpdk.org/api/series/31915/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31915", "date": "2024-05-13T18:52:10", "name": "generic SW counters", "version": 2, "mbox": "http://patchwork.dpdk.org/series/31915/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/140040/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/140040/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DA9B44401D;\n\tMon, 13 May 2024 20:55:06 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E6BF04067D;\n\tMon, 13 May 2024 20:55:01 +0200 (CEST)", "from mail-pf1-f177.google.com (mail-pf1-f177.google.com\n [209.85.210.177])\n by mails.dpdk.org (Postfix) with ESMTP id 29052402CD\n for <dev@dpdk.org>; Mon, 13 May 2024 20:55:00 +0200 (CEST)", "by mail-pf1-f177.google.com with SMTP id\n d2e1a72fcca58-6f450f43971so3938501b3a.3\n for <dev@dpdk.org>; Mon, 13 May 2024 11:55:00 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-634103f7237sm8154680a12.71.2024.05.13.11.54.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 May 2024 11:54:58 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715626499;\n x=1716231299; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=qDTur2+NCw1uV0OtsmGZpp6yEEmoZEWlPL0svpl1uRo=;\n b=D/OmNW/AiYgGc7zsNdVnJPaZAhMJHMk6WxDTt7bFoelmjuaF2K2EOL9/yeq83wsg0F\n pN4M9PX/ca1oXRqxl2RPACO2y/BAC2fX19HHaJyVtc4LpqsfP03usjVeojeH64qjBs1j\n uXFtd6mRcNzXJFjcZeGP106pfLStYemG77xMmP2esgYDskU2fzIuL3BQhN+slKFHzT0Z\n N4OopgxFZXgAuTCQGXIIkCtnvM4A4P3Fw5pEa3yLbdUUDIGfgUacmnBIvaGy2lkUvjHN\n vXBFfvN6RiS9G072L0f4e8k8/hfeXTGyi6hH9oJ1fTPxsqbaRTsB5xC93h9/PtAZGJc/\n MpGQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715626499; x=1716231299;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=qDTur2+NCw1uV0OtsmGZpp6yEEmoZEWlPL0svpl1uRo=;\n b=Y/cN657htZXr6QK24+dWSg/uyusEv4BaKTPIyYjhvyc3wWHeko4reWNtBKp4cp/h8l\n h8r2GwzNFEInpZwnLkZO5Xlz9k5lYUUFsW7fjf6I0XsfDCgOT8hT/LWqs9W7nxSNMs4q\n osetA1SYOzSfCKgTNhG70Vky97+8N76ZjHl2e2RL/2AfaVTRHgBnGcNm/g+Cs8Yh+Syl\n ILMGN0gALvOk8P8JPOUdLtTFnadlF5QwHYiGzxxC+dP0VQx1huw1MDW2TlRxfIiX13p5\n 0bvW4yVzTGbXLIQxZXC3GSOnOHhhY8c9USUkzSg6dWfPnPrydQZajTikP4ATms2YrEli\n YtSg==", "X-Gm-Message-State": "AOJu0YynopHbrTH/ckrMycQiAzO/LTbES5CU8HehfCRShar5uuyNRjxR\n 8PRyDK8595L3g+EccUt5v+srFIfz4CPLdAJo2QyW5SvzbXOy4vw+PhjWYgiwtgFK1VlZbNk9TuU\n 9FEcHiQ==", "X-Google-Smtp-Source": "\n AGHT+IHJTlBPu8/azLI1lpZGJL/9aq7qJd+d5nqvUXk/lOh3D8Phjo8yh+rzFNw7Jh8DkL96xcXQEg==", "X-Received": "by 2002:a05:6a00:1397:b0:6e6:89ad:1233 with SMTP id\n d2e1a72fcca58-6f4e02a6150mr14387366b3a.2.1715626499277;\n Mon, 13 May 2024 11:54:59 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[RFC v2 1/7] eal: generic 64 bit counter", "Date": "Mon, 13 May 2024 11:52:11 -0700", "Message-ID": "<20240513185448.120356-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240513185448.120356-1-stephen@networkplumber.org>", "References": "<20240510050507.14381-1-stephen@networkplumber.org>\n <20240513185448.120356-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This header implements 64 bit counters that are NOT atomic\nbut are safe against load/store splits on 32 bit platforms.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/include/meson.build | 1 +\n lib/eal/include/rte_counter.h | 91 +++++++++++++++++++++++++++++++++++\n 2 files changed, 92 insertions(+)\n create mode 100644 lib/eal/include/rte_counter.h", "diff": "diff --git a/lib/eal/include/meson.build b/lib/eal/include/meson.build\nindex e94b056d46..c070dd0079 100644\n--- a/lib/eal/include/meson.build\n+++ b/lib/eal/include/meson.build\n@@ -12,6 +12,7 @@ headers += files(\n 'rte_class.h',\n 'rte_common.h',\n 'rte_compat.h',\n+ 'rte_counter.h',\n 'rte_debug.h',\n 'rte_dev.h',\n 'rte_devargs.h',\ndiff --git a/lib/eal/include/rte_counter.h b/lib/eal/include/rte_counter.h\nnew file mode 100644\nindex 0000000000..1c1c34c2fb\n--- /dev/null\n+++ b/lib/eal/include/rte_counter.h\n@@ -0,0 +1,91 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (c) Stephen Hemminger <stephen@networkplumber.org>\n+ */\n+\n+#ifndef _RTE_COUNTER_H_\n+#define _RTE_COUNTER_H_\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+/**\n+ * @file\n+ * RTE Counter\n+ *\n+ * A counter is 64 bit value that is safe from split read/write\n+ * on 32 bit platforms. It assumes that only one cpu at a time\n+ * will update the counter, and another CPU may want to read it.\n+ *\n+ * This is a much weaker guarantee than @rte_atomic but is faster\n+ * since no locked operations are required for update.\n+ */\n+\n+#include <stdatomic.h>\n+\n+#ifdef RTE_ARCH_64\n+/*\n+ * On a platform that can support native 64 bit type, no special handling.\n+ * These are just wrapper around 64 bit value.\n+ */\n+typedef uint64_t rte_counter64_t;\n+\n+/**\n+ * Add value to counter.\n+ */\n+__rte_experimental\n+static inline void\n+rte_counter64_add(rte_counter64_t *counter, uint32_t val)\n+{\n+\t*counter += val;\n+}\n+\n+__rte_experimental\n+static inline uint64_t\n+rte_counter64_fetch(const rte_counter64_t *counter)\n+{\n+\treturn *counter;\n+}\n+\n+__rte_experimental\n+static inline void\n+rte_counter64_reset(rte_counter64_t *counter)\n+{\n+\t*counter = 0;\n+}\n+\n+#else\n+/*\n+ * On a 32 bit platform need to use atomic to force the compler to not\n+ * split 64 bit read/write.\n+ */\n+typedef RTE_ATOMIC(uint64_t) rte_counter64_t;\n+\n+__rte_experimental\n+static inline void\n+rte_counter64_add(rte_counter64_t *counter, uint32_t val)\n+{\n+\trte_atomic_fetch_add_explicit(counter, val, rte_memory_order_relaxed);\n+}\n+\n+__rte_experimental\n+static inline uint64_t\n+rte_counter64_fetch(rte_counter64_t *counter)\n+{\n+\treturn rte_atomic_load_explicit(counter, rte_memory_order_relaxed);\n+}\n+\n+__rte_experimental\n+static inline void\n+rte_counter64_reset(rte_counter64_t *counter)\n+{\n+\trte_atomic_store_explicit(counter, 0, rte_memory_order_relaxed);\n+}\n+#endif\n+\n+\n+#ifdef __cplusplus\n+}\n+#endif\n+\n+#endif /* _RTE_COUNTER_H_ */\n", "prefixes": [ "RFC", "v2", "1/7" ] }