Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 140049,
    "url": "http://patchwork.dpdk.org/api/patches/140049/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240514084155.50673-3-ciara.loftus@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20240514084155.50673-3-ciara.loftus@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20240514084155.50673-3-ciara.loftus@intel.com",
    "date": "2024-05-14T08:41:53",
    "name": "[v2,2/4] net/af_xdp: fix mbuf alloc failed statistic",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "d6fde2c2cb0943f95db98f0937dec21ab1d8fc97",
    "submitter": {
        "id": 144,
        "url": "http://patchwork.dpdk.org/api/people/144/?format=api",
        "name": "Loftus, Ciara",
        "email": "ciara.loftus@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patchwork.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240514084155.50673-3-ciara.loftus@intel.com/mbox/",
    "series": [
        {
            "id": 31917,
            "url": "http://patchwork.dpdk.org/api/series/31917/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31917",
            "date": "2024-05-14T08:41:51",
            "name": "AF_XDP PMD Bugfixes",
            "version": 2,
            "mbox": "http://patchwork.dpdk.org/series/31917/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/140049/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/140049/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9B44E4402A;\n\tTue, 14 May 2024 10:43:11 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 56F854068E;\n\tTue, 14 May 2024 10:43:07 +0200 (CEST)",
            "from mgamail.intel.com (mgamail.intel.com [192.198.163.16])\n by mails.dpdk.org (Postfix) with ESMTP id 298A0402ED;\n Tue, 14 May 2024 10:43:05 +0200 (CEST)",
            "from fmviesa006.fm.intel.com ([10.60.135.146])\n by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 May 2024 01:43:05 -0700",
            "from silpixa00401177.ir.intel.com (HELO vm177..) ([10.55.128.139])\n by fmviesa006.fm.intel.com with ESMTP; 14 May 2024 01:43:03 -0700"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1715676185; x=1747212185;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=9KvEG33BwdjssPwZh56mDWIOo82RsTL+9MS8eZf4aEk=;\n b=hqGXYDg+GAmyxumecFMoP1t3k3M7cxbLjBnaJTTgPAQ2sN2w97Vg0yhg\n Fuy6eivxGiO6xtws9lbX6QqjHfzufQW4IyA5CaW7Wo6rrtXqZV+xdocVJ\n arvLyET5kAX5z1IvNCxJxj5uKt8vO9zNqJFI14LdZoE14vrhywKyLpuOJ\n FXXM/fM5Y6V7tjnVbcofJvvwFfMX0r9wPF38sNeiq6vCryk79zzDVYmkr\n n3KDY5he4bBFVO4QMkNn98sWST13V+Qh7bnVgnwZQCD4iHOZa/Af1DGm4\n RX1K8/AsMy+DtxL1XjIQtRDzpg9a3CAO12nNN99v1F1Z8KvF7VVcUj+zp g==;",
        "X-CSE-ConnectionGUID": [
            "juCYDjhmTt+NMINvSJ3XYQ==",
            "A/gKsWDmRUOsCsqEOeXxRg=="
        ],
        "X-CSE-MsgGUID": [
            "Rz5P6vMlQx+oCgUPC0bByw==",
            "WYe23x3wQPeDIkHapWs0Zg=="
        ],
        "X-IronPort-AV": [
            "E=McAfee;i=\"6600,9927,11072\"; a=\"11513811\"",
            "E=Sophos;i=\"6.08,159,1712646000\"; d=\"scan'208\";a=\"11513811\"",
            "E=Sophos;i=\"6.08,159,1712646000\"; d=\"scan'208\";a=\"30657435\""
        ],
        "X-ExtLoop1": "1",
        "From": "Ciara Loftus <ciara.loftus@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Ciara Loftus <ciara.loftus@intel.com>, stable@dpdk.org,\n Stephen Hemminger <stephen@networkplumber.org>",
        "Subject": "[PATCH v2 2/4] net/af_xdp: fix mbuf alloc failed statistic",
        "Date": "Tue, 14 May 2024 08:41:53 +0000",
        "Message-Id": "<20240514084155.50673-3-ciara.loftus@intel.com>",
        "X-Mailer": "git-send-email 2.34.1",
        "In-Reply-To": "<20240514084155.50673-1-ciara.loftus@intel.com>",
        "References": "<20240514084155.50673-1-ciara.loftus@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Failures to allocate mbufs in the receive path were not being\naccounted for in the ethdev statistics. Fix this.\n\nBugzilla ID: 1429\nFixes: f1debd77efaf (\"net/af_xdp: introduce AF_XDP PMD\")\ncc: stable@dpdk.org\n\nReported-by: Stephen Hemminger <stephen@networkplumber.org>\nSigned-off-by: Ciara Loftus <ciara.loftus@intel.com>\n---\nv2:\n* Fixed typo in commit message\n* Remove unnecessary local stat for alloc_failed\n\n drivers/net/af_xdp/rte_eth_af_xdp.c | 5 +++++\n 1 file changed, 5 insertions(+)",
    "diff": "diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c\nindex fee0d5d5f3..9bcf971ae5 100644\n--- a/drivers/net/af_xdp/rte_eth_af_xdp.c\n+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c\n@@ -312,6 +312,7 @@ af_xdp_rx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tunsigned long rx_bytes = 0;\n \tint i;\n \tstruct rte_mbuf *fq_bufs[ETH_AF_XDP_RX_BATCH_SIZE];\n+\tstruct rte_eth_dev *dev = &rte_eth_devices[rxq->port];\n \n \tnb_pkts = xsk_ring_cons__peek(rx, nb_pkts, &idx_rx);\n \n@@ -339,6 +340,8 @@ af_xdp_rx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t * xsk_ring_cons__peek\n \t\t */\n \t\trx->cached_cons -= nb_pkts;\n+\t\tdev->data->rx_mbuf_alloc_failed += nb_pkts;\n+\n \t\treturn 0;\n \t}\n \n@@ -390,6 +393,7 @@ af_xdp_rx_cp(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tint i;\n \tuint32_t free_thresh = fq->size >> 1;\n \tstruct rte_mbuf *mbufs[ETH_AF_XDP_RX_BATCH_SIZE];\n+\tstruct rte_eth_dev *dev = &rte_eth_devices[rxq->port];\n \n \tif (xsk_prod_nb_free(fq, free_thresh) >= free_thresh)\n \t\t(void)reserve_fill_queue(umem, nb_pkts, NULL, fq);\n@@ -408,6 +412,7 @@ af_xdp_rx_cp(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t * xsk_ring_cons__peek\n \t\t */\n \t\trx->cached_cons -= nb_pkts;\n+\t\tdev->data->rx_mbuf_alloc_failed += nb_pkts;\n \t\treturn 0;\n \t}\n \n",
    "prefixes": [
        "v2",
        "2/4"
    ]
}