Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140122/?format=api
{ "id": 140122, "url": "http://patchwork.dpdk.org/api/patches/140122/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240514201436.2496-5-jspewock@iol.unh.edu/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240514201436.2496-5-jspewock@iol.unh.edu>", "list_archive_url": "https://inbox.dpdk.org/dev/20240514201436.2496-5-jspewock@iol.unh.edu", "date": "2024-05-14T20:14:36", "name": "[v1,4/4] dts: add test case that utilizes offload to pmd_buffer_scatter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a651f80b78465cfddd9f749e4ca5214f978e5577", "submitter": { "id": 2772, "url": "http://patchwork.dpdk.org/api/people/2772/?format=api", "name": "Jeremy Spewock", "email": "jspewock@iol.unh.edu" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240514201436.2496-5-jspewock@iol.unh.edu/mbox/", "series": [ { "id": 31928, "url": "http://patchwork.dpdk.org/api/series/31928/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31928", "date": "2024-05-14T20:14:32", "name": "Add second scatter test case", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31928/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/140122/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/140122/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BCD344402B;\n\tTue, 14 May 2024 22:15:30 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9510540693;\n\tTue, 14 May 2024 22:15:08 +0200 (CEST)", "from mail-pl1-f225.google.com (mail-pl1-f225.google.com\n [209.85.214.225])\n by mails.dpdk.org (Postfix) with ESMTP id 5395C402EC\n for <dev@dpdk.org>; Tue, 14 May 2024 22:15:07 +0200 (CEST)", "by mail-pl1-f225.google.com with SMTP id\n d9443c01a7336-1ed904c2280so32021505ad.2\n for <dev@dpdk.org>; Tue, 14 May 2024 13:15:07 -0700 (PDT)", "from postal.iol.unh.edu (postal.iol.unh.edu.\n [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id\n d9443c01a7336-1ef0c02e585sm3722345ad.128.2024.05.14.13.15.06\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Tue, 14 May 2024 13:15:06 -0700 (PDT)", "from iol.unh.edu (unknown\n [IPv6:2606:4100:3880:1271:90f9:1b64:f6e6:867f])\n by postal.iol.unh.edu (Postfix) with ESMTP id AD472605C373;\n Tue, 14 May 2024 16:15:05 -0400 (EDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=iol.unh.edu; s=unh-iol; t=1715717706; x=1716322506; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=LAUPBkQJvt7S4aewCgi4DDmdlyGjSpBEjEZoeoR3lYc=;\n b=fBkkgtLyNYgs+em/slme4K4iCRJu4rHttVK1aXMNvQki57XS8FeUKaCcSsvFoMnsR9\n 95V2uMnkqY0oooD83wWAvyW4WvJiP2MnHilVJ3slmMEF+SbUU43+/l+t5HCoQ0H3gaxm\n xOdyvpRqTnywORGs9V265vyXyiaGMMxb3/uPw=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715717706; x=1716322506;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=LAUPBkQJvt7S4aewCgi4DDmdlyGjSpBEjEZoeoR3lYc=;\n b=cgIJUloIX5ppbuZfMwLGTgW0v+gAq4CY6l36+WlYhiJi02t8zy3z6DYi0FO/9+bUEk\n jmWiRyPs2lcuQzsbdIs0av84fob+tS8BenG4uClWIwF55QR4O/ps9lW9jRMUT0IR08R+\n nxrz1liYdTNLEkCaa1royAFKVqLv6WGbppWLN/dcgf35k96wANK8hZ/A/JWuXerf8/3+\n 1hItw3VrxV3CaFND0gzo4RhddUm1O1Lvjh5Xn9K9nIcafhtvyuFCTOkpyPAt7Yf+vX3q\n utXHA3GjdOR6ttecvAGzZ4je5/2OMBGCKaOZbxYdz81f73GD3ih31ahOPW3MBsFRwgE7\n Ms9Q==", "X-Gm-Message-State": "AOJu0YzwDSo0mPZ/U7+g++K44HYfuu4bs7TXKNrbayMP8w33MgI9TtBU\n ZwXdOI819zZswYEyn9eQ1cENHxPhXvTxAtGuixkJgA28BHscPZ7+ND5cD7le0aouTdEnlZ5AgGc\n bhJnF1GR7cqvjnLBIIdrf4CPHg2+j8wauSt2Qwp56APLvQ6rt", "X-Google-Smtp-Source": "\n AGHT+IHSlOEw+X8lWObTASRN2BeaSlGiHUNpHaI1urC2s9NJpQPuwlw4deIPxIBF6tdSAWMIbCRik/8XwGTf", "X-Received": "by 2002:a17:902:d64a:b0:1e7:eeb3:e295 with SMTP id\n d9443c01a7336-1ef4404cc0emr123811795ad.69.1715717706518;\n Tue, 14 May 2024 13:15:06 -0700 (PDT)", "X-Relaying-Domain": "iol.unh.edu", "From": "jspewock@iol.unh.edu", "To": "yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com,\n paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu,\n Luca.Vizzarro@arm.com, wathsala.vithanage@arm.com, thomas@monjalon.net", "Cc": "dev@dpdk.org,\n\tJeremy Spewock <jspewock@iol.unh.edu>", "Subject": "[PATCH v1 4/4] dts: add test case that utilizes offload to\n pmd_buffer_scatter", "Date": "Tue, 14 May 2024 16:14:36 -0400", "Message-ID": "<20240514201436.2496-5-jspewock@iol.unh.edu>", "X-Mailer": "git-send-email 2.44.0", "In-Reply-To": "<20240514201436.2496-1-jspewock@iol.unh.edu>", "References": "<20240514201436.2496-1-jspewock@iol.unh.edu>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Jeremy Spewock <jspewock@iol.unh.edu>\n\nSome NICs tested in DPDK allow for the scattering of packets without an\noffload and others enforce that you enable the scattered_rx offload in\ntestpmd. The current version of the suite for testing support of\nscattering packets only tests the case where the NIC supports testing\nwithout the offload, so an expansion of coverage is needed to cover the\nsecond case as well.\n\ndepends-on: patch-139227 (\"dts: skip test cases based on capabilities\")\n\nSigned-off-by: Jeremy Spewock <jspewock@iol.unh.edu>\n---\n dts/tests/TestSuite_pmd_buffer_scatter.py | 49 ++++++++++++++++++-----\n 1 file changed, 38 insertions(+), 11 deletions(-)", "diff": "diff --git a/dts/tests/TestSuite_pmd_buffer_scatter.py b/dts/tests/TestSuite_pmd_buffer_scatter.py\nindex 41f6090a7e..6d04663c8a 100644\n--- a/dts/tests/TestSuite_pmd_buffer_scatter.py\n+++ b/dts/tests/TestSuite_pmd_buffer_scatter.py\n@@ -16,14 +16,19 @@\n \"\"\"\n \n import struct\n+from typing import ClassVar\n \n from scapy.layers.inet import IP # type: ignore[import]\n from scapy.layers.l2 import Ether # type: ignore[import]\n from scapy.packet import Raw # type: ignore[import]\n from scapy.utils import hexstr # type: ignore[import]\n \n-from framework.remote_session.testpmd_shell import TestPmdForwardingModes, TestPmdShell\n-from framework.test_suite import TestSuite\n+from framework.remote_session.testpmd_shell import (\n+ NicCapability,\n+ TestPmdForwardingModes,\n+ TestPmdShell,\n+)\n+from framework.test_suite import TestSuite, requires\n \n \n class TestPmdBufferScatter(TestSuite):\n@@ -48,6 +53,14 @@ class TestPmdBufferScatter(TestSuite):\n and a single byte of packet data stored in a second buffer alongside the CRC.\n \"\"\"\n \n+ #: Parameters for testing scatter using testpmd which are universal across all test cases.\n+ base_testpmd_parameters: ClassVar[list[str]] = [\n+ \"--mbcache=200\",\n+ \"--max-pkt-len=9000\",\n+ \"--port-topology=paired\",\n+ \"--tx-offloads=0x00008000\",\n+ ]\n+\n def set_up_suite(self) -> None:\n \"\"\"Set up the test suite.\n \n@@ -91,7 +104,7 @@ def scatter_pktgen_send_packet(self, pktsize: int) -> str:\n \n return load\n \n- def pmd_scatter(self, mbsize: int) -> None:\n+ def pmd_scatter(self, mbsize: int, testpmd_params: list[str]) -> None:\n \"\"\"Testpmd support of receiving and sending scattered multi-segment packets.\n \n Support for scattered packets is shown by sending 5 packets of differing length\n@@ -103,17 +116,14 @@ def pmd_scatter(self, mbsize: int) -> None:\n \"\"\"\n testpmd_shell = self.sut_node.create_interactive_shell(\n TestPmdShell,\n- app_parameters=(\n- \"--mbcache=200 \"\n- f\"--mbuf-size={mbsize} \"\n- \"--max-pkt-len=9000 \"\n- \"--port-topology=paired \"\n- \"--tx-offloads=0x00008000\"\n- ),\n+ app_parameters=\" \".join(testpmd_params),\n privileged=True,\n )\n with testpmd_shell as testpmd:\n testpmd.set_forward_mode(TestPmdForwardingModes.mac)\n+ # adjust the MTU of the SUT ports\n+ testpmd.set_port_mtu(0, 9000)\n+ testpmd.set_port_mtu(1, 9000)\n testpmd.start()\n \n for offset in [-1, 0, 1, 4, 5]:\n@@ -127,10 +137,27 @@ def pmd_scatter(self, mbsize: int) -> None:\n f\"{offset}.\",\n )\n testpmd.stop()\n+ # reset the MTU of the SUT ports\n+ testpmd.set_port_mtu(0, 1500)\n+ testpmd.set_port_mtu(1, 1500)\n \n+ @requires(NicCapability.scattered_rx)\n def test_scatter_mbuf_2048(self) -> None:\n \"\"\"Run the :meth:`pmd_scatter` test with `mbsize` set to 2048.\"\"\"\n- self.pmd_scatter(mbsize=2048)\n+ self.pmd_scatter(\n+ mbsize=2048, testpmd_params=[*(self.base_testpmd_parameters), \"--mbuf-size=2048\"]\n+ )\n+\n+ def test_scatter_mbuf_2048_with_offload(self) -> None:\n+ \"\"\"Run the :meth:`pmd_scatter` test with `mbsize` set to 2048 and rx_scatter offload.\"\"\"\n+ self.pmd_scatter(\n+ mbsize=2048,\n+ testpmd_params=[\n+ *(self.base_testpmd_parameters),\n+ \"--mbuf-size=2048\",\n+ \"--enable-scatter\",\n+ ],\n+ )\n \n def tear_down_suite(self) -> None:\n \"\"\"Tear down the test suite.\n", "prefixes": [ "v1", "4/4" ] }