Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140130/?format=api
{ "id": 140130, "url": "http://patchwork.dpdk.org/api/patches/140130/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240515234234.5015-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240515234234.5015-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240515234234.5015-3-stephen@networkplumber.org", "date": "2024-05-15T23:40:54", "name": "[v4,2/8] ethdev: add common counters for statistics", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b743a03d877d90874b670966bdfc93c51fb5ed45", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240515234234.5015-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 31935, "url": "http://patchwork.dpdk.org/api/series/31935/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31935", "date": "2024-05-15T23:40:52", "name": "Generic 64 bit counters for SW PMD's", "version": 4, "mbox": "http://patchwork.dpdk.org/series/31935/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/140130/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/140130/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 20AC04403F;\n\tThu, 16 May 2024 01:43:00 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C5C1140649;\n\tThu, 16 May 2024 01:42:49 +0200 (CEST)", "from mail-pg1-f180.google.com (mail-pg1-f180.google.com\n [209.85.215.180])\n by mails.dpdk.org (Postfix) with ESMTP id CD6F3402E1\n for <dev@dpdk.org>; Thu, 16 May 2024 01:42:46 +0200 (CEST)", "by mail-pg1-f180.google.com with SMTP id\n 41be03b00d2f7-6570bd6c3d7so652747a12.0\n for <dev@dpdk.org>; Wed, 15 May 2024 16:42:46 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-6f67b0cd494sm958479b3a.161.2024.05.15.16.42.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 15 May 2024 16:42:45 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715816566;\n x=1716421366; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Z8eKqf5lNQlmO6QqgxdqNWvOCC2KYo8qD/rGb5b3ZPM=;\n b=zjbDODa/9uqmb7NICMmQkNQBjm8mPfKiP5j+Dkoudr85ppAYJuxfleDcGz9s3v3KTd\n k6X2ccbuDfz+2+qKkaNqJX+4UVm0JaM5/1jjzRzefmIy0Pq6fO8pn8D0xyY8MIoRcoZL\n fMPmLhY7l941SArLCR7UbtsjzJUCWJHbaectAi3Bn94CtqpTMMMHyWSVfExwLDWF7qoz\n 1sfLBgvEa4AVDD7B1wCKYtbi6qtPd5Ty1Q0Vxv0pkqY57ilyC3GrdnMH1TodJdSZjj5P\n Uf33gS6oX0z9xbfKHTv6UFDWMrZPxn9FA4aBZIr0lXNMzDWNTDkXTrjeYJ49YcSRQmV9\n acWQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715816566; x=1716421366;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=Z8eKqf5lNQlmO6QqgxdqNWvOCC2KYo8qD/rGb5b3ZPM=;\n b=KXC+m0sJhehvNtI8Dziy8T/ISL3TWFBY8gXjqI9lnBN0zl2nDe6Z92K+ze3Njuo0IM\n AMxtdSCIl4WGWdZyC5cDEOCeefQaCWQYaKh+N8cIWQzLIHNpnK/Lr/GJvs2jyAx4Blsk\n dA/DQz1LMe0Lrk2WTjlriFYqYqJKWLyO0yelRn6TWlXQ5ydUmdqoromxemvkjXTsLOad\n 7dLTPagXrt6EFmDQB5PiJ3S7cRL9kp+vKxdtuQ89e7D2ha237XQIgCsU31wrDZI7KhLQ\n NYQ0SIceASALs/21lbwLjGNtjHYg3ka4QOkOso6oSLP+nkMRmYMQoE0sH6+Qqd0DbIRk\n TYhQ==", "X-Gm-Message-State": "AOJu0Yzz3fBmn2iXiy4tb5VgJcoDvWJ5cNIV3OIYL0+Oexe2/BoGIl3t\n SM701Oz2Qi8JJ8PGph9u0qzvMxWASEhAIn1glHeoNY+ZH6tx6UrXiKzvF9qAam6mwgsOE7CUmtY\n BvN8=", "X-Google-Smtp-Source": "\n AGHT+IEWRTGOGR0FoQ4zYFU2owOYyKMXphce6BKWY4qGwkiDuSBXRCukBvTosTAOwn1MnxWFiIR9KQ==", "X-Received": "by 2002:a05:6a20:e607:b0:1af:fe9e:5e43 with SMTP id\n adf61e73a8af0-1affe9e608fmr7759407637.11.1715816565868;\n Wed, 15 May 2024 16:42:45 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Subject": "[PATCH v4 2/8] ethdev: add common counters for statistics", "Date": "Wed, 15 May 2024 16:40:54 -0700", "Message-ID": "<20240515234234.5015-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240515234234.5015-1-stephen@networkplumber.org>", "References": "<20240510050507.14381-1-stephen@networkplumber.org>\n <20240515234234.5015-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Introduce common helper routines for keeping track of per-queue\nstatistics in SW PMD's. The code in several drivers had\ncopy/pasted the same code for this, but had common issues\nwith 64 bit counters on 32 bit platforms.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/ethdev/ethdev_swstats.c | 109 +++++++++++++++++++++++++++++++\n lib/ethdev/ethdev_swstats.h | 124 ++++++++++++++++++++++++++++++++++++\n lib/ethdev/meson.build | 2 +\n lib/ethdev/version.map | 3 +\n 4 files changed, 238 insertions(+)\n create mode 100644 lib/ethdev/ethdev_swstats.c\n create mode 100644 lib/ethdev/ethdev_swstats.h", "diff": "diff --git a/lib/ethdev/ethdev_swstats.c b/lib/ethdev/ethdev_swstats.c\nnew file mode 100644\nindex 0000000000..7892b2180b\n--- /dev/null\n+++ b/lib/ethdev/ethdev_swstats.c\n@@ -0,0 +1,109 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (c) Stephen Hemminger <stephen@networkplumber.org>\n+ */\n+\n+\n+#include <rte_config.h>\n+#include <rte_common.h>\n+#include <rte_atomic.h>\n+\n+#include \"rte_ethdev.h\"\n+#include \"ethdev_driver.h\"\n+#include \"ethdev_swstats.h\"\n+\n+int\n+rte_eth_counters_stats_get(const struct rte_eth_dev *dev,\n+\t\t\t size_t tx_offset, size_t rx_offset,\n+\t\t\t struct rte_eth_stats *stats)\n+{\n+\tuint64_t packets, bytes, errors;\n+\tunsigned int i;\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tconst void *txq = dev->data->tx_queues[i];\n+\t\tconst struct rte_eth_counters *counters;\n+\n+\t\tif (txq == NULL)\n+\t\t\tcontinue;\n+\n+\t\tcounters = (const struct rte_eth_counters *)((const char *)txq + tx_offset);\n+\t\tpackets = rte_counter64_fetch(&counters->packets);\n+\t\tbytes = rte_counter64_fetch(&counters->bytes);\n+\t\terrors = rte_counter64_fetch(&counters->errors);\n+\n+\t\t/*\n+\t\t * Prevent compiler from fetching values twice which would\n+\t\t * cause per-queue and global statistics to not match.\n+\t\t */\n+\t\trte_compiler_barrier();\n+\n+\t\tstats->opackets += packets;\n+\t\tstats->obytes += bytes;\n+\t\tstats->oerrors += errors;\n+\n+\t\tif (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {\n+\t\t\tstats->q_opackets[i] = packets;\n+\t\t\tstats->q_obytes[i] = bytes;\n+\t\t}\n+\t}\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tconst void *rxq = dev->data->rx_queues[i];\n+\t\tconst struct rte_eth_counters *counters;\n+\n+\t\tif (rxq == NULL)\n+\t\t\tcontinue;\n+\n+\t\tcounters = (const struct rte_eth_counters *)((const char *)rxq + rx_offset);\n+\t\tpackets = rte_counter64_fetch(&counters->packets);\n+\t\tbytes = rte_counter64_fetch(&counters->bytes);\n+\t\terrors = rte_counter64_fetch(&counters->errors);\n+\n+\t\trte_compiler_barrier();\n+\n+\t\tstats->ipackets += packets;\n+\t\tstats->ibytes += bytes;\n+\t\tstats->ierrors += errors;\n+\n+\t\tif (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {\n+\t\t\tstats->q_ipackets[i] = packets;\n+\t\t\tstats->q_ibytes[i] = bytes;\n+\t\t}\n+\t}\n+\n+\tstats->rx_nombuf = dev->data->rx_mbuf_alloc_failed;\n+\treturn 0;\n+}\n+\n+int\n+rte_eth_counters_reset(struct rte_eth_dev *dev, size_t tx_offset, size_t rx_offset)\n+{\n+\tstruct rte_eth_counters *counters;\n+\tunsigned int i;\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tvoid *txq = dev->data->tx_queues[i];\n+\n+\t\tif (txq == NULL)\n+\t\t\tcontinue;\n+\n+\t\tcounters = (struct rte_eth_counters *)((char *)txq + tx_offset);\n+\t\trte_counter64_reset(&counters->packets);\n+\t\trte_counter64_reset(&counters->bytes);\n+\t\trte_counter64_reset(&counters->errors);\n+\t}\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tvoid *rxq = dev->data->rx_queues[i];\n+\n+\t\tif (rxq == NULL)\n+\t\t\tcontinue;\n+\n+\t\tcounters = (struct rte_eth_counters *)((char *)rxq + rx_offset);\n+\t\trte_counter64_reset(&counters->packets);\n+\t\trte_counter64_reset(&counters->bytes);\n+\t\trte_counter64_reset(&counters->errors);\n+\t}\n+\n+\treturn 0;\n+}\ndiff --git a/lib/ethdev/ethdev_swstats.h b/lib/ethdev/ethdev_swstats.h\nnew file mode 100644\nindex 0000000000..808c540640\n--- /dev/null\n+++ b/lib/ethdev/ethdev_swstats.h\n@@ -0,0 +1,124 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (c) Stephen Hemminger <stephen@networkplumber.org>\n+ */\n+\n+#ifndef _RTE_ETHDEV_SWSTATS_H_\n+#define _RTE_ETHDEV_SWSTATS_H_\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+/**\n+ * @file\n+ *\n+ * Internal statistics counters for software based devices.\n+ * Hardware PMD's should use the hardware counters instead.\n+ *\n+ * This provides a library for PMD's to keep track of packets and bytes.\n+ * It is assumed that this will be used per queue and queues are not\n+ * shared by lcores.\n+ */\n+\n+#include <rte_counter.h>\n+\n+/**\n+ * A structure to be embedded in the device driver per-queue data.\n+ */\n+struct rte_eth_counters {\n+\trte_counter64_t\tpackets;\t/**< Total number of packets. */\n+\trte_counter64_t\tbytes;\t\t/**< Total number of bytes. */\n+\trte_counter64_t\terrors;\t\t/**< Total number of packets with errors. */\n+};\n+\n+/**\n+ * @internal\n+ * Increment counters for a single packet.\n+ *\n+ * @param counters\n+ * Pointer to queue structure containing counters.\n+ * @param sz\n+ * Size of the packet in bytes.\n+ */\n+__rte_internal\n+static inline void\n+rte_eth_count_packet(struct rte_eth_counters *counters, uint32_t sz)\n+{\n+\trte_counter64_add(&counters->packets, 1);\n+\trte_counter64_add(&counters->bytes, sz);\n+}\n+\n+/**\n+ * @internal\n+ * Increment counters based on mbuf.\n+ *\n+ * @param counters\n+ * Pointer to queue structure containing counters.\n+ * @param mbuf\n+ * Received or transmitted mbuf.\n+ */\n+__rte_internal\n+static inline void\n+rte_eth_count_mbuf(struct rte_eth_counters *counters, const struct rte_mbuf *mbuf)\n+{\n+\trte_eth_count_packet(counters, rte_pktmbuf_pkt_len(mbuf));\n+}\n+\n+/**\n+ * @internal\n+ * Increment error counter.\n+ *\n+ * @param counters\n+ * Pointer to queue structure containing counters.\n+ */\n+__rte_internal\n+static inline void\n+rte_eth_count_error(struct rte_eth_counters *counters)\n+{\n+\trte_counter64_add(&counters->errors, 1);\n+}\n+\n+/**\n+ * @internal\n+ * Retrieve the general statistics for all queues.\n+ * @see rte_eth_stats_get.\n+ *\n+ * @param dev\n+ * Pointer to the Ethernet device structure.\n+ * @param tx_offset\n+ * Offset from the tx_queue structure where stats are located.\n+ * @param rx_offset\n+ * Offset from the rx_queue structure where stats are located.\n+ * @param stats\n+ * A pointer to a structure of type *rte_eth_stats* to be filled\n+ * @return\n+ * Zero if successful. Non-zero otherwise.\n+ */\n+__rte_internal\n+int rte_eth_counters_stats_get(const struct rte_eth_dev *dev,\n+\t\t\t size_t tx_offset, size_t rx_offset,\n+\t\t\t struct rte_eth_stats *stats);\n+\n+/**\n+ * @internal\n+ * Reset the statistics for all queues.\n+ * @see rte_eth_stats_reset.\n+ *\n+ * @param dev\n+ * Pointer to the Ethernet device structure.\n+ * @param tx_offset\n+ * Offset from the tx_queue structure where stats are located.\n+ * @param rx_offset\n+ * Offset from the rx_queue structure where stats are located.\n+ * @return\n+ * Zero if successful. Non-zero otherwise.\n+ */\n+__rte_internal\n+int rte_eth_counters_reset(struct rte_eth_dev *dev,\n+\t\t\t size_t tx_offset, size_t rx_offset);\n+\n+#ifdef __cplusplus\n+}\n+#endif\n+\n+#endif /* _RTE_ETHDEV_SWSTATS_H_ */\ndiff --git a/lib/ethdev/meson.build b/lib/ethdev/meson.build\nindex f1d2586591..7ce29a46d4 100644\n--- a/lib/ethdev/meson.build\n+++ b/lib/ethdev/meson.build\n@@ -3,6 +3,7 @@\n \n sources = files(\n 'ethdev_driver.c',\n+ 'ethdev_swstats.c',\n 'ethdev_private.c',\n 'ethdev_profile.c',\n 'ethdev_trace_points.c',\n@@ -42,6 +43,7 @@ driver_sdk_headers += files(\n 'ethdev_driver.h',\n 'ethdev_pci.h',\n 'ethdev_vdev.h',\n+ 'ethdev_swstats.h',\n )\n \n if is_linux\ndiff --git a/lib/ethdev/version.map b/lib/ethdev/version.map\nindex 79f6f5293b..fc595be278 100644\n--- a/lib/ethdev/version.map\n+++ b/lib/ethdev/version.map\n@@ -358,4 +358,7 @@ INTERNAL {\n \trte_eth_switch_domain_alloc;\n \trte_eth_switch_domain_free;\n \trte_flow_fp_default_ops;\n+\n+\trte_eth_counters_reset;\n+\trte_eth_counters_stats_get;\n };\n", "prefixes": [ "v4", "2/8" ] }