Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 140145,
    "url": "http://patchwork.dpdk.org/api/patches/140145/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240516154327.64104-7-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20240516154327.64104-7-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20240516154327.64104-7-stephen@networkplumber.org",
    "date": "2024-05-16T15:40:42",
    "name": "[v5,6/9] test/pmd_ring: initialize mbufs",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "9d0ae2481202f5fde67dc012971c80a82c11d87b",
    "submitter": {
        "id": 27,
        "url": "http://patchwork.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240516154327.64104-7-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 31939,
            "url": "http://patchwork.dpdk.org/api/series/31939/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31939",
            "date": "2024-05-16T15:40:36",
            "name": "Generic 64 bit counters",
            "version": 5,
            "mbox": "http://patchwork.dpdk.org/series/31939/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/140145/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/140145/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C1AEA43F81;\n\tThu, 16 May 2024 17:44:28 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 11C1840695;\n\tThu, 16 May 2024 17:43:49 +0200 (CEST)",
            "from mail-pf1-f175.google.com (mail-pf1-f175.google.com\n [209.85.210.175])\n by mails.dpdk.org (Postfix) with ESMTP id 00941402ED\n for <dev@dpdk.org>; Thu, 16 May 2024 17:43:44 +0200 (CEST)",
            "by mail-pf1-f175.google.com with SMTP id\n d2e1a72fcca58-6f44881ad9eso341191b3a.3\n for <dev@dpdk.org>; Thu, 16 May 2024 08:43:44 -0700 (PDT)",
            "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-6f67b526b44sm2457430b3a.149.2024.05.16.08.43.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 May 2024 08:43:43 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715874224;\n x=1716479024; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=48/wBIK0Rg56e+UC+zjHPq/BPpLP+2PzmpWMiPh48wQ=;\n b=awbkXBAM7XUNSEkrpVb364b4bxUecHzASB/nCmieEO7UgytrX65w5+sOvU2nztMQXu\n DFeDa8GswyvpEV6OQUn3tsTxse3blhO7zDDh5y4L31VJhX+F5vLOOdx0Fu5cm1yhaDxW\n YFOJWDzc1PbpGpWo63QGiwsW4hxkHwQXgMmk8nEP4GhTUg+OZtf6i1H9iPDAKOSBtKtZ\n 17oSR4wmYR+Nw8uzABJ7DlmtFN73ft8tKRd3vA9BFNjRMlgzF7TdoSUtEe/1NRskyGEv\n b37Wg+8yAet5v7B8k9T26PmTYwB1cmmA8cZBWXHPVA7srNscdhvSHFquc6Qnsg6+KVyw\n hZcg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715874224; x=1716479024;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=48/wBIK0Rg56e+UC+zjHPq/BPpLP+2PzmpWMiPh48wQ=;\n b=TwrHb9IYItdVpjEDlQKH6KEaBFYKMqo8o9k89Twlszg5eTfK8IHvlu7WCnWT4GRKjL\n d5HCx9/U11jzs1YE3vPPbRNo6DKl2RiEdRqB8LbrZYQlMGM1MAUqJhUbfZFvTah42elo\n gI/lz9O1N+KxagWKMdvq5okLYLig1/Ql22+dZ8m0M5whW9+FlFQJDz/bn6cM+BZ4f+xP\n r8UC5jiamjgR7H4TTDDQVTrTbzOKIdIMvUO1GsNVUj85rGFExF6frxjXli7gYUbWpIDx\n zL/w82Of5ueOtS15Eupxr0h47z98MBWQoNviZxpm3016Yht4IQB1w2a77i8g1yQGe+Y+\n YAtA==",
        "X-Gm-Message-State": "AOJu0YwjJOHH9XrjtJhTxSTT61rgUtFBRVm+YjTaHgOokoqUXTcRTArr\n PArr++q0WS3+YrI49yIX49Uv8lgsoqxjURG4+QWHxzNf15oWOTNXOBNvKZOc8qwZNSaUld+Nx0G\n qYUQ=",
        "X-Google-Smtp-Source": "\n AGHT+IGg0p2oOFcFGvx3WqsINQJ36vZ5559kPnN9pTk7+sK7D1kRewldyihwRjrU2qUac86Tpp+GTg==",
        "X-Received": "by 2002:a05:6a20:a11e:b0:1a7:5fe0:1c99 with SMTP id\n adf61e73a8af0-1afde1b27c0mr19967756637.46.1715874223984;\n Thu, 16 May 2024 08:43:43 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Bruce Richardson <bruce.richardson@intel.com>",
        "Subject": "[PATCH v5 6/9] test/pmd_ring: initialize mbufs",
        "Date": "Thu, 16 May 2024 08:40:42 -0700",
        "Message-ID": "<20240516154327.64104-7-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.43.0",
        "In-Reply-To": "<20240516154327.64104-1-stephen@networkplumber.org>",
        "References": "<20240510050507.14381-1-stephen@networkplumber.org>\n <20240516154327.64104-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Do not pass uninitialized mbuf into the ring PMD.\nThe mbuf should be initialized first so that length is zero.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test/test_pmd_ring.c | 22 +++++++++++++++-------\n 1 file changed, 15 insertions(+), 7 deletions(-)",
    "diff": "diff --git a/app/test/test_pmd_ring.c b/app/test/test_pmd_ring.c\nindex e83b9dd6b8..9cd5ae46db 100644\n--- a/app/test/test_pmd_ring.c\n+++ b/app/test/test_pmd_ring.c\n@@ -68,14 +68,16 @@ test_ethdev_configure_port(int port)\n static int\n test_send_basic_packets(void)\n {\n-\tstruct rte_mbuf  bufs[RING_SIZE];\n-\tstruct rte_mbuf *pbufs[RING_SIZE];\n+\tstruct rte_mbuf bufs[RING_SIZE];\n+\tstruct rte_mbuf *pbufs[RING_SIZE] = { };\n \tint i;\n \n \tprintf(\"Testing send and receive RING_SIZE/2 packets (tx_porta -> rx_portb)\\n\");\n \n-\tfor (i = 0; i < RING_SIZE/2; i++)\n+\tfor (i = 0; i < RING_SIZE / 2; i++) {\n+\t\trte_pktmbuf_reset(&bufs[i]);\n \t\tpbufs[i] = &bufs[i];\n+\t}\n \n \tif (rte_eth_tx_burst(tx_porta, 0, pbufs, RING_SIZE/2) < RING_SIZE/2) {\n \t\tprintf(\"Failed to transmit packet burst port %d\\n\", tx_porta);\n@@ -99,14 +101,16 @@ test_send_basic_packets(void)\n static int\n test_send_basic_packets_port(int port)\n {\n-\tstruct rte_mbuf  bufs[RING_SIZE];\n-\tstruct rte_mbuf *pbufs[RING_SIZE];\n+\tstruct rte_mbuf bufs[RING_SIZE];\n+\tstruct rte_mbuf *pbufs[RING_SIZE] = { };\n \tint i;\n \n \tprintf(\"Testing send and receive RING_SIZE/2 packets (cmdl_port0 -> cmdl_port0)\\n\");\n \n-\tfor (i = 0; i < RING_SIZE/2; i++)\n+\tfor (i = 0; i < RING_SIZE / 2; i++) {\n+\t\trte_pktmbuf_reset(&bufs[i]);\n \t\tpbufs[i] = &bufs[i];\n+\t}\n \n \tif (rte_eth_tx_burst(port, 0, pbufs, RING_SIZE/2) < RING_SIZE/2) {\n \t\tprintf(\"Failed to transmit packet burst port %d\\n\", port);\n@@ -134,10 +138,11 @@ test_get_stats(int port)\n \tstruct rte_eth_stats stats;\n \tstruct rte_mbuf buf, *pbuf = &buf;\n \n+\trte_pktmbuf_reset(&buf);\n+\n \tprintf(\"Testing ring PMD stats_get port %d\\n\", port);\n \n \t/* check stats of RXTX port, should all be zero */\n-\n \trte_eth_stats_get(port, &stats);\n \tif (stats.ipackets != 0 || stats.opackets != 0 ||\n \t\t\tstats.ibytes != 0 || stats.obytes != 0 ||\n@@ -173,6 +178,8 @@ test_stats_reset(int port)\n \tstruct rte_eth_stats stats;\n \tstruct rte_mbuf buf, *pbuf = &buf;\n \n+\trte_pktmbuf_reset(&buf);\n+\n \tprintf(\"Testing ring PMD stats_reset port %d\\n\", port);\n \n \trte_eth_stats_reset(port);\n@@ -228,6 +235,7 @@ test_pmd_ring_pair_create_attach(void)\n \tint ret;\n \n \tmemset(&null_conf, 0, sizeof(struct rte_eth_conf));\n+\trte_pktmbuf_reset(&buf);\n \n \tif ((rte_eth_dev_configure(rxtx_portd, 1, 1, &null_conf) < 0)\n \t\t\t|| (rte_eth_dev_configure(rxtx_porte, 1, 1,\n",
    "prefixes": [
        "v5",
        "6/9"
    ]
}