Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140157/?format=api
{ "id": 140157, "url": "http://patchwork.dpdk.org/api/patches/140157/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240517001302.65514-10-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240517001302.65514-10-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240517001302.65514-10-stephen@networkplumber.org", "date": "2024-05-17T00:12:09", "name": "[v6,9/9] net/null: use generic SW stats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b33a1bb0f88ad49439abe2aabf07058a1659e5b6", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240517001302.65514-10-stephen@networkplumber.org/mbox/", "series": [ { "id": 31940, "url": "http://patchwork.dpdk.org/api/series/31940/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31940", "date": "2024-05-17T00:12:00", "name": "Generic 64 bit counters for SW drivers", "version": 6, "mbox": "http://patchwork.dpdk.org/series/31940/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/140157/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/140157/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 55EB144044;\n\tFri, 17 May 2024 02:14:25 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 384EE40A7F;\n\tFri, 17 May 2024 02:13:35 +0200 (CEST)", "from mail-pg1-f178.google.com (mail-pg1-f178.google.com\n [209.85.215.178])\n by mails.dpdk.org (Postfix) with ESMTP id 59AA44067D\n for <dev@dpdk.org>; Fri, 17 May 2024 02:13:20 +0200 (CEST)", "by mail-pg1-f178.google.com with SMTP id\n 41be03b00d2f7-5c6bd3100fcso552963a12.3\n for <dev@dpdk.org>; Thu, 16 May 2024 17:13:20 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-2b9f5820ce9sm3337495a91.56.2024.05.16.17.13.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 May 2024 17:13:19 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715904799;\n x=1716509599; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=F1v3feu5BR4POSxHAthIeXNE69YI+TXuZU380J4Tk78=;\n b=dwNTnaLDHVrKv3S+nQvYgSSq6uXpOT+tXkCKdXn5vBFg8IdE9XFu8Zk8VTk6cDrUOr\n de5h+VFckNYCL5FJjaOD34BWESBef6of3sNKoRS1HeiybFIwR1DJs9WW2d3N9n0Bq2lU\n ohdwh23b7UGAW1db/a6fGy0SOvgTwGQ8bBOmDjxe9+CPWMz/RVPI2q1DcM3mBDj0qnBl\n lr9loaZ+tbKEAIbc//VC7EvNRSu5+7bw/3noxUf9BEFIa1ctS7qGgR9Q/TLB3claab42\n aoeW2fuBuvpBdBcG869en7IwA6lmSGVaUNVZVke8vGKBmpdMCD+tNRheRkAGC737K45N\n u7gQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715904799; x=1716509599;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=F1v3feu5BR4POSxHAthIeXNE69YI+TXuZU380J4Tk78=;\n b=U9VaDJ15Co8VnLSt9EWhxawcEQde1tzv7PPWk9lkkWSM0bx/54e7GEK2nRB7OIULwI\n kqaDVNsVHnPJOe8AsbwO9wGzk63mFjxubUQMGfWCiHNO2FH8QY7FaeTH22D+vJvYpFSK\n EqTED4iritDwzBnNx9BridhidGVuq3+MUKEr+D3uHLRN+21qOoF1785gEp5xJ8WVXe77\n vF3ozJUWHxk7WqmUaZqqezpiwoPwXSwmRgRUkdT/D3q5wJeZfTZ0Mcnsgu16wMuV9pQn\n NKANvgJcxsz10u/GDz0KGZNM4wUAsEUO6iKf4f+hhf5SxDRQN1seL/itTu1/XAh1LFcp\n A25w==", "X-Gm-Message-State": "AOJu0YzqSTJCIW1xbJfhs030MB++ndtfCDkqpzeAP6aBW6b5nXXj6tKP\n YaPw6ZJRxl6J1USD41mwQVhQ3Gp1UZ+kw56ufwocSPOk6YrnwZ3ZAvDRNBetYIKOegdzIooO/Hg\n zxdU=", "X-Google-Smtp-Source": "\n AGHT+IFbZxZhQrCC/BTVe7VPoFv9B+seQoGLAwoNHOylu2i8UN4bSM5FMy7/aP8T0ARlUh+7nhk5dA==", "X-Received": "by 2002:a17:90a:f2d8:b0:2b9:f6bc:e4c1 with SMTP id\n 98e67ed59e1d1-2b9f6bceda6mr4783545a91.28.1715904799495;\n Thu, 16 May 2024 17:13:19 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Tetsuya Mukawa <mtetsuyah@gmail.com>", "Subject": "[PATCH v6 9/9] net/null: use generic SW stats", "Date": "Thu, 16 May 2024 17:12:09 -0700", "Message-ID": "<20240517001302.65514-10-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240517001302.65514-1-stephen@networkplumber.org>", "References": "<20240510050507.14381-1-stephen@networkplumber.org>\n <20240517001302.65514-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use the new common code for statistics.\nThis also fixes the bug that this driver was not accounting\nfor bytes.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/null/rte_eth_null.c | 80 +++++++--------------------------\n 1 file changed, 17 insertions(+), 63 deletions(-)", "diff": "diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c\nindex 7c46004f1e..7786982732 100644\n--- a/drivers/net/null/rte_eth_null.c\n+++ b/drivers/net/null/rte_eth_null.c\n@@ -8,6 +8,7 @@\n #include <rte_mbuf.h>\n #include <ethdev_driver.h>\n #include <ethdev_vdev.h>\n+#include <ethdev_swstats.h>\n #include <rte_malloc.h>\n #include <rte_memcpy.h>\n #include <bus_vdev_driver.h>\n@@ -37,8 +38,8 @@ struct null_queue {\n \tstruct rte_mempool *mb_pool;\n \tstruct rte_mbuf *dummy_packet;\n \n-\tuint64_t rx_pkts;\n-\tuint64_t tx_pkts;\n+\tstruct rte_eth_counters tx_stats;\n+\tstruct rte_eth_counters rx_stats;\n };\n \n struct pmd_options {\n@@ -99,11 +100,9 @@ eth_null_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n \t\tbufs[i]->data_len = (uint16_t)packet_size;\n \t\tbufs[i]->pkt_len = packet_size;\n \t\tbufs[i]->port = h->internals->port_id;\n+\t\trte_eth_count_mbuf(&h->rx_stats, bufs[i]);\n \t}\n \n-\t/* NOTE: review for potential ordering optimization */\n-\t__atomic_fetch_add(&h->rx_pkts, i, __ATOMIC_SEQ_CST);\n-\n \treturn i;\n }\n \n@@ -127,11 +126,9 @@ eth_null_copy_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n \t\tbufs[i]->data_len = (uint16_t)packet_size;\n \t\tbufs[i]->pkt_len = packet_size;\n \t\tbufs[i]->port = h->internals->port_id;\n+\t\trte_eth_count_mbuf(&h->rx_stats, bufs[i]);\n \t}\n \n-\t/* NOTE: review for potential ordering optimization */\n-\t__atomic_fetch_add(&h->rx_pkts, i, __ATOMIC_SEQ_CST);\n-\n \treturn i;\n }\n \n@@ -151,11 +148,10 @@ eth_null_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n \tif ((q == NULL) || (bufs == NULL))\n \t\treturn 0;\n \n-\tfor (i = 0; i < nb_bufs; i++)\n+\tfor (i = 0; i < nb_bufs; i++) {\n+\t\trte_eth_count_mbuf(&h->tx_stats, bufs[i]);\n \t\trte_pktmbuf_free(bufs[i]);\n-\n-\t/* NOTE: review for potential ordering optimization */\n-\t__atomic_fetch_add(&h->tx_pkts, i, __ATOMIC_SEQ_CST);\n+\t}\n \n \treturn i;\n }\n@@ -174,12 +170,10 @@ eth_null_copy_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n \tfor (i = 0; i < nb_bufs; i++) {\n \t\trte_memcpy(h->dummy_packet, rte_pktmbuf_mtod(bufs[i], void *),\n \t\t\t\t\tpacket_size);\n+\t\trte_eth_count_mbuf(&h->tx_stats, bufs[i]);\n \t\trte_pktmbuf_free(bufs[i]);\n \t}\n \n-\t/* NOTE: review for potential ordering optimization */\n-\t__atomic_fetch_add(&h->tx_pkts, i, __ATOMIC_SEQ_CST);\n-\n \treturn i;\n }\n \n@@ -322,60 +316,20 @@ eth_dev_info(struct rte_eth_dev *dev,\n }\n \n static int\n-eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)\n+eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n {\n-\tunsigned int i, num_stats;\n-\tunsigned long rx_total = 0, tx_total = 0;\n-\tconst struct pmd_internals *internal;\n-\n-\tif ((dev == NULL) || (igb_stats == NULL))\n-\t\treturn -EINVAL;\n-\n-\tinternal = dev->data->dev_private;\n-\tnum_stats = RTE_MIN((unsigned int)RTE_ETHDEV_QUEUE_STAT_CNTRS,\n-\t\t\tRTE_MIN(dev->data->nb_rx_queues,\n-\t\t\t\tRTE_DIM(internal->rx_null_queues)));\n-\tfor (i = 0; i < num_stats; i++) {\n-\t\t/* NOTE: review for atomic access */\n-\t\tigb_stats->q_ipackets[i] =\n-\t\t\tinternal->rx_null_queues[i].rx_pkts;\n-\t\trx_total += igb_stats->q_ipackets[i];\n-\t}\n-\n-\tnum_stats = RTE_MIN((unsigned int)RTE_ETHDEV_QUEUE_STAT_CNTRS,\n-\t\t\tRTE_MIN(dev->data->nb_tx_queues,\n-\t\t\t\tRTE_DIM(internal->tx_null_queues)));\n-\tfor (i = 0; i < num_stats; i++) {\n-\t\t/* NOTE: review for atomic access */\n-\t\tigb_stats->q_opackets[i] =\n-\t\t\tinternal->tx_null_queues[i].tx_pkts;\n-\t\ttx_total += igb_stats->q_opackets[i];\n-\t}\n-\n-\tigb_stats->ipackets = rx_total;\n-\tigb_stats->opackets = tx_total;\n-\n-\treturn 0;\n+\treturn rte_eth_counters_stats_get(dev,\n+\t\t\t\t\t offsetof(struct null_queue, tx_stats),\n+\t\t\t\t\t offsetof(struct null_queue, rx_stats),\n+\t\t\t\t\t stats);\n }\n \n static int\n eth_stats_reset(struct rte_eth_dev *dev)\n {\n-\tunsigned int i;\n-\tstruct pmd_internals *internal;\n-\n-\tif (dev == NULL)\n-\t\treturn -EINVAL;\n-\n-\tinternal = dev->data->dev_private;\n-\tfor (i = 0; i < RTE_DIM(internal->rx_null_queues); i++)\n-\t\t/* NOTE: review for atomic access */\n-\t\tinternal->rx_null_queues[i].rx_pkts = 0;\n-\tfor (i = 0; i < RTE_DIM(internal->tx_null_queues); i++)\n-\t\t/* NOTE: review for atomic access */\n-\t\tinternal->tx_null_queues[i].tx_pkts = 0;\n-\n-\treturn 0;\n+\treturn rte_eth_counters_reset(dev,\n+\t\t\t\t offsetof(struct null_queue, tx_stats),\n+\t\t\t\t offsetof(struct null_queue, rx_stats));\n }\n \n static void\n", "prefixes": [ "v6", "9/9" ] }