Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140165/?format=api
{ "id": 140165, "url": "http://patchwork.dpdk.org/api/patches/140165/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240517074448.3146611-5-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240517074448.3146611-5-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240517074448.3146611-5-ndabilpuram@marvell.com", "date": "2024-05-17T07:44:43", "name": "[05/10] net/cnxk: update SA userdata and keep original cookie", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "db603df90f9686b795c6de26cfc57c88fab7922a", "submitter": { "id": 1202, "url": "http://patchwork.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240517074448.3146611-5-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 31944, "url": "http://patchwork.dpdk.org/api/series/31944/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31944", "date": "2024-05-17T07:44:39", "name": "[01/10] common/cnxk: sync VF root weight with kernel", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31944/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/140165/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/140165/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4AEF144048;\n\tFri, 17 May 2024 09:45:28 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0519440695;\n\tFri, 17 May 2024 09:45:11 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 46E0D4064C;\n Fri, 17 May 2024 09:45:09 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id\n 44GLNDGx025260;\n Fri, 17 May 2024 00:45:08 -0700", "from dc5-exch05.marvell.com ([199.233.59.128])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3y5t0vhc35-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Fri, 17 May 2024 00:45:08 -0700 (PDT)", "from DC5-EXCH05.marvell.com (10.69.176.209) by\n DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1544.4; Fri, 17 May 2024 00:45:07 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com\n (10.69.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend\n Transport; Fri, 17 May 2024 00:45:07 -0700", "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id C67363F7059;\n Fri, 17 May 2024 00:45:04 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=\n pfpt0220; bh=6JISprTMn9mKU8UW4BJ2epRKK5KGJeB7GX/YoOtmM3k=; b=Vqb\n bQZTeKKwgF0BwymtlMA8HEEpiirQ8nQR2nwT7ZL21OkxeYMIjDTW1jRi2R1R/rOa\n UU9E0Kg4qj5USURZ0bM9EBxUCXYoGeK9n0kXxaSh86aLmA6H/JndJEYs7BVbg9Wt\n WIKmXpt2deok9P8e4AiS6VW47A04Cuz0WKyclhLi1DmQnzlg7er20sHiMkymPOzq\n SCZaD2ioT+0XrrolnJJ2BASVWRWgoQo2tapTLNpFyjfYzjsQRMdqCl38PRXBHC0n\n GfyA/uQa8Gu7Q/Kud3a7qbylGw3/Gwi6O7YVGLWp1OYmF+LH67KTMNgbOyUvH+UT\n OOKPmwp5yyv76sg+Lbw==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>, Harman Kalra <hkalra@marvell.com>", "CC": "<jerinj@marvell.com>, <dev@dpdk.org>, <stable@dpdk.org>", "Subject": "[PATCH 05/10] net/cnxk: update SA userdata and keep original cookie", "Date": "Fri, 17 May 2024 13:14:43 +0530", "Message-ID": "<20240517074448.3146611-5-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240517074448.3146611-1-ndabilpuram@marvell.com>", "References": "<20240517074448.3146611-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "rsSVZXwXj1rty8rKeEhNBiihg0j7bvfW", "X-Proofpoint-GUID": "rsSVZXwXj1rty8rKeEhNBiihg0j7bvfW", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26\n definitions=2024-05-16_07,2024-05-15_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Update SA userdata as part of session_update() and\nkeep the original cookie that is used to identify\nSA.\n\nFixes: 8efa348e8160 (\"net/cnxk: support custom SA index\")\nCc: stable@dpdk.org\n\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\n---\n drivers/net/cnxk/cn10k_ethdev_sec.c | 57 ++++++++++++++++++++++++++++-\n 1 file changed, 55 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/cnxk/cn10k_ethdev_sec.c b/drivers/net/cnxk/cn10k_ethdev_sec.c\nindex af27d3bbc1..eed4c29218 100644\n--- a/drivers/net/cnxk/cn10k_ethdev_sec.c\n+++ b/drivers/net/cnxk/cn10k_ethdev_sec.c\n@@ -1101,8 +1101,8 @@ cn10k_eth_sec_session_update(void *device, struct rte_security_session *sess,\n {\n \tstruct rte_eth_dev *eth_dev = (struct rte_eth_dev *)device;\n \tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n-\tstruct roc_ot_ipsec_inb_sa *inb_sa_dptr;\n \tstruct rte_security_ipsec_xform *ipsec;\n+\tstruct cn10k_sec_sess_priv sess_priv;\n \tstruct rte_crypto_sym_xform *crypto;\n \tstruct cnxk_eth_sec_sess *eth_sec;\n \tbool inbound;\n@@ -1123,6 +1123,11 @@ cn10k_eth_sec_session_update(void *device, struct rte_security_session *sess,\n \teth_sec->spi = conf->ipsec.spi;\n \n \tif (inbound) {\n+\t\tstruct roc_ot_ipsec_inb_sa *inb_sa_dptr, *inb_sa;\n+\t\tstruct cn10k_inb_priv_data *inb_priv;\n+\n+\t\tinb_sa = eth_sec->sa;\n+\t\tinb_priv = roc_nix_inl_ot_ipsec_inb_sa_sw_rsvd(inb_sa);\n \t\tinb_sa_dptr = (struct roc_ot_ipsec_inb_sa *)dev->inb.sa_dptr;\n \t\tmemset(inb_sa_dptr, 0, sizeof(struct roc_ot_ipsec_inb_sa));\n \n@@ -1130,26 +1135,74 @@ cn10k_eth_sec_session_update(void *device, struct rte_security_session *sess,\n \t\t\t\t\t true);\n \t\tif (rc)\n \t\t\treturn -EINVAL;\n+\t\t/* Use cookie for original data */\n+\t\tinb_sa_dptr->w1.s.cookie = inb_sa->w1.s.cookie;\n+\n+\t\tif (ipsec->options.stats == 1) {\n+\t\t\t/* Enable mib counters */\n+\t\t\tinb_sa_dptr->w0.s.count_mib_bytes = 1;\n+\t\t\tinb_sa_dptr->w0.s.count_mib_pkts = 1;\n+\t\t}\n+\n+\t\t/* Enable out-of-place processing */\n+\t\tif (ipsec->options.ingress_oop)\n+\t\t\tinb_sa_dptr->w0.s.pkt_format = ROC_IE_OT_SA_PKT_FMT_FULL;\n \n \t\trc = roc_nix_inl_ctx_write(&dev->nix, inb_sa_dptr, eth_sec->sa,\n \t\t\t\t\t eth_sec->inb,\n \t\t\t\t\t sizeof(struct roc_ot_ipsec_inb_sa));\n \t\tif (rc)\n \t\t\treturn -EINVAL;\n+\n+\t\t/* Save userdata in inb private area */\n+\t\tinb_priv->userdata = conf->userdata;\n \t} else {\n-\t\tstruct roc_ot_ipsec_outb_sa *outb_sa_dptr;\n+\t\tstruct roc_ot_ipsec_outb_sa *outb_sa_dptr, *outb_sa;\n+\t\tstruct cn10k_outb_priv_data *outb_priv;\n+\t\tstruct cnxk_ipsec_outb_rlens *rlens;\n \n+\t\toutb_sa = eth_sec->sa;\n+\t\toutb_priv = roc_nix_inl_ot_ipsec_outb_sa_sw_rsvd(outb_sa);\n+\t\trlens = &outb_priv->rlens;\n \t\toutb_sa_dptr = (struct roc_ot_ipsec_outb_sa *)dev->outb.sa_dptr;\n \t\tmemset(outb_sa_dptr, 0, sizeof(struct roc_ot_ipsec_outb_sa));\n \n \t\trc = cnxk_ot_ipsec_outb_sa_fill(outb_sa_dptr, ipsec, crypto);\n \t\tif (rc)\n \t\t\treturn -EINVAL;\n+\n+\t\t/* Save rlen info */\n+\t\tcnxk_ipsec_outb_rlens_get(rlens, ipsec, crypto);\n+\n+\t\tif (ipsec->options.stats == 1) {\n+\t\t\t/* Enable mib counters */\n+\t\t\toutb_sa_dptr->w0.s.count_mib_bytes = 1;\n+\t\t\toutb_sa_dptr->w0.s.count_mib_pkts = 1;\n+\t\t}\n+\n+\t\tsess_priv.u64 = 0;\n+\t\tsess_priv.sa_idx = outb_priv->sa_idx;\n+\t\tsess_priv.roundup_byte = rlens->roundup_byte;\n+\t\tsess_priv.roundup_len = rlens->roundup_len;\n+\t\tsess_priv.partial_len = rlens->partial_len;\n+\t\tsess_priv.mode = outb_sa_dptr->w2.s.ipsec_mode;\n+\t\tsess_priv.outer_ip_ver = outb_sa_dptr->w2.s.outer_ip_ver;\n+\t\t/* Propagate inner checksum enable from SA to fast path */\n+\t\tsess_priv.chksum =\n+\t\t\t(!ipsec->options.ip_csum_enable << 1 | !ipsec->options.l4_csum_enable);\n+\t\tsess_priv.dec_ttl = ipsec->options.dec_ttl;\n+\t\tif (roc_feature_nix_has_inl_ipsec_mseg() && dev->outb.cpt_eng_caps & BIT_ULL(35))\n+\t\t\tsess_priv.nixtx_off = 1;\n+\n \t\trc = roc_nix_inl_ctx_write(&dev->nix, outb_sa_dptr, eth_sec->sa,\n \t\t\t\t\t eth_sec->inb,\n \t\t\t\t\t sizeof(struct roc_ot_ipsec_outb_sa));\n \t\tif (rc)\n \t\t\treturn -EINVAL;\n+\n+\t\t/* Save userdata */\n+\t\toutb_priv->userdata = conf->userdata;\n+\t\tsess->fast_mdata = sess_priv.u64;\n \t}\n \n \treturn 0;\n", "prefixes": [ "05/10" ] }