Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140173/?format=api
http://patchwork.dpdk.org/api/patches/140173/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240517174044.90952-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240517174044.90952-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240517174044.90952-2-stephen@networkplumber.org", "date": "2024-05-17T17:35:08", "name": "[v7,1/9] eal: generic 64 bit counter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b6e962eaa953a615f9c4367510d3a18d32a5df17", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240517174044.90952-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 31946, "url": "http://patchwork.dpdk.org/api/series/31946/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31946", "date": "2024-05-17T17:35:07", "name": "Use weak atomic operations for SW PMD counters", "version": 7, "mbox": "http://patchwork.dpdk.org/series/31946/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/140173/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/140173/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3D39044052;\n\tFri, 17 May 2024 19:40:55 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 31E0C4064C;\n\tFri, 17 May 2024 19:40:51 +0200 (CEST)", "from mail-pl1-f173.google.com (mail-pl1-f173.google.com\n [209.85.214.173])\n by mails.dpdk.org (Postfix) with ESMTP id 7A8A040268\n for <dev@dpdk.org>; Fri, 17 May 2024 19:40:48 +0200 (CEST)", "by mail-pl1-f173.google.com with SMTP id\n d9443c01a7336-1ed012c1afbso7156715ad.1\n for <dev@dpdk.org>; Fri, 17 May 2024 10:40:48 -0700 (PDT)", "from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-1ef0bf31032sm158830485ad.131.2024.05.17.10.40.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 May 2024 10:40:46 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715967647;\n x=1716572447; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ALuFLJILP6C+V/9ZzQqYB1D5U2Yok5jTHH8UBj4O/kg=;\n b=z8Q83rp8Vei7ZHTBTOFYKkepcFxemu6KiNjGTlonvCPzkJkGOHjRjRteIvlOqMeLWt\n Pt9xpaZav3P+ADePb3hjvjbIxekg09hbMutmSnGPTVjmJopdskUyjzn9XvvwBlq+OEHo\n 9BnOW3aMMohBfdVVYH5ND1W5SHu4RO8HKqqqszuYKA1SG3rGIBb4gxahu24dVbJI++OO\n V8w2fnEy/YAlwZKPRNqWH9bYNdIT4T5cONp26JtF8qiHB4cH6GJb9al80/G6arJee/de\n AfjlyHzolhwSu0eNFcsMN+Y/1GL4suxcFD0SS+oGbtVW4q/LWLwYDNRIHtkiP5J3g1DJ\n SviQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715967647; x=1716572447;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=ALuFLJILP6C+V/9ZzQqYB1D5U2Yok5jTHH8UBj4O/kg=;\n b=vQoZwbL32biSyRWofj5U3NScsSoTZQJ+Ct16d+6pZqcZjlJSd4LqLffKZ2njeOJ3M/\n LQiwW5eNUvIOCVPW8gP3Au+Hl45qTbtbmKjxrN28XshmkrbhDUxk2ep3mwhQxS+WlCY7\n Ty6jOXH7UuaThNncW5FkhpxpdBTiceiqfWWJ+Wste38Rk3954OQCJplGDegD4R10XJvq\n gwe13SpJ7uSzb4gx+KAh03wWpI+qL5m8FbpB6Elshzv0JtVmSGTVoFfAz4SGT9Evg5gb\n QyDL3pBFVgoRsIW9f2eu9bUGUW/t0czUatB4X0L7HNaMsOvYwIg2lIabotWoxu3E1jXo\n RoNg==", "X-Gm-Message-State": "AOJu0YwC4gD/ChH+R51qb/H9ZvNWO6wy9dIOHEm9SdFlaEhWf9BQTY4Q\n YX0hWmPlJjzH0jPP3zulmD+mNgc/zNHBjsx0nRv2JS0ujcEi2PAT6QcdSInY8k9Vl7d4GXGjiTH\n BMDM=", "X-Google-Smtp-Source": "\n AGHT+IGif2we2gSsQJ0+0rfsL4n8sVVXQgN/CxEn+6TtrDT70d5ouX632On6SMjHyO6CTsVtVNPV6g==", "X-Received": "by 2002:a17:902:d507:b0:1ec:c6ba:f2c3 with SMTP id\n d9443c01a7336-1ef42d69b5amr362755805ad.2.1715967647453;\n Fri, 17 May 2024 10:40:47 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>, =?utf-8?q?Morten_Br?=\n\t=?utf-8?q?=C3=B8rup?= <mb@smartsharesystems.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v7 1/9] eal: generic 64 bit counter", "Date": "Fri, 17 May 2024 10:35:08 -0700", "Message-ID": "<20240517174044.90952-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240517174044.90952-1-stephen@networkplumber.org>", "References": "<20240510050507.14381-1-stephen@networkplumber.org>\n <20240517174044.90952-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This header implements 64 bit counters using atomic\noperations but with a weak memory ordering so that\nthey are safe against load/store splits on 32 bit platforms.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/eal/include/meson.build | 1 +\n lib/eal/include/rte_counter.h | 116 ++++++++++++++++++++++++++++++++++\n 2 files changed, 117 insertions(+)\n create mode 100644 lib/eal/include/rte_counter.h", "diff": "diff --git a/lib/eal/include/meson.build b/lib/eal/include/meson.build\nindex e94b056d46..c070dd0079 100644\n--- a/lib/eal/include/meson.build\n+++ b/lib/eal/include/meson.build\n@@ -12,6 +12,7 @@ headers += files(\n 'rte_class.h',\n 'rte_common.h',\n 'rte_compat.h',\n+ 'rte_counter.h',\n 'rte_debug.h',\n 'rte_dev.h',\n 'rte_devargs.h',\ndiff --git a/lib/eal/include/rte_counter.h b/lib/eal/include/rte_counter.h\nnew file mode 100644\nindex 0000000000..cdaa426e12\n--- /dev/null\n+++ b/lib/eal/include/rte_counter.h\n@@ -0,0 +1,116 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (c) Stephen Hemminger <stephen@networkplumber.org>\n+ */\n+\n+#ifndef _RTE_COUNTER_H_\n+#define _RTE_COUNTER_H_\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+#include <stdint.h>\n+#include <rte_common.h>\n+#include <rte_stdatomic.h>\n+\n+/**\n+ * @file\n+ * RTE Counter\n+ *\n+ * A counter is 64 bit value that is safe from split read/write.\n+ * It assumes that only one cpu at a time will update the counter,\n+ * and another CPU may want to read it.\n+ *\n+ * This is a weaker subset of full atomic variables.\n+ *\n+ * The counters are subject to the restrictions of atomic variables\n+ * in packed structures or unaligned.\n+ */\n+\n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n+ *\n+ * The RTE counter type.\n+ */\n+typedef RTE_ATOMIC(uint64_t) rte_counter64_t;\n+\n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n+ *\n+ * Add value to counter.\n+ * Assumes this operation is only done by one thread on the object.\n+ *\n+ * @param counter\n+ * A pointer to the counter.\n+ * @param val\n+ * The value to add to the counter.\n+ */\n+__rte_experimental\n+static inline void\n+rte_counter64_add(rte_counter64_t *counter, uint32_t val)\n+{\n+\trte_atomic_fetch_add_explicit(counter, val, rte_memory_order_relaxed);\n+}\n+\n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n+ *\n+ * Read a counter.\n+ * This operation can be done by any thread.\n+ *\n+ * @param counter\n+ * A pointer to the counter.\n+ * @return\n+ * The current value of the counter.\n+ */\n+__rte_experimental\n+static inline uint64_t\n+rte_counter64_fetch(const rte_counter64_t *counter)\n+{\n+\treturn rte_atomic_load_explicit(counter, rte_memory_order_consume);\n+}\n+\n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n+ *\n+ * Set a counter.\n+ * This operation can be done by any thread.\n+ *\n+ * @param counter\n+ * A pointer to the counter.\n+ * @param val\n+ * Value to set counter to.\n+ */\n+__rte_experimental\n+static inline void\n+rte_counter64_set(rte_counter64_t *counter, uint64_t val)\n+{\n+\trte_atomic_store_explicit(counter, val, rte_memory_order_release);\n+}\n+\n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n+ *\n+ * Reset a counter to zero.\n+ * This operation can be done by any thread.\n+ *\n+ * @param counter\n+ * A pointer to the counter.\n+ */\n+__rte_experimental\n+static inline void\n+rte_counter64_reset(rte_counter64_t *counter)\n+{\n+\trte_counter64_set(counter, 0);\n+}\n+\n+#ifdef __cplusplus\n+}\n+#endif\n+\n+#endif /* _RTE_COUNTER_H_ */\n", "prefixes": [ "v7", "1/9" ] }{ "id": 140173, "url": "