Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140179/?format=api
{ "id": 140179, "url": "http://patchwork.dpdk.org/api/patches/140179/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240517174044.90952-8-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240517174044.90952-8-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240517174044.90952-8-stephen@networkplumber.org", "date": "2024-05-17T17:35:14", "name": "[v7,7/9] net/ring: use generic SW stats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f1718c75cf54f55324155465ee60fd835d185000", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240517174044.90952-8-stephen@networkplumber.org/mbox/", "series": [ { "id": 31946, "url": "http://patchwork.dpdk.org/api/series/31946/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31946", "date": "2024-05-17T17:35:07", "name": "Use weak atomic operations for SW PMD counters", "version": 7, "mbox": "http://patchwork.dpdk.org/series/31946/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/140179/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/140179/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D0FB344052;\n\tFri, 17 May 2024 19:41:37 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 33FD440A75;\n\tFri, 17 May 2024 19:40:59 +0200 (CEST)", "from mail-pl1-f174.google.com (mail-pl1-f174.google.com\n [209.85.214.174])\n by mails.dpdk.org (Postfix) with ESMTP id 0192940695\n for <dev@dpdk.org>; Fri, 17 May 2024 19:40:54 +0200 (CEST)", "by mail-pl1-f174.google.com with SMTP id\n d9443c01a7336-1e651a9f3ffso15447975ad.1\n for <dev@dpdk.org>; Fri, 17 May 2024 10:40:53 -0700 (PDT)", "from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-1ef0bf31032sm158830485ad.131.2024.05.17.10.40.52\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 May 2024 10:40:52 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715967653;\n x=1716572453; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=RQHsK1gWBPW+bM15aASK3G4n/oOoE48zyy1OE2N7qD4=;\n b=X7fs9+NLvBiGZk1zHreO/HIDYst1qVA3uR0jK3Md8DgBoQCD0VxoVcHsOhnMeusymr\n drX8O4Xqo1JXTl5SDaWo4YV3s504hi24YINMs+htn4UD6ILIOVnBN8vmGIzDqsCtz0eq\n 5t2m0AgUBX/GLURb7EISEGOG4/yOyApwAYg1Q8EXQnuisurgYaDZ11zPzgL9hLfP0E+Y\n y+IT+e0OzQl1wm5JWSbMj76KGTHLdGYEYGg9jrpZksAhvoUVwESVItLEG7yDvqn2BQl9\n xRYYO1VNShNHoSS+/IgtCrRZcoznhQfyJZ/Z8x+/Px+3AeUsZeKqHnPnlVAYB05KS3yj\n I+tw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715967653; x=1716572453;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=RQHsK1gWBPW+bM15aASK3G4n/oOoE48zyy1OE2N7qD4=;\n b=aZ4/60++bUZ7Uufove1JIIpsRHHAcqCzn+67Vtgo1Cf2y5IFtiDEzudicfESuKrXe2\n FoWEFOJGwdt5gqcFeXpXQqT1eRGlMHL7/4/ludnPh1OV+zx2sC6XGV0nB2OYuWkwH7Or\n ZiTGyawlz7+GU97/dSkcfvog4mhWWtaVJqOpSyVYFuRMuvUdyqvzM6msQxYVyKjUVqIO\n qLOUo7RecvnYob2xskTFwCmRY+xs9TK4cO11SOGqQiKEI6qzHfJ57vZ4bzoSgs8GjL/l\n 3guNFFk27pdf1cJIqgucgCO9s9JirstwBGgP8/erN58ok8dHN3ViwDt1zvu5o/c4hvRM\n bgYQ==", "X-Gm-Message-State": "AOJu0YwBc+DQKBTdMyR8nNVt4fWpTPfwYrbpN4j0ppGOeNyahUt7v5R8\n I1Sz9hDblWAP9q+fTwBpHZKwX++UQRuqFd4rj5m4TpxObj61IxfbQMdRPMZ55DSykq07fOLkAXM\n IX4Y=", "X-Google-Smtp-Source": "\n AGHT+IHeicD0+gB2h1RrAvFG+4HmSFdW4C6Abft2mLPrceuNGDVEdfuBWat4QUY8CRmXZviSAhkkBw==", "X-Received": "by 2002:a17:902:fc4f:b0:1e8:c962:4f6e with SMTP id\n d9443c01a7336-1ef43d27f6fmr254015385ad.20.1715967653073;\n Fri, 17 May 2024 10:40:53 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v7 7/9] net/ring: use generic SW stats", "Date": "Fri, 17 May 2024 10:35:14 -0700", "Message-ID": "<20240517174044.90952-8-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240517174044.90952-1-stephen@networkplumber.org>", "References": "<20240510050507.14381-1-stephen@networkplumber.org>\n <20240517174044.90952-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use generic per-queue infrastructure.\nThis also fixes bug where ring code was not accounting\nfor bytes.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/ring/rte_eth_ring.c | 71 +++++++++++++--------------------\n 1 file changed, 28 insertions(+), 43 deletions(-)", "diff": "diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex b16f5d55f2..85f14dd679 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -7,6 +7,7 @@\n #include \"rte_eth_ring.h\"\n #include <rte_mbuf.h>\n #include <ethdev_driver.h>\n+#include <ethdev_swstats.h>\n #include <rte_malloc.h>\n #include <rte_memcpy.h>\n #include <rte_os_shim.h>\n@@ -44,8 +45,8 @@ enum dev_action {\n \n struct ring_queue {\n \tstruct rte_ring *rng;\n-\tRTE_ATOMIC(uint64_t) rx_pkts;\n-\tRTE_ATOMIC(uint64_t) tx_pkts;\n+\n+\tstruct rte_eth_counters stats;\n };\n \n struct pmd_internals {\n@@ -77,12 +78,13 @@ eth_ring_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n {\n \tvoid **ptrs = (void *)&bufs[0];\n \tstruct ring_queue *r = q;\n-\tconst uint16_t nb_rx = (uint16_t)rte_ring_dequeue_burst(r->rng,\n-\t\t\tptrs, nb_bufs, NULL);\n-\tif (r->rng->flags & RING_F_SC_DEQ)\n-\t\tr->rx_pkts += nb_rx;\n-\telse\n-\t\trte_atomic_fetch_add_explicit(&r->rx_pkts, nb_rx, rte_memory_order_relaxed);\n+\tuint16_t i, nb_rx;\n+\n+\tnb_rx = (uint16_t)rte_ring_dequeue_burst(r->rng, ptrs, nb_bufs, NULL);\n+\n+\tfor (i = 0; i < nb_rx; i++)\n+\t\trte_eth_count_mbuf(&r->stats, bufs[i]);\n+\n \treturn nb_rx;\n }\n \n@@ -90,13 +92,20 @@ static uint16_t\n eth_ring_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n {\n \tvoid **ptrs = (void *)&bufs[0];\n+\tuint32_t *sizes;\n \tstruct ring_queue *r = q;\n-\tconst uint16_t nb_tx = (uint16_t)rte_ring_enqueue_burst(r->rng,\n-\t\t\tptrs, nb_bufs, NULL);\n-\tif (r->rng->flags & RING_F_SP_ENQ)\n-\t\tr->tx_pkts += nb_tx;\n-\telse\n-\t\trte_atomic_fetch_add_explicit(&r->tx_pkts, nb_tx, rte_memory_order_relaxed);\n+\tuint16_t i, nb_tx;\n+\n+\tsizes = alloca(sizeof(uint32_t) * nb_bufs);\n+\n+\tfor (i = 0; i < nb_bufs; i++)\n+\t\tsizes[i] = rte_pktmbuf_pkt_len(bufs[i]);\n+\n+\tnb_tx = (uint16_t)rte_ring_enqueue_burst(r->rng, ptrs, nb_bufs, NULL);\n+\n+\tfor (i = 0; i < nb_tx; i++)\n+\t\trte_eth_count_packet(&r->stats, sizes[i]);\n+\n \treturn nb_tx;\n }\n \n@@ -193,40 +202,16 @@ eth_dev_info(struct rte_eth_dev *dev,\n static int\n eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n {\n-\tunsigned int i;\n-\tunsigned long rx_total = 0, tx_total = 0;\n-\tconst struct pmd_internals *internal = dev->data->dev_private;\n-\n-\tfor (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&\n-\t\t\ti < dev->data->nb_rx_queues; i++) {\n-\t\tstats->q_ipackets[i] = internal->rx_ring_queues[i].rx_pkts;\n-\t\trx_total += stats->q_ipackets[i];\n-\t}\n-\n-\tfor (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&\n-\t\t\ti < dev->data->nb_tx_queues; i++) {\n-\t\tstats->q_opackets[i] = internal->tx_ring_queues[i].tx_pkts;\n-\t\ttx_total += stats->q_opackets[i];\n-\t}\n-\n-\tstats->ipackets = rx_total;\n-\tstats->opackets = tx_total;\n-\n-\treturn 0;\n+\treturn rte_eth_counters_stats_get(dev, offsetof(struct ring_queue, stats),\n+\t\t\t\t\t offsetof(struct ring_queue, stats),\n+\t\t\t\t\t stats);\n }\n \n static int\n eth_stats_reset(struct rte_eth_dev *dev)\n {\n-\tunsigned int i;\n-\tstruct pmd_internals *internal = dev->data->dev_private;\n-\n-\tfor (i = 0; i < dev->data->nb_rx_queues; i++)\n-\t\tinternal->rx_ring_queues[i].rx_pkts = 0;\n-\tfor (i = 0; i < dev->data->nb_tx_queues; i++)\n-\t\tinternal->tx_ring_queues[i].tx_pkts = 0;\n-\n-\treturn 0;\n+\treturn rte_eth_counters_reset(dev, offsetof(struct ring_queue, stats),\n+\t\t\t\t offsetof(struct ring_queue, stats));\n }\n \n static void\n", "prefixes": [ "v7", "7/9" ] }