Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140181/?format=api
{ "id": 140181, "url": "http://patchwork.dpdk.org/api/patches/140181/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240517174044.90952-10-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240517174044.90952-10-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240517174044.90952-10-stephen@networkplumber.org", "date": "2024-05-17T17:35:16", "name": "[v7,9/9] net/null: use generic SW stats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "cb1cddb0984bdc6b400021aebf5d40739cb7e401", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240517174044.90952-10-stephen@networkplumber.org/mbox/", "series": [ { "id": 31946, "url": "http://patchwork.dpdk.org/api/series/31946/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31946", "date": "2024-05-17T17:35:07", "name": "Use weak atomic operations for SW PMD counters", "version": 7, "mbox": "http://patchwork.dpdk.org/series/31946/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/140181/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/140181/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9639F44052;\n\tFri, 17 May 2024 19:41:51 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1B76740DCB;\n\tFri, 17 May 2024 19:41:02 +0200 (CEST)", "from mail-pl1-f171.google.com (mail-pl1-f171.google.com\n [209.85.214.171])\n by mails.dpdk.org (Postfix) with ESMTP id A6FA7409FA\n for <dev@dpdk.org>; Fri, 17 May 2024 19:40:55 +0200 (CEST)", "by mail-pl1-f171.google.com with SMTP id\n d9443c01a7336-1ec41d82b8bso19065805ad.2\n for <dev@dpdk.org>; Fri, 17 May 2024 10:40:55 -0700 (PDT)", "from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-1ef0bf31032sm158830485ad.131.2024.05.17.10.40.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 May 2024 10:40:54 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715967655;\n x=1716572455; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=lYXDUrkpOH74UzCatXaIUkTb9X4azvwOXkFfc0kL1is=;\n b=q+PVZu7TD/WiE26AQ3ekZ+SFQR4PFNKz7LJV1+qCfvWOYsCD8Uk+xiA+STk7cTZEYd\n 1k43IMjw4jMboXH4vy+OdZjzTAXrgph0fjhfokcFIu4bvxQMT2iFXRfk0t9j515qYueu\n 6pBkjLZQK387/fWsGPraBvAqhOgnA0J/xkx49hkdGg3QLyU+yh3KjfvOlP1D3s7k/9J0\n XQQaGQ0yw5CrAhoDrjCBCy9eUQsMOVyBWpE8phM1cAUyZm5u6mH2IbkNwnaFPsmtxmz9\n 4VLYAMc4h8CO/fIuM5nnxGf9c4fIySL2/ju7aKwGBxDIk1FT9vNmvd66g7Aex5K0bN7I\n OfQQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715967655; x=1716572455;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=lYXDUrkpOH74UzCatXaIUkTb9X4azvwOXkFfc0kL1is=;\n b=MSTf7Jn4iE664YP0IYVSN8amgrBBFL3cnwmHOm/IDHuC5G+MmxuKNtMwU0I7FWwNTq\n DlX3HauGRXsjU9mChL6Pn4hVZ1C0OWxxkvqmPKN2jd3/bMh20OjjzC3C23xweQ3jXYsJ\n Mds5NJNlOYz3LqRNyVq0kehmovDVjY+x21TOurhB0eNkO/Fj0hng+FY5umvGaLIlaalc\n AznLgVT9K6vG8mowoLrspbKURRP5JM8nMo0xd6O1RwmFiy+loAOrE961PtJf3escNX18\n iT85IJxuLG+0AkPiVCzGpJUwAXXVn7ta2icHsJJfRbMpCcSvBZ416JZXOlr6LymgYlE1\n OjYQ==", "X-Gm-Message-State": "AOJu0Yy+0oYJR9GE4AzPDGVsa2hSGraO+VMVzUKLaiDbdmS/XGqxn2NZ\n DyOiSZOzglbwJCygvvkAVZMTOigL8TrDSBGR+6Q+Vo9/FdgvW9gQWlFM4rqUb2c2lojWzAvrYRV\n l75k=", "X-Google-Smtp-Source": "\n AGHT+IEMx7COjsJticqmW2zTmO8G3HXjTTgUVM2jeYoNS2SkOmATLOAHpsy5lj9EQ9ziDXuSvloGxw==", "X-Received": "by 2002:a17:902:e881:b0:1e3:dfdd:21bd with SMTP id\n d9443c01a7336-1ef43f51ff5mr217367815ad.55.1715967654849;\n Fri, 17 May 2024 10:40:54 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Tetsuya Mukawa <mtetsuyah@gmail.com>", "Subject": "[PATCH v7 9/9] net/null: use generic SW stats", "Date": "Fri, 17 May 2024 10:35:16 -0700", "Message-ID": "<20240517174044.90952-10-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240517174044.90952-1-stephen@networkplumber.org>", "References": "<20240510050507.14381-1-stephen@networkplumber.org>\n <20240517174044.90952-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use the new common code for statistics.\nThis also fixes the bug that this driver was not accounting\nfor bytes.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/null/rte_eth_null.c | 80 +++++++--------------------------\n 1 file changed, 17 insertions(+), 63 deletions(-)", "diff": "diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c\nindex f4ed3b8a7f..7786982732 100644\n--- a/drivers/net/null/rte_eth_null.c\n+++ b/drivers/net/null/rte_eth_null.c\n@@ -8,6 +8,7 @@\n #include <rte_mbuf.h>\n #include <ethdev_driver.h>\n #include <ethdev_vdev.h>\n+#include <ethdev_swstats.h>\n #include <rte_malloc.h>\n #include <rte_memcpy.h>\n #include <bus_vdev_driver.h>\n@@ -37,8 +38,8 @@ struct null_queue {\n \tstruct rte_mempool *mb_pool;\n \tstruct rte_mbuf *dummy_packet;\n \n-\tRTE_ATOMIC(uint64_t) rx_pkts;\n-\tRTE_ATOMIC(uint64_t) tx_pkts;\n+\tstruct rte_eth_counters tx_stats;\n+\tstruct rte_eth_counters rx_stats;\n };\n \n struct pmd_options {\n@@ -99,11 +100,9 @@ eth_null_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n \t\tbufs[i]->data_len = (uint16_t)packet_size;\n \t\tbufs[i]->pkt_len = packet_size;\n \t\tbufs[i]->port = h->internals->port_id;\n+\t\trte_eth_count_mbuf(&h->rx_stats, bufs[i]);\n \t}\n \n-\t/* NOTE: review for potential ordering optimization */\n-\trte_atomic_fetch_add_explicit(&h->rx_pkts, i, rte_memory_order_seq_cst);\n-\n \treturn i;\n }\n \n@@ -127,11 +126,9 @@ eth_null_copy_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n \t\tbufs[i]->data_len = (uint16_t)packet_size;\n \t\tbufs[i]->pkt_len = packet_size;\n \t\tbufs[i]->port = h->internals->port_id;\n+\t\trte_eth_count_mbuf(&h->rx_stats, bufs[i]);\n \t}\n \n-\t/* NOTE: review for potential ordering optimization */\n-\trte_atomic_fetch_add_explicit(&h->rx_pkts, i, rte_memory_order_seq_cst);\n-\n \treturn i;\n }\n \n@@ -151,11 +148,10 @@ eth_null_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n \tif ((q == NULL) || (bufs == NULL))\n \t\treturn 0;\n \n-\tfor (i = 0; i < nb_bufs; i++)\n+\tfor (i = 0; i < nb_bufs; i++) {\n+\t\trte_eth_count_mbuf(&h->tx_stats, bufs[i]);\n \t\trte_pktmbuf_free(bufs[i]);\n-\n-\t/* NOTE: review for potential ordering optimization */\n-\trte_atomic_fetch_add_explicit(&h->tx_pkts, i, rte_memory_order_seq_cst);\n+\t}\n \n \treturn i;\n }\n@@ -174,12 +170,10 @@ eth_null_copy_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n \tfor (i = 0; i < nb_bufs; i++) {\n \t\trte_memcpy(h->dummy_packet, rte_pktmbuf_mtod(bufs[i], void *),\n \t\t\t\t\tpacket_size);\n+\t\trte_eth_count_mbuf(&h->tx_stats, bufs[i]);\n \t\trte_pktmbuf_free(bufs[i]);\n \t}\n \n-\t/* NOTE: review for potential ordering optimization */\n-\trte_atomic_fetch_add_explicit(&h->tx_pkts, i, rte_memory_order_seq_cst);\n-\n \treturn i;\n }\n \n@@ -322,60 +316,20 @@ eth_dev_info(struct rte_eth_dev *dev,\n }\n \n static int\n-eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)\n+eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n {\n-\tunsigned int i, num_stats;\n-\tunsigned long rx_total = 0, tx_total = 0;\n-\tconst struct pmd_internals *internal;\n-\n-\tif ((dev == NULL) || (igb_stats == NULL))\n-\t\treturn -EINVAL;\n-\n-\tinternal = dev->data->dev_private;\n-\tnum_stats = RTE_MIN((unsigned int)RTE_ETHDEV_QUEUE_STAT_CNTRS,\n-\t\t\tRTE_MIN(dev->data->nb_rx_queues,\n-\t\t\t\tRTE_DIM(internal->rx_null_queues)));\n-\tfor (i = 0; i < num_stats; i++) {\n-\t\t/* NOTE: review for atomic access */\n-\t\tigb_stats->q_ipackets[i] =\n-\t\t\tinternal->rx_null_queues[i].rx_pkts;\n-\t\trx_total += igb_stats->q_ipackets[i];\n-\t}\n-\n-\tnum_stats = RTE_MIN((unsigned int)RTE_ETHDEV_QUEUE_STAT_CNTRS,\n-\t\t\tRTE_MIN(dev->data->nb_tx_queues,\n-\t\t\t\tRTE_DIM(internal->tx_null_queues)));\n-\tfor (i = 0; i < num_stats; i++) {\n-\t\t/* NOTE: review for atomic access */\n-\t\tigb_stats->q_opackets[i] =\n-\t\t\tinternal->tx_null_queues[i].tx_pkts;\n-\t\ttx_total += igb_stats->q_opackets[i];\n-\t}\n-\n-\tigb_stats->ipackets = rx_total;\n-\tigb_stats->opackets = tx_total;\n-\n-\treturn 0;\n+\treturn rte_eth_counters_stats_get(dev,\n+\t\t\t\t\t offsetof(struct null_queue, tx_stats),\n+\t\t\t\t\t offsetof(struct null_queue, rx_stats),\n+\t\t\t\t\t stats);\n }\n \n static int\n eth_stats_reset(struct rte_eth_dev *dev)\n {\n-\tunsigned int i;\n-\tstruct pmd_internals *internal;\n-\n-\tif (dev == NULL)\n-\t\treturn -EINVAL;\n-\n-\tinternal = dev->data->dev_private;\n-\tfor (i = 0; i < RTE_DIM(internal->rx_null_queues); i++)\n-\t\t/* NOTE: review for atomic access */\n-\t\tinternal->rx_null_queues[i].rx_pkts = 0;\n-\tfor (i = 0; i < RTE_DIM(internal->tx_null_queues); i++)\n-\t\t/* NOTE: review for atomic access */\n-\t\tinternal->tx_null_queues[i].tx_pkts = 0;\n-\n-\treturn 0;\n+\treturn rte_eth_counters_reset(dev,\n+\t\t\t\t offsetof(struct null_queue, tx_stats),\n+\t\t\t\t offsetof(struct null_queue, rx_stats));\n }\n \n static void\n", "prefixes": [ "v7", "9/9" ] }