Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140210/?format=api
{ "id": 140210, "url": "http://patchwork.dpdk.org/api/patches/140210/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240521170746.119330-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240521170746.119330-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240521170746.119330-5-stephen@networkplumber.org", "date": "2024-05-21T17:06:04", "name": "[v14,04/11] net/tap: validate and setup parameters for BPF RSS", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "47fbb18b1a6ff30a166077f3d88529f0d2d37040", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240521170746.119330-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 31954, "url": "http://patchwork.dpdk.org/api/series/31954/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31954", "date": "2024-05-21T17:06:00", "name": "net/tap: make RSS work again", "version": 14, "mbox": "http://patchwork.dpdk.org/series/31954/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/140210/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/140210/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F03614408C;\n\tTue, 21 May 2024 19:08:25 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E9FE040DCA;\n\tTue, 21 May 2024 19:08:04 +0200 (CEST)", "from mail-pf1-f172.google.com (mail-pf1-f172.google.com\n [209.85.210.172])\n by mails.dpdk.org (Postfix) with ESMTP id C6A6A406BA\n for <dev@dpdk.org>; Tue, 21 May 2024 19:08:01 +0200 (CEST)", "by mail-pf1-f172.google.com with SMTP id\n d2e1a72fcca58-6f490b5c23bso556066b3a.3\n for <dev@dpdk.org>; Tue, 21 May 2024 10:08:01 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-6f4d2af52b4sm21634041b3a.174.2024.05.21.10.08.00\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 May 2024 10:08:00 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1716311281;\n x=1716916081; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=OU7guZVDu6aosJdXQlVaUaaoZmgdURl1pOYy82R+ePg=;\n b=z/7aVwl35AIAESoQ26IY8EIR9/spBC+Yof3UtnyQSwyV9hCShxztwLzyyoZxa4D12n\n bAZGOZBclv1g/MtduyrKx7V8VkQsAEjWkdYo23j857Wllaraxs+F7CdyNLzCsbL46z/U\n Q+mAYOIGAMOmPcfcbEN5s5tJGN5n4Mv95cyFiEPVWTO/BJBs9UHPb/qbkASbP8bmz8ZJ\n ymJswzGoI6HTQs3y542jtpEA4qcOaXhwsO+VtbftmJeiG1DezK+sXeT1E9y9wNO9McOf\n YE3OJAdBF1RV7P6WG1aABIiA1sz4Ru1bCjRWBid7eEMQbVbmi6gsjuC833qtaPZRx3LW\n EbUQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1716311281; x=1716916081;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=OU7guZVDu6aosJdXQlVaUaaoZmgdURl1pOYy82R+ePg=;\n b=qXwK84u+Y+TgftZX0Pu6a1ZVTHa4xFPhiBNSQ7m1jdNIoDM08ziG4d7B33klja5EYT\n mJnWWU5tboMjawyOz54go67o6YBhM4EAe+DEoc1YQFq8sCTfJ84DBv8fzSmHpaPoKXUM\n T8DGj36OhCtZ0PbL4SJWS2OgWA8/ge/8J03uKtmUTnGiJPl+XEm1LxW4hrqMHbNvlOGh\n ivyl3byOU1niAhctQhBDRMKy6zIiocu/e4E8FPYVYCaZioHcDHoMBKpA04W69UmT0tos\n QqXgRrcrQ9jc+8eeYt85vpbQj64rOwxw9PxRWos7Oi+BexBhyn8bQbVDjIgXkxjJt+CK\n RffA==", "X-Gm-Message-State": "AOJu0Yw8+eeL2Pt0h3mcGcZY5EaG0q7wCNe7LNoeVS5U4ehgJGb5XQiD\n QdXzJxneyktlFCoe6AsTH5/4gECzgJPCl7sVo8ndgv/kN3MyOCrfa9lNxXR9vU2qezKQRXzDz2/\n l", "X-Google-Smtp-Source": "\n AGHT+IGGoM9divLKDFGsc1qQFbFODH6U/9uHKfGA8tpbuxzdqIFwJcsLiTXvVQHx+07MwOd3SgNbEQ==", "X-Received": "by 2002:a05:6a00:b51:b0:6ed:88e5:53d4 with SMTP id\n d2e1a72fcca58-6f4e02aa365mr39675586b3a.8.1716311280888;\n Tue, 21 May 2024 10:08:00 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Subject": "[PATCH v14 04/11] net/tap: validate and setup parameters for BPF RSS", "Date": "Tue, 21 May 2024 10:06:04 -0700", "Message-ID": "<20240521170746.119330-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240521170746.119330-1-stephen@networkplumber.org>", "References": "<20240130034925.44869-1-stephen@networkplumber.org>\n <20240521170746.119330-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The flow RSS support via BPF was not using the key, or\nhash type parameters. Which is good because they were never\nproperly setup.\n\nFix the setup and validate the flow parameters, the BPF\nside gets fixed later.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/tap/tap_flow.c | 75 +++++++++++++++++++++++++++++++++++---\n drivers/net/tap/tap_rss.h | 5 +--\n 2 files changed, 72 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c\nindex 8fccd599f0..dd4e69b876 100644\n--- a/drivers/net/tap/tap_flow.c\n+++ b/drivers/net/tap/tap_flow.c\n@@ -11,9 +11,11 @@\n \n #include <rte_byteorder.h>\n #include <rte_jhash.h>\n+#include <rte_thash.h>\n #include <rte_random.h>\n #include <rte_malloc.h>\n #include <rte_eth_tap.h>\n+\n #include <tap_flow.h>\n #include <tap_autoconf.h>\n #include <tap_tcmsgs.h>\n@@ -2061,6 +2063,21 @@ static int bpf_rss_key(enum bpf_rss_key_e cmd, __u32 *key_idx)\n \treturn err;\n }\n \n+\n+/* Default RSS hash key also used by mlx devices */\n+static const uint8_t rss_hash_default_key[] = {\n+\t0x2c, 0xc6, 0x81, 0xd1,\n+\t0x5b, 0xdb, 0xf4, 0xf7,\n+\t0xfc, 0xa2, 0x83, 0x19,\n+\t0xdb, 0x1a, 0x3e, 0x94,\n+\t0x6b, 0x9e, 0x38, 0xd9,\n+\t0x2c, 0x9c, 0x03, 0xd1,\n+\t0xad, 0x99, 0x44, 0xa7,\n+\t0xd9, 0x56, 0x3d, 0x59,\n+\t0x06, 0x3c, 0x25, 0xf3,\n+\t0xfc, 0x1f, 0xdc, 0x2a,\n+};\n+\n /**\n * Add RSS hash calculations and queue selection\n *\n@@ -2079,11 +2096,11 @@ static int rss_add_actions(struct rte_flow *flow, struct pmd_internals *pmd,\n \t\t\t const struct rte_flow_action_rss *rss,\n \t\t\t struct rte_flow_error *error)\n {\n-\t/* 4096 is the maximum number of instructions for a BPF program */\n+\tstruct rss_key rss_entry = { };\n+\tconst uint8_t *key_in;\n+\tuint32_t hash_type = 0;\n \tunsigned int i;\n \tint err;\n-\tstruct rss_key rss_entry = { .hash_fields = 0,\n-\t\t\t\t .key_size = 0 };\n \n \t/* Check supported RSS features */\n \tif (rss->func != RTE_ETH_HASH_FUNCTION_DEFAULT)\n@@ -2095,6 +2112,51 @@ static int rss_add_actions(struct rte_flow *flow, struct pmd_internals *pmd,\n \t\t\t(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,\n \t\t\t \"a nonzero RSS encapsulation level is not supported\");\n \n+\tif (rss->queue_num == 0 || rss->queue_num >= TAP_MAX_QUEUES)\n+\t\treturn rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,\n+\t\t\t\t\t \"invalid number of queues\");\n+\n+\t/*\n+\t * Follow the semantics of RSS key (see rte_ethdev.h)\n+\t * There are two valid cases:\n+\t * 1. key_length of zero, and key must be NULL;\n+\t * this uses the default driver key.\n+\t *\n+\t * 2. key_length is the TAP_RSS_HASH_KEY_SIZE (40 bytes)\n+\t * and the key must not be NULL.\n+\t *\n+\t * Anything else is an error.\n+\t */\n+\tif (rss->key_len == 0) {\n+\t\tif (rss->key != NULL)\n+\t\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_CONF,\n+\t\t\t\t\t\t &rss->key_len, \"RSS hash key length 0\");\n+\t\tkey_in = rss_hash_default_key;\n+\t} else {\n+\t\tif (rss->key_len != TAP_RSS_HASH_KEY_SIZE)\n+\t\t\treturn rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t\t NULL, \"RSS hash invalid key length\");\n+\t\tif (rss->key == NULL)\n+\t\t\treturn rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t\t NULL, \"RSS hash key is NULL\");\n+\t\tkey_in = rss->key;\n+\t}\n+\n+\tif (rss->types & TAP_RSS_HF_MASK)\n+\t\treturn rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL, \"RSS hash type not supported\");\n+\n+\tif (rss->types & (RTE_ETH_RSS_NONFRAG_IPV4_UDP | RTE_ETH_RSS_NONFRAG_IPV4_TCP))\n+\t\thash_type |= RTE_BIT32(HASH_FIELD_IPV4_L3_L4);\n+\telse if (rss->types & (RTE_ETH_RSS_IPV4 | RTE_ETH_RSS_FRAG_IPV4))\n+\t\thash_type |= RTE_BIT32(HASH_FIELD_IPV4_L3);\n+\n+\tif (rss->types & (RTE_ETH_RSS_NONFRAG_IPV6_UDP | RTE_ETH_RSS_NONFRAG_IPV6_TCP))\n+\t\thash_type |= RTE_BIT32(HASH_FIELD_IPV6_L3_L4);\n+\telse if (rss->types & (RTE_ETH_RSS_IPV6 | RTE_ETH_RSS_FRAG_IPV6 | RTE_ETH_RSS_IPV6_EX))\n+\t\thash_type |= RTE_BIT32(HASH_FIELD_IPV6_L3);\n+\n \t/* Get a new map key for a new RSS rule */\n \terr = bpf_rss_key(KEY_CMD_GET, &flow->key_idx);\n \tif (err < 0) {\n@@ -2109,8 +2171,11 @@ static int rss_add_actions(struct rte_flow *flow, struct pmd_internals *pmd,\n \trss_entry.nb_queues = rss->queue_num;\n \tfor (i = 0; i < rss->queue_num; i++)\n \t\trss_entry.queues[i] = rss->queue[i];\n-\trss_entry.hash_fields =\n-\t\t(1 << HASH_FIELD_IPV4_L3_L4) | (1 << HASH_FIELD_IPV6_L3_L4);\n+\n+\trss_entry.hash_fields = hash_type;\n+\trte_convert_rss_key((const uint32_t *)key_in, (uint32_t *)rss_entry.key,\n+\t\t\t TAP_RSS_HASH_KEY_SIZE);\n+\n \n \t/* Add this RSS entry to map */\n \terr = tap_flow_bpf_update_rss_elem(pmd->map_fd,\ndiff --git a/drivers/net/tap/tap_rss.h b/drivers/net/tap/tap_rss.h\nindex 8766ffc244..6009be7031 100644\n--- a/drivers/net/tap/tap_rss.h\n+++ b/drivers/net/tap/tap_rss.h\n@@ -24,11 +24,10 @@ enum hash_field {\n };\n \n struct rss_key {\n-\t __u8 key[128];\n \t__u32 hash_fields;\n-\t__u32 key_size;\n-\t__u32 queues[TAP_MAX_QUEUES];\n+\t__u8 key[TAP_RSS_HASH_KEY_SIZE];\n \t__u32 nb_queues;\n+\t__u32 queues[TAP_MAX_QUEUES];\n } __attribute__((packed));\n \n #endif /* _TAP_RSS_H_ */\n", "prefixes": [ "v14", "04/11" ] }