Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/140229/?format=api
{ "id": 140229, "url": "http://patchwork.dpdk.org/api/patches/140229/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20240521201801.126886-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240521201801.126886-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240521201801.126886-2-stephen@networkplumber.org", "date": "2024-05-21T20:16:34", "name": "[v9,1/8] eal: generic 64 bit counter", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2a84514bcf84ec35f8fe4e0464c825331fcae96f", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240521201801.126886-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 31956, "url": "http://patchwork.dpdk.org/api/series/31956/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31956", "date": "2024-05-21T20:16:33", "name": "Common statistics for SW PMD's", "version": 9, "mbox": "http://patchwork.dpdk.org/series/31956/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/140229/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/140229/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 611B54408D;\n\tTue, 21 May 2024 22:18:27 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7954040698;\n\tTue, 21 May 2024 22:18:24 +0200 (CEST)", "from mail-pg1-f177.google.com (mail-pg1-f177.google.com\n [209.85.215.177])\n by mails.dpdk.org (Postfix) with ESMTP id 203E4400D7\n for <dev@dpdk.org>; Tue, 21 May 2024 22:18:05 +0200 (CEST)", "by mail-pg1-f177.google.com with SMTP id\n 41be03b00d2f7-5ce2aada130so1655814a12.1\n for <dev@dpdk.org>; Tue, 21 May 2024 13:18:05 -0700 (PDT)", "from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-1f30fb5303csm16119075ad.166.2024.05.21.13.18.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 May 2024 13:18:03 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1716322684;\n x=1716927484; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=i2YHvLy3+uhrayXw6Xzkckul2FnuttPdhJh6fffHLCU=;\n b=j5HUEp7YS59XHpIswyLmO9+1mw/rTNEdisWvXg+YaQE4NBYBTNksAusFROrzJluYjG\n RpNZf9dHk8+Hy/aU9xI5DZdhhpjX2KkA65yOCvRUnusoOjBH3OVSlVBL5gN+CzMtYQMd\n pwEAaf6NY+OoyKYIhHfsk0c5z/YPV55Ahmhk7tXjPycocjcUGVAuYHGQ6aCJBo1gmVg9\n axpjn14JeWLNnHXlkqSxQoDV2cH0Jp36+OL0epd/FoAHuFxBc1fozXNf7qDYlT2m3qo+\n Ihqf8qgas78zS5E+JNSyKmCGsxdWGDJSeRMAdTaqO9bxB2Vg7mp3SmH3651xJ9fr0dnu\n PC1A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1716322684; x=1716927484;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=i2YHvLy3+uhrayXw6Xzkckul2FnuttPdhJh6fffHLCU=;\n b=Ga3VzOgbIbYxBZRC8JhJSG7nX18ZTKhQnQjDTmMBCm8NO1KgsrRhUAIT1YQJX/5D6F\n WW2ahpn+Yb7UDxXOSSUMYDtxpNSOX9yxRW4kM19BGNTnQrHIXyPnJRFxrTEaaPsYrB2c\n /x82XHNt/tvWBcUBkSQ92ezT2JFIXc55OidrMQ8db1zj8j9OYNrngmcjQSNgn8OgAjDj\n rpQWQGzvjwE17ieQBqBXD+VaKIW1SLvLS9MWjz2AKu/zdI3qfDZ5StXSLXl0RL6FZxdk\n TFDWd4n6WVR3/hCOf8iK36KXKmsjrpsmgidLDly3swXIvX2fiSnlTVptMehx7NjVrjps\n hBQg==", "X-Gm-Message-State": "AOJu0Yz5Y7NQhs5scdfuOPAkpoKljxcuURd8b4qJaS9gNTwAD4NCvH1b\n 7c8frpXHcx1IeUxkBlbDhs9TkELl7SR9xgqgYJlTeQESQ2phlZW8/lkNbN1tcpRKkZJV4xyiR58\n A", "X-Google-Smtp-Source": "\n AGHT+IFX+54mF11TBEn6JwyW1l85siKl01oM+td+0y+ONM/pMkww5YoclfsBm5Aa10QYhCHtiskaNg==", "X-Received": "by 2002:a17:902:d4ca:b0:1e7:8d21:7fd7 with SMTP id\n d9443c01a7336-1f31c98ee00mr381585ad.28.1716322684305;\n Tue, 21 May 2024 13:18:04 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>, =?utf-8?q?Morten_Br?=\n\t=?utf-8?q?=C3=B8rup?= <mb@smartsharesystems.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v9 1/8] eal: generic 64 bit counter", "Date": "Tue, 21 May 2024 13:16:34 -0700", "Message-ID": "<20240521201801.126886-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240521201801.126886-1-stephen@networkplumber.org>", "References": "<20240510050507.14381-1-stephen@networkplumber.org>\n <20240521201801.126886-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This header implements 64 bit counters using atomic\noperations but with a weak memory ordering so that\nthey are safe against load/store splits on 32 bit platforms.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/eal/include/meson.build | 1 +\n lib/eal/include/rte_counter.h | 150 ++++++++++++++++++++++++++++++++++\n 2 files changed, 151 insertions(+)\n create mode 100644 lib/eal/include/rte_counter.h", "diff": "diff --git a/lib/eal/include/meson.build b/lib/eal/include/meson.build\nindex e94b056d46..c070dd0079 100644\n--- a/lib/eal/include/meson.build\n+++ b/lib/eal/include/meson.build\n@@ -12,6 +12,7 @@ headers += files(\n 'rte_class.h',\n 'rte_common.h',\n 'rte_compat.h',\n+ 'rte_counter.h',\n 'rte_debug.h',\n 'rte_dev.h',\n 'rte_devargs.h',\ndiff --git a/lib/eal/include/rte_counter.h b/lib/eal/include/rte_counter.h\nnew file mode 100644\nindex 0000000000..f0c2b71a6c\n--- /dev/null\n+++ b/lib/eal/include/rte_counter.h\n@@ -0,0 +1,150 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (c) Stephen Hemminger <stephen@networkplumber.org>\n+ */\n+\n+#ifndef _RTE_COUNTER_H_\n+#define _RTE_COUNTER_H_\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+#include <stdint.h>\n+#include <rte_compat.h>\n+#include <rte_common.h>\n+#include <rte_stdatomic.h>\n+\n+/**\n+ * @file\n+ * RTE Counter\n+ *\n+ * A counter is 64 bit value that is safe from split read/write.\n+ * It assumes that only one cpu at a time will update the counter,\n+ * and another CPU may want to read it.\n+ *\n+ * This is a weaker subset of full atomic variables.\n+ *\n+ * The counters are subject to the restrictions of atomic variables\n+ * in packed structures or unaligned.\n+ */\n+\n+#ifdef RTE_ARCH_64\n+\n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n+ *\n+ * On native 64 bit platform, counter is implemented as basic\n+ * 64 bit unsigned integer that only increases.\n+ */\n+typedef struct {\n+\tuint64_t current;\n+\tuint64_t offset;\n+} rte_counter64_t;\n+\n+/**\n+ * @internal\n+ * Macro to implement read once (compiler barrier) using stdatomic.\n+ * This is compiler barrier only.\n+ */\n+#define __rte_read_once(var)\t\t\t\t\t\t\\\n+\trte_atomic_load_explicit((__rte_atomic typeof(&(var)))&(var),\t\\\n+\t\trte_memory_order_consume)\n+\n+/**\n+ * @internal\n+ * Macro to implement write once (compiler barrier) using stdatomic.\n+ * This is compiler barrier only.\n+ */\n+#define __rte_write_once(var, val)\t\t\t\t\t \\\n+\trte_atomic_store_explicit((__rte_atomic typeof(&(var)))&(var), val, \\\n+\t\trte_memory_order_release)\n+\n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n+ *\n+ * Add value to counter.\n+ * Assumes this operation is only done by one thread on the object.\n+ *\n+ * @param counter\n+ * A pointer to the counter.\n+ * @param val\n+ * The value to add to the counter.\n+ */\n+static inline void\n+rte_counter64_add(rte_counter64_t *counter, uint32_t val)\n+{\n+\tcounter->current += val;\n+}\n+\n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n+ *\n+ * Read a counter.\n+ * This operation can be done by any thread.\n+ *\n+ * @param counter\n+ * A pointer to the counter.\n+ * @return\n+ * The current value of the counter.\n+ */\n+__rte_experimental\n+static inline uint64_t\n+rte_counter64_read(const rte_counter64_t *counter)\n+{\n+\treturn __rte_read_once(counter->current) - __rte_read_once(counter->offset);\n+}\n+\n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n+ *\n+ * Reset a counter to zero.\n+ * This operation can be done by any thread.\n+ *\n+ * @param counter\n+ * A pointer to the counter.\n+ */\n+__rte_experimental\n+static inline void\n+rte_counter64_reset(rte_counter64_t *counter)\n+{\n+\t__rte_write_once(counter->offset, __rte_read_once(counter->current));\n+}\n+\n+#else\n+\n+/* On 32 bit platform, need to use atomic to avoid load/store tearing */\n+typedef RTE_ATOMIC(uint64_t) rte_counter64_t;\n+\n+__rte_experimental\n+static inline void\n+rte_counter64_add(rte_counter64_t *counter, uint32_t val)\n+{\n+\trte_atomic_fetch_add_explicit(counter, val, rte_memory_order_relaxed);\n+}\n+\n+__rte_experimental\n+static inline uint64_t\n+rte_counter64_read(const rte_counter64_t *counter)\n+{\n+\treturn rte_atomic_load_explicit(counter, rte_memory_order_consume);\n+}\n+\n+__rte_experimental\n+static inline void\n+rte_counter64_reset(rte_counter64_t *counter)\n+{\n+\trte_atomic_store_explicit(counter, 0, rte_memory_order_release);\n+}\n+\n+#endif /* RTE_ARCH_64 */\n+\n+\n+#ifdef __cplusplus\n+}\n+#endif\n+\n+#endif /* _RTE_COUNTER_H_ */\n", "prefixes": [ "v9", "1/8" ] }