Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 14268,
    "url": "http://patchwork.dpdk.org/api/patches/14268/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20160623092552.30932-1-mchandras@suse.de/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20160623092552.30932-1-mchandras@suse.de>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20160623092552.30932-1-mchandras@suse.de",
    "date": "2016-06-23T09:25:52",
    "name": "[dpdk-dev] e1000/base: Add missing braces to the 'if' statements",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "13cc1e12160b5e61cf0a81f2dbb139fc55d97130",
    "submitter": {
        "id": 451,
        "url": "http://patchwork.dpdk.org/api/people/451/?format=api",
        "name": "Markos Chandras",
        "email": "mchandras@suse.de"
    },
    "delegate": {
        "id": 10,
        "url": "http://patchwork.dpdk.org/api/users/10/?format=api",
        "username": "bruce",
        "first_name": "Bruce",
        "last_name": "Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20160623092552.30932-1-mchandras@suse.de/mbox/",
    "series": [],
    "comments": "http://patchwork.dpdk.org/api/patches/14268/comments/",
    "check": "pending",
    "checks": "http://patchwork.dpdk.org/api/patches/14268/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E335CC46E;\n\tThu, 23 Jun 2016 11:26:02 +0200 (CEST)",
            "from mx2.suse.de (mx2.suse.de [195.135.220.15])\n\tby dpdk.org (Postfix) with ESMTP id EEDF6C412\n\tfor <dev@dpdk.org>; Thu, 23 Jun 2016 11:26:00 +0200 (CEST)",
            "from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx2.suse.de (Postfix) with ESMTP id 7DE1CAC6E\n\tfor <dev@dpdk.org>; Thu, 23 Jun 2016 09:26:00 +0000 (UTC)"
        ],
        "X-Virus-Scanned": "by amavisd-new at test-mx.suse.de",
        "From": "Markos Chandras <mchandras@suse.de>",
        "To": "dev@dpdk.org",
        "Cc": "Markos Chandras <mchandras@suse.de>",
        "Date": "Thu, 23 Jun 2016 10:25:52 +0100",
        "Message-Id": "<20160623092552.30932-1-mchandras@suse.de>",
        "X-Mailer": "git-send-email 2.8.4",
        "Subject": "[dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if'\n\tstatements",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Add the missing braces to the 'if' statements to fix the misleading\nidentation. This also fixes the following build errors when building\nwith gcc >= 6:\n\ndrivers/net/e1000/base/e1000_phy.c:4156:2:\nerror: this 'if' clause does not guard... [-Werror=misleading-indentation]\nif (locked)\n^~\n\ndrivers/net/e1000/base/e1000_phy.c:4158:3:\nnote: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'\nif (!ready)\n^~\n\ndrivers/net/e1000/base/e1000_phy.c: In function 'e1000_write_phy_reg_mphy':\ndrivers/net/e1000/base/e1000_phy.c:4221:2:\nerror: this 'if' clause does not guard... [-Werror=misleading-indentation]\nif (locked)\n^~\n\ndrivers/net/e1000/base/e1000_phy.c:4223:3:\nnote: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'\nif (!ready)\n^~\n\nSigned-off-by: Markos Chandras <mchandras@suse.de>\n---\n drivers/net/e1000/base/e1000_phy.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/e1000/base/e1000_phy.c b/drivers/net/e1000/base/e1000_phy.c\nindex d43b7ce..33f478b 100644\n--- a/drivers/net/e1000/base/e1000_phy.c\n+++ b/drivers/net/e1000/base/e1000_phy.c\n@@ -4153,12 +4153,13 @@ s32 e1000_read_phy_reg_mphy(struct e1000_hw *hw, u32 address, u32 *data)\n \t*data = E1000_READ_REG(hw, E1000_MPHY_DATA);\n \n \t/* Disable access to mPHY if it was originally disabled */\n-\tif (locked)\n+\tif (locked) {\n \t\tready = e1000_is_mphy_ready(hw);\n \t\tif (!ready)\n \t\t\treturn -E1000_ERR_PHY;\n \t\tE1000_WRITE_REG(hw, E1000_MPHY_ADDR_CTRL,\n \t\t\t\tE1000_MPHY_DIS_ACCESS);\n+\t}\n \n \treturn E1000_SUCCESS;\n }\n@@ -4218,12 +4219,13 @@ s32 e1000_write_phy_reg_mphy(struct e1000_hw *hw, u32 address, u32 data,\n \tE1000_WRITE_REG(hw, E1000_MPHY_DATA, data);\n \n \t/* Disable access to mPHY if it was originally disabled */\n-\tif (locked)\n+\tif (locked) {\n \t\tready = e1000_is_mphy_ready(hw);\n \t\tif (!ready)\n \t\t\treturn -E1000_ERR_PHY;\n \t\tE1000_WRITE_REG(hw, E1000_MPHY_ADDR_CTRL,\n \t\t\t\tE1000_MPHY_DIS_ACCESS);\n+\t}\n \n \treturn E1000_SUCCESS;\n }\n",
    "prefixes": [
        "dpdk-dev"
    ]
}