Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 14543,
    "url": "http://patchwork.dpdk.org/api/patches/14543/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1467649049-22275-1-git-send-email-reshma.pattan@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1467649049-22275-1-git-send-email-reshma.pattan@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1467649049-22275-1-git-send-email-reshma.pattan@intel.com",
    "date": "2016-07-04T16:17:29",
    "name": "[dpdk-dev] pdump: close client socket",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "3ae1f136bc159050c7927337ed420b7c1d859897",
    "submitter": {
        "id": 70,
        "url": "http://patchwork.dpdk.org/api/people/70/?format=api",
        "name": "Pattan, Reshma",
        "email": "reshma.pattan@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1467649049-22275-1-git-send-email-reshma.pattan@intel.com/mbox/",
    "series": [],
    "comments": "http://patchwork.dpdk.org/api/patches/14543/comments/",
    "check": "pending",
    "checks": "http://patchwork.dpdk.org/api/patches/14543/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 93DA929C6;\n\tMon,  4 Jul 2016 18:17:36 +0200 (CEST)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 0CE0E9E7\n\tfor <dev@dpdk.org>; Mon,  4 Jul 2016 18:17:34 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga104.fm.intel.com with ESMTP; 04 Jul 2016 09:17:34 -0700",
            "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga002.fm.intel.com with ESMTP; 04 Jul 2016 09:17:33 -0700",
            "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tu64GHWP1029652; Mon, 4 Jul 2016 17:17:32 +0100",
            "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id u64GHW8e022315;\n\tMon, 4 Jul 2016 17:17:32 +0100",
            "(from reshmapa@localhost)\n\tby sivswdev02.ir.intel.com with  id u64GHVKj022311;\n\tMon, 4 Jul 2016 17:17:31 +0100"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.26,575,1459839600\"; d=\"scan'208\";\n\ta=\"1015497205\"",
        "From": "Reshma Pattan <reshma.pattan@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Reshma Pattan <reshma.pattan@intel.com>",
        "Date": "Mon,  4 Jul 2016 17:17:29 +0100",
        "Message-Id": "<1467649049-22275-1-git-send-email-reshma.pattan@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "Subject": "[dpdk-dev] [PATCH] pdump: close client socket",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Close the client socket before returning on error.\n\nCoverity issue: 127555\n\nFixes: f3c1829130ac (\"pdump: check missing home environment variable\")\n\nSigned-off-by: Reshma Pattan <reshma.pattan@intel.com>\n---\n lib/librte_pdump/rte_pdump.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c\nindex ee566cb..22ed476 100644\n--- a/lib/librte_pdump/rte_pdump.c\n+++ b/lib/librte_pdump/rte_pdump.c\n@@ -677,7 +677,7 @@ pdump_create_client_socket(struct pdump_request *p)\n \t\tRTE_LOG(ERR, PDUMP,\n \t\t\t\"Failed to get client socket path: %s:%d\\n\",\n \t\t\t__func__, __LINE__);\n-\t\treturn -1;\n+\t\tgoto exit;\n \t}\n \taddr.sun_family = AF_UNIX;\n \taddr_len = sizeof(struct sockaddr_un);\n@@ -728,6 +728,7 @@ pdump_create_client_socket(struct pdump_request *p)\n \t\tret = server_resp.err_value;\n \t} while (0);\n \n+exit:\n \tclose(socket_fd);\n \tunlink(addr.sun_path);\n \treturn ret;\n",
    "prefixes": [
        "dpdk-dev"
    ]
}