Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/14680/?format=api
{ "id": 14680, "url": "http://patchwork.dpdk.org/api/patches/14680/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1467988944-25004-6-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1467988944-25004-6-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1467988944-25004-6-git-send-email-thomas.monjalon@6wind.com", "date": "2016-07-08T14:42:19", "name": "[dpdk-dev,v3,05/10] mk: fix verbose pmdinfogen run", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "db94eb588467c96bd1cf32e0e66bab280413259d", "submitter": { "id": 1, "url": "http://patchwork.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1467988944-25004-6-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/14680/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/14680/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A52E195DB;\n\tFri, 8 Jul 2016 16:42:37 +0200 (CEST)", "from mail-wm0-f50.google.com (mail-wm0-f50.google.com\n\t[74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 2619D95C8\n\tfor <dev@dpdk.org>; Fri, 8 Jul 2016 16:42:34 +0200 (CEST)", "by mail-wm0-f50.google.com with SMTP id f126so14675052wma.1\n\tfor <dev@dpdk.org>; Fri, 08 Jul 2016 07:42:34 -0700 (PDT)", "from XPS13.localdomain (184.203.134.77.rev.sfr.net.\n\t[77.134.203.184]) by smtp.gmail.com with ESMTPSA id\n\tqf7sm1713958wjc.41.2016.07.08.07.42.32\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 08 Jul 2016 07:42:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=AkPFvEQ73H9x99NdoiJUSzP9rF/WSHIbOx1XI1es7gA=;\n\tb=vDuR7fhuTDEyRAo9J0ATmFW9MSYNEVZhdl9Zf43SJ/c2S4sDzScjOioRQfPruJcr3F\n\tzTKGQOdhKlyur4nJdfcEf/10cw4if40ujUI9Wzg9O/9Pc2sCCyO4/WAm6/KDn2GRvaaH\n\tjJyI1VFTIHC6MaLr3gbbfyHRjNE321DTkYVQCsycLx4zuGAKpI6x1/cf5GjO7QBkWaoq\n\t+Lqu6JHH/0ta9TdEMiMjtzHw1ApCkZhsfVjB0c2wXEp/3kjHgYM9ndlxYXmQd+dTRbDV\n\tVpTiZ7nt3qtE/POr/JbwZCaG8Cw1WlEkgTBEBgAzLj3J81kocIuKPRIwysI6cSs4SDkW\n\tFXnA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=AkPFvEQ73H9x99NdoiJUSzP9rF/WSHIbOx1XI1es7gA=;\n\tb=FmwdMU2JO7J4uiBqWkSTptuCMjnbVLcJl1BB31CzXr3fk3XO8qlmUrODQG15k2O+4m\n\t33eTg+FLVPXKsZHW389+8/4ag232XhXqryPSK057IIHlyvLw8K3Sw2x+dfJ1hNLYc3ut\n\tq1dl+zy9233lK/+JgQI+9ndkaeGnDzwm3Hezba3x1YQPI/hm1GjlCk9x/3lpBES0q4Nu\n\tZQxJcSt/3SNjbH/is+l3p17QRkqHUZZGKrPI0rStA4fEmwB4PUVJqZRdBq00BVePKboS\n\tVLA2KYimqMk2oQX9A1VvK729Hz6cSaTg7eOsFvfLzHJkODqOgSniej4UPDCjkfO3r5Vf\n\tgQ4A==", "X-Gm-Message-State": "ALyK8tIL0ej1kiq+TCfuEpOaZ9mRXOFCtfrz/i+zgOfK2viGA1CNIezmn6yB4YBRmtRUle3Y", "X-Received": "by 10.194.5.40 with SMTP id p8mr5790413wjp.56.1467988953948;\n\tFri, 08 Jul 2016 07:42:33 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Neil Horman <nhorman@tuxdriver.com>", "Cc": "dev@dpdk.org", "Date": "Fri, 8 Jul 2016 16:42:19 +0200", "Message-Id": "<1467988944-25004-6-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.7.0", "In-Reply-To": "<1467988944-25004-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1467972855-21873-1-git-send-email-thomas.monjalon@6wind.com>\n\t<1467988944-25004-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH v3 05/10] mk: fix verbose pmdinfogen run", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When building with \"make V=1\" it is expected to see the output of each\ncompiler command in order to debug them.\nUnfortunately the pmdinfogen related commands were always quiet.\n\nIt is fixed by defining the commands in some Makefile variables.\nThey are printed if the verbose mode is enabled.\n\nThe other benefit of this rework is to stop compilation after a\nfailure with pmdinfogen.\n\nThe command readlink is removed in this rework because it seems useless.\n\nFixes: 3d781ca32874 (\"mk: do post processing on objects that register a driver\")\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\nAcked-by: Neil Horman <nhorman@tuxdriver.com>\n---\n mk/internal/rte.compile-pre.mk | 26 ++++++++++++--------------\n 1 file changed, 12 insertions(+), 14 deletions(-)", "diff": "diff --git a/mk/internal/rte.compile-pre.mk b/mk/internal/rte.compile-pre.mk\nindex 87d2d93..9c25ff6 100644\n--- a/mk/internal/rte.compile-pre.mk\n+++ b/mk/internal/rte.compile-pre.mk\n@@ -84,28 +84,26 @@ C_TO_O = $(CC) -Wp,-MD,$(call obj2dep,$(@)).tmp $(CFLAGS) \\\n C_TO_O_STR = $(subst ','\\'',$(C_TO_O)) #'# fix syntax highlight\n C_TO_O_DISP = $(if $(V),\"$(C_TO_O_STR)\",\" CC $(@)\")\n endif\n+PMDINFO_GEN = $(RTE_SDK_BIN)/app/pmdinfogen $@ $@.pmd.c\n+PMDINFO_CC = $(CC) $(CFLAGS) -c -o $@.pmd.o $@.pmd.c\n+PMDINFO_LD = $(CROSS)ld $(LDFLAGS) -r -o $@.o $@.pmd.o $@\n+PMDINFO_TO_O = if grep -q 'PMD_REGISTER_DRIVER(.*)' $<; then \\\n+\techo \"$(if $V,$(PMDINFO_GEN), PMDINFO $@.pmd.c)\" && \\\n+\t$(PMDINFO_GEN) && \\\n+\techo \"$(if $V,$(PMDINFO_CC), CC $@.pmd.o)\" && \\\n+\t$(PMDINFO_CC) && \\\n+\techo \"$(if $V,$(PMDINFO_LD), LD $@)\" && \\\n+\t$(PMDINFO_LD) && \\\n+\tmv -f $@.o $@; fi\n C_TO_O_CMD = 'cmd_$@ = $(C_TO_O_STR)'\n C_TO_O_DO = @set -e; \\\n \techo $(C_TO_O_DISP); \\\n \t$(C_TO_O) && \\\n-\tsh -c \"grep -q \\\"PMD_REGISTER_DRIVER(.*)\\\" $<; \\\n-\tif [ \\$$? -eq 0 ]; then \\\n-\t\techo \\\" PMDINFOGEN\\\" $@; \\\n-\t\tOBJF=`readlink -f $@`; \\\n-\t\t$(RTE_SDK_BIN)/app/pmdinfogen \\$$OBJF \\$$OBJF.pmd.c; \\\n-\t\tif [ \\$$? -eq 0 ]; \\\n-\t\tthen \\\n-\t\t\techo \\\" PMDINFOBUILD\\\" $@; \\\n-\t\t\t$(CC) $(CFLAGS) -c -o \\$$OBJF.pmd.o \\$$OBJF.pmd.c; \\\n-\t\t\t$(CROSS)ld $(LDFLAGS) -r -o \\$$OBJF.o \\$$OBJF.pmd.o \\$$OBJF; \\\n-\t\t\tmv -f \\$$OBJF.o \\$$OBJF; \\\n-\t\tfi; \\\n-\tfi;\" && \\\n+\t$(PMDINFO_TO_O) && \\\n \techo $(C_TO_O_CMD) > $(call obj2cmd,$(@)) && \\\n \tsed 's,'$@':,dep_'$@' =,' $(call obj2dep,$(@)).tmp > $(call obj2dep,$(@)) && \\\n \trm -f $(call obj2dep,$(@)).tmp\n \n-\n # return an empty string if string are equal\n compare = $(strip $(subst $(1),,$(2)) $(subst $(2),,$(1)))\n \n", "prefixes": [ "dpdk-dev", "v3", "05/10" ] }