Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/15456/?format=api
{ "id": 15456, "url": "http://patchwork.dpdk.org/api/patches/15456/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1472279367-25042-3-git-send-email-rasesh.mody@qlogic.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1472279367-25042-3-git-send-email-rasesh.mody@qlogic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1472279367-25042-3-git-send-email-rasesh.mody@qlogic.com", "date": "2016-08-27T06:29:18", "name": "[dpdk-dev,08/17] qede: fix to prevent duplicate VLAN filters", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4894755d6e046222d8f938a31c671313e98c397c", "submitter": { "id": 325, "url": "http://patchwork.dpdk.org/api/people/325/?format=api", "name": "Rasesh Mody", "email": "rasesh.mody@qlogic.com" }, "delegate": { "id": 10, "url": "http://patchwork.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1472279367-25042-3-git-send-email-rasesh.mody@qlogic.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/15456/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/15456/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CB0715938;\n\tSat, 27 Aug 2016 08:29:45 +0200 (CEST)", "from mx0b-0016ce01.pphosted.com (mx0a-0016ce01.pphosted.com\n\t[67.231.148.157]) by dpdk.org (Postfix) with ESMTP id 41950590E\n\tfor <dev@dpdk.org>; Sat, 27 Aug 2016 08:29:44 +0200 (CEST)", "from pps.filterd (m0095336.ppops.net [127.0.0.1])\n\tby mx0a-0016ce01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id\n\tu7R6QaED028017 for <dev@dpdk.org>; Fri, 26 Aug 2016 23:29:43 -0700", "from avcashub1.qlogic.com ([198.186.0.115])\n\tby mx0a-0016ce01.pphosted.com with ESMTP id 250fxrxewm-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT)\n\tfor <dev@dpdk.org>; Fri, 26 Aug 2016 23:29:43 -0700", "from avluser05.qlc.com (10.1.113.115) by qlc.com (10.1.4.190) with\n\tMicrosoft SMTP Server id 14.3.235.1;\n\tFri, 26 Aug 2016 23:29:43 -0700", "(from rmody@localhost)\tby avluser05.qlc.com (8.14.4/8.14.4/Submit)\n\tid u7R6ThkC025098;\tFri, 26 Aug 2016 23:29:43 -0700" ], "X-Authentication-Warning": "avluser05.qlc.com: rmody set sender to\n\trasesh.mody@qlogic.com using -f", "From": "Rasesh Mody <rasesh.mody@qlogic.com>", "To": "<dev@dpdk.org>", "CC": "<Dept-EngDPDKDev@qlogic.com>, Harish Patil <harish.patil@qlogic.com>", "Date": "Fri, 26 Aug 2016 23:29:18 -0700", "Message-ID": "<1472279367-25042-3-git-send-email-rasesh.mody@qlogic.com>", "X-Mailer": "git-send-email 1.7.10.3", "In-Reply-To": "<1472279367-25042-1-git-send-email-rasesh.mody@qlogic.com>", "References": "<1472279367-25042-1-git-send-email-rasesh.mody@qlogic.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "disclaimer": "bypass", "X-Proofpoint-Virus-Version": "vendor=nai engine=5800 definitions=8269\n\tsignatures=670749", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0\n\tpriorityscore=1501 suspectscore=3\n\tmalwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015\n\timpostorscore=0 lowpriorityscore=0 adultscore=0 classifier=spam\n\tadjust=0\n\treason=mlx scancount=1 engine=8.0.1-1604210000\n\tdefinitions=main-1608270067", "Subject": "[dpdk-dev] [PATCH 08/17] qede: fix to prevent duplicate VLAN filters", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Harish Patil <harish.patil@qlogic.com>\n\nlibrte_ether does not keep track of VLAN filters\nconfigured, so it becomes driver's responsibility to\nkeep track of it and prevent duplicate filter\nprogramming. The fix is to use a singly linked\nlist for tracking the entries and there by prevent\nduplicates.\n\nFixes: 2ea6f76 (\"qede: add core driver\")\n\nSigned-off-by: Harish Patil <harish.patil@qlogic.com>\n---\n drivers/net/qede/qede_ethdev.c | 67 ++++++++++++++++++++++++++++++++--------\n drivers/net/qede/qede_ethdev.h | 15 ++++-----\n 2 files changed, 62 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c\nindex c580131..5c67fd7 100644\n--- a/drivers/net/qede/qede_ethdev.c\n+++ b/drivers/net/qede/qede_ethdev.c\n@@ -406,10 +406,11 @@ static int qede_vlan_filter_set(struct rte_eth_dev *eth_dev,\n \tstruct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);\n \tstruct ecore_dev *edev = QEDE_INIT_EDEV(qdev);\n \tstruct qed_dev_eth_info *dev_info = &qdev->dev_info;\n+\tstruct qede_vlan_entry *tmp = NULL;\n+\tstruct qede_vlan_entry *vlan;\n \tint rc;\n \n-\tif (vlan_id != 0 &&\n-\t qdev->configured_vlans == dev_info->num_vlan_filters) {\n+\tif (qdev->configured_vlans == dev_info->num_vlan_filters) {\n \t\tDP_NOTICE(edev, false, \"Reached max VLAN filter limit\"\n \t\t\t\t \" enabling accept_any_vlan\\n\");\n \t\tqede_config_accept_any_vlan(qdev, true);\n@@ -417,28 +418,66 @@ static int qede_vlan_filter_set(struct rte_eth_dev *eth_dev,\n \t}\n \n \tif (on) {\n+\t\tSLIST_FOREACH(tmp, &qdev->vlan_list_head, list) {\n+\t\t\tif (tmp->vid == vlan_id) {\n+\t\t\t\tDP_ERR(edev, \"VLAN %u already configured\\n\",\n+\t\t\t\t vlan_id);\n+\t\t\t\treturn -EEXIST;\n+\t\t\t}\n+\t\t}\n+\n+\t\tvlan = rte_malloc(NULL, sizeof(struct qede_vlan_entry),\n+\t\t\t\t RTE_CACHE_LINE_SIZE);\n+\n+\t\tif (!vlan) {\n+\t\t\tDP_ERR(edev, \"Did not allocate memory for VLAN\\n\");\n+\t\t\treturn -ENOMEM;\n+\t\t}\n+\n \t\trc = qede_set_ucast_rx_vlan(qdev, QED_FILTER_XCAST_TYPE_ADD,\n \t\t\t\t\t vlan_id);\n-\t\tif (rc)\n+\t\tif (rc) {\n \t\t\tDP_ERR(edev, \"Failed to add VLAN %u rc %d\\n\", vlan_id,\n \t\t\t rc);\n-\t\telse\n-\t\t\tif (vlan_id != 0)\n-\t\t\t\tqdev->configured_vlans++;\n+\t\t\trte_free(vlan);\n+\t\t} else {\n+\t\t\tvlan->vid = vlan_id;\n+\t\t\tSLIST_INSERT_HEAD(&qdev->vlan_list_head, vlan, list);\n+\t\t\tqdev->configured_vlans++;\n+\t\t\tDP_INFO(edev, \"VLAN %u added, configured_vlans %u\\n\",\n+\t\t\t\tvlan_id, qdev->configured_vlans);\n+\t\t}\n \t} else {\n+\t\tSLIST_FOREACH(tmp, &qdev->vlan_list_head, list) {\n+\t\t\tif (tmp->vid == vlan_id)\n+\t\t\t\tbreak;\n+\t\t}\n+\n+\t\tif (!tmp) {\n+\t\t\tif (qdev->configured_vlans == 0) {\n+\t\t\t\tDP_INFO(edev,\n+\t\t\t\t\t\"No VLAN filters configured yet\\n\");\n+\t\t\t\treturn 0;\n+\t\t\t}\n+\n+\t\t\tDP_ERR(edev, \"VLAN %u not configured\\n\", vlan_id);\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n+\t\tSLIST_REMOVE(&qdev->vlan_list_head, tmp, qede_vlan_entry, list);\n+\n \t\trc = qede_set_ucast_rx_vlan(qdev, QED_FILTER_XCAST_TYPE_DEL,\n \t\t\t\t\t vlan_id);\n-\t\tif (rc)\n+\t\tif (rc) {\n \t\t\tDP_ERR(edev, \"Failed to delete VLAN %u rc %d\\n\",\n \t\t\t vlan_id, rc);\n-\t\telse\n-\t\t\tif (vlan_id != 0)\n-\t\t\t\tqdev->configured_vlans--;\n+\t\t} else {\n+\t\t\tqdev->configured_vlans--;\n+\t\t\tDP_INFO(edev, \"VLAN %u removed configured_vlans %u\\n\",\n+\t\t\t\tvlan_id, qdev->configured_vlans);\n+\t\t}\n \t}\n \n-\tDP_INFO(edev, \"vlan_id %u on %u rc %d configured_vlans %u\\n\",\n-\t\t\tvlan_id, on, rc, qdev->configured_vlans);\n-\n \treturn rc;\n }\n \n@@ -517,6 +556,8 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev)\n \t\tDP_INFO(edev, \"IP/UDP/TCP checksum offload is always enabled \"\n \t\t\t \"in hw\\n\");\n \n+\tSLIST_INIT(&qdev->vlan_list_head);\n+\n \t/* Check for the port restart case */\n \tif (qdev->state != QEDE_DEV_INIT) {\n \t\trc = qdev->ops->vport_stop(edev, 0);\ndiff --git a/drivers/net/qede/qede_ethdev.h b/drivers/net/qede/qede_ethdev.h\nindex f2e908c..ed2d41c 100644\n--- a/drivers/net/qede/qede_ethdev.h\n+++ b/drivers/net/qede/qede_ethdev.h\n@@ -10,6 +10,8 @@\n #ifndef _QEDE_ETHDEV_H_\n #define _QEDE_ETHDEV_H_\n \n+#include <sys/queue.h>\n+\n #include <rte_ether.h>\n #include <rte_ethdev.h>\n #include <rte_dev.h>\n@@ -116,6 +118,11 @@ enum qede_dev_state {\n \tQEDE_DEV_STOP, /* Deactivate vport and stop traffic */\n };\n \n+struct qede_vlan_entry {\n+\tSLIST_ENTRY(qede_vlan_entry) list;\n+\tuint16_t vid;\n+};\n+\n /*\n * Structure to store private data for each port.\n */\n@@ -136,16 +143,10 @@ struct qede_dev {\n \tuint16_t num_queues;\n \tuint8_t fp_num_tx;\n \tuint8_t fp_num_rx;\n-\n \tenum qede_dev_state state;\n-\n-\t/* Vlans */\n-\tosal_list_t vlan_list;\n+\tSLIST_HEAD(vlan_list_head, qede_vlan_entry)vlan_list_head;\n \tuint16_t configured_vlans;\n-\tuint16_t non_configured_vlans;\n \tbool accept_any_vlan;\n-\tuint16_t vxlan_dst_port;\n-\n \tstruct ether_addr primary_mac;\n \tbool handle_hw_err;\n \tchar drv_ver[QED_DRV_VER_STR_SIZE];\n", "prefixes": [ "dpdk-dev", "08/17" ] }