Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/15988/?format=api
{ "id": 15988, "url": "http://patchwork.dpdk.org/api/patches/15988/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20160920161708.9707-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20160920161708.9707-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20160920161708.9707-1-ferruh.yigit@intel.com", "date": "2016-09-20T16:17:07", "name": "[dpdk-dev,1/2] mempool: fix comments for mempool create functions", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "92ec9665e4a3c783fe92af90424502e915452f20", "submitter": { "id": 324, "url": "http://patchwork.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20160920161708.9707-1-ferruh.yigit@intel.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/15988/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/15988/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id BFCD058C3;\n\tTue, 20 Sep 2016 18:17:14 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 826C35698\n\tfor <dev@dpdk.org>; Tue, 20 Sep 2016 18:17:13 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga102.fm.intel.com with ESMTP; 20 Sep 2016 09:17:12 -0700", "from sivswdev02.ir.intel.com ([10.237.217.46])\n\tby fmsmga006.fm.intel.com with ESMTP; 20 Sep 2016 09:17:11 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.30,368,1470726000\"; d=\"scan'208\";a=\"11300481\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "dev@dpdk.org", "Cc": "Olivier Matz <olivier.matz@6wind.com>", "Date": "Tue, 20 Sep 2016 17:17:07 +0100", "Message-Id": "<20160920161708.9707-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.8.4", "Subject": "[dpdk-dev] [PATCH 1/2] mempool: fix comments for mempool create\n\tfunctions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fixes: 85226f9c526b (\"mempool: introduce a function to create an empty pool\")\nFixes: d1d914ebbc25 (\"mempool: allocate in several memory chunks by default\")\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n lib/librte_mempool/rte_mempool.c | 4 +---\n lib/librte_mempool/rte_mempool.h | 4 +---\n 2 files changed, 2 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c\nindex df8b68c..e96d14f 100644\n--- a/lib/librte_mempool/rte_mempool.c\n+++ b/lib/librte_mempool/rte_mempool.c\n@@ -908,9 +908,7 @@ rte_mempool_create(const char *name, unsigned n, unsigned elt_size,\n /*\n * Create the mempool over already allocated chunk of memory.\n * That external memory buffer can consists of physically disjoint pages.\n- * Setting vaddr to NULL, makes mempool to fallback to original behaviour\n- * and allocate space for mempool and it's elements as one big chunk of\n- * physically continuos memory.\n+ * Setting vaddr to NULL, makes mempool to fallback to original behaviour.\n */\n struct rte_mempool *\n rte_mempool_xmem_create(const char *name, unsigned n, unsigned elt_size,\ndiff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h\nindex 0243f9e..6fc331a 100644\n--- a/lib/librte_mempool/rte_mempool.h\n+++ b/lib/librte_mempool/rte_mempool.h\n@@ -591,8 +591,6 @@ typedef void (rte_mempool_ctor_t)(struct rte_mempool *, void *);\n *\n * This function uses ``memzone_reserve()`` to allocate memory. The\n * pool contains n elements of elt_size. Its size is set to n.\n- * All elements of the mempool are allocated together with the mempool header,\n- * in one physically continuous chunk of memory.\n *\n * @param name\n * The name of the mempool.\n@@ -748,7 +746,7 @@ rte_mempool_xmem_create(const char *name, unsigned n, unsigned elt_size,\n *\n * The mempool is allocated and initialized, but it is not populated: no\n * memory is allocated for the mempool elements. The user has to call\n- * rte_mempool_populate_*() or to add memory chunks to the pool. Once\n+ * rte_mempool_populate_*() to add memory chunks to the pool. Once\n * populated, the user may also want to initialize each object with\n * rte_mempool_obj_iter().\n *\n", "prefixes": [ "dpdk-dev", "1/2" ] }