Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17156/?format=api
{ "id": 17156, "url": "http://patchwork.dpdk.org/api/patches/17156/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1479740470-6723-44-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1479740470-6723-44-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1479740470-6723-44-git-send-email-arybchenko@solarflare.com", "date": "2016-11-21T15:00:57", "name": "[dpdk-dev,43/56] net/sfc: implement device operation to retrieve link info", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "7da8fc818cb8f1656eb373665b9a6ddfe415df9d", "submitter": { "id": 607, "url": "http://patchwork.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1479740470-6723-44-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/17156/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/17156/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 268A0D69A;\n\tMon, 21 Nov 2016 16:03:54 +0100 (CET)", "from nbfkord-smmo02.seg.att.com (nbfkord-smmo02.seg.att.com\n\t[209.65.160.78]) by dpdk.org (Postfix) with ESMTP id 4A19C558B\n\tfor <dev@dpdk.org>; Mon, 21 Nov 2016 16:01:57 +0100 (CET)", "from unknown [12.187.104.26] (EHLO nbfkord-smmo02.seg.att.com)\n\tby nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id\n\t56c03385.2b924e6b0940.1541334.00-2465.3424386.nbfkord-smmo02.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tMon, 21 Nov 2016 15:01:57 +0000 (UTC)", "from unknown [12.187.104.26]\n\tby nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) with SMTP id\n\tc5c03385.0.1541296.00-2372.3424277.nbfkord-smmo02.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tMon, 21 Nov 2016 15:01:49 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Mon, 21 Nov 2016 07:01:22 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Mon, 21 Nov 2016 07:01:22 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuALF1LCj007227; Mon, 21 Nov 2016 15:01:21 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tuALF1J3Y006765; Mon, 21 Nov 2016 15:01:20 GMT" ], "X-MXL-Hash": [ "58330c653fdd77db-9afcee42d375e9b2d5025759066f904e44f82216", "58330c5d718a2e37-259db2528c76c04362f98feca0f72f24917ca47b" ], "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Artem Andreev <Artem.Andreev@oktetlabs.ru>", "Date": "Mon, 21 Nov 2016 15:00:57 +0000", "Message-ID": "<1479740470-6723-44-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>", "References": "<1479740470-6723-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-AnalysisOut": [ "[v=2.1 cv=UI/baXry c=1 sm=1 tr=0 a=8BlWFWvVlq5taO8ncb8nKg==]", "[:17 a=L24OOQBejmoA:10 a=pK7X0mNQAAAA:8 a=zRKbQ67AAAAA:8 a=]", "[vkRlZemiprFAPncsQN0A:9 a=MsD47lMrz1QYs4eB:21 a=Eh926OBYhiL]", "[V6DWb:21 a=5HA-qpC1VU4iIGLgRoNS:22 a=PA03WX8tBzeizutn5_OT:]", "[22]" ], "X-Spam": "[F=0.4581989432; CM=0.500; S=0.458(2015072901)]", "X-MAIL-FROM": "<arybchenko@solarflare.com>", "X-SOURCE-IP": "[12.187.104.26]", "Subject": "[dpdk-dev] [PATCH 43/56] net/sfc: implement device operation to\n\tretrieve link info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Artem Andreev <Artem.Andreev@oktetlabs.ru>\n\nReviewed-by: Andy Moreton <amoreton@solarflare.com>\nSigned-off-by: Artem Andreev <Artem.Andreev@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n doc/guides/nics/features/sfc_efx.ini | 1 +\n doc/guides/nics/sfc_efx.rst | 2 ++\n drivers/net/sfc/efx/sfc.h | 3 ++\n drivers/net/sfc/efx/sfc_ethdev.c | 42 ++++++++++++++++++++++++++\n drivers/net/sfc/efx/sfc_ev.c | 12 ++++++--\n drivers/net/sfc/efx/sfc_port.c | 58 ++++++++++++++++++++++++++++++++++++\n 6 files changed, 115 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/nics/features/sfc_efx.ini b/doc/guides/nics/features/sfc_efx.ini\nindex 59eb830..7dc2e92 100644\n--- a/doc/guides/nics/features/sfc_efx.ini\n+++ b/doc/guides/nics/features/sfc_efx.ini\n@@ -4,6 +4,7 @@\n ; Refer to default.ini for the full list of available PMD features.\n ;\n [Features]\n+Link status = Y\n BSD nic_uio = Y\n Linux UIO = Y\n Linux VFIO = Y\ndiff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst\nindex 271c8c6..46c892b 100644\n--- a/doc/guides/nics/sfc_efx.rst\n+++ b/doc/guides/nics/sfc_efx.rst\n@@ -44,6 +44,8 @@ SFC EFX PMD has support for:\n \n - Multiple transmit and receive queues\n \n+- Link state information\n+\n \n Non-supported Features\n ----------------------\ndiff --git a/drivers/net/sfc/efx/sfc.h b/drivers/net/sfc/efx/sfc.h\nindex ab867da..f328482 100644\n--- a/drivers/net/sfc/efx/sfc.h\n+++ b/drivers/net/sfc/efx/sfc.h\n@@ -215,6 +215,9 @@ int sfc_port_init(struct sfc_adapter *sa);\n void sfc_port_fini(struct sfc_adapter *sa);\n int sfc_port_start(struct sfc_adapter *sa);\n void sfc_port_stop(struct sfc_adapter *sa);\n+void sfc_port_link_mode_to_info(efx_link_mode_t link_mode,\n+\t\t\t\tstruct rte_eth_link *link_info);\n+\n \n #ifdef __cplusplus\n }\ndiff --git a/drivers/net/sfc/efx/sfc_ethdev.c b/drivers/net/sfc/efx/sfc_ethdev.c\nindex a328232..a8a6a17 100644\n--- a/drivers/net/sfc/efx/sfc_ethdev.c\n+++ b/drivers/net/sfc/efx/sfc_ethdev.c\n@@ -37,6 +37,7 @@\n #include \"sfc_debug.h\"\n #include \"sfc_log.h\"\n #include \"sfc_kvargs.h\"\n+#include \"sfc_ev.h\"\n \n \n static void\n@@ -98,6 +99,46 @@ sfc_dev_start(struct rte_eth_dev *dev)\n \treturn -rc;\n }\n \n+static int\n+sfc_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)\n+{\n+\tstruct sfc_adapter *sa = dev->data->dev_private;\n+\tstruct rte_eth_link *dev_link = &dev->data->dev_link;\n+\tstruct rte_eth_link old_link;\n+\tstruct rte_eth_link current_link;\n+\n+\tsfc_log_init(sa, \"entry\");\n+\n+\tif (sa->state != SFC_ADAPTER_STARTED)\n+\t\treturn 0;\n+\n+retry:\n+\tEFX_STATIC_ASSERT(sizeof(*dev_link) == sizeof(rte_atomic64_t));\n+\t*(int64_t *)&old_link = rte_atomic64_read((rte_atomic64_t *)dev_link);\n+\n+\tif (wait_to_complete) {\n+\t\tefx_link_mode_t link_mode;\n+\n+\t\tefx_port_poll(sa->nic, &link_mode);\n+\t\tsfc_port_link_mode_to_info(link_mode, ¤t_link);\n+\n+\t\tif (!rte_atomic64_cmpset((volatile uint64_t *)dev_link,\n+\t\t\t\t\t *(uint64_t *)&old_link,\n+\t\t\t\t\t *(uint64_t *)¤t_link))\n+\t\t\tgoto retry;\n+\t} else {\n+\t\tsfc_ev_mgmt_qpoll(sa);\n+\t\t*(int64_t *)¤t_link =\n+\t\t\trte_atomic64_read((rte_atomic64_t *)dev_link);\n+\t}\n+\n+\tif (old_link.link_status != current_link.link_status)\n+\t\tsfc_info(sa, \"Link status is %s\",\n+\t\t\t current_link.link_status ? \"UP\" : \"DOWN\");\n+\n+\treturn old_link.link_status == current_link.link_status ? 0 : -1;\n+}\n+\n static void\n sfc_dev_stop(struct rte_eth_dev *dev)\n {\n@@ -145,6 +186,7 @@ static const struct eth_dev_ops sfc_eth_dev_ops = {\n \t.dev_start\t\t\t= sfc_dev_start,\n \t.dev_stop\t\t\t= sfc_dev_stop,\n \t.dev_close\t\t\t= sfc_dev_close,\n+\t.link_update\t\t\t= sfc_dev_link_update,\n \t.dev_infos_get\t\t\t= sfc_dev_infos_get,\n };\n \ndiff --git a/drivers/net/sfc/efx/sfc_ev.c b/drivers/net/sfc/efx/sfc_ev.c\nindex 1cb9771..8e2fc94 100644\n--- a/drivers/net/sfc/efx/sfc_ev.c\n+++ b/drivers/net/sfc/efx/sfc_ev.c\n@@ -182,10 +182,16 @@ static boolean_t\n sfc_ev_link_change(void *arg, efx_link_mode_t link_mode)\n {\n \tstruct sfc_evq *evq = arg;\n+\tstruct sfc_adapter *sa = evq->sa;\n+\tstruct rte_eth_link *dev_link = &sa->eth_dev->data->dev_link;\n+\tstruct rte_eth_link new_link;\n \n-\tsfc_err(evq->sa, \"EVQ %u unexpected link change\",\n-\t\tevq->evq_index);\n-\treturn B_TRUE;\n+\tEFX_STATIC_ASSERT(sizeof(*dev_link) == sizeof(rte_atomic64_t));\n+\n+\tsfc_port_link_mode_to_info(link_mode, &new_link);\n+\trte_atomic64_set((rte_atomic64_t *)dev_link, *(uint64_t *)&new_link);\n+\n+\treturn B_FALSE;\n }\n \n static const efx_ev_callbacks_t sfc_ev_callbacks = {\ndiff --git a/drivers/net/sfc/efx/sfc_port.c b/drivers/net/sfc/efx/sfc_port.c\nindex 844363c..c124181 100644\n--- a/drivers/net/sfc/efx/sfc_port.c\n+++ b/drivers/net/sfc/efx/sfc_port.c\n@@ -129,3 +129,61 @@ sfc_port_fini(struct sfc_adapter *sa)\n \n \tsfc_log_init(sa, \"done\");\n }\n+\n+void\n+sfc_port_link_mode_to_info(efx_link_mode_t link_mode,\n+\t\t\t struct rte_eth_link *link_info)\n+{\n+\tSFC_ASSERT(link_mode < EFX_LINK_NMODES);\n+\n+\tmemset(link_info, 0, sizeof(*link_info));\n+\tif ((link_mode == EFX_LINK_DOWN) || (link_mode == EFX_LINK_UNKNOWN))\n+\t\tlink_info->link_status = ETH_LINK_DOWN;\n+\telse\n+\t\tlink_info->link_status = ETH_LINK_UP;\n+\n+\tswitch (link_mode) {\n+\tcase EFX_LINK_10HDX:\n+\t\tlink_info->link_speed = ETH_SPEED_NUM_10M;\n+\t\tlink_info->link_duplex = ETH_LINK_HALF_DUPLEX;\n+\t\tbreak;\n+\tcase EFX_LINK_10FDX:\n+\t\tlink_info->link_speed = ETH_SPEED_NUM_10M;\n+\t\tlink_info->link_duplex = ETH_LINK_FULL_DUPLEX;\n+\t\tbreak;\n+\tcase EFX_LINK_100HDX:\n+\t\tlink_info->link_speed = ETH_SPEED_NUM_100M;\n+\t\tlink_info->link_duplex = ETH_LINK_HALF_DUPLEX;\n+\t\tbreak;\n+\tcase EFX_LINK_100FDX:\n+\t\tlink_info->link_speed = ETH_SPEED_NUM_100M;\n+\t\tlink_info->link_duplex = ETH_LINK_FULL_DUPLEX;\n+\t\tbreak;\n+\tcase EFX_LINK_1000HDX:\n+\t\tlink_info->link_speed = ETH_SPEED_NUM_1G;\n+\t\tlink_info->link_duplex = ETH_LINK_HALF_DUPLEX;\n+\t\tbreak;\n+\tcase EFX_LINK_1000FDX:\n+\t\tlink_info->link_speed = ETH_SPEED_NUM_1G;\n+\t\tlink_info->link_duplex = ETH_LINK_FULL_DUPLEX;\n+\t\tbreak;\n+\tcase EFX_LINK_10000FDX:\n+\t\tlink_info->link_speed = ETH_SPEED_NUM_10G;\n+\t\tlink_info->link_duplex = ETH_LINK_FULL_DUPLEX;\n+\t\tbreak;\n+\tcase EFX_LINK_40000FDX:\n+\t\tlink_info->link_speed = ETH_SPEED_NUM_40G;\n+\t\tlink_info->link_duplex = ETH_LINK_FULL_DUPLEX;\n+\t\tbreak;\n+\tdefault:\n+\t\tSFC_ASSERT(B_FALSE);\n+\t\t/* FALLTHROUGH */\n+\tcase EFX_LINK_UNKNOWN:\n+\tcase EFX_LINK_DOWN:\n+\t\tlink_info->link_speed = ETH_SPEED_NUM_NONE;\n+\t\tlink_info->link_duplex = 0;\n+\t\tbreak;\n+\t}\n+\n+\tlink_info->link_autoneg = ETH_LINK_AUTONEG;\n+}\n", "prefixes": [ "dpdk-dev", "43/56" ] }