get:
Show a patch.

patch:
Update a patch.

put:
Update a patch.

GET /api/patches/17170/?format=api
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 17170,
    "url": "http://patchwork.dpdk.org/api/patches/17170/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1479751574-5704-1-git-send-email-david.marchand@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1479751574-5704-1-git-send-email-david.marchand@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1479751574-5704-1-git-send-email-david.marchand@6wind.com",
    "date": "2016-11-21T18:06:13",
    "name": "[dpdk-dev,v2,1/2] net: remove dead driver names",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "c3ff3cb327f436cc51045fec3223b0a49766ff8c",
    "submitter": {
        "id": 3,
        "url": "http://patchwork.dpdk.org/api/people/3/?format=api",
        "name": "David Marchand",
        "email": "david.marchand@6wind.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patchwork.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1479751574-5704-1-git-send-email-david.marchand@6wind.com/mbox/",
    "series": [],
    "comments": "http://patchwork.dpdk.org/api/patches/17170/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/17170/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 033E12BC6;\n\tMon, 21 Nov 2016 19:06:27 +0100 (CET)",
            "from mail-wm0-f43.google.com (mail-wm0-f43.google.com\n\t[74.125.82.43]) by dpdk.org (Postfix) with ESMTP id D6CFA29D6\n\tfor <dev@dpdk.org>; Mon, 21 Nov 2016 19:06:25 +0100 (CET)",
            "by mail-wm0-f43.google.com with SMTP id a197so161707296wmd.0\n\tfor <dev@dpdk.org>; Mon, 21 Nov 2016 10:06:25 -0800 (PST)",
            "from gloops.dev.6wind.com (89.156.119.78.rev.sfr.net.\n\t[78.119.156.89]) by smtp.gmail.com with ESMTPSA id\n\tl74sm20871567wmg.2.2016.11.21.10.06.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 21 Nov 2016 10:06:24 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=3snHhtkq+1Ul/SnsK//Q6UOpLs5nn/X227E5rguQzrQ=;\n\tb=0tgUfVuWdr3H7+xwZjPFUdX/HvHtxdbt3s+AK9cmtxOhMjEgvXLVA++kQHHCHnvzux\n\t/Khpdl3tP/PyjA5FpiG+K1lMDwad0d3mpLCCsBj1S430m2EB1yHfZI5XhFpaCRz1jitZ\n\tLB/Dncp5YB5pG+T8tsAwgysbL2l4o+7mPJhH4XM7ItCLFIY4Qy/kkKDF5kn2GHlP6yCc\n\tjB8EZ7qddrwR+A9bHr5QBOKZX6G8RVdq1+7lPqebowz0Y7TgrbODQlEoW/Ddf7eCDovP\n\tCYjs7y28SiiHFf3Hc61l16l8RoAX4+ilPBnrh8AMPk0G2mdJGwkdJdy0XjtjTAUQ0Ksu\n\t7IYQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=3snHhtkq+1Ul/SnsK//Q6UOpLs5nn/X227E5rguQzrQ=;\n\tb=GTkeen1k6LTSWGIFifaVj7aE2hWwigqLFrVTnHYCY1hmEArcdBtzRjH0aEwsiheeao\n\tnaCZ+0B5cJSXeHeWlS0autXkJCDkKcQVXFQ2smQ7PidcdNNExQ0+w+aKkMVAm8ZWhHJT\n\ta+h/nFg0+mU/EmmqOi2MKcSPOQmMu+KkDFhW9pKUaOHnU1T4gsaEYL7BNiaf1lnB//id\n\tz0jAbsYlpCKLGDgwx8l7nrxHK/vWdpgUZTPcdvNsKd6+y+XjuVG3jxBHrWEY2zooqCvT\n\tmQdL5MRv85Q4RALzpajtDOc+yuEZxetQWgpn+yuMiACIH5kNOFRtKAVuzUuUVbjHDBNB\n\tXaxw==",
        "X-Gm-Message-State": "AKaTC00BL8NUtHrxgaZvvr8DTkl+xHY//KxlYbTXc2MMeuuZ12w1T7XmOgiEuB3kGEhxV0vI",
        "X-Received": "by 10.28.142.16 with SMTP id q16mr15991972wmd.35.1479751585093; \n\tMon, 21 Nov 2016 10:06:25 -0800 (PST)",
        "From": "David Marchand <david.marchand@6wind.com>",
        "To": "thomas.monjalon@6wind.com",
        "Cc": "dev@dpdk.org, ferruh.yigit@intel.com, jblunck@infradead.org,\n\tlinville@tuxdriver.com, declan.doherty@intel.com, zlu@ezchip.com,\n\tlsun@ezchip.com, alejandro.lucero@netronome.com, mtetsuyah@gmail.com, \n\tnicolas.pernas.maradei@emutex.com, harish.patil@qlogic.com,\n\trasesh.mody@qlogic.com, sony.chacko@qlogic.com,\n\tbruce.richardson@intel.com, \n\thuawei.xie@intel.com, yuanhan.liu@linux.intel.com, jianfeng.tan@intel.com",
        "Date": "Mon, 21 Nov 2016 19:06:13 +0100",
        "Message-Id": "<1479751574-5704-1-git-send-email-david.marchand@6wind.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1478785884-29273-1-git-send-email-david.marchand@6wind.com>",
        "References": "<1478785884-29273-1-git-send-email-david.marchand@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH v2 1/2] net: remove dead driver names",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Since commit b1fb53a39d88 (\"ethdev: remove some PCI specific handling\"),\nrte_eth_dev_info_get() relies on dev->data->drv_name to report the driver\nname to caller.\n\nHaving the pmds set driver_info->driver_name in the pmds is useless,\nsince ethdev overwrites it right after.\nThe only thing the pmd must do is:\n- for pci drivers, call rte_eth_copy_pci_info() which then sets\n  data->drv_name\n- for vdev drivers, manually set data->drv_name\n\nAt this stage, virtio-user does not properly report a driver name (fixed in\nnext commit).\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\nReviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>\nReviewed-by: Jan Blunck <jblunck@infradead.org>\n---\n\nChanges since v1:\n- fixed commit log (checkpatch warning)\n- removed stale variable in qede driver (caught by Jan B.)\n---\n drivers/net/af_packet/rte_eth_af_packet.c | 5 +----\n drivers/net/nfp/nfp_net.c                 | 1 -\n drivers/net/null/rte_eth_null.c           | 4 +---\n drivers/net/pcap/rte_eth_pcap.c           | 4 +---\n drivers/net/qede/qede_ethdev.c            | 2 --\n drivers/net/ring/rte_eth_ring.c           | 4 +---\n drivers/net/vhost/rte_eth_vhost.c         | 3 ---\n drivers/net/virtio/virtio_ethdev.c        | 4 ----\n drivers/net/xenvirt/rte_eth_xenvirt.c     | 5 +----\n 9 files changed, 5 insertions(+), 27 deletions(-)",
    "diff": "diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c\nindex ff45068..a66a657 100644\n--- a/drivers/net/af_packet/rte_eth_af_packet.c\n+++ b/drivers/net/af_packet/rte_eth_af_packet.c\n@@ -115,8 +115,6 @@ static const char *valid_arguments[] = {\n \tNULL\n };\n \n-static const char *drivername = \"AF_PACKET PMD\";\n-\n static struct rte_eth_link pmd_link = {\n \t.link_speed = ETH_SPEED_NUM_10G,\n \t.link_duplex = ETH_LINK_FULL_DUPLEX,\n@@ -280,7 +278,6 @@ eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n {\n \tstruct pmd_internals *internals = dev->data->dev_private;\n \n-\tdev_info->driver_name = drivername;\n \tdev_info->if_index = internals->if_index;\n \tdev_info->max_mac_addrs = 1;\n \tdev_info->max_rx_pktlen = (uint32_t)ETH_FRAME_LEN;\n@@ -693,7 +690,7 @@ rte_pmd_init_internals(const char *name,\n \t(*eth_dev)->dev_ops = &ops;\n \t(*eth_dev)->driver = NULL;\n \t(*eth_dev)->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n-\t(*eth_dev)->data->drv_name = drivername;\n+\t(*eth_dev)->data->drv_name = \"AF_PACKET PMD\";\n \t(*eth_dev)->data->kdrv = RTE_KDRV_NONE;\n \t(*eth_dev)->data->numa_node = numa_node;\n \ndiff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c\nindex c6b1587..0c342ab 100644\n--- a/drivers/net/nfp/nfp_net.c\n+++ b/drivers/net/nfp/nfp_net.c\n@@ -1006,7 +1006,6 @@ nfp_net_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n-\tdev_info->driver_name = dev->driver->pci_drv.driver.name;\n \tdev_info->max_rx_queues = (uint16_t)hw->max_rx_queues;\n \tdev_info->max_tx_queues = (uint16_t)hw->max_tx_queues;\n \tdev_info->min_rx_bufsize = ETHER_MIN_MTU;\ndiff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c\nindex 836d982..09d77fd 100644\n--- a/drivers/net/null/rte_eth_null.c\n+++ b/drivers/net/null/rte_eth_null.c\n@@ -88,7 +88,6 @@ struct pmd_internals {\n \n \n static struct ether_addr eth_addr = { .addr_bytes = {0} };\n-static const char *drivername = \"Null PMD\";\n static struct rte_eth_link pmd_link = {\n \t.link_speed = ETH_SPEED_NUM_10G,\n \t.link_duplex = ETH_LINK_FULL_DUPLEX,\n@@ -295,7 +294,6 @@ eth_dev_info(struct rte_eth_dev *dev,\n \t\treturn;\n \n \tinternals = dev->data->dev_private;\n-\tdev_info->driver_name = drivername;\n \tdev_info->max_mac_addrs = 1;\n \tdev_info->max_rx_pktlen = (uint32_t)-1;\n \tdev_info->max_rx_queues = RTE_DIM(internals->rx_null_queues);\n@@ -555,7 +553,7 @@ eth_dev_null_create(const char *name,\n \teth_dev->driver = NULL;\n \tdata->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \tdata->kdrv = RTE_KDRV_NONE;\n-\tdata->drv_name = drivername;\n+\tdata->drv_name = \"Null PMD\";\n \tdata->numa_node = numa_node;\n \n \t/* finally assign rx and tx ops */\ndiff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c\nindex 0162f44..8b4fba7 100644\n--- a/drivers/net/pcap/rte_eth_pcap.c\n+++ b/drivers/net/pcap/rte_eth_pcap.c\n@@ -119,7 +119,6 @@ static struct ether_addr eth_addr = {\n \t.addr_bytes = { 0, 0, 0, 0x1, 0x2, 0x3 }\n };\n \n-static const char *drivername = \"Pcap PMD\";\n static struct rte_eth_link pmd_link = {\n \t\t.link_speed = ETH_SPEED_NUM_10G,\n \t\t.link_duplex = ETH_LINK_FULL_DUPLEX,\n@@ -552,7 +551,6 @@ eth_dev_info(struct rte_eth_dev *dev,\n {\n \tstruct pmd_internals *internals = dev->data->dev_private;\n \n-\tdev_info->driver_name = drivername;\n \tdev_info->if_index = internals->if_index;\n \tdev_info->max_mac_addrs = 1;\n \tdev_info->max_rx_pktlen = (uint32_t) -1;\n@@ -842,7 +840,7 @@ pmd_init_internals(const char *name, const unsigned int nb_rx_queues,\n \t(*eth_dev)->driver = NULL;\n \tdata->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \tdata->kdrv = RTE_KDRV_NONE;\n-\tdata->drv_name = drivername;\n+\tdata->drv_name = \"Pcap PMD\";\n \tdata->numa_node = numa_node;\n \n \treturn 0;\ndiff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c\nindex d106dd0..2c600c1 100644\n--- a/drivers/net/qede/qede_ethdev.c\n+++ b/drivers/net/qede/qede_ethdev.c\n@@ -12,7 +12,6 @@\n \n /* Globals */\n static const struct qed_eth_ops *qed_ops;\n-static const char *drivername = \"qede pmd\";\n static int64_t timer_period = 1;\n \n struct rte_qede_xstats_name_off {\n@@ -663,7 +662,6 @@ qede_dev_info_get(struct rte_eth_dev *eth_dev,\n \t\tdev_info->max_vfs = 0;\n \telse\n \t\tdev_info->max_vfs = (uint16_t)NUM_OF_VFS(&qdev->edev);\n-\tdev_info->driver_name = qdev->drv_ver;\n \tdev_info->reta_size = ECORE_RSS_IND_TABLE_SIZE;\n \tdev_info->flow_type_rss_offloads = (uint64_t)QEDE_RSS_OFFLOAD_ALL;\n \ndiff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex c1767c4..56afaf2 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -75,7 +75,6 @@ struct pmd_internals {\n };\n \n \n-static const char *drivername = \"Rings PMD\";\n static struct rte_eth_link pmd_link = {\n \t\t.link_speed = ETH_SPEED_NUM_10G,\n \t\t.link_duplex = ETH_LINK_FULL_DUPLEX,\n@@ -173,7 +172,6 @@ eth_dev_info(struct rte_eth_dev *dev,\n \t\tstruct rte_eth_dev_info *dev_info)\n {\n \tstruct pmd_internals *internals = dev->data->dev_private;\n-\tdev_info->driver_name = drivername;\n \tdev_info->max_mac_addrs = 1;\n \tdev_info->max_rx_pktlen = (uint32_t)-1;\n \tdev_info->max_rx_queues = (uint16_t)internals->max_rx_queues;\n@@ -343,7 +341,7 @@ do_eth_dev_ring_create(const char *name,\n \teth_dev->dev_ops = &ops;\n \tdata->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \tdata->kdrv = RTE_KDRV_NONE;\n-\tdata->drv_name = drivername;\n+\tdata->drv_name = \"Rings PMD\";\n \tdata->numa_node = numa_node;\n \n \tTAILQ_INIT(&(eth_dev->link_intr_cbs));\ndiff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c\nindex 766d4ef..96bf391 100644\n--- a/drivers/net/vhost/rte_eth_vhost.c\n+++ b/drivers/net/vhost/rte_eth_vhost.c\n@@ -53,8 +53,6 @@\n #define ETH_VHOST_CLIENT_ARG\t\t\"client\"\n #define ETH_VHOST_DEQUEUE_ZERO_COPY\t\"dequeue-zero-copy\"\n \n-static const char *drivername = \"VHOST PMD\";\n-\n static const char *valid_arguments[] = {\n \tETH_VHOST_IFACE_ARG,\n \tETH_VHOST_QUEUES_ARG,\n@@ -861,7 +859,6 @@ eth_dev_info(struct rte_eth_dev *dev,\n \t\treturn;\n \t}\n \n-\tdev_info->driver_name = drivername;\n \tdev_info->max_mac_addrs = 1;\n \tdev_info->max_rx_pktlen = (uint32_t)-1;\n \tdev_info->max_rx_queues = internal->max_queues;\ndiff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 079fd6c..741688e 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1624,10 +1624,6 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \tuint64_t tso_mask;\n \tstruct virtio_hw *hw = dev->data->dev_private;\n \n-\tif (dev->pci_dev)\n-\t\tdev_info->driver_name = dev->driver->pci_drv.driver.name;\n-\telse\n-\t\tdev_info->driver_name = \"virtio_user PMD\";\n \tdev_info->max_rx_queues =\n \t\tRTE_MIN(hw->max_queue_pairs, VIRTIO_MAX_RX_QUEUES);\n \tdev_info->max_tx_queues =\ndiff --git a/drivers/net/xenvirt/rte_eth_xenvirt.c b/drivers/net/xenvirt/rte_eth_xenvirt.c\nindex c08a056..f74d72c 100644\n--- a/drivers/net/xenvirt/rte_eth_xenvirt.c\n+++ b/drivers/net/xenvirt/rte_eth_xenvirt.c\n@@ -70,8 +70,6 @@\n /* virtio_idx is increased after new device is created.*/\n static int virtio_idx = 0;\n \n-static const char *drivername = \"xen virtio PMD\";\n-\n static struct rte_eth_link pmd_link = {\n \t\t.link_speed = ETH_SPEED_NUM_10G,\n \t\t.link_duplex = ETH_LINK_FULL_DUPLEX,\n@@ -331,7 +329,6 @@ eth_dev_info(struct rte_eth_dev *dev,\n \tstruct pmd_internals *internals = dev->data->dev_private;\n \n \tRTE_SET_USED(internals);\n-\tdev_info->driver_name = drivername;\n \tdev_info->max_mac_addrs = 1;\n \tdev_info->max_rx_pktlen = (uint32_t)2048;\n \tdev_info->max_rx_queues = (uint16_t)1;\n@@ -675,7 +672,7 @@ eth_dev_xenvirt_create(const char *name, const char *params,\n \n \teth_dev->data->dev_flags = RTE_PCI_DRV_DETACHABLE;\n \teth_dev->data->kdrv = RTE_KDRV_NONE;\n-\teth_dev->data->drv_name = drivername;\n+\teth_dev->data->drv_name = \"xen virtio PMD\";\n \teth_dev->driver = NULL;\n \teth_dev->data->numa_node = numa_node;\n \n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "1/2"
    ]
}