Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17216/?format=api
{ "id": 17216, "url": "http://patchwork.dpdk.org/api/patches/17216/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1479921780-9813-9-git-send-email-wenzhuo.lu@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1479921780-9813-9-git-send-email-wenzhuo.lu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1479921780-9813-9-git-send-email-wenzhuo.lu@intel.com", "date": "2016-11-23T17:22:52", "name": "[dpdk-dev,08/16] e1000/base: clear ULP configuration register on ULP exit", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a3c132ae73f9dfc88e8e8613925fe7276bed99dc", "submitter": { "id": 258, "url": "http://patchwork.dpdk.org/api/people/258/?format=api", "name": "Wenzhuo Lu", "email": "wenzhuo.lu@intel.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1479921780-9813-9-git-send-email-wenzhuo.lu@intel.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/17216/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/17216/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5DB63592A;\n\tThu, 24 Nov 2016 02:33:11 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 5C11647CD\n\tfor <dev@dpdk.org>; Thu, 24 Nov 2016 02:32:13 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga105.jf.intel.com with ESMTP; 23 Nov 2016 17:32:13 -0800", "from dpdk26.sh.intel.com ([10.239.128.228])\n\tby fmsmga006.fm.intel.com with ESMTP; 23 Nov 2016 17:32:12 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,689,1473145200\"; d=\"scan'208\";a=\"35041898\"", "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>", "To": "dev@dpdk.org", "Cc": "Wenzhuo Lu <wenzhuo.lu@intel.com>", "Date": "Wed, 23 Nov 2016 12:22:52 -0500", "Message-Id": "<1479921780-9813-9-git-send-email-wenzhuo.lu@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1479921780-9813-1-git-send-email-wenzhuo.lu@intel.com>", "References": "<1479921780-9813-1-git-send-email-wenzhuo.lu@intel.com>", "Subject": "[dpdk-dev] [PATCH 08/16] e1000/base: clear ULP configuration\n\tregister on ULP exit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There are some Client PHY Ultra Low Power (ULP) register bits\nthat are configured by the Manageability Engine (ME) FW.\nThe driver must ensure that these bits are cleared on exit\nfrom ULP. Ordinarily the ME FW would do that, but there are\ncases in which the FW is not present, and the driver must\nhandle that.\n\nSigned-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\n drivers/net/e1000/base/e1000_ich8lan.c | 2 ++\n drivers/net/e1000/base/e1000_ich8lan.h | 4 ++++\n 2 files changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/e1000/base/e1000_ich8lan.c b/drivers/net/e1000/base/e1000_ich8lan.c\nindex 4d893d2..212526f 100644\n--- a/drivers/net/e1000/base/e1000_ich8lan.c\n+++ b/drivers/net/e1000/base/e1000_ich8lan.c\n@@ -1343,6 +1343,8 @@ s32 e1000_disable_ulp_lpt_lp(struct e1000_hw *hw, bool force)\n \t\t\t I218_ULP_CONFIG1_RESET_TO_SMBUS |\n \t\t\t I218_ULP_CONFIG1_WOL_HOST |\n \t\t\t I218_ULP_CONFIG1_INBAND_EXIT |\n+\t\t\t I218_ULP_CONFIG1_EN_ULP_LANPHYPC |\n+\t\t\t I218_ULP_CONFIG1_DIS_CLR_STICKY_ON_PERST |\n \t\t\t I218_ULP_CONFIG1_DISABLE_SMB_PERST);\n \t\te1000_write_phy_reg_hv_locked(hw, I218_ULP_CONFIG1, phy_reg);\n \ndiff --git a/drivers/net/e1000/base/e1000_ich8lan.h b/drivers/net/e1000/base/e1000_ich8lan.h\nindex 6aa9288..352b959 100644\n--- a/drivers/net/e1000/base/e1000_ich8lan.h\n+++ b/drivers/net/e1000/base/e1000_ich8lan.h\n@@ -198,6 +198,10 @@ POSSIBILITY OF SUCH DAMAGE.\n #define I218_ULP_CONFIG1_INBAND_EXIT\t0x0020 /* Inband on ULP exit */\n #define I218_ULP_CONFIG1_WOL_HOST\t0x0040 /* WoL Host on ULP exit */\n #define I218_ULP_CONFIG1_RESET_TO_SMBUS\t0x0100 /* Reset to SMBus mode */\n+/* enable ULP even if when phy powered down via lanphypc */\n+#define I218_ULP_CONFIG1_EN_ULP_LANPHYPC\t0x0400\n+/* disable clear of sticky ULP on PERST */\n+#define I218_ULP_CONFIG1_DIS_CLR_STICKY_ON_PERST\t0x0800\n #define I218_ULP_CONFIG1_DISABLE_SMB_PERST\t0x1000 /* Disable on PERST# */\n \n #endif /* !EXTERNAL_RELEASE || ULP_SUPPORT */\n", "prefixes": [ "dpdk-dev", "08/16" ] }