Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17233/?format=api
{ "id": 17233, "url": "http://patchwork.dpdk.org/api/patches/17233/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1479981261-19512-2-git-send-email-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1479981261-19512-2-git-send-email-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1479981261-19512-2-git-send-email-olivier.matz@6wind.com", "date": "2016-11-24T09:54:13", "name": "[dpdk-dev,RFC,1/9] ethdev: clarify api comments of rx queue count", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5d29874cc5018a700dd2eaa617f86d8f645f5e91", "submitter": { "id": 8, "url": "http://patchwork.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1479981261-19512-2-git-send-email-olivier.matz@6wind.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/17233/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/17233/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CA883567A;\n\tThu, 24 Nov 2016 11:00:25 +0100 (CET)", "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n\t[62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 628035585\n\tfor <dev@dpdk.org>; Thu, 24 Nov 2016 10:59:38 +0100 (CET)", "from glumotte.dev.6wind.com (unknown [10.16.0.195])\n\tby proxy.6wind.com (Postfix) with ESMTP id EF7F4278A2;\n\tThu, 24 Nov 2016 10:59:33 +0100 (CET)" ], "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Cc": "thomas.monjalon@6wind.com, konstantin.ananyev@intel.com,\n\twenzhuo.lu@intel.com, helin.zhang@intel.com", "Date": "Thu, 24 Nov 2016 10:54:13 +0100", "Message-Id": "<1479981261-19512-2-git-send-email-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.8.1", "In-Reply-To": "<1479981261-19512-1-git-send-email-olivier.matz@6wind.com>", "References": "<1479981261-19512-1-git-send-email-olivier.matz@6wind.com>", "Subject": "[dpdk-dev] [RFC 1/9] ethdev: clarify api comments of rx queue count", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The API comments are not consistent between each other.\n\nThe function rte_eth_rx_queue_count() returns the number of used\ndescriptors on a receive queue.\n\nPR=52423\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\nAcked-by: Ivan Boule <ivan.boule@6wind.com>\n---\n lib/librte_ether/rte_ethdev.h | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex 9678179..c3edc23 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -1145,7 +1145,7 @@ typedef void (*eth_queue_release_t)(void *queue);\n \n typedef uint32_t (*eth_rx_queue_count_t)(struct rte_eth_dev *dev,\n \t\t\t\t\t uint16_t rx_queue_id);\n-/**< @internal Get number of available descriptors on a receive queue of an Ethernet device. */\n+/**< @internal Get number of used descriptors on a receive queue. */\n \n typedef int (*eth_rx_descriptor_done_t)(void *rxq, uint16_t offset);\n /**< @internal Check DD bit of specific RX descriptor */\n@@ -1459,7 +1459,8 @@ struct eth_dev_ops {\n \teth_queue_stop_t tx_queue_stop;/**< Stop TX for a queue.*/\n \teth_rx_queue_setup_t rx_queue_setup;/**< Set up device RX queue.*/\n \teth_queue_release_t rx_queue_release;/**< Release RX queue.*/\n-\teth_rx_queue_count_t rx_queue_count; /**< Get Rx queue count. */\n+\teth_rx_queue_count_t rx_queue_count;\n+\t/**< Get the number of used RX descriptors. */\n \teth_rx_descriptor_done_t rx_descriptor_done; /**< Check rxd DD bit */\n \t/**< Enable Rx queue interrupt. */\n \teth_rx_enable_intr_t rx_queue_intr_enable;\n@@ -2684,7 +2685,7 @@ rte_eth_rx_burst(uint8_t port_id, uint16_t queue_id,\n }\n \n /**\n- * Get the number of used descriptors in a specific queue\n+ * Get the number of used descriptors of a rx queue\n *\n * @param port_id\n * The port identifier of the Ethernet device.\n@@ -2699,9 +2700,11 @@ static inline int\n rte_eth_rx_queue_count(uint8_t port_id, uint16_t queue_id)\n {\n \tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n+\n \tRTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);\n \tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_count, -ENOTSUP);\n- return (*dev->dev_ops->rx_queue_count)(dev, queue_id);\n+\n+\treturn (*dev->dev_ops->rx_queue_count)(dev, queue_id);\n }\n \n /**\n", "prefixes": [ "dpdk-dev", "RFC", "1/9" ] }