Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 19929,
    "url": "http://patchwork.dpdk.org/api/patches/19929/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1485245660-2127-1-git-send-email-wei.dai@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1485245660-2127-1-git-send-email-wei.dai@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1485245660-2127-1-git-send-email-wei.dai@intel.com",
    "date": "2017-01-24T08:14:20",
    "name": "[dpdk-dev] net/ixgbe: correct error when SFP not present",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "04a1d61e8f918da2e5af4b24acd810da04d1bc92",
    "submitter": {
        "id": 490,
        "url": "http://patchwork.dpdk.org/api/people/490/?format=api",
        "name": "Wei Dai",
        "email": "wei.dai@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patchwork.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1485245660-2127-1-git-send-email-wei.dai@intel.com/mbox/",
    "series": [],
    "comments": "http://patchwork.dpdk.org/api/patches/19929/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/19929/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CBDAD108D;\n\tTue, 24 Jan 2017 09:18:30 +0100 (CET)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 3191EDE3\n\tfor <dev@dpdk.org>; Tue, 24 Jan 2017 09:18:28 +0100 (CET)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga105.fm.intel.com with ESMTP; 24 Jan 2017 00:18:27 -0800",
            "from dpdk4.bj.intel.com ([172.16.182.178])\n\tby fmsmga001.fm.intel.com with ESMTP; 24 Jan 2017 00:18:26 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.33,277,1477983600\"; d=\"scan'208\";\n\ta=\"1098119185\"",
        "From": "Wei Dai <wei.dai@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "helin.zhang@intel.com, konstantin.ananyev@intel.com,\n\tWei Dai <wei.dai@intel.com>",
        "Date": "Tue, 24 Jan 2017 16:14:20 +0800",
        "Message-Id": "<1485245660-2127-1-git-send-email-wei.dai@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH] net/ixgbe: correct error when SFP not present",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Ignore the error=IXGBE_ERR_SFP_NOT_PRESENT when SFP is not present.\nIf it is not ignored, testpmd will in the NIC initialization process.\nIxgbe kernel driver ignores this error and works well. So DPDK\ndoes same thing.\n\nSigned-off-by: Wei Dai <wei.dai@intel.com>\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\nTested-by: Yuan Peng <yuan.peng@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++\n 1 file changed, 5 insertions(+)",
    "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex bdf4e2b..ae7fb86 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -898,6 +898,8 @@ ixgbe_pf_reset_hw(struct ixgbe_hw *hw)\n \tIXGBE_WRITE_REG(hw, IXGBE_CTRL_EXT, ctrl_ext);\n \tIXGBE_WRITE_FLUSH(hw);\n \n+\tif (status == IXGBE_ERR_SFP_NOT_PRESENT)\n+\t\tstatus = IXGBE_SUCCESS;\n \treturn status;\n }\n \n@@ -1237,6 +1239,9 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev)\n \t\tdiag = ixgbe_init_hw(hw);\n \t}\n \n+\tif (diag == IXGBE_ERR_SFP_NOT_PRESENT)\n+\t\tdiag = IXGBE_SUCCESS;\n+\n \tif (diag == IXGBE_ERR_EEPROM_VERSION) {\n \t\tPMD_INIT_LOG(ERR, \"This device is a pre-production adapter/\"\n \t\t\t     \"LOM.  Please be aware there may be issues associated \"\n",
    "prefixes": [
        "dpdk-dev"
    ]
}