Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/300/?format=api
{ "id": 300, "url": "http://patchwork.dpdk.org/api/patches/300/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1409759378-10113-7-git-send-email-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1409759378-10113-7-git-send-email-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1409759378-10113-7-git-send-email-bruce.richardson@intel.com", "date": "2014-09-03T15:49:31", "name": "[dpdk-dev,06/13] mbuf: minor changes for readability", "commit_ref": "", "pull_url": "", "state": "superseded", "archived": true, "hash": "d913fc2f32fdeefdd746b941cce344d4f529627c", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1409759378-10113-7-git-send-email-bruce.richardson@intel.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/300/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/300/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<bricha3@ecsmtp.ir.intel.com>", "Received": [ "from mga02.intel.com (mga02.intel.com [134.134.136.20])\r\n\tby dpdk.org (Postfix) with ESMTP id 6BFA658EE\r\n\tfor <dev@dpdk.org>; Wed, 3 Sep 2014 17:45:06 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\r\n\tby orsmga101.jf.intel.com with ESMTP; 03 Sep 2014 08:49:41 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\r\n\tby orsmga001.jf.intel.com with ESMTP; 03 Sep 2014 08:49:40 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\r\n\t[10.237.217.46])\r\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\r\n\ts83Fndd8025425; Wed, 3 Sep 2014 16:49:39 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\r\n\tby sivswdev02.ir.intel.com with ESMTP id s83FndY1010455;\r\n\tWed, 3 Sep 2014 16:49:39 +0100", "(from bricha3@localhost)\r\n\tby sivswdev02.ir.intel.com with id s83FndSl010451;\r\n\tWed, 3 Sep 2014 16:49:39 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,458,1406617200\"; d=\"scan'208\";a=\"567777838\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 3 Sep 2014 16:49:31 +0100", "Message-Id": "<1409759378-10113-7-git-send-email-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<1409759378-10113-1-git-send-email-bruce.richardson@intel.com>", "References": "<1409759378-10113-1-git-send-email-bruce.richardson@intel.com>", "Subject": "[dpdk-dev] [PATCH 06/13] mbuf: minor changes for readability", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\r\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\r\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Wed, 03 Sep 2014 15:45:06 -0000" }, "content": "* Ensure comments line up correctly\n* Simplify the #ifdefs around the refcnt fields to make them clearer\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_mbuf/rte_mbuf.h | 17 ++++++++---------\n 1 file changed, 8 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\r\nindex 7b0b4f2..5260001 100644\r\n--- a/lib/librte_mbuf/rte_mbuf.h\r\n+++ b/lib/librte_mbuf/rte_mbuf.h\r\n@@ -126,7 +126,6 @@ struct rte_mbuf {\r\n \tuint16_t buf_len; /**< Length of segment buffer. */\r\n \tuint16_t data_off;\r\n \r\n-#ifdef RTE_MBUF_REFCNT\r\n \t/**\r\n \t * 16-bit Reference counter.\r\n \t * It should only be accessed using the following functions:\r\n@@ -136,12 +135,12 @@ struct rte_mbuf {\r\n \t * config option.\r\n \t */\r\n \tunion {\r\n-\t\trte_atomic16_t refcnt_atomic; /**< Atomically accessed refcnt */\r\n-\t\tuint16_t refcnt; /**< Non-atomically accessed refcnt */\r\n-\t};\r\n-#else\r\n-\tuint16_t refcnt_reserved; /**< Do not use this field */\r\n+#ifdef RTE_MBUF_REFCNT\r\n+\t\trte_atomic16_t refcnt_atomic; /**< Atomically accessed refcnt */\r\n+\t\tuint16_t refcnt; /**< Non-atomically accessed refcnt */\r\n #endif\r\n+\t\tuint16_t refcnt_reserved; /**< Do not use this field */\r\n+\t};\r\n \tuint8_t nb_segs; /**< Number of segments. */\r\n \tuint8_t port; /**< Input port. */\r\n \r\n@@ -155,12 +154,12 @@ struct rte_mbuf {\r\n \tuint16_t l2_len:7; /**< L2 (MAC) Header Length. */\r\n \tuint16_t vlan_tci; /**< VLAN Tag Control Identifier (CPU order). */\r\n \tunion {\r\n-\t\tuint32_t rss; /**< RSS hash result if RSS enabled */\r\n+\t\tuint32_t rss; /**< RSS hash result if RSS enabled */\r\n \t\tstruct {\r\n \t\t\tuint16_t hash;\r\n \t\t\tuint16_t id;\r\n-\t\t} fdir; /**< Filter identifier if FDIR enabled */\r\n-\t\tuint32_t sched; /**< Hierarchical scheduler */\r\n+\t\t} fdir; /**< Filter identifier if FDIR enabled */\r\n+\t\tuint32_t sched; /**< Hierarchical scheduler */\r\n \t} hash; /**< hash information */\r\n \r\n \t/* fields only used in slow path or on TX */\r\n", "prefixes": [ "dpdk-dev", "06/13" ] }