Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/3243/?format=api
{ "id": 3243, "url": "http://patchwork.dpdk.org/api/patches/3243/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1423791501-1555-5-git-send-email-cunming.liang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1423791501-1555-5-git-send-email-cunming.liang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1423791501-1555-5-git-send-email-cunming.liang@intel.com", "date": "2015-02-13T01:38:06", "name": "[dpdk-dev,v6,04/19] eal: fix wrong strnlen() return value in 32bit icc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e1b755ac236434c76a0928e586c7b61d6c174dd4", "submitter": { "id": 46, "url": "http://patchwork.dpdk.org/api/people/46/?format=api", "name": "Cunming Liang", "email": "cunming.liang@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1423791501-1555-5-git-send-email-cunming.liang@intel.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/3243/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/3243/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 922FAAD84;\n\tFri, 13 Feb 2015 02:38:50 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 7C72BAD7C\n\tfor <dev@dpdk.org>; Fri, 13 Feb 2015 02:38:45 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga103.fm.intel.com with ESMTP; 12 Feb 2015 17:31:32 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga003.jf.intel.com with ESMTP; 12 Feb 2015 17:30:28 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t1D1cd7L005641;\n\tFri, 13 Feb 2015 09:38:39 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t1D1cZFw001643; Fri, 13 Feb 2015 09:38:37 +0800", "(from cliang18@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t1D1cZ8n001639; \n\tFri, 13 Feb 2015 09:38:35 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,568,1418112000\"; d=\"scan'208\";a=\"526919218\"", "From": "Cunming Liang <cunming.liang@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 13 Feb 2015 09:38:06 +0800", "Message-Id": "<1423791501-1555-5-git-send-email-cunming.liang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1423791501-1555-1-git-send-email-cunming.liang@intel.com>", "References": "<1423728996-3004-1-git-send-email-cunming.liang@intel.com>\n\t<1423791501-1555-1-git-send-email-cunming.liang@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 04/19] eal: fix wrong strnlen() return value\n\tin 32bit icc", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The problem is that strnlen() here may return invalid value with 32bit icc.\n(actually it returns it’s second parameter,e.g: sysconf(_SC_ARG_MAX)).\nIt starts to manifest hwen max_len parameter is > 2M and using icc –m32 –O2 (or above).\n\nSuggested-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\nSigned-off-by: Cunming Liang <cunming.liang@intel.com>\n---\n v5 changes:\n using strlen instead of strnlen.\n\n lib/librte_eal/common/eal_common_options.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex 178e303..9cf2faa 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -167,7 +167,7 @@ eal_parse_coremask(const char *coremask)\n \tif (coremask[0] == '0' && ((coremask[1] == 'x')\n \t\t|| (coremask[1] == 'X')))\n \t\tcoremask += 2;\n-\ti = strnlen(coremask, PATH_MAX);\n+\ti = strlen(coremask);\n \twhile ((i > 0) && isblank(coremask[i - 1]))\n \t\ti--;\n \tif (i == 0)\n@@ -227,7 +227,7 @@ eal_parse_corelist(const char *corelist)\n \t/* Remove all blank characters ahead and after */\n \twhile (isblank(*corelist))\n \t\tcorelist++;\n-\ti = strnlen(corelist, sysconf(_SC_ARG_MAX));\n+\ti = strlen(corelist);\n \twhile ((i > 0) && isblank(corelist[i - 1]))\n \t\ti--;\n \n@@ -472,7 +472,7 @@ eal_parse_lcores(const char *lcores)\n \t/* Remove all blank characters ahead and after */\n \twhile (isblank(*lcores))\n \t\tlcores++;\n-\ti = strnlen(lcores, sysconf(_SC_ARG_MAX));\n+\ti = strlen(lcores);\n \twhile ((i > 0) && isblank(lcores[i - 1]))\n \t\ti--;\n \n", "prefixes": [ "dpdk-dev", "v6", "04/19" ] }