Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/356/?format=api
{ "id": 356, "url": "http://patchwork.dpdk.org/api/patches/356/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1410445387-4849-4-git-send-email-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1410445387-4849-4-git-send-email-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1410445387-4849-4-git-send-email-bruce.richardson@intel.com", "date": "2014-09-11T14:23:07", "name": "[dpdk-dev,3/3] eal: affinitize low-priority threads to lcore 0", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "8a2bcf9ce1f22a562400b4e46b5b9e638da26511", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1410445387-4849-4-git-send-email-bruce.richardson@intel.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/356/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/356/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 804D7B3A6;\n\tThu, 11 Sep 2014 16:18:24 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 9DFA4B3A1\n\tfor <dev@dpdk.org>; Thu, 11 Sep 2014 16:18:21 +0200 (CEST)", "from azsmga001.ch.intel.com ([10.2.17.19])\n\tby orsmga101.jf.intel.com with ESMTP; 11 Sep 2014 07:23:31 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby azsmga001.ch.intel.com with ESMTP; 11 Sep 2014 07:23:09 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\ts8BEN8Wg013319; Thu, 11 Sep 2014 15:23:08 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id s8BEN7cS004910;\n\tThu, 11 Sep 2014 15:23:07 +0100", "(from bricha3@localhost)\n\tby sivswdev02.ir.intel.com with id s8BEN777004906;\n\tThu, 11 Sep 2014 15:23:07 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,506,1406617200\"; d=\"scan'208\";a=\"476889863\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 11 Sep 2014 15:23:07 +0100", "Message-Id": "<1410445387-4849-4-git-send-email-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1410445387-4849-1-git-send-email-bruce.richardson@intel.com>", "References": "<1410445387-4849-1-git-send-email-bruce.richardson@intel.com>", "Subject": "[dpdk-dev] [PATCH 3/3] eal: affinitize low-priority threads to\n\tlcore 0", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There are extra utility threads inside the linuxapp EAL, for managing\nthings like interrupts, requests for the vfio file handle for\nmulti-process, and hpet timer management. These are mostly sleeping, but\nto avoid any possibility of conflict with threads handling packets, this\npatch affinitizes those threads to lcore 0 explicitly.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_eal/linuxapp/eal/eal_interrupts.c | 5 +++++\n lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c | 6 ++++++\n lib/librte_eal/linuxapp/eal/eal_timer.c | 5 +++++\n 3 files changed, 16 insertions(+)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_interrupts.c b/lib/librte_eal/linuxapp/eal/eal_interrupts.c\nindex dc2668a..6227f2b 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_interrupts.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_interrupts.c\n@@ -739,6 +739,11 @@ eal_intr_thread_main(__rte_unused void *arg)\n {\n \tstruct epoll_event ev;\n \n+\t/* set our affinity to lcore 0 so we never interfere with the normal\n+\t * data-plane threads. Lcore 0 is used by Linux so is subject to\n+\t * interruptions anyway. */\n+\trte_eal_thread_set_affinity(0);\n+\n \t/* host thread, never break out */\n \tfor (;;) {\n \t\t/* build up the epoll fd with all descriptors we are to\ndiff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c\nindex 6588fb1..ccccbdb 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio_mp_sync.c\n@@ -53,6 +53,7 @@\n #include <rte_eal_memconfig.h>\n #include <rte_malloc.h>\n \n+#include <eal_private.h>\n #include \"eal_filesystem.h\"\n #include \"eal_pci_init.h\"\n \n@@ -268,6 +269,11 @@ pci_vfio_mp_sync_thread(void __rte_unused * arg)\n {\n \tint ret, fd, vfio_group_no;\n \n+\t/* set our affinity to lcore 0 so we never interfere with the normal\n+\t * data-plane threads. Lcore 0 is used by Linux so is subject to\n+\t * interruptions anyway. */\n+\trte_eal_thread_set_affinity(0);\n+\n \t/* wait for requests on the socket */\n \tfor (;;) {\n \t\tint conn_sock;\ndiff --git a/lib/librte_eal/linuxapp/eal/eal_timer.c b/lib/librte_eal/linuxapp/eal/eal_timer.c\nindex ca57916..f61e303 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_timer.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_timer.c\n@@ -125,6 +125,11 @@ hpet_msb_inc(__attribute__((unused)) void *arg)\n {\n \tuint32_t t;\n \n+\t/* set our affinity to lcore 0 so we never interfere with the normal\n+\t * data-plane threads. Lcore 0 is used by Linux so is subject to\n+\t * interruptions anyway. */\n+\trte_eal_thread_set_affinity(0);\n+\n \twhile (1) {\n \t\tt = (eal_hpet->counter_l >> 30);\n \t\tif (t != (eal_hpet_msb & 3))\n", "prefixes": [ "dpdk-dev", "3/3" ] }