Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 40658,
    "url": "http://patchwork.dpdk.org/api/patches/40658/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1528208163-31560-1-git-send-email-konstantin.ananyev@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1528208163-31560-1-git-send-email-konstantin.ananyev@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1528208163-31560-1-git-send-email-konstantin.ananyev@intel.com",
    "date": "2018-06-05T14:16:02",
    "name": "[dpdk-dev,1/2] examples/ipsec-secgw: fix bypass rule processing for outbound port",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "08e09c44b15024d827118f0a90f1bbcbc24b8fa0",
    "submitter": {
        "id": 33,
        "url": "http://patchwork.dpdk.org/api/people/33/?format=api",
        "name": "Ananyev, Konstantin",
        "email": "konstantin.ananyev@intel.com"
    },
    "delegate": {
        "id": 22,
        "url": "http://patchwork.dpdk.org/api/users/22/?format=api",
        "username": "pdelarag",
        "first_name": "Pablo",
        "last_name": "de Lara Guarch",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1528208163-31560-1-git-send-email-konstantin.ananyev@intel.com/mbox/",
    "series": [],
    "comments": "http://patchwork.dpdk.org/api/patches/40658/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/40658/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DAC3D1BA46;\n\tTue,  5 Jun 2018 16:16:14 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 98C111B972\n\tfor <dev@dpdk.org>; Tue,  5 Jun 2018 16:16:13 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Jun 2018 07:16:11 -0700",
            "from sivswdev02.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.46])\n\tby fmsmga002.fm.intel.com with ESMTP; 05 Jun 2018 07:16:10 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.49,479,1520924400\"; d=\"scan'208\";a=\"53985927\"",
        "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>",
        "To": [
            "dev@dpdk.org",
            "dev@dpdk.org"
        ],
        "Cc": [
            "Konstantin Ananyev <konstantin.ananyev@intel.com>",
            "radu.nicolau@intel.com"
        ],
        "Date": "Tue,  5 Jun 2018 15:16:02 +0100",
        "Message-Id": "<1528208163-31560-1-git-send-email-konstantin.ananyev@intel.com>",
        "X-Mailer": "git-send-email 1.7.0.7",
        "cc": [
            "Konstantin Ananyev <konstantin.ananyev@intel.com>",
            "radu.nicolau@intel.com"
        ],
        "Subject": "[dpdk-dev] [PATCH 1/2] examples/ipsec-secgw: fix bypass rule\n\tprocessing for outbound port",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "For outbound ports BYPASS rule is erroneously treated as PROTECT one\nwith SA idx zero.\n\nFixes: 2a5106af132b (\"examples/ipsec-secgw: fix corner case for SPI value\")\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n examples/ipsec-secgw/ipsec-secgw.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c\nindex a5da8b280..fafb41161 100644\n--- a/examples/ipsec-secgw/ipsec-secgw.c\n+++ b/examples/ipsec-secgw/ipsec-secgw.c\n@@ -510,11 +510,13 @@ outbound_sp(struct sp_ctx *sp, struct traffic_type *ip,\n \t\tsa_idx = ip->res[i] & PROTECT_MASK;\n \t\tif (ip->res[i] & DISCARD)\n \t\t\trte_pktmbuf_free(m);\n+\t\telse if (ip->res[i] & BYPASS)\n+\t\t\tip->pkts[j++] = m;\n \t\telse if (sa_idx < IPSEC_SA_MAX_ENTRIES) {\n \t\t\tipsec->res[ipsec->num] = sa_idx;\n \t\t\tipsec->pkts[ipsec->num++] = m;\n-\t\t} else /* BYPASS */\n-\t\t\tip->pkts[j++] = m;\n+\t\t} else /* invalid SA idx */\n+\t\t\trte_pktmbuf_free(m);\n \t}\n \tip->num = j;\n }\n",
    "prefixes": [
        "dpdk-dev",
        "1/2"
    ]
}