Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 40659,
    "url": "http://patchwork.dpdk.org/api/patches/40659/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1528208163-31560-2-git-send-email-konstantin.ananyev@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1528208163-31560-2-git-send-email-konstantin.ananyev@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1528208163-31560-2-git-send-email-konstantin.ananyev@intel.com",
    "date": "2018-06-05T14:16:03",
    "name": "[dpdk-dev,2/2] examples/ipsec-secgw: fix portmask option parsing",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "9c090e82b953f170d6de5a58c64c481a87ef53fb",
    "submitter": {
        "id": 33,
        "url": "http://patchwork.dpdk.org/api/people/33/?format=api",
        "name": "Ananyev, Konstantin",
        "email": "konstantin.ananyev@intel.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patchwork.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1528208163-31560-2-git-send-email-konstantin.ananyev@intel.com/mbox/",
    "series": [],
    "comments": "http://patchwork.dpdk.org/api/patches/40659/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/40659/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AE0CC1BA5A;\n\tTue,  5 Jun 2018 16:16:16 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 5A1371B972\n\tfor <dev@dpdk.org>; Tue,  5 Jun 2018 16:16:14 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Jun 2018 07:16:12 -0700",
            "from sivswdev02.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.46])\n\tby fmsmga002.fm.intel.com with ESMTP; 05 Jun 2018 07:16:11 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.49,479,1520924400\"; d=\"scan'208\";a=\"53985936\"",
        "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>",
        "To": [
            "dev@dpdk.org",
            "dev@dpdk.org"
        ],
        "Cc": [
            "Konstantin Ananyev <konstantin.ananyev@intel.com>",
            "radu.nicolau@intel.com"
        ],
        "Date": "Tue,  5 Jun 2018 15:16:03 +0100",
        "Message-Id": "<1528208163-31560-2-git-send-email-konstantin.ananyev@intel.com>",
        "X-Mailer": "git-send-email 1.7.0.7",
        "In-Reply-To": "<1528208163-31560-1-git-send-email-konstantin.ananyev@intel.com>",
        "References": "<1528208163-31560-1-git-send-email-konstantin.ananyev@intel.com>",
        "cc": [
            "Konstantin Ananyev <konstantin.ananyev@intel.com>",
            "radu.nicolau@intel.com"
        ],
        "Subject": "[dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option\n\tparsing",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "parse_portmask() returns both portmask value and possible error code\nas 32-bit integer. That causes some confusion for callers.\nSplit error code and portmask value into two distinct variables.\nAlso allows to run the app with unprotected_port_mask == 0.\n\nFixes: d299106e8e31 (\"examples/ipsec-secgw: add IPsec sample application\")\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n examples/ipsec-secgw/ipsec-secgw.c | 29 +++++++++++++++--------------\n 1 file changed, 15 insertions(+), 14 deletions(-)",
    "diff": "diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c\nindex fafb41161..5d7071657 100644\n--- a/examples/ipsec-secgw/ipsec-secgw.c\n+++ b/examples/ipsec-secgw/ipsec-secgw.c\n@@ -972,20 +972,19 @@ print_usage(const char *prgname)\n }\n \n static int32_t\n-parse_portmask(const char *portmask)\n+parse_portmask(const char *portmask, uint32_t *pmv)\n {\n-\tchar *end = NULL;\n+\tchar *end;\n \tunsigned long pm;\n \n \t/* parse hexadecimal string */\n+\terrno = 0;\n \tpm = strtoul(portmask, &end, 16);\n-\tif ((portmask[0] == '\\0') || (end == NULL) || (*end != '\\0'))\n+\tif (errno != 0 || *end != '\\0' || pm > UINT32_MAX)\n \t\treturn -1;\n \n-\tif ((pm == 0) && errno)\n-\t\treturn -1;\n-\n-\treturn pm;\n+\t*pmv = pm;\n+\treturn 0;\n }\n \n static int32_t\n@@ -1063,6 +1062,7 @@ parse_args(int32_t argc, char **argv)\n \tint32_t opt, ret;\n \tchar **argvopt;\n \tint32_t option_index;\n+\tuint32_t v;\n \tchar *prgname = argv[0];\n \tint32_t f_present = 0;\n \n@@ -1073,8 +1073,8 @@ parse_args(int32_t argc, char **argv)\n \n \t\tswitch (opt) {\n \t\tcase 'p':\n-\t\t\tenabled_port_mask = parse_portmask(optarg);\n-\t\t\tif (enabled_port_mask == 0) {\n+\t\t\tret = parse_portmask(optarg, &enabled_port_mask);\n+\t\t\tif (ret < 0 || enabled_port_mask == 0) {\n \t\t\t\tprintf(\"invalid portmask\\n\");\n \t\t\t\tprint_usage(prgname);\n \t\t\t\treturn -1;\n@@ -1085,8 +1085,8 @@ parse_args(int32_t argc, char **argv)\n \t\t\tpromiscuous_on = 1;\n \t\t\tbreak;\n \t\tcase 'u':\n-\t\t\tunprotected_port_mask = parse_portmask(optarg);\n-\t\t\tif (unprotected_port_mask == 0) {\n+\t\t\tret = parse_portmask(optarg, &unprotected_port_mask);\n+\t\t\tif (ret < 0) {\n \t\t\t\tprintf(\"invalid unprotected portmask\\n\");\n \t\t\t\tprint_usage(prgname);\n \t\t\t\treturn -1;\n@@ -1147,15 +1147,16 @@ parse_args(int32_t argc, char **argv)\n \t\t\t\t\tsingle_sa_idx);\n \t\t\tbreak;\n \t\tcase CMD_LINE_OPT_CRYPTODEV_MASK_NUM:\n-\t\t\tret = parse_portmask(optarg);\n+\t\t\tret = parse_portmask(optarg, &v);\n \t\t\tif (ret == -1) {\n-\t\t\t\tprintf(\"Invalid argument[portmask]\\n\");\n+\t\t\t\tprintf(\"Invalid argument[%s]\\n\",\n+\t\t\t\t\tCMD_LINE_OPT_CRYPTODEV_MASK);\n \t\t\t\tprint_usage(prgname);\n \t\t\t\treturn -1;\n \t\t\t}\n \n \t\t\t/* else */\n-\t\t\tenabled_cryptodev_mask = ret;\n+\t\t\tenabled_cryptodev_mask = v;\n \t\t\tbreak;\n \t\tdefault:\n \t\t\tprint_usage(prgname);\n",
    "prefixes": [
        "dpdk-dev",
        "2/2"
    ]
}