Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40722/?format=api
{ "id": 40722, "url": "http://patchwork.dpdk.org/api/patches/40722/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180607094322.14312-9-mk@semihalf.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180607094322.14312-9-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180607094322.14312-9-mk@semihalf.com", "date": "2018-06-07T09:43:04", "name": "[dpdk-dev,v3,09/27] net/ena: add reset routine", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dacb82203501621aef43639f9057566c0d29f2c0", "submitter": { "id": 786, "url": "http://patchwork.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180607094322.14312-9-mk@semihalf.com/mbox/", "series": [ { "id": 26, "url": "http://patchwork.dpdk.org/api/series/26/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=26", "date": "2018-06-07T09:43:00", "name": "net/ena: new features and fixes", "version": 3, "mbox": "http://patchwork.dpdk.org/series/26/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/40722/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/40722/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A4F6D1B1DF;\n\tThu, 7 Jun 2018 11:43:47 +0200 (CEST)", "from mail-lf0-f67.google.com (mail-lf0-f67.google.com\n\t[209.85.215.67]) by dpdk.org (Postfix) with ESMTP id AD7181B171\n\tfor <dev@dpdk.org>; Thu, 7 Jun 2018 11:43:40 +0200 (CEST)", "by mail-lf0-f67.google.com with SMTP id n3-v6so13624005lfe.12\n\tfor <dev@dpdk.org>; Thu, 07 Jun 2018 02:43:40 -0700 (PDT)", "from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\tp28-v6sm3612368lfh.24.2018.06.07.02.43.39\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 07 Jun 2018 02:43:39 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=yOhkPgeuxFr3Izg9Mc0fDQZggJFJFcgN58Ij9AGZ1Qg=;\n\tb=RG7B0DqMA8OFROnXM1gtI/Nmvd8QpEWSLCg7Apm+2j3mCe4mkp6FXtuUxqtw9UYQwM\n\twu9HyrDFf3aK5mcDyIuf+5We5vdvXmNJgHqwT+NwrjGzex/V1vbxxOA/WbS0e8qQjTb6\n\t9Ai5r+No2oL3uCFQSxwFVnpq1am0jkQL9WNmVxPlyC4I+w6ueeVwXhDhzrS9nYI/u3wv\n\tsVBjOZyENK/X9Kr2VfNvsvXvIGGWUjgnInjPtH2HL6BfiR777Se7NSPSBkEWqgvgyhSC\n\tHXkTRhcMG7GNOpV9PzWwa+4ThiCpGtT/T0rGmjildym/3DhNdO/RSJS9cNn/GckHUGzq\n\tsAuQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=yOhkPgeuxFr3Izg9Mc0fDQZggJFJFcgN58Ij9AGZ1Qg=;\n\tb=Uue3us7su1rFU1OORd0+SWiB+0gd+9aimv2b4jlxmqjCdC/I7kYQ8T1yh6wT7/tn03\n\to1E9fd3S6bETLILk7gQhCQGdevGThIcbDSi3ig82xITyqFXY0X44LvOBUd08DdNZrt+7\n\t3T8ctSAHMOK/W80H05NKfJOVnQrDRtLy6OY89dJv9MGJXDdO8HAbx6gWYIzXdDmJ8Sb7\n\tJUgbclvQ6PCCogR3B0bi6Qu4tQXX0P//7ZSRbv5+QeRayHlTdp5tX3FDziu5QW43X6ZW\n\t7HVsUCa6Qht63rA8i93ssjDYELNw7ZmqOoEQoH2MdoP12C80nnj+npIUICVyDitKgKBR\n\tpboA==", "X-Gm-Message-State": "APt69E06ROlk+v1Y0qLlUog+MElj5144uC0GAGEMzdy22IYzGpdCg6PS\n\t2+8DAIbdXEwurdlrmDO4qk2PNQ==", "X-Google-Smtp-Source": "ADUXVKIeWLrOJZ4405U5tKz9xeiMZ8dP6DWRI/sUDhOBm6WMaXywVOvtqVmbWcTY8+0aKYlUY/ZUTQ==", "X-Received": "by 2002:a2e:944d:: with SMTP id\n\to13-v6mr999401ljh.65.1528364620363; \n\tThu, 07 Jun 2018 02:43:40 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>,\n\tGuy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>", "Cc": "dev@dpdk.org,\n\tmatua@amazon.com", "Date": "Thu, 7 Jun 2018 11:43:04 +0200", "Message-Id": "<20180607094322.14312-9-mk@semihalf.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20180607094322.14312-1-mk@semihalf.com>", "References": "<20180607094322.14312-1-mk@semihalf.com>", "Subject": "[dpdk-dev] [PATCH v3 09/27] net/ena: add reset routine", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Reset routine can be used by the DPDK application to reset the device in\ncase of receiving RTE_ETH_EVENT_INTR_RESET from the PMD.\n\nThe reset event is not triggered by the driver, yet. It will be added in\nnext commits to enable error recovery in case of misfunctioning of the\ndevice.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\n---\n drivers/net/ena/ena_ethdev.c | 64 +++++++++++++++++++++++++++++++++++++++++++-\n drivers/net/ena/ena_ethdev.h | 2 ++\n 2 files changed, 65 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 58cf8a971..4fae4fd66 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -225,6 +225,7 @@ static int ena_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);\n static int ena_start(struct rte_eth_dev *dev);\n static void ena_stop(struct rte_eth_dev *dev);\n static void ena_close(struct rte_eth_dev *dev);\n+static int ena_dev_reset(struct rte_eth_dev *dev);\n static int ena_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats);\n static void ena_rx_queue_release_all(struct rte_eth_dev *dev);\n static void ena_tx_queue_release_all(struct rte_eth_dev *dev);\n@@ -262,6 +263,7 @@ static const struct eth_dev_ops ena_dev_ops = {\n \t.rx_queue_release = ena_rx_queue_release,\n \t.tx_queue_release = ena_tx_queue_release,\n \t.dev_close = ena_close,\n+\t.dev_reset = ena_dev_reset,\n \t.reta_update = ena_rss_reta_update,\n \t.reta_query = ena_rss_reta_query,\n };\n@@ -470,6 +472,63 @@ static void ena_close(struct rte_eth_dev *dev)\n \tena_tx_queue_release_all(dev);\n }\n \n+static int\n+ena_dev_reset(struct rte_eth_dev *dev)\n+{\n+\tstruct rte_mempool *mb_pool_rx[ENA_MAX_NUM_QUEUES];\n+\tstruct rte_eth_dev *eth_dev;\n+\tstruct rte_pci_device *pci_dev;\n+\tstruct rte_intr_handle *intr_handle;\n+\tstruct ena_com_dev *ena_dev;\n+\tstruct ena_com_dev_get_features_ctx get_feat_ctx;\n+\tstruct ena_adapter *adapter;\n+\tint nb_queues;\n+\tint rc, i;\n+\n+\tadapter = (struct ena_adapter *)(dev->data->dev_private);\n+\tena_dev = &adapter->ena_dev;\n+\teth_dev = adapter->rte_dev;\n+\tpci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);\n+\tintr_handle = &pci_dev->intr_handle;\n+\tnb_queues = eth_dev->data->nb_rx_queues;\n+\n+\tena_com_set_admin_running_state(ena_dev, false);\n+\n+\tena_com_dev_reset(ena_dev, adapter->reset_reason);\n+\n+\tfor (i = 0; i < nb_queues; i++)\n+\t\tmb_pool_rx[i] = adapter->rx_ring[i].mb_pool;\n+\n+\tena_rx_queue_release_all(eth_dev);\n+\tena_tx_queue_release_all(eth_dev);\n+\n+\trte_intr_disable(intr_handle);\n+\n+\tena_com_abort_admin_commands(ena_dev);\n+\tena_com_wait_for_abort_completion(ena_dev);\n+\tena_com_admin_destroy(ena_dev);\n+\tena_com_mmio_reg_read_request_destroy(ena_dev);\n+\n+\trc = ena_device_init(ena_dev, &get_feat_ctx);\n+\tif (rc) {\n+\t\tPMD_INIT_LOG(CRIT, \"Cannot initialize device\\n\");\n+\t\treturn rc;\n+\t}\n+\n+\trte_intr_enable(intr_handle);\n+\tena_com_set_admin_polling_mode(ena_dev, false);\n+\tena_com_admin_aenq_enable(ena_dev);\n+\n+\tfor (i = 0; i < nb_queues; ++i)\n+\t\tena_rx_queue_setup(eth_dev, i, adapter->rx_ring_size, 0, NULL,\n+\t\t\tmb_pool_rx[i]);\n+\n+\tfor (i = 0; i < nb_queues; ++i)\n+\t\tena_tx_queue_setup(eth_dev, i, adapter->tx_ring_size, 0, NULL);\n+\n+\treturn 0;\n+}\n+\n static int ena_rss_reta_update(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_rss_reta_entry64 *reta_conf,\n \t\t\t uint16_t reta_size)\n@@ -1074,7 +1133,10 @@ static int ena_tx_queue_setup(struct rte_eth_dev *dev,\n \tfor (i = 0; i < txq->ring_size; i++)\n \t\ttxq->empty_tx_reqs[i] = i;\n \n-\ttxq->offloads = tx_conf->offloads | dev->data->dev_conf.txmode.offloads;\n+\tif (tx_conf != NULL) {\n+\t\ttxq->offloads =\n+\t\t\ttx_conf->offloads | dev->data->dev_conf.txmode.offloads;\n+\t}\n \n \t/* Store pointer to this queue in upper layer */\n \ttxq->configured = 1;\ndiff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h\nindex 16172a54a..79e9e655d 100644\n--- a/drivers/net/ena/ena_ethdev.h\n+++ b/drivers/net/ena/ena_ethdev.h\n@@ -183,6 +183,8 @@ struct ena_adapter {\n \tuint64_t rx_selected_offloads;\n \n \tbool link_status;\n+\n+\tenum ena_regs_reset_reason_types reset_reason;\n };\n \n #endif /* _ENA_ETHDEV_H_ */\n", "prefixes": [ "dpdk-dev", "v3", "09/27" ] }