Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40725/?format=api
{ "id": 40725, "url": "http://patchwork.dpdk.org/api/patches/40725/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180607094322.14312-12-mk@semihalf.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180607094322.14312-12-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180607094322.14312-12-mk@semihalf.com", "date": "2018-06-07T09:43:07", "name": "[dpdk-dev,v3,12/27] net/ena: add checking for admin queue state", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e52eb896f7be4301a57b629145aba26a808ccad5", "submitter": { "id": 786, "url": "http://patchwork.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180607094322.14312-12-mk@semihalf.com/mbox/", "series": [ { "id": 26, "url": "http://patchwork.dpdk.org/api/series/26/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=26", "date": "2018-06-07T09:43:00", "name": "net/ena: new features and fixes", "version": 3, "mbox": "http://patchwork.dpdk.org/series/26/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/40725/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/40725/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5C1B81B219;\n\tThu, 7 Jun 2018 11:43:51 +0200 (CEST)", "from mail-lf0-f66.google.com (mail-lf0-f66.google.com\n\t[209.85.215.66]) by dpdk.org (Postfix) with ESMTP id C134A1B1DB\n\tfor <dev@dpdk.org>; Thu, 7 Jun 2018 11:43:46 +0200 (CEST)", "by mail-lf0-f66.google.com with SMTP id v135-v6so13648944lfa.9\n\tfor <dev@dpdk.org>; Thu, 07 Jun 2018 02:43:46 -0700 (PDT)", "from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\tp28-v6sm3612368lfh.24.2018.06.07.02.43.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 07 Jun 2018 02:43:44 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=3Vitdk7ctM7aZRDSswk6hosriHw7EHcK/VUdY6MZGtM=;\n\tb=LPsWSDR3uZ6BVUSQBeXE+E+/KyCU5tiCT7GdcAVx/6LVgKDlCfhWaf/sU9iEXcjX04\n\t3po4q4Be+T6GwUOZtUz//UBJ3MCTxnySKKquYLkCkw/GMlJI7bHv5/yi0g4sosWaCjnH\n\tWRIl+wKTzPO6En8f89pbwPTDurjQrmKl47ncFsdghkFj/2D2WCO382Zs1ZC+/D3eo2dk\n\tFKR4dkBMdi/DjTSxz1tq1d1atc9xNfmrQkPrqZvLDBrV9mkdM2raOF2aZqEyjqYJGJ8a\n\t/WsJ0fMJjCYDLyj+QhgBLedUUNH1lpYDycXFB41VOJuePYRy93Zfx8A4P41XqIx6Nov8\n\tTeew==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=3Vitdk7ctM7aZRDSswk6hosriHw7EHcK/VUdY6MZGtM=;\n\tb=AwxdQQnvNtnEw34MXyUReuFPSLposhZ6JAaLnVvJg6XN3j+83BT4PXUElqS/oPG9kz\n\t8iKlWCCAObTuqFQdzxh/6Si0633Rh2kPD5rKBfdUy/fVmfD4hsur65iu6CyfxlqXlCNq\n\tQhp1lN37q8k+pf1o2Tn5JuPsL2UNRg0iZC5oJJtQLr2LRrQdK1LgAtuJOPPNFS2xZmi3\n\tVRqF9fY/e1TVk/qC3DGdmqS01dPNXjHWdNWNzyda+4UloXE2iFPNFZHGeyGygLWOZ6sz\n\thf6UzUVg06v1wfzB6JE96yBBi2ms8MtbluPJCMwEY+peteDFCuQaw6v4KEr1deGlrtsw\n\t5/CA==", "X-Gm-Message-State": "APt69E3W+uRuBRysvOrX7TvkeCd6blut7FZDjTEYAk4rbjGvejjDpsFD\n\tCBM7ypeotK1I9jgg/cV12vn7TQ==", "X-Google-Smtp-Source": "ADUXVKLjmky1PVbKxSTNgHjEi4r42i4Gp20yW9uH8dGf5Q2EYiL8gL69LZmHPQOFyxy2ihF0SXOsCg==", "X-Received": "by 2002:a2e:401b:: with SMTP id\n\tn27-v6mr1008282lja.6.1528364626433; \n\tThu, 07 Jun 2018 02:43:46 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>,\n\tGuy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>", "Cc": "dev@dpdk.org,\n\tmatua@amazon.com", "Date": "Thu, 7 Jun 2018 11:43:07 +0200", "Message-Id": "<20180607094322.14312-12-mk@semihalf.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20180607094322.14312-1-mk@semihalf.com>", "References": "<20180607094322.14312-1-mk@semihalf.com>", "Subject": "[dpdk-dev] [PATCH v3 12/27] net/ena: add checking for admin queue\n\tstate", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The admin queue can stop responding or became inactive due to unexpected\nbehaviour of the device. In that case, the whole device should be\nrestarted.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\n---\n drivers/net/ena/ena_ethdev.c | 37 +++++++++++++++++++++++++++++--------\n drivers/net/ena/ena_ethdev.h | 2 ++\n 2 files changed, 31 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 796b6fc0a..dc253c384 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -527,6 +527,8 @@ ena_dev_reset(struct rte_eth_dev *dev)\n \tfor (i = 0; i < nb_queues; ++i)\n \t\tena_tx_queue_setup(eth_dev, i, adapter->tx_ring_size, 0, NULL);\n \n+\tadapter->trigger_reset = false;\n+\n \treturn 0;\n }\n \n@@ -1400,21 +1402,40 @@ static void ena_interrupt_handler_rte(void *cb_arg)\n \t\tena_com_aenq_intr_handler(ena_dev, adapter);\n }\n \n+static void check_for_missing_keep_alive(struct ena_adapter *adapter)\n+{\n+\tif (adapter->keep_alive_timeout == ENA_HW_HINTS_NO_TIMEOUT)\n+\t\treturn;\n+\n+\tif (unlikely((rte_get_timer_cycles() - adapter->timestamp_wd) >=\n+\t adapter->keep_alive_timeout)) {\n+\t\tRTE_LOG(ERR, PMD, \"Keep alive timeout\\n\");\n+\t\tadapter->reset_reason = ENA_REGS_RESET_KEEP_ALIVE_TO;\n+\t\tadapter->trigger_reset = true;\n+\t}\n+}\n+\n+/* Check if admin queue is enabled */\n+static void check_for_admin_com_state(struct ena_adapter *adapter)\n+{\n+\tif (unlikely(!ena_com_get_admin_running_state(&adapter->ena_dev))) {\n+\t\tRTE_LOG(ERR, PMD, \"ENA admin queue is not in running state!\\n\");\n+\t\tadapter->reset_reason = ENA_REGS_RESET_ADMIN_TO;\n+\t\tadapter->trigger_reset = true;\n+\t}\n+}\n+\n static void ena_timer_wd_callback(__rte_unused struct rte_timer *timer,\n \t\t\t\t void *arg)\n {\n \tstruct ena_adapter *adapter = (struct ena_adapter *)arg;\n \tstruct rte_eth_dev *dev = adapter->rte_dev;\n \n-\tif (adapter->keep_alive_timeout == ENA_HW_HINTS_NO_TIMEOUT)\n-\t\treturn;\n+\tcheck_for_missing_keep_alive(adapter);\n+\tcheck_for_admin_com_state(adapter);\n \n-\t/* Within reasonable timing range no memory barriers are needed */\n-\tif ((rte_get_timer_cycles() - adapter->timestamp_wd) >=\n-\t adapter->keep_alive_timeout) {\n-\t\tRTE_LOG(ERR, PMD, \"The ENA device is not responding - \"\n-\t\t\t\"performing device reset...\");\n-\t\tadapter->reset_reason = ENA_REGS_RESET_KEEP_ALIVE_TO;\n+\tif (unlikely(adapter->trigger_reset)) {\n+\t\tRTE_LOG(ERR, PMD, \"Trigger reset is on\\n\");\n \t\t_rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET,\n \t\t\tNULL);\n \t}\ndiff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h\nindex b44cca23e..1f6a7062f 100644\n--- a/drivers/net/ena/ena_ethdev.h\n+++ b/drivers/net/ena/ena_ethdev.h\n@@ -194,6 +194,8 @@ struct ena_adapter {\n \tstruct rte_timer timer_wd;\n \tuint64_t timestamp_wd;\n \tuint64_t keep_alive_timeout;\n+\n+\tbool trigger_reset;\n };\n \n #endif /* _ENA_ETHDEV_H_ */\n", "prefixes": [ "dpdk-dev", "v3", "12/27" ] }