Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40767/?format=api
{ "id": 40767, "url": "http://patchwork.dpdk.org/api/patches/40767/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180607125240.17017-1-xuemingl@mellanox.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180607125240.17017-1-xuemingl@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180607125240.17017-1-xuemingl@mellanox.com", "date": "2018-06-07T12:52:40", "name": "[dpdk-dev,RFC,v1] ethdev: add flow metadata", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4d913a0875267d5003c773cfc95d8d3b138eaa4a", "submitter": { "id": 814, "url": "http://patchwork.dpdk.org/api/people/814/?format=api", "name": "Xueming Li", "email": "xuemingl@mellanox.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180607125240.17017-1-xuemingl@mellanox.com/mbox/", "series": [ { "id": 31, "url": "http://patchwork.dpdk.org/api/series/31/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31", "date": "2018-06-07T12:52:40", "name": "[dpdk-dev,RFC,v1] ethdev: add flow metadata", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/40767/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/40767/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 150851B171;\n\tThu, 7 Jun 2018 14:53:08 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 37D301B016\n\tfor <dev@dpdk.org>; Thu, 7 Jun 2018 14:53:06 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\txuemingl@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 7 Jun 2018 15:55:19 +0300", "from dev-r630-06.mtbc.labs.mlnx (dev-r630-06.mtbc.labs.mlnx\n\t[10.12.205.180])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id w57Cr2jo024018;\n\tThu, 7 Jun 2018 15:53:02 +0300", "from dev-r630-06.mtbc.labs.mlnx (localhost [127.0.0.1])\n\tby dev-r630-06.mtbc.labs.mlnx (8.14.7/8.14.7) with ESMTP id\n\tw57Cr1HJ017062; Thu, 7 Jun 2018 20:53:01 +0800", "(from xuemingl@localhost)\n\tby dev-r630-06.mtbc.labs.mlnx (8.14.7/8.14.7/Submit) id\n\tw57CqrkB017061; Thu, 7 Jun 2018 20:52:53 +0800" ], "From": "Xueming Li <xuemingl@mellanox.com>", "To": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "Cc": "Xueming Li <xuemingl@mellanox.com>, dev@dpdk.org,\n\tShahaf Shuler <shahafs@mellanox.com>,\n\tThomas Monjalon <thomasm@mellanox.com>,\n\tOlivier Matz <olivier.matz@6wind.com>", "Date": "Thu, 7 Jun 2018 20:52:40 +0800", "Message-Id": "<20180607125240.17017-1-xuemingl@mellanox.com>", "X-Mailer": "git-send-email 2.13.3", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC v1] ethdev: add flow metadata", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, rte_flow pattern only match packet header fields.\nThis patch adds additional data to match the packet.\n\nFor example, in egress direction, to do an action depending on the VM\nid, the application needs to configure rte_flow rule with the new\nmetadata pattern:\n\tpattern meta data is {vm} / end action encap …\nThen the PMD will send VM id as metadata associated in mbuf to NIC,\nthen egress flow on NIC match metadata as other regular packet headers,\nthe appropriate encapsulation is done according to the VM id metadata.\n\nMetadata could be used on ingress as well to save useful info before\nflow modification (not defined yet) or decapsulation action. PMD is\nresponsible to save metadata into mbuf field. The application must get\nmetadata from the mbuf.\n\nThis patch introduces metadata item type for rte_flow, and new metadata\nfields in mbuf to support metadata usage. They are two 32 bits metadata\nfields defined for HW that support multiple metadata fields.\n\nCc: Thomas Monjalon <thomasm@mellanox.com>\nCc: Olivier Matz <olivier.matz@6wind.com>\nCc: Shahaf Shuler <shahafs@mellanox.com>\nSigned-off-by: Xueming Li <xuemingl@mellanox.com>\n---\n doc/guides/prog_guide/rte_flow.rst | 7 +++++++\n lib/librte_ethdev/rte_flow.c | 1 +\n lib/librte_ethdev/rte_flow.h | 28 ++++++++++++++++++++++++++++\n lib/librte_mbuf/rte_mbuf.h | 4 ++++\n 4 files changed, 40 insertions(+)", "diff": "diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst\nindex b305a72a5..c2f01fc9f 100644\n--- a/doc/guides/prog_guide/rte_flow.rst\n+++ b/doc/guides/prog_guide/rte_flow.rst\n@@ -1191,6 +1191,13 @@ Normally preceded by any of:\n - `Item: ICMP6_ND_NS`_\n - `Item: ICMP6_ND_OPT`_\n \n+Item: ``META``\n+^^^^^^^^^^^^^^\n+\n+Matches an metadata variable.\n+\n+- ``data``: 32 bit value.\n+\n Actions\n ~~~~~~~\n \ndiff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c\nindex b2afba089..54a07dd4a 100644\n--- a/lib/librte_ethdev/rte_flow.c\n+++ b/lib/librte_ethdev/rte_flow.c\n@@ -66,6 +66,7 @@ static const struct rte_flow_desc_data rte_flow_desc_item[] = {\n \t\t sizeof(struct rte_flow_item_icmp6_nd_opt_sla_eth)),\n \tMK_FLOW_ITEM(ICMP6_ND_OPT_TLA_ETH,\n \t\t sizeof(struct rte_flow_item_icmp6_nd_opt_tla_eth)),\n+\tMK_FLOW_ITEM(META, sizeof(struct rte_flow_item_meta)),\n };\n \n /** Generate flow_action[] entry. */\ndiff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h\nindex f8ba71cdb..f74e0eaec 100644\n--- a/lib/librte_ethdev/rte_flow.h\n+++ b/lib/librte_ethdev/rte_flow.h\n@@ -413,6 +413,18 @@ enum rte_flow_item_type {\n \t * See struct rte_flow_item_mark.\n \t */\n \tRTE_FLOW_ITEM_TYPE_MARK,\n+\n+\t/**\n+\t * Matches a metadata variable.\n+\t *\n+\t * Possible sources of metadata:\n+\t * - mbuf port or metadata field on egress\n+\t * - egress metadata loopback to ingress\n+\t * - data copied from packet header\n+\t *\n+\t * See struct rte_flow_item_meta.\n+\t */\n+\tRTE_FLOW_ITEM_TYPE_META,\n };\n \n /**\n@@ -849,6 +861,22 @@ static const struct rte_flow_item_gre rte_flow_item_gre_mask = {\n #endif\n \n /**\n+ * RTE_FLOW_ITEM_TYPE_META.\n+ *\n+ * Matches a meta data header.\n+ */\n+struct rte_flow_item_meta {\n+\tuint32_t data;\n+};\n+\n+/** Default mask for RTE_FLOW_ITEM_TYPE_META. */\n+#ifndef __cplusplus\n+static const struct rte_flow_item_meta rte_flow_item_meta_mask = {\n+\t.data = RTE_BE32(UINT32_MAX),\n+};\n+#endif\n+\n+/**\n * RTE_FLOW_ITEM_TYPE_FUZZY\n *\n * Fuzzy pattern match, expect faster than default.\ndiff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\nindex 8e6b4d292..a9e376b22 100644\n--- a/lib/librte_mbuf/rte_mbuf.h\n+++ b/lib/librte_mbuf/rte_mbuf.h\n@@ -550,6 +550,10 @@ struct rte_mbuf {\n \tRTE_STD_C11\n \tunion {\n \t\tvoid *userdata; /**< Can be used for external metadata */\n+\t\tstruct {\n+\t\t\tuint32_t metadata0; /**< Metadata0 for rx/tx flow */\n+\t\t\tuint32_t metadata1; /**< Metadata1 for rx/tx flow */\n+\t\t};\n \t\tuint64_t udata64; /**< Allow 8-byte userdata on 32-bit */\n \t};\n \n", "prefixes": [ "dpdk-dev", "RFC", "v1" ] }