Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40768/?format=api
{ "id": 40768, "url": "http://patchwork.dpdk.org/api/patches/40768/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180607143826.23647-1-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180607143826.23647-1-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180607143826.23647-1-maxime.coquelin@redhat.com", "date": "2018-06-07T14:38:26", "name": "[dpdk-dev] vhost: use SMP memory barrier before kicking guest", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fba070395f1ce2973bc28f9f1b5e0301b687ee0a", "submitter": { "id": 512, "url": "http://patchwork.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180607143826.23647-1-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 32, "url": "http://patchwork.dpdk.org/api/series/32/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=32", "date": "2018-06-07T14:38:26", "name": "[dpdk-dev] vhost: use SMP memory barrier before kicking guest", "version": 1, "mbox": "http://patchwork.dpdk.org/series/32/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/40768/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/40768/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 547251B368;\n\tThu, 7 Jun 2018 16:38:44 +0200 (CEST)", "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id 73DB61B28E\n\tfor <dev@dpdk.org>; Thu, 7 Jun 2018 16:38:42 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 030E3401DEC2;\n\tThu, 7 Jun 2018 14:38:42 +0000 (UTC)", "from localhost.localdomain (ovpn-112-46.ams2.redhat.com\n\t[10.36.112.46])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2B77410EE6C5;\n\tThu, 7 Jun 2018 14:38:37 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "zhihong.wang@intel.com,\n\ttiwei.bie@intel.com,\n\tdev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Thu, 7 Jun 2018 16:38:26 +0200", "Message-Id": "<20180607143826.23647-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.3", "X-Greylist": [ "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.6]); Thu, 07 Jun 2018 14:38:42 +0000 (UTC)", "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.6]); \n\tThu, 07 Jun 2018 14:38:42 +0000 (UTC) for IP:'10.11.54.3'\n\tDOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''" ], "Subject": "[dpdk-dev] [PATCH] vhost: use SMP memory barrier before kicking\n\tguest", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "vhost_vring_call() used rte_mb(), which translates into\nmfence instruction on x86.\n\nThis patch changes to use rte_smp_mb(), which changed recently\nto translate into a locked ADD instruction for performance\nreason.\n\nThe measured gain is up to 3% with the testpmd benchmarks.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/vhost.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h\nindex 58c425a5c..1bc99ed3c 100644\n--- a/lib/librte_vhost/vhost.h\n+++ b/lib/librte_vhost/vhost.h\n@@ -591,7 +591,7 @@ static __rte_always_inline void\n vhost_vring_call(struct virtio_net *dev, struct vhost_virtqueue *vq)\n {\n \t/* Flush used->idx update before we read avail->flags. */\n-\trte_mb();\n+\trte_smp_mb();\n \n \t/* Don't kick guest if we don't reach index specified by guest. */\n \tif (dev->features & (1ULL << VIRTIO_RING_F_EVENT_IDX)) {\n", "prefixes": [ "dpdk-dev" ] }