Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40813/?format=api
{ "id": 40813, "url": "http://patchwork.dpdk.org/api/patches/40813/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1528449484-8664-1-git-send-email-xiangxia.m.yue@gmail.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1528449484-8664-1-git-send-email-xiangxia.m.yue@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1528449484-8664-1-git-send-email-xiangxia.m.yue@gmail.com", "date": "2018-06-08T09:18:04", "name": "[dpdk-dev] vhost: refine the vhost_new_device", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d323b8cc0c62abb2944b0ddb438eb8c0d7008794", "submitter": { "id": 834, "url": "http://patchwork.dpdk.org/api/people/834/?format=api", "name": "Tonghao Zhang", "email": "xiangxia.m.yue@gmail.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1528449484-8664-1-git-send-email-xiangxia.m.yue@gmail.com/mbox/", "series": [ { "id": 46, "url": "http://patchwork.dpdk.org/api/series/46/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=46", "date": "2018-06-08T09:18:04", "name": "[dpdk-dev] vhost: refine the vhost_new_device", "version": 1, "mbox": "http://patchwork.dpdk.org/series/46/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/40813/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/40813/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9A339A49F;\n\tFri, 8 Jun 2018 11:18:16 +0200 (CEST)", "from mail-pl0-f68.google.com (mail-pl0-f68.google.com\n\t[209.85.160.68]) by dpdk.org (Postfix) with ESMTP id 65BA77CE1\n\tfor <dev@dpdk.org>; Fri, 8 Jun 2018 11:18:14 +0200 (CEST)", "by mail-pl0-f68.google.com with SMTP id t12-v6so7939086plo.7\n\tfor <dev@dpdk.org>; Fri, 08 Jun 2018 02:18:14 -0700 (PDT)", "from local.opencloud.tech.localdomain ([13.94.31.177])\n\tby smtp.gmail.com with ESMTPSA id\n\tq68-v6sm99787890pfb.182.2018.06.08.02.18.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 08 Jun 2018 02:18:12 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=N4eh1rQjBatUsQLD0d2RxDTPc9nSzm7RJCoPcdTGRgA=;\n\tb=aotxYO5itdkRVOqdL+5WtQRGN8K8Cm4h/iD1sk7szFgqQqNHB7HEGnwveFbnKauM22\n\tJ72s8Lay2ZB7u/gtkvJ7/goxzFlySaw7p8uZu4itzWx2jOJxaNzElza0uGALW72uqU4X\n\tVVxvfjbM2o+ZD12tLEYOcnNBXSnmvsOaGVllgvK9hrPZ1P2d+zZ+vEZToKzyBndkhCR7\n\tgzb3WsiERo7j4S6RIZVaQR+hrw6dWb/bnDSV9BwvrZLwM+elQGZ8swkWv5tcvQwOvYjI\n\tDJ6bE7ErPTAUrurdwcgULvWnsONSNDkpAbpfJjzx054kGAJXGGLNLkO+19lbS8YOVfXY\n\t94Ug==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=N4eh1rQjBatUsQLD0d2RxDTPc9nSzm7RJCoPcdTGRgA=;\n\tb=mHruPdI3hqDvHxqPVNtPwtOTVOvxIfgCAGrCGXwF43kQcUQxRWOe+xrn7tSMag5Ci+\n\tThAOV8G98/yqWP3nVkNdZEq7ognVdGff43K3rYSdta6etptgWjHqwMKgzPPaN8ZO5jyr\n\t4PM5UcYheUzU50vZbVSwgsUSCV9B2JUMsqEXGmgGZ2Yc4gPMi2RPhavyNncwpUrGXt2p\n\t2RiPK/piH7hCyb47w12QJjXqEO8meV1kFU9eb2R/Lf+GGVffQs/wVFalQ8mCYkQFr0Q1\n\tpHrMvH5lMDqjjOJ2SY1bhkTmO1zh6fp7FKAnUilKvK82M+yEaVEm82wJIzDmgCnxIs0y\n\tSNsw==", "X-Gm-Message-State": "APt69E2E84TQNTnWxe61KqrVJ7zUXmwTgPz0M2VUKkAZny3h8W2n/Cu4\n\tWMRGHWiXgkNrVF2zkBzzaKwSEceG", "X-Google-Smtp-Source": "ADUXVKKkHJ33QLBt3tlpD3WqgIxxA+xtVG7rN5DPGceExpoz2nRr1qhzDOyX8ScCzBIT46r6gKM+Mw==", "X-Received": "by 2002:a17:902:6b45:: with SMTP id\n\tg5-v6mr5827388plt.67.1528449493337; \n\tFri, 08 Jun 2018 02:18:13 -0700 (PDT)", "From": "xiangxia.m.yue@gmail.com", "To": "dev@dpdk.org", "Cc": "Tonghao Zhang <xiangxia.m.yue@gmail.com>", "Date": "Fri, 8 Jun 2018 02:18:04 -0700", "Message-Id": "<1528449484-8664-1-git-send-email-xiangxia.m.yue@gmail.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH] vhost: refine the vhost_new_device", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Tonghao Zhang <xiangxia.m.yue@gmail.com>\n\nMake sure find avalid device id before allocating\nvirtio_net, if not, return directly. It may avoid\nallocating and freeing virtio_net when there is\nnot valid device id.\n\nSigned-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>\n---\n lib/librte_vhost/vhost.c | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c\nindex afded49..ed7b7ac 100644\n--- a/lib/librte_vhost/vhost.c\n+++ b/lib/librte_vhost/vhost.c\n@@ -268,21 +268,21 @@\n \tstruct virtio_net *dev;\n \tint i;\n \n-\tdev = rte_zmalloc(NULL, sizeof(struct virtio_net), 0);\n-\tif (dev == NULL) {\n-\t\tRTE_LOG(ERR, VHOST_CONFIG,\n-\t\t\t\"Failed to allocate memory for new dev.\\n\");\n-\t\treturn -1;\n-\t}\n-\n \tfor (i = 0; i < MAX_VHOST_DEVICE; i++) {\n \t\tif (vhost_devices[i] == NULL)\n \t\t\tbreak;\n \t}\n+\n \tif (i == MAX_VHOST_DEVICE) {\n \t\tRTE_LOG(ERR, VHOST_CONFIG,\n \t\t\t\"Failed to find a free slot for new device.\\n\");\n-\t\trte_free(dev);\n+\t\treturn -1;\n+\t}\n+\n+\tdev = rte_zmalloc(NULL, sizeof(struct virtio_net), 0);\n+\tif (dev == NULL) {\n+\t\tRTE_LOG(ERR, VHOST_CONFIG,\n+\t\t\t\"Failed to allocate memory for new dev.\\n\");\n \t\treturn -1;\n \t}\n \n", "prefixes": [ "dpdk-dev" ] }