Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40860/?format=api
{ "id": 40860, "url": "http://patchwork.dpdk.org/api/patches/40860/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180608163807.66737-8-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180608163807.66737-8-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180608163807.66737-8-bruce.richardson@intel.com", "date": "2018-06-08T16:38:07", "name": "[dpdk-dev,7/7] net/avp: fix 32-bit meson builds", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "509c10927526eef979be7ef7a6bbb12a907a91d3", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180608163807.66737-8-bruce.richardson@intel.com/mbox/", "series": [ { "id": 57, "url": "http://patchwork.dpdk.org/api/series/57/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=57", "date": "2018-06-08T16:38:01", "name": "Enable 32-bit native builds with meson", "version": 1, "mbox": "http://patchwork.dpdk.org/series/57/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/40860/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/40860/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 72F0E1CDF7;\n\tFri, 8 Jun 2018 18:38:52 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 2160E1CDF5\n\tfor <dev@dpdk.org>; Fri, 8 Jun 2018 18:38:49 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Jun 2018 09:38:49 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.223])\n\tby fmsmga008.fm.intel.com with ESMTP; 08 Jun 2018 09:38:48 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,490,1520924400\"; d=\"scan'208\";a=\"46302114\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n\tallain.legacy@windriver.com", "Date": "Fri, 8 Jun 2018 17:38:07 +0100", "Message-Id": "<20180608163807.66737-8-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20180608163807.66737-1-bruce.richardson@intel.com>", "References": "<20180608163807.66737-1-bruce.richardson@intel.com>", "Subject": "[dpdk-dev] [PATCH 7/7] net/avp: fix 32-bit meson builds", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When compiling with meson, extra warnings are enabled about casting from\nintegers to different size pointers. This triggers an error in AVP as the\naddition of the offset to the pointer address causes the result to be a\n64-bit integer which doesn't fit a 32-bit pointer. The fix here is to\nexplicitly indicate that the offset is of type \"uintptr_t\" which prevents\nany promotion which would cause errors.\n\nFixes: c0ad584222b5 (\"net/avp: add device initialization\")\n\nCc: allain.legacy@windriver.com\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/net/avp/avp_ethdev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c\nindex dc97e60e6..5e859c8dd 100644\n--- a/drivers/net/avp/avp_ethdev.c\n+++ b/drivers/net/avp/avp_ethdev.c\n@@ -383,7 +383,7 @@ avp_dev_translate_address(struct rte_eth_dev *eth_dev,\n \t\t\t(host_phys_addr < (map->phys_addr + map->length))) {\n \t\t\t/* address is within this segment */\n \t\t\toffset += (host_phys_addr - map->phys_addr);\n-\t\t\taddr = RTE_PTR_ADD(addr, offset);\n+\t\t\taddr = RTE_PTR_ADD(addr, (uintptr_t)offset);\n \n \t\t\tPMD_DRV_LOG(DEBUG, \"Translating host physical 0x%\" PRIx64 \" to guest virtual 0x%p\\n\",\n \t\t\t\t host_phys_addr, addr);\n", "prefixes": [ "dpdk-dev", "7/7" ] }