Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/40957/?format=api
{ "id": 40957, "url": "http://patchwork.dpdk.org/api/patches/40957/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180608225709.19473-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180608225709.19473-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180608225709.19473-1-ferruh.yigit@intel.com", "date": "2018-06-08T22:57:09", "name": "[RFC] ethdev: add new offload flag to keep CRC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b0900026ad8b9830a06e9808aa0d6c829c0108e5", "submitter": { "id": 324, "url": "http://patchwork.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180608225709.19473-1-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 69, "url": "http://patchwork.dpdk.org/api/series/69/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=69", "date": "2018-06-08T22:57:09", "name": "[RFC] ethdev: add new offload flag to keep CRC", "version": 1, "mbox": "http://patchwork.dpdk.org/series/69/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/40957/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/40957/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1F3281BB0E;\n\tFri, 8 Jun 2018 23:57:40 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 8AF621BAFB\n\tfor <dev@dpdk.org>; Fri, 8 Jun 2018 23:57:38 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Jun 2018 14:57:36 -0700", "from silpixa00399752.ir.intel.com (HELO\n\tsilpixa00399752.ger.corp.intel.com) ([10.237.222.212])\n\tby fmsmga005.fm.intel.com with ESMTP; 08 Jun 2018 14:57:34 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.49,491,1520924400\"; d=\"scan'208\";a=\"235640229\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Neil Horman <nhorman@tuxdriver.com>,\n\tJohn McNamara <john.mcnamara@intel.com>,\n\tMarko Kovacevic <marko.kovacevic@intel.com>,\n\tThomas Monjalon <thomas@monjalon.net>", "Cc": "dev@dpdk.org,\n\tFerruh Yigit <ferruh.yigit@intel.com>", "Date": "Fri, 8 Jun 2018 23:57:09 +0100", "Message-Id": "<20180608225709.19473-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.14.4", "Subject": "[dpdk-dev] [RFC] ethdev: add new offload flag to keep CRC", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "DEV_RX_OFFLOAD_KEEP_CRC offload flag added.\n\nDEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release\ndefault behavior in PMDs is to keep the CRC until this flag removed\n\nUntil DEV_RX_OFFLOAD_CRC_STRIP flag is removed:\n- Setting both KEEP_CRC & CRC_STRIP is INVALID\n- Setting only CRC_STRIP PMD should strip the CRC\n- Setting only KEEP_CRC PMD should keep the CRC\n- Not setting both PMD should keep the CRC\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n doc/guides/rel_notes/deprecation.rst | 10 ----------\n lib/librte_ethdev/rte_ethdev.h | 4 ++++\n 2 files changed, 4 insertions(+), 10 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 1ce692eac..cd128ae23 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -67,16 +67,6 @@ Deprecation Notices\n - removal of ``txq_flags`` field from ``rte_eth_txconf`` struct.\n - removal of the offloads bit-field from ``rte_eth_rxmode`` struct.\n \n-* ethdev: A new offloading flag ``DEV_RX_OFFLOAD_KEEP_CRC`` will be added in v18.08,\n- This will replace the usage of not setting ``DEV_RX_OFFLOAD_CRC_STRIP`` flag\n- and will be implemented in PMDs accordingly.\n- In v18.08 both ``DEV_RX_OFFLOAD_KEEP_CRC`` and ``DEV_RX_OFFLOAD_CRC_STRIP`` flags\n- will be available, usage will be:\n- ``CRC_STRIP``: Strip CRC from packet\n- ``KEEP_CRC``: Keep CRC in packet\n- Both ``CRC_STRIP`` & ``KEEP_CRC``: Invalid\n- No flag: Keep CRC in packet\n-\n * ethdev: In v18.11 ``DEV_RX_OFFLOAD_CRC_STRIP`` offload flag will be removed, default\n behavior without any flag will be changed to CRC strip.\n To keep CRC ``DEV_RX_OFFLOAD_KEEP_CRC`` flag is required.\ndiff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h\nindex 36e3984ea..c81af09f8 100644\n--- a/lib/librte_ethdev/rte_ethdev.h\n+++ b/lib/librte_ethdev/rte_ethdev.h\n@@ -939,6 +939,10 @@ struct rte_eth_conf {\n #define DEV_RX_OFFLOAD_SCATTER\t\t0x00002000\n #define DEV_RX_OFFLOAD_TIMESTAMP\t0x00004000\n #define DEV_RX_OFFLOAD_SECURITY 0x00008000\n+\n+/* Invalid to set both DEV_RX_OFFLOAD_CRC_STRIP and DEV_RX_OFFLOAD_KEEP_CRC\n+ * No DEV_RX_OFFLOAD_CRC_STRIP flag means keep CRC */\n+#define DEV_RX_OFFLOAD_KEEP_CRC\t\t0x00010000\n #define DEV_RX_OFFLOAD_CHECKSUM (DEV_RX_OFFLOAD_IPV4_CKSUM | \\\n \t\t\t\t DEV_RX_OFFLOAD_UDP_CKSUM | \\\n \t\t\t\t DEV_RX_OFFLOAD_TCP_CKSUM)\n", "prefixes": [ "RFC" ] }