get:
Show a patch.

patch:
Update a patch.

put:
Update a patch.

GET /api/patches/40998/?format=api
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 40998,
    "url": "http://patchwork.dpdk.org/api/patches/40998/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1528784667-21578-1-git-send-email-naga.sureshx.somarowthu@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1528784667-21578-1-git-send-email-naga.sureshx.somarowthu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1528784667-21578-1-git-send-email-naga.sureshx.somarowthu@intel.com",
    "date": "2018-06-12T06:24:27",
    "name": "crypto/aesni_mb: add dynamic logging to aesni_mb",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "2f410b09183ca13b3421b454969c99be4b27c2ab",
    "submitter": {
        "id": 1053,
        "url": "http://patchwork.dpdk.org/api/people/1053/?format=api",
        "name": "Naga Suresh Somarowthu",
        "email": "naga.sureshx.somarowthu@intel.com"
    },
    "delegate": {
        "id": 22,
        "url": "http://patchwork.dpdk.org/api/users/22/?format=api",
        "username": "pdelarag",
        "first_name": "Pablo",
        "last_name": "de Lara Guarch",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1528784667-21578-1-git-send-email-naga.sureshx.somarowthu@intel.com/mbox/",
    "series": [
        {
            "id": 88,
            "url": "http://patchwork.dpdk.org/api/series/88/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=88",
            "date": "2018-06-12T06:24:27",
            "name": "crypto/aesni_mb: add dynamic logging to aesni_mb",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/88/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/40998/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/40998/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 07F101E3B3;\n\tTue, 12 Jun 2018 08:24:41 +0200 (CEST)",
            "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 4A2771E351\n\tfor <dev@dpdk.org>; Tue, 12 Jun 2018 08:24:38 +0200 (CEST)",
            "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Jun 2018 23:24:37 -0700",
            "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga005.fm.intel.com with ESMTP; 11 Jun 2018 23:24:36 -0700",
            "from wgcvswdev001.ir.intel.com (wgcvswdev001.ir.intel.com\n\t[10.102.246.100])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw5C6OZlK016228; Tue, 12 Jun 2018 07:24:35 +0100",
            "from wgcvswdev001.ir.intel.com (localhost [127.0.0.1])\n\tby wgcvswdev001.ir.intel.com with ESMTP id w5C6OZNn021637;\n\tTue, 12 Jun 2018 07:24:35 +0100",
            "(from jmparthx@localhost)\n\tby wgcvswdev001.ir.intel.com with ? id w5C6OZlv021633;\n\tTue, 12 Jun 2018 07:24:35 +0100"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,213,1526367600\"; d=\"scan'208\";a=\"236389177\"",
        "From": "Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "pablo.de.lara.guarch@intel.com, reshma.pattan@intel.com,\n\tNaga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>",
        "Date": "Tue, 12 Jun 2018 07:24:27 +0100",
        "Message-Id": "<1528784667-21578-1-git-send-email-naga.sureshx.somarowthu@intel.com>",
        "X-Mailer": "git-send-email 1.7.12.2",
        "Subject": "[dpdk-dev] [PATCH] crypto/aesni_mb: add dynamic logging to aesni_mb",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com> \n\n1.added new logtype for aesni_mb driver.\n2.registered new logtype.\n3.MB_LOG_ERR and CDEV_LOG_ERR are\nreplaced with new logtype name AESNI_MB_PMD_LOG.\n\nSigned-off-by: Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>\nReviewed-by: Reshma Pattan <reshma.pattan@intel.com>\n---\n drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c         | 43 +++++++++++++---------\n drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c     | 12 +++---\n drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 27 ++++----------\n 3 files changed, 39 insertions(+), 43 deletions(-)",
    "diff": "diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\nindex bb35c66ab..dbe8b2546 100644\n--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\n+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\n@@ -108,7 +108,7 @@ aesni_mb_set_session_auth_parameters(const struct aesni_mb_op_fns *mb_ops,\n \t}\n \n \tif (xform->type != RTE_CRYPTO_SYM_XFORM_AUTH) {\n-\t\tMB_LOG_ERR(\"Crypto xform struct not of type auth\");\n+\t\tAESNI_MB_PMD_LOG(ERR, \"Crypto xform struct not of type auth\");\n \t\treturn -1;\n \t}\n \n@@ -161,7 +161,7 @@ aesni_mb_set_session_auth_parameters(const struct aesni_mb_op_fns *mb_ops,\n \t\thash_oneblock_fn = mb_ops->aux.one_block.sha512;\n \t\tbreak;\n \tdefault:\n-\t\tMB_LOG_ERR(\"Unsupported authentication algorithm selection\");\n+\t\tAESNI_MB_PMD_LOG(ERR, \"Unsupported authentication algorithm selection\");\n \t\treturn -ENOTSUP;\n \t}\n \n@@ -190,7 +190,7 @@ aesni_mb_set_session_cipher_parameters(const struct aesni_mb_op_fns *mb_ops,\n \t}\n \n \tif (xform->type != RTE_CRYPTO_SYM_XFORM_CIPHER) {\n-\t\tMB_LOG_ERR(\"Crypto xform struct not of type cipher\");\n+\t\tAESNI_MB_PMD_LOG(ERR, \"Crypto xform struct not of type cipher\");\n \t\treturn -EINVAL;\n \t}\n \n@@ -203,7 +203,7 @@ aesni_mb_set_session_cipher_parameters(const struct aesni_mb_op_fns *mb_ops,\n \t\tsess->cipher.direction = DECRYPT;\n \t\tbreak;\n \tdefault:\n-\t\tMB_LOG_ERR(\"Invalid cipher operation parameter\");\n+\t\tAESNI_MB_PMD_LOG(ERR, \"Invalid cipher operation parameter\");\n \t\treturn -EINVAL;\n \t}\n \n@@ -228,7 +228,7 @@ aesni_mb_set_session_cipher_parameters(const struct aesni_mb_op_fns *mb_ops,\n \t\tsess->cipher.mode = DOCSIS_DES;\n \t\tbreak;\n \tdefault:\n-\t\tMB_LOG_ERR(\"Unsupported cipher mode parameter\");\n+\t\tAESNI_MB_PMD_LOG(ERR, \"Unsupported cipher mode parameter\");\n \t\treturn -ENOTSUP;\n \t}\n \n@@ -252,7 +252,7 @@ aesni_mb_set_session_cipher_parameters(const struct aesni_mb_op_fns *mb_ops,\n \t\t\taes_keyexp_fn = mb_ops->aux.keyexp.aes256;\n \t\t\tbreak;\n \t\tdefault:\n-\t\t\tMB_LOG_ERR(\"Invalid cipher key length\");\n+\t\t\tAESNI_MB_PMD_LOG(ERR, \"Invalid cipher key length\");\n \t\t\treturn -EINVAL;\n \t\t}\n \n@@ -263,7 +263,7 @@ aesni_mb_set_session_cipher_parameters(const struct aesni_mb_op_fns *mb_ops,\n \n \t} else {\n \t\tif (xform->cipher.key.length != 8) {\n-\t\t\tMB_LOG_ERR(\"Invalid cipher key length\");\n+\t\t\tAESNI_MB_PMD_LOG(ERR, \"Invalid cipher key length\");\n \t\t\treturn -EINVAL;\n \t\t}\n \t\tsess->cipher.key_length_in_bytes = 8;\n@@ -294,7 +294,7 @@ aesni_mb_set_session_aead_parameters(const struct aesni_mb_op_fns *mb_ops,\n \t\tsess->auth.operation = RTE_CRYPTO_AUTH_OP_VERIFY;\n \t\tbreak;\n \tdefault:\n-\t\tMB_LOG_ERR(\"Invalid aead operation parameter\");\n+\t\tAESNI_MB_PMD_LOG(ERR, \"Invalid aead operation parameter\");\n \t\treturn -EINVAL;\n \t}\n \n@@ -304,7 +304,7 @@ aesni_mb_set_session_aead_parameters(const struct aesni_mb_op_fns *mb_ops,\n \t\tsess->auth.algo = AES_CCM;\n \t\tbreak;\n \tdefault:\n-\t\tMB_LOG_ERR(\"Unsupported aead mode parameter\");\n+\t\tAESNI_MB_PMD_LOG(ERR, \"Unsupported aead mode parameter\");\n \t\treturn -ENOTSUP;\n \t}\n \n@@ -320,7 +320,7 @@ aesni_mb_set_session_aead_parameters(const struct aesni_mb_op_fns *mb_ops,\n \t\taes_keyexp_fn = mb_ops->aux.keyexp.aes128;\n \t\tbreak;\n \tdefault:\n-\t\tMB_LOG_ERR(\"Invalid cipher key length\");\n+\t\tAESNI_MB_PMD_LOG(ERR, \"Invalid cipher key length\");\n \t\treturn -EINVAL;\n \t}\n \n@@ -391,7 +391,7 @@ aesni_mb_set_session_parameters(const struct aesni_mb_op_fns *mb_ops,\n \t\tbreak;\n \tcase AESNI_MB_OP_NOT_SUPPORTED:\n \tdefault:\n-\t\tMB_LOG_ERR(\"Unsupported operation chain order parameter\");\n+\t\tAESNI_MB_PMD_LOG(ERR, \"Unsupported operation chain order parameter\");\n \t\treturn -ENOTSUP;\n \t}\n \n@@ -400,14 +400,14 @@ aesni_mb_set_session_parameters(const struct aesni_mb_op_fns *mb_ops,\n \n \tret = aesni_mb_set_session_auth_parameters(mb_ops, sess, auth_xform);\n \tif (ret != 0) {\n-\t\tMB_LOG_ERR(\"Invalid/unsupported authentication parameters\");\n+\t\tAESNI_MB_PMD_LOG(ERR, \"Invalid/unsupported authentication parameters\");\n \t\treturn ret;\n \t}\n \n \tret = aesni_mb_set_session_cipher_parameters(mb_ops, sess,\n \t\t\tcipher_xform);\n \tif (ret != 0) {\n-\t\tMB_LOG_ERR(\"Invalid/unsupported cipher parameters\");\n+\t\tAESNI_MB_PMD_LOG(ERR, \"Invalid/unsupported cipher parameters\");\n \t\treturn ret;\n \t}\n \n@@ -415,7 +415,7 @@ aesni_mb_set_session_parameters(const struct aesni_mb_op_fns *mb_ops,\n \t\tret = aesni_mb_set_session_aead_parameters(mb_ops, sess,\n \t\t\t\taead_xform);\n \t\tif (ret != 0) {\n-\t\t\tMB_LOG_ERR(\"Invalid/unsupported aead parameters\");\n+\t\t\tAESNI_MB_PMD_LOG(ERR, \"Invalid/unsupported aead parameters\");\n \t\t\treturn ret;\n \t\t}\n \t}\n@@ -555,7 +555,7 @@ set_mb_job_params(JOB_AES_HMAC *job, struct aesni_mb_qp *qp,\n \t\tchar *odata = rte_pktmbuf_append(m_dst,\n \t\t\t\trte_pktmbuf_data_len(op->sym->m_src));\n \t\tif (odata == NULL) {\n-\t\t\tMB_LOG_ERR(\"failed to allocate space in destination \"\n+\t\t\tAESNI_MB_PMD_LOG(ERR, \"failed to allocate space in destination \"\n \t\t\t\t\t\"mbuf for source data\");\n \t\t\top->status = RTE_CRYPTO_OP_STATUS_ERROR;\n \t\t\treturn -1;\n@@ -832,13 +832,13 @@ cryptodev_aesni_mb_create(const char *name,\n \n \t/* Check CPU for support for AES instruction set */\n \tif (!rte_cpu_get_flag_enabled(RTE_CPUFLAG_AES)) {\n-\t\tMB_LOG_ERR(\"AES instructions not supported by CPU\");\n+\t\tAESNI_MB_PMD_LOG(ERR, \"AES instructions not supported by CPU\");\n \t\treturn -EFAULT;\n \t}\n \n \tdev = rte_cryptodev_pmd_create(name, &vdev->device, init_params);\n \tif (dev == NULL) {\n-\t\tMB_LOG_ERR(\"failed to create cryptodev vdev\");\n+\t\tAESNI_MB_PMD_LOG(ERR, \"failed to create cryptodev vdev\");\n \t\treturn -ENODEV;\n \t}\n \n@@ -911,7 +911,7 @@ cryptodev_aesni_mb_probe(struct rte_vdev_device *vdev)\n \n \tretval = rte_cryptodev_pmd_parse_input_args(&init_params, args);\n \tif (retval) {\n-\t\tMB_LOG_ERR(\"Failed to parse initialisation arguments[%s]\\n\",\n+\t\tAESNI_MB_PMD_LOG(ERR, \"Failed to parse initialisation arguments[%s]\",\n \t\t\t\targs);\n \t\treturn -EINVAL;\n \t}\n@@ -952,3 +952,10 @@ RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_AESNI_MB_PMD,\n RTE_PMD_REGISTER_CRYPTO_DRIVER(aesni_mb_crypto_drv,\n \t\tcryptodev_aesni_mb_pmd_drv.driver,\n \t\tcryptodev_driver_id);\n+\n+RTE_INIT(aesni_mb_init_log);\n+static void\n+aesni_mb_init_log(void)\n+{\n+\taesni_mb_logtype_driver = rte_log_register(\"pmd.crypto.aesni_mb\");\n+}\ndiff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c\nindex 01530523f..8972a9c44 100644\n--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c\n+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c\n@@ -441,12 +441,12 @@ aesni_mb_pmd_qp_create_processed_ops_ring(struct aesni_mb_qp *qp,\n \tr = rte_ring_lookup(ring_name);\n \tif (r) {\n \t\tif (rte_ring_get_size(r) >= ring_size) {\n-\t\t\tMB_LOG_INFO(\"Reusing existing ring %s for processed ops\",\n+\t\t\tAESNI_MB_PMD_LOG(INFO, \"Reusing existing ring %s for processed ops\",\n \t\t\tring_name);\n \t\t\treturn r;\n \t\t}\n \n-\t\tMB_LOG_ERR(\"Unable to reuse existing ring %s for processed ops\",\n+\t\tAESNI_MB_PMD_LOG(ERR, \"Unable to reuse existing ring %s for processed ops\",\n \t\t\tring_name);\n \t\treturn NULL;\n \t}\n@@ -550,20 +550,20 @@ aesni_mb_pmd_session_configure(struct rte_cryptodev *dev,\n \tint ret;\n \n \tif (unlikely(sess == NULL)) {\n-\t\tMB_LOG_ERR(\"invalid session struct\");\n+\t\tAESNI_MB_PMD_LOG(ERR, \"invalid session struct\");\n \t\treturn -EINVAL;\n \t}\n \n \tif (rte_mempool_get(mempool, &sess_private_data)) {\n-\t\tCDEV_LOG_ERR(\n-\t\t\t\"Couldn't get object from session mempool\");\n+\t\tAESNI_MB_PMD_LOG(ERR,\n+\t\t\t\t\"Couldn't get object from session mempool\");\n \t\treturn -ENOMEM;\n \t}\n \n \tret = aesni_mb_set_session_parameters(&job_ops[internals->vector_mode],\n \t\t\tsess_private_data, xform);\n \tif (ret != 0) {\n-\t\tMB_LOG_ERR(\"failed configure session parameters\");\n+\t\tAESNI_MB_PMD_LOG(ERR, \"failed configure session parameters\");\n \n \t\t/* Return session to mempool */\n \t\trte_mempool_put(mempool, sess_private_data);\ndiff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h\nindex a33b2f695..281a4558e 100644\n--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h\n+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h\n@@ -10,25 +10,14 @@\n #define CRYPTODEV_NAME_AESNI_MB_PMD\tcrypto_aesni_mb\n /**< AES-NI Multi buffer PMD device name */\n \n-#define MB_LOG_ERR(fmt, args...) \\\n-\tRTE_LOG(ERR, CRYPTODEV, \"[%s] %s() line %u: \" fmt \"\\n\",  \\\n-\t\t\tRTE_STR(CRYPTODEV_NAME_AESNI_MB_PMD), \\\n-\t\t\t__func__, __LINE__, ## args)\n-\n-#ifdef RTE_LIBRTE_AESNI_MB_DEBUG\n-#define MB_LOG_INFO(fmt, args...) \\\n-\tRTE_LOG(INFO, CRYPTODEV, \"[%s] %s() line %u: \" fmt \"\\n\", \\\n-\t\t\tCRYPTODEV_NAME_AESNI_MB_PMD, \\\n-\t\t\t__func__, __LINE__, ## args)\n-\n-#define MB_LOG_DBG(fmt, args...) \\\n-\tRTE_LOG(DEBUG, CRYPTODEV, \"[%s] %s() line %u: \" fmt \"\\n\", \\\n-\t\t\tCRYPTODEV_NAME_AESNI_MB_PMD, \\\n-\t\t\t__func__, __LINE__, ## args)\n-#else\n-#define MB_LOG_INFO(fmt, args...)\n-#define MB_LOG_DBG(fmt, args...)\n-#endif\n+/** AESNI_MB PMD LOGTYPE DRIVER */\n+int aesni_mb_logtype_driver;\n+\n+#define AESNI_MB_PMD_LOG(level, fmt, ...)  \\\n+\trte_log(RTE_LOG_ ## level, aesni_mb_logtype_driver,  \\\n+\t\t\t\"%s() line %u: \" fmt \"\\n\", __func__, __LINE__,  \\\n+\t\t\t\t\t## __VA_ARGS__)\n+\n \n #define HMAC_IPAD_VALUE\t\t\t(0x36)\n #define HMAC_OPAD_VALUE\t\t\t(0x5C)\n",
    "prefixes": []
}