Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41025/?format=api
{ "id": 41025, "url": "http://patchwork.dpdk.org/api/patches/41025/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1528877502-5076-1-git-send-email-wei.zhao1@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1528877502-5076-1-git-send-email-wei.zhao1@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1528877502-5076-1-git-send-email-wei.zhao1@intel.com", "date": "2018-06-13T08:11:42", "name": "[v2] net/ixgbe: fix tunnel type set error for FDIR", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7c9034816e5e8b87ddbfefe5fbf23c6e335187e3", "submitter": { "id": 495, "url": "http://patchwork.dpdk.org/api/people/495/?format=api", "name": "Zhao1, Wei", "email": "wei.zhao1@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1528877502-5076-1-git-send-email-wei.zhao1@intel.com/mbox/", "series": [ { "id": 105, "url": "http://patchwork.dpdk.org/api/series/105/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=105", "date": "2018-06-13T08:11:42", "name": "[v2] net/ixgbe: fix tunnel type set error for FDIR", "version": 2, "mbox": "http://patchwork.dpdk.org/series/105/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41025/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/41025/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 632FF1EF45;\n\tWed, 13 Jun 2018 10:32:29 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id AE81E1EE25;\n\tWed, 13 Jun 2018 10:32:27 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Jun 2018 01:32:26 -0700", "from dpdk6.bj.intel.com ([172.16.182.94])\n\tby orsmga006.jf.intel.com with ESMTP; 13 Jun 2018 01:32:25 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,218,1526367600\"; d=\"scan'208\";a=\"49503650\"", "From": "Wei Zhao <wei.zhao1@intel.com>", "To": "dev@dpdk.org", "Cc": "wenzhuo.lu@intel.com,\n\tstable@dpdk.org,\n\tWei Zhao <wei.zhao1@intel.com>", "Date": "Wed, 13 Jun 2018 16:11:42 +0800", "Message-Id": "<1528877502-5076-1-git-send-email-wei.zhao1@intel.com>", "X-Mailer": "git-send-email 2.7.5", "In-Reply-To": "<1528189935-34943-5-git-send-email-wei.zhao1@intel.com>", "References": "<1528189935-34943-5-git-send-email-wei.zhao1@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel type set error for FDIR", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Tunnel type format should be translated to ixgbe required format\nbefore register set in FDIR cloud mode, Ans also some register\nnot useful in cloud mode but only useful in IP mode should be set\nto zero as datasheet request.\n\nFixes: 82fb702077f6 (\"ixgbe: support new flow director modes for X550\")\nFixes: 11777435c727 (\"net/ixgbe: parse flow director filter\")\n\nSigned-off-by: Wei Zhao <wei.zhao1@intel.com>\n---\n\nv2:\n-change register write function for FDIRIPSA and FDIRIPDA.\n\n---\n drivers/net/ixgbe/ixgbe_fdir.c | 17 +++++++++++++----\n drivers/net/ixgbe/ixgbe_flow.c | 6 ++----\n 2 files changed, 15 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c\nindex 67ab627..3feb815 100644\n--- a/drivers/net/ixgbe/ixgbe_fdir.c\n+++ b/drivers/net/ixgbe/ixgbe_fdir.c\n@@ -771,8 +771,15 @@ ixgbe_fdir_filter_to_atr_input(const struct rte_eth_fdir_filter *fdir_filter,\n \t\t\tinput->formatted.inner_mac,\n \t\t\tfdir_filter->input.flow.tunnel_flow.mac_addr.addr_bytes,\n \t\t\tsizeof(input->formatted.inner_mac));\n-\t\tinput->formatted.tunnel_type =\n-\t\t\tfdir_filter->input.flow.tunnel_flow.tunnel_type;\n+\t\tif (fdir_filter->input.flow.tunnel_flow.tunnel_type ==\n+\t\t\t\tRTE_FDIR_TUNNEL_TYPE_VXLAN)\n+\t\t\tinput->formatted.tunnel_type = 0x8000;\n+\t\telse if (fdir_filter->input.flow.tunnel_flow.tunnel_type ==\n+\t\t\t\tRTE_FDIR_TUNNEL_TYPE_NVGRE)\n+\t\t\tinput->formatted.tunnel_type = 0;\n+\t\telse\n+\t\t\tPMD_DRV_LOG(ERR, \" invalid tunnel type arguments.\");\n+\n \t\tinput->formatted.tni_vni =\n \t\t\tfdir_filter->input.flow.tunnel_flow.tunnel_id >> 8;\n \t}\n@@ -1001,8 +1008,7 @@ fdir_write_perfect_filter_82599(struct ixgbe_hw *hw,\n \t\t\tIXGBE_WRITE_REG(hw, IXGBE_FDIRSIPv6(2), 0);\n \t\t} else {\n \t\t\t/* tunnel mode */\n-\t\t\tif (input->formatted.tunnel_type !=\n-\t\t\t\tRTE_FDIR_TUNNEL_TYPE_NVGRE)\n+\t\t\tif (input->formatted.tunnel_type)\n \t\t\t\ttunnel_type = 0x80000000;\n \t\t\ttunnel_type |= addr_high;\n \t\t\tIXGBE_WRITE_REG(hw, IXGBE_FDIRSIPv6(0), addr_low);\n@@ -1010,6 +1016,9 @@ fdir_write_perfect_filter_82599(struct ixgbe_hw *hw,\n \t\t\tIXGBE_WRITE_REG(hw, IXGBE_FDIRSIPv6(2),\n \t\t\t\t\tinput->formatted.tni_vni);\n \t\t}\n+\t\tIXGBE_WRITE_REG(hw, IXGBE_FDIRIPSA, 0);\n+\t\tIXGBE_WRITE_REG(hw, IXGBE_FDIRIPDA, 0);\n+\t\tIXGBE_WRITE_REG(hw, IXGBE_FDIRPORT, 0);\n \t}\n \n \t/* record vlan (little-endian) and flex_bytes(big-endian) */\ndiff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c\nindex f47f125..06bc2a7 100644\n--- a/drivers/net/ixgbe/ixgbe_flow.c\n+++ b/drivers/net/ixgbe/ixgbe_flow.c\n@@ -2436,8 +2436,7 @@ ixgbe_parse_fdir_filter_tunnel(const struct rte_flow_attr *attr,\n \n \t/* Get the VxLAN info */\n \tif (item->type == RTE_FLOW_ITEM_TYPE_VXLAN) {\n-\t\trule->ixgbe_fdir.formatted.tunnel_type =\n-\t\t\tRTE_FDIR_TUNNEL_TYPE_VXLAN;\n+\t\trule->ixgbe_fdir.formatted.tunnel_type = 0x8000;\n \n \t\t/* Only care about VNI, others should be masked. */\n \t\tif (!item->mask) {\n@@ -2494,8 +2493,7 @@ ixgbe_parse_fdir_filter_tunnel(const struct rte_flow_attr *attr,\n \n \t/* Get the NVGRE info */\n \tif (item->type == RTE_FLOW_ITEM_TYPE_NVGRE) {\n-\t\trule->ixgbe_fdir.formatted.tunnel_type =\n-\t\t\tRTE_FDIR_TUNNEL_TYPE_NVGRE;\n+\t\trule->ixgbe_fdir.formatted.tunnel_type = 0;\n \n \t\t/**\n \t\t * Only care about flags0, flags1, protocol and TNI,\n", "prefixes": [ "v2" ] }